@gotgenes/pi-permission-system 10.1.0 → 10.3.0

package/test/runtime.test.ts

@@ -1,4 +1,3 @@
-import { join } from "node:path";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 
 // ── logger stub ────────────────────────────────────────────────────────────
@@ -6,9 +5,6 @@ const {
   mockLoggerDebug,
   mockLoggerReview,
   mockCreateLogger,
-  mockLoadAndMergeConfigs,
-  mockSyncPermissionSystemStatus,
-  mockBuildResolvedConfigLogEntry,
   mockDiscoverGlobalNodeModulesRoot,
 } = vi.hoisted(() => ({
   mockLoggerDebug:
@@ -20,9 +16,6 @@ const {
       (event: string, details?: Record<string, unknown>) => string | undefined
     >(),
   mockCreateLogger: vi.fn(),
-  mockLoadAndMergeConfigs: vi.fn(),
-  mockSyncPermissionSystemStatus: vi.fn(),
-  mockBuildResolvedConfigLogEntry: vi.fn(),
   mockDiscoverGlobalNodeModulesRoot: vi.fn<() => string | null>(),
 }));
 
@@ -34,21 +27,6 @@ vi.mock("../src/permission-manager", () => ({
   PermissionManager: vi.fn(),
 }));
 
-vi.mock("../src/config-loader", () => ({
-  loadAndMergeConfigs: mockLoadAndMergeConfigs,
-  loadUnifiedConfig: vi.fn().mockReturnValue({ config: {} }),
-}));
-
-vi.mock("../src/status", () => ({
-  PERMISSION_SYSTEM_STATUS_KEY: "permission-system",
-  syncPermissionSystemStatus: mockSyncPermissionSystemStatus,
-  getPermissionSystemStatus: vi.fn(),
-}));
-
-vi.mock("../src/config-reporter", () => ({
-  buildResolvedConfigLogEntry: mockBuildResolvedConfigLogEntry,
-}));
-
 vi.mock("../src/subagent-context", () => ({
   isSubagentExecutionContext: vi.fn().mockReturnValue(false),
 }));
@@ -62,20 +40,9 @@ vi.mock("../src/session-rules", () => ({
   deriveApprovalPattern: vi.fn(),
 }));
 
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import {
-  getGlobalConfigPath,
-  getGlobalLogsDir,
-  getProjectConfigPath,
-} from "#src/config-paths";
+import { getGlobalLogsDir } from "#src/config-paths";
 import { DEFAULT_EXTENSION_CONFIG } from "#src/extension-config";
-import { PermissionManager } from "#src/permission-manager";
-import {
-  createExtensionRuntime,
-  createPermissionManagerForCwd,
-  derivePiProjectPaths,
-  refreshExtensionConfig,
-} from "#src/runtime";
+import { createExtensionRuntime } from "#src/runtime";
 
 // ── test suite ─────────────────────────────────────────────────────────────
 
@@ -162,9 +129,9 @@ describe("createExtensionRuntime", () => {
 
   // ── Default mutable state ────────────────────────────────────────────────
 
-  it("initializes config to DEFAULT_EXTENSION_CONFIG", () => {
+  it("initializes configStore.current() to DEFAULT_EXTENSION_CONFIG", () => {
     const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
-    expect(runtime.config).toEqual(DEFAULT_EXTENSION_CONFIG);
+    expect(runtime.configStore.current()).toEqual(DEFAULT_EXTENSION_CONFIG);
   });
 
   it("initializes runtimeContext to null", () => {
@@ -192,11 +159,6 @@ describe("createExtensionRuntime", () => {
     expect(runtime.lastPromptStateCacheKey).toBeNull();
   });
 
-  it("initializes lastConfigWarning to null", () => {
-    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
-    expect(runtime.lastConfigWarning).toBeNull();
-  });
-
   it("creates a sessionRules instance", () => {
     const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
     expect(runtime.sessionRules).toBeDefined();
@@ -204,17 +166,6 @@ describe("createExtensionRuntime", () => {
 
   // ── Mutable state is writable ──────────────────────────────────────────
 
-  it("allows config to be updated", () => {
-    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
-    const newConfig = {
-      debugLog: true,
-      permissionReviewLog: false,
-      yoloMode: false,
-    };
-    runtime.config = newConfig;
-    expect(runtime.config).toEqual(newConfig);
-  });
-
   it("allows runtimeContext to be updated", () => {
     const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
     const mockCtx = { hasUI: false } as never;
@@ -237,19 +188,13 @@ describe("createExtensionRuntime", () => {
     expect(opts.reviewLogPath).toContain(expectedLogsDir);
   });
 
-  it("passes getConfig that reads current runtime.config", () => {
-    const runtime = createExtensionRuntime({ agentDir: "/test/agent" });
+  it("passes getConfig that reads from configStore.current()", () => {
+    createExtensionRuntime({ agentDir: "/test/agent" });
     const opts = mockCreateLogger.mock.calls[0][0] as {
       getConfig: () => typeof DEFAULT_EXTENSION_CONFIG;
     };
-    const updatedConfig = {
-      debugLog: true,
-      permissionReviewLog: false,
-      yoloMode: false,
-    };
-    runtime.config = updatedConfig;
-    // getConfig() should reflect the updated value
-    expect(opts.getConfig()).toEqual(updatedConfig);
+    // getConfig() reads from configStore.current() — DEFAULT_EXTENSION_CONFIG at startup
+    expect(opts.getConfig()).toEqual(DEFAULT_EXTENSION_CONFIG);
   });
 
   // ── writeDebugLog delegates to logger.debug ──────────────────────────────
@@ -351,217 +296,8 @@ describe("createExtensionRuntime", () => {
   });
 });
 
-// ── derivePiProjectPaths ───────────────────────────────────────────────────
-
-describe("derivePiProjectPaths", () => {
-  it("returns null for null cwd", () => {
-    expect(derivePiProjectPaths(null)).toBeNull();
-  });
-
-  it("returns null for undefined cwd", () => {
-    expect(derivePiProjectPaths(undefined)).toBeNull();
-  });
-
-  it("returns null for empty string cwd", () => {
-    expect(derivePiProjectPaths("")).toBeNull();
-  });
-
-  it("returns projectGlobalConfigPath via getProjectConfigPath", () => {
-    const result = derivePiProjectPaths("/my/project");
-    expect(result?.projectGlobalConfigPath).toBe(
-      getProjectConfigPath("/my/project"),
-    );
-  });
-
-  it("returns projectAgentsDir as .pi/agent/agents under cwd", () => {
-    const result = derivePiProjectPaths("/my/project");
-    expect(result?.projectAgentsDir).toBe(
-      join("/my/project", ".pi", "agent", "agents"),
-    );
-  });
-});
-
-// ── createPermissionManagerForCwd ─────────────────────────────────────────
-
-describe("createPermissionManagerForCwd", () => {
-  beforeEach(() => {
-    // PermissionManager is already mocked as vi.fn() at module scope.
-  });
-
-  it("creates a PermissionManager with globalConfigPath from agentDir", () => {
-    const MockPM = PermissionManager as ReturnType<typeof vi.fn>;
-    MockPM.mockClear();
-    createPermissionManagerForCwd("/test/agent", null);
-    expect(MockPM).toHaveBeenCalledWith(
-      expect.objectContaining({
-        globalConfigPath: getGlobalConfigPath("/test/agent"),
-      }),
-    );
-  });
-
-  it("includes projectGlobalConfigPath when cwd is provided", () => {
-    const MockPM = PermissionManager as ReturnType<typeof vi.fn>;
-    MockPM.mockClear();
-    createPermissionManagerForCwd("/test/agent", "/my/project");
-    expect(MockPM).toHaveBeenCalledWith(
-      expect.objectContaining({
-        globalConfigPath: getGlobalConfigPath("/test/agent"),
-        projectGlobalConfigPath: getProjectConfigPath("/my/project"),
-      }),
-    );
-  });
-
-  it("excludes projectGlobalConfigPath when cwd is null", () => {
-    const MockPM = PermissionManager as ReturnType<typeof vi.fn>;
-    MockPM.mockClear();
-    createPermissionManagerForCwd("/test/agent", null);
-    const callArg = MockPM.mock.calls[0][0] as Record<string, unknown>;
-    expect(callArg.projectGlobalConfigPath).toBeUndefined();
-  });
-});
-
-// ── refreshExtensionConfig ────────────────────────────────────────────────
-
-describe("refreshExtensionConfig", () => {
-  function makeRuntime() {
-    mockCreateLogger.mockReturnValue({
-      debug: mockLoggerDebug,
-      review: mockLoggerReview,
-    });
-    return createExtensionRuntime({ agentDir: "/test/agent" });
-  }
-
-  function makeCtx(
-    overrides: Partial<ExtensionContext> = {},
-  ): ExtensionContext {
-    return {
-      cwd: "/test/project",
-      hasUI: false,
-      ui: { notify: vi.fn(), setStatus: vi.fn() },
-      sessionManager: { getEntries: vi.fn(), addEntry: vi.fn() },
-      ...overrides,
-    } as unknown as ExtensionContext;
-  }
-
-  beforeEach(() => {
-    mockLoggerDebug.mockReset().mockReturnValue(undefined);
-    mockLoggerReview.mockReset().mockReturnValue(undefined);
-    mockLoadAndMergeConfigs.mockReset().mockReturnValue({
-      merged: { ...DEFAULT_EXTENSION_CONFIG },
-      issues: [],
-    });
-    mockSyncPermissionSystemStatus.mockReset();
-  });
-
-  it("updates runtime.runtimeContext when ctx is provided", () => {
-    const runtime = makeRuntime();
-    const ctx = makeCtx();
-    refreshExtensionConfig(runtime, ctx);
-    expect(runtime.runtimeContext).toBe(ctx);
-  });
-
-  it("does not override runtimeContext when ctx is omitted", () => {
-    const runtime = makeRuntime();
-    const existing = makeCtx();
-    runtime.runtimeContext = existing;
-    refreshExtensionConfig(runtime);
-    expect(runtime.runtimeContext).toBe(existing);
-  });
-
-  it("updates runtime.config with normalized merged result", () => {
-    const runtime = makeRuntime();
-    mockLoadAndMergeConfigs.mockReturnValue({
-      merged: { debugLog: true, permissionReviewLog: false, yoloMode: false },
-      issues: [],
-    });
-    refreshExtensionConfig(runtime);
-    expect(runtime.config.debugLog).toBe(true);
-    expect(runtime.config.permissionReviewLog).toBe(false);
-  });
-
-  it("calls loadAndMergeConfigs with runtime.agentDir and cwd", () => {
-    const runtime = makeRuntime();
-    const ctx = makeCtx({ cwd: "/my/project" });
-    refreshExtensionConfig(runtime, ctx);
-    expect(mockLoadAndMergeConfigs).toHaveBeenCalledWith(
-      "/test/agent",
-      "/my/project",
-      expect.any(String), // EXTENSION_ROOT
-    );
-  });
-
-  it("writes config.loaded debug log", () => {
-    const runtime = makeRuntime();
-    refreshExtensionConfig(runtime);
-    expect(mockLoggerDebug).toHaveBeenCalledWith(
-      "config.loaded",
-      expect.objectContaining({ debugLog: false }),
-    );
-  });
-
-  it("sets lastConfigWarning when issues are present", () => {
-    const runtime = makeRuntime();
-    mockLoadAndMergeConfigs.mockReturnValue({
-      merged: { ...DEFAULT_EXTENSION_CONFIG },
-      issues: ["legacy config detected"],
-    });
-    refreshExtensionConfig(runtime);
-    expect(runtime.lastConfigWarning).toBe("legacy config detected");
-  });
-
-  it("clears lastConfigWarning when no issues", () => {
-    const runtime = makeRuntime();
-    runtime.lastConfigWarning = "old warning";
-    mockLoadAndMergeConfigs.mockReturnValue({
-      merged: { ...DEFAULT_EXTENSION_CONFIG },
-      issues: [],
-    });
-    refreshExtensionConfig(runtime);
-    expect(runtime.lastConfigWarning).toBeNull();
-  });
-
-  it("notifies UI when a new warning appears and hasUI is true", () => {
-    const runtime = makeRuntime();
-    const mockNotify = vi.fn();
-    const ctx = makeCtx({ hasUI: true, ui: { notify: mockNotify } as never });
-    mockLoadAndMergeConfigs.mockReturnValue({
-      merged: { ...DEFAULT_EXTENSION_CONFIG },
-      issues: ["new warning"],
-    });
-    refreshExtensionConfig(runtime, ctx);
-    expect(mockNotify).toHaveBeenCalledWith("new warning", "warning");
-  });
-
-  it("does not re-notify the same warning on subsequent calls", () => {
-    const runtime = makeRuntime();
-    const mockNotify = vi.fn();
-    const ctx = makeCtx({ hasUI: true, ui: { notify: mockNotify } as never });
-    mockLoadAndMergeConfigs.mockReturnValue({
-      merged: { ...DEFAULT_EXTENSION_CONFIG },
-      issues: ["persistent warning"],
-    });
-    refreshExtensionConfig(runtime, ctx);
-    refreshExtensionConfig(runtime, ctx);
-    expect(mockNotify).toHaveBeenCalledTimes(1);
-  });
-
-  it("calls syncPermissionSystemStatus when hasUI is true", () => {
-    const runtime = makeRuntime();
-    const ctx = makeCtx({ hasUI: true });
-    refreshExtensionConfig(runtime, ctx);
-    expect(mockSyncPermissionSystemStatus).toHaveBeenCalledWith(
-      ctx,
-      expect.any(Object),
-    );
-  });
-
-  it("does not call syncPermissionSystemStatus when hasUI is false", () => {
-    const runtime = makeRuntime();
-    const ctx = makeCtx({ hasUI: false });
-    refreshExtensionConfig(runtime, ctx);
-    expect(mockSyncPermissionSystemStatus).not.toHaveBeenCalled();
-  });
-});
+// refreshExtensionConfig / saveExtensionConfig / logResolvedConfigPaths are
+// thin delegators to runtime.configStore — behavior covered in config-store.test.ts.
 
 // resolveAgentName was moved to PermissionSession (#129)
-// Tests live in tests/permission-session.test.ts
+// Tests live in test/permission-session.test.ts