@gotgenes/pi-permission-system 10.1.0 → 10.2.0

package/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [10.2.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v10.1.0...pi-permission-system-v10.2.0) (2026-06-04)
+
+
+### Features
+
+* add PermissionManager.configureForCwd and agentDir option ([5a2d363](https://github.com/gotgenes/pi-packages/commit/5a2d3634a0b8466a5d6aa8baa170a9bf53e068fb))
+
 ## [10.1.0](https://github.com/gotgenes/pi-packages/compare/pi-permission-system-v10.0.0...pi-permission-system-v10.1.0) (2026-06-03)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "10.1.0",
+  "version": "10.2.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "exports": {

package/src/index.ts

@@ -18,6 +18,7 @@ import { SkillInputGatePipeline } from "./handlers/gates/skill-input-gate-pipeli
 import { ToolCallGatePipeline } from "./handlers/gates/tool-call-gate-pipeline";
 import { requestPermissionDecisionFromUi } from "./permission-dialog";
 import { registerPermissionRpcHandlers } from "./permission-event-rpc";
+import { PermissionManager } from "./permission-manager";
 import { PermissionPrompter } from "./permission-prompter";
 import { PermissionSession } from "./permission-session";
 import { LocalPermissionsService } from "./permissions-service";
@@ -69,6 +70,8 @@ export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
 
   refreshExtensionConfig(runtime);
 
+  const sessionManager = new PermissionManager({ agentDir: runtime.agentDir });
+
   const session = new PermissionSession(
     runtime,
     createSessionLogger(runtime),
@@ -77,6 +80,7 @@ export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
       forwarder,
       subagentRegistry,
     ),
+    sessionManager,
     {
       refreshExtensionConfig: (ctx) => refreshExtensionConfig(runtime, ctx),
       logResolvedConfigPaths: () => logResolvedConfigPaths(runtime),

package/src/permission-manager.ts

@@ -1,4 +1,6 @@
+import { join } from "node:path";
 import { isPermissionState } from "./common";
+import { getGlobalConfigPath, getProjectConfigPath } from "./config-paths";
 import { normalizeInput } from "./input-normalizer";
 import { normalizeFlatConfig } from "./normalize";
 import {
@@ -48,19 +50,66 @@ type ResolvedPermissions = {
   composedRules: Ruleset;
 };
 
+/**
+ * Narrow interface for session-scoped permission checking.
+ * `PermissionSession` depends on this — not the full concrete class — so
+ * test mocks can satisfy it without an `as unknown as PermissionManager` cast.
+ */
+export interface ScopedPermissionManager {
+  configureForCwd(cwd: string | undefined | null): void;
+  checkPermission(
+    toolName: string,
+    input: unknown,
+    agentName?: string,
+    sessionRules?: Ruleset,
+  ): PermissionCheckResult;
+  getToolPermission(toolName: string, agentName?: string): PermissionState;
+  getConfigIssues(agentName?: string): string[];
+  getPolicyCacheStamp(agentName?: string): string;
+}
+
 export interface PermissionManagerOptions extends PolicyLoaderOptions {
   policyLoader?: PolicyLoader;
+  /**
+   * Pi agent directory.  When provided, the manager derives all loader paths
+   * from this value and supports {@link PermissionManager.configureForCwd}.
+   */
+  agentDir?: string;
 }
 
-export class PermissionManager {
-  private readonly loader: PolicyLoader;
+export class PermissionManager implements ScopedPermissionManager {
+  private readonly agentDir: string | undefined;
+  private loader: PolicyLoader;
   private readonly resolvedPermissionsCache = new Map<
     string,
     FileCacheEntry<ResolvedPermissions>
   >();
 
   constructor(options: PermissionManagerOptions = {}) {
-    this.loader = options.policyLoader ?? new FilePolicyLoader(options);
+    this.agentDir = options.agentDir;
+    this.loader =
+      options.policyLoader ??
+      new FilePolicyLoader(
+        options.agentDir !== undefined
+          ? derivePolicyLoaderOptions(options.agentDir, undefined)
+          : options,
+      );
+  }
+
+  /**
+   * Rebuild the policy loader for a new working directory and clear the
+   * resolved-permissions cache.
+   *
+   * When `agentDir` was not provided at construction (e.g. test managers
+   * built with explicit paths), only the cache is cleared.
+   */
+  configureForCwd(cwd: string | undefined | null): void {
+    if (this.agentDir !== undefined) {
+      this.loader = new FilePolicyLoader(
+        derivePolicyLoaderOptions(this.agentDir, cwd),
+      );
+    }
+    this.resolvedPermissionsCache.clear();
   }
 
   getConfigIssues(agentName?: string): string[] {
@@ -219,6 +268,23 @@ export class PermissionManager {
   }
 }
 
+/**
+ * Derive `PolicyLoaderOptions` from an agentDir + an optional cwd.
+ * Setting agentsDir explicitly from agentDir removes the hidden
+ * `getAgentDir()` env-read that FilePolicyLoader's default would perform.
+ */
+function derivePolicyLoaderOptions(
+  agentDir: string,
+  cwd: string | undefined | null,
+): PolicyLoaderOptions {
+  return {
+    globalConfigPath: getGlobalConfigPath(agentDir),
+    agentsDir: join(agentDir, "agents"),
+    projectGlobalConfigPath: cwd ? getProjectConfigPath(cwd) : undefined,
+    projectAgentsDir: cwd ? join(cwd, ".pi", "agent", "agents") : undefined,
+  };
+}
+
 /**
  * Map a matched rule + tool name to the correct PermissionCheckResult.source.
  *

package/src/permission-session.ts

@@ -11,11 +11,10 @@ import type { ForwardingController } from "./forwarding-manager";
 import type { GateHandlerSession } from "./gate-handler-session";
 import type { GatePrompter } from "./gate-prompter";
 import type { PermissionPromptDecision } from "./permission-dialog";
-import type { PermissionManager } from "./permission-manager";
+import type { ScopedPermissionManager } from "./permission-manager";
 import type { PromptPermissionDetails } from "./permission-prompter";
 import type { PermissionResolver } from "./permission-resolver";
 import type { Rule } from "./rule";
-import { createPermissionManagerForCwd } from "./runtime";
 import type { SessionApproval } from "./session-approval";
 import type { SessionApprovalRecorder } from "./session-approval-recorder";
 import type { SessionLifecycleSession } from "./session-lifecycle-session";
@@ -74,7 +73,6 @@ export class PermissionSession
     SessionLifecycleSession
 {
   private context: ExtensionContext | null = null;
-  private permissionManager: PermissionManager;
   private readonly sessionRules = new SessionRules();
   private skillEntries: SkillPromptEntry[] = [];
   private knownAgentName: string | null = null;
@@ -85,13 +83,9 @@ export class PermissionSession
     private readonly paths: ExtensionPaths,
     readonly logger: SessionLogger,
     private readonly forwarding: ForwardingController,
+    private readonly permissionManager: ScopedPermissionManager,
     private readonly runtimeDeps: PermissionSessionRuntimeDeps,
-  ) {
-    this.permissionManager = createPermissionManagerForCwd(
-      paths.agentDir,
-      undefined,
-    );
-  }
+  ) {}
 
   // ── Context lifecycle ──────────────────────────────────────────────────
 
@@ -173,14 +167,11 @@ export class PermissionSession
   /**
    * Reset all mutable state for a new session.
    *
-   * Creates a fresh PermissionManager scoped to `ctx.cwd`, clears caches,
+   * Configures the injected PermissionManager for `ctx.cwd`, clears caches,
    * skill entries, and activates the new context.
    */
   resetForNewSession(ctx: ExtensionContext): void {
-    this.permissionManager = createPermissionManagerForCwd(
-      this.paths.agentDir,
-      ctx.cwd,
-    );
+    this.permissionManager.configureForCwd(ctx.cwd);
     this.skillEntries = [];
     this.toolsCacheKey = null;
     this.promptCacheKey = null;
@@ -204,10 +195,7 @@ export class PermissionSession
    * Used on config reload (e.g. `resources_discover` with reason "reload").
    */
   reload(): void {
-    this.permissionManager = createPermissionManagerForCwd(
-      this.paths.agentDir,
-      this.context?.cwd,
-    );
+    this.permissionManager.configureForCwd(this.context?.cwd);
     this.skillEntries = [];
     this.toolsCacheKey = null;
     this.promptCacheKey = null;

package/src/runtime.ts

@@ -19,7 +19,6 @@ import {
   getLegacyExtensionConfigPath,
   getLegacyGlobalPolicyPath,
   getLegacyProjectPolicyPath,
-  getProjectConfigPath,
   REVIEW_LOG_FILENAME,
 } from "./config-paths";
 import { buildResolvedConfigLogEntry } from "./config-reporter";
@@ -77,41 +76,6 @@ export interface ExtensionRuntime extends ExtensionPaths, SessionState {
   writeReviewLog(event: string, details?: Record<string, unknown>): void;
 }
 
-// ── Pure helpers ───────────────────────────────────────────────────────────
-
-/**
- * Derive Pi project-level config and agents paths from a working directory.
- * Returns null when cwd is absent (headless / global-only config).
- */
-export function derivePiProjectPaths(cwd: string | undefined | null): {
-  projectGlobalConfigPath: string;
-  projectAgentsDir: string;
-} | null {
-  if (!cwd) {
-    return null;
-  }
-  return {
-    projectGlobalConfigPath: getProjectConfigPath(cwd),
-    projectAgentsDir: join(cwd, ".pi", "agent", "agents"),
-  };
-}
-
-/**
- * Create a new PermissionManager scoped to a working directory's config hierarchy.
- * Pass `cwd` as null/undefined to use global config only.
- */
-export function createPermissionManagerForCwd(
-  agentDir: string,
-  cwd: string | undefined | null,
-): PermissionManager {
-  const projectPaths = derivePiProjectPaths(cwd);
-  return new PermissionManager({
-    globalConfigPath: getGlobalConfigPath(agentDir),
-    projectGlobalConfigPath: projectPaths?.projectGlobalConfigPath,
-    projectAgentsDir: projectPaths?.projectAgentsDir,
-  });
-}
-
 /**
  * Reload merged config from disk into the runtime.
  * If `ctx` is provided, updates `runtime.runtimeContext` first.
@@ -261,7 +225,7 @@ export function createExtensionRuntime(options?: {
     ...paths,
     config: { ...DEFAULT_EXTENSION_CONFIG },
     runtimeContext: null,
-    permissionManager: createPermissionManagerForCwd(agentDir, undefined),
+    permissionManager: new PermissionManager({ agentDir }),
     activeSkillEntries: [],
     lastKnownActiveAgentName: null,
     lastActiveToolsCacheKey: null,