@gotgenes/pi-permission-system 0.7.0 → 1.0.0

package/CHANGELOG.md

@@ -5,6 +5,40 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.0](https://github.com/gotgenes/pi-permission-system/compare/v0.8.0...v1.0.0) (2026-05-03)
+
+
+### ⚠ BREAKING CHANGES
+
+* The bundled temperature-stripping shim for OpenAI Responses-style APIs (openai-codex-responses, openai-responses, azure-openai-responses) has been removed. This module monkey-patched the provider stack at the process level and had no connection to permission enforcement. Users who need the shim can extract it into a standalone extension.
+
+### Features
+
+* remove out-of-scope model-option-compatibility provider shim ([#17](https://github.com/gotgenes/pi-permission-system/issues/17)) ([b390896](https://github.com/gotgenes/pi-permission-system/commit/b39089611fe565f81dacf7fa0bff3af36d50f7ce))
+
+
+### Documentation
+
+* plan removal of out-of-scope model-option-compatibility shim ([#17](https://github.com/gotgenes/pi-permission-system/issues/17)) ([a48f2ef](https://github.com/gotgenes/pi-permission-system/commit/a48f2ef025cbe970d21071b94552fcb9a4f7de89))
+* **retro:** add retro notes for issue [#16](https://github.com/gotgenes/pi-permission-system/issues/16) ([ee710cb](https://github.com/gotgenes/pi-permission-system/commit/ee710cba9b1fe92a39016c61348d2a0eb2895d1f))
+
+## [0.8.0](https://github.com/gotgenes/pi-permission-system/compare/v0.7.0...v0.8.0) (2026-05-03)
+
+
+### Features
+
+* replace vendored zellij-modal with direct pi-tui SettingsList ([#16](https://github.com/gotgenes/pi-permission-system/issues/16)) ([868675f](https://github.com/gotgenes/pi-permission-system/commit/868675ff2df1ab429dc48160c7e545ddc8a451e1))
+
+
+### Documentation
+
+* plan delete vendored zellij-modal and rebuild settings UI ([#16](https://github.com/gotgenes/pi-permission-system/issues/16)) ([35274da](https://github.com/gotgenes/pi-permission-system/commit/35274da005b90023de29bbc144abfa6ad27bb73c))
+
+
+### Miscellaneous Chores
+
+* add project-local pi-autoformat config ([13a6f33](https://github.com/gotgenes/pi-permission-system/commit/13a6f339a52a546812432bc055bdb32cc2bd6d90))
+
 ## [0.7.0](https://github.com/gotgenes/pi-permission-system/compare/v0.6.1...v0.7.0) (2026-05-02)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-system",
-  "version": "0.7.0",
+  "version": "1.0.0",
   "description": "Permission enforcement extension for the Pi coding agent.",
   "type": "module",
   "main": "./index.ts",

package/src/config-modal.ts

@@ -1,14 +1,14 @@
-import type {
-  ExtensionAPI,
-  ExtensionCommandContext,
+import {
+  type ExtensionAPI,
+  type ExtensionCommandContext,
+  getSettingsListTheme,
 } from "@mariozechner/pi-coding-agent";
-import type { SettingItem } from "@mariozechner/pi-tui";
+import { type SettingItem, SettingsList } from "@mariozechner/pi-tui";
 
 import {
   DEFAULT_EXTENSION_CONFIG,
   type PermissionSystemExtensionConfig,
 } from "./extension-config.js";
-import { ZellijModal, ZellijSettingsModal } from "./zellij-modal.js";
 
 interface PermissionSystemConfigController {
   getConfig(): PermissionSystemExtensionConfig;
@@ -19,10 +19,6 @@ interface PermissionSystemConfigController {
   getConfigPath(): string;
 }
 
-interface SettingValueSyncTarget {
-  updateValue(id: string, value: string): void;
-}
-
 const ON_OFF = ["on", "off"];
 const COMMAND_ARGUMENTS = [
   {
@@ -118,7 +114,7 @@ function applySetting(
 }
 
 function syncSettingValues(
-  settingsList: SettingValueSyncTarget,
+  settingsList: SettingsList,
   config: PermissionSystemExtensionConfig,
 ): void {
   settingsList.updateValue("yoloMode", toOnOff(config.yoloMode));
@@ -155,60 +151,22 @@ async function openSettingsModal(
   };
 
   await ctx.ui.custom<void>(
-    (tui, theme, _keybindings, done) => {
+    (_tui, _theme, _keybindings, done) => {
       let current = controller.getConfig();
-      let settingsModal: ZellijSettingsModal | null = null;
-
-      settingsModal = new ZellijSettingsModal(
-        {
-          title: "Permission System Settings",
-          description:
-            "Local extension options for permission logging and auto-approval behavior",
-          settings: buildSettingItems(current),
-          onChange: (id, newValue) => {
-            current = applySetting(current, id, newValue);
-            controller.setConfig(current, ctx);
-            current = controller.getConfig();
-            if (settingsModal) {
-              syncSettingValues(settingsModal, current);
-            }
-          },
-          onClose: () => done(),
-          helpText: `/permission-system show • /permission-system reset • ${controller.getConfigPath()}`,
-          enableSearch: true,
-        },
-        theme,
-      );
-
-      const modal = new ZellijModal(
-        settingsModal,
-        {
-          borderStyle: "rounded",
-          titleBar: {
-            left: "Permission System Settings",
-            right: "pi-permission-system",
-          },
-          helpUndertitle: {
-            text: "Esc: close | ↑↓: navigate | Space: toggle",
-            color: "dim",
-          },
-          overlay: overlayOptions,
+      const settingsList = new SettingsList(
+        buildSettingItems(current),
+        10,
+        getSettingsListTheme(),
+        (id, newValue) => {
+          current = applySetting(current, id, newValue);
+          controller.setConfig(current, ctx);
+          current = controller.getConfig();
+          syncSettingValues(settingsList, current);
         },
-        theme,
+        () => done(),
       );
 
-      return {
-        render(width: number) {
-          return modal.renderModal(width).lines;
-        },
-        invalidate() {
-          modal.invalidate();
-        },
-        handleInput(data: string) {
-          modal.handleInput(data);
-          tui.requestRender();
-        },
-      };
+      return settingsList;
     },
     { overlay: true, overlayOptions },
   );

package/src/index.ts

@@ -35,7 +35,6 @@ import {
   savePermissionSystemConfig,
 } from "./extension-config.js";
 import { createPermissionSystemLogger, safeJsonStringify } from "./logging.js";
-import { registerModelOptionCompatibilityGuard } from "./model-option-compatibility.js";
 import {
   isPermissionDecisionState,
   type PermissionPromptDecision,
@@ -297,7 +296,7 @@ function getActiveAgentNameFromSystemPrompt(
   }
 
   const match = systemPrompt.match(ACTIVE_AGENT_TAG_REGEX);
-  if (!match || !match[1]) {
+  if (!match?.[1]) {
     return null;
   }
 
@@ -1338,8 +1337,6 @@ export default function piPermissionSystemExtension(pi: ExtensionAPI): void {
 
   setLoggingWarningReporter(notifyWarning);
   refreshExtensionConfig();
-  registerModelOptionCompatibilityGuard(pi);
-
   registerPermissionSystemCommand(pi, {
     getConfig: () => extensionConfig,
     setConfig: saveExtensionConfig,

package/tests/config-modal.test.ts

@@ -16,14 +16,6 @@ vi.mock("@mariozechner/pi-coding-agent", () => ({
 }));
 
 vi.mock("@mariozechner/pi-tui", () => ({
-  Box: class {},
-  Container: class {
-    addChild(): void {}
-    render(): string[] {
-      return [];
-    }
-    invalidate(): void {}
-  },
   SettingsList: class {
     handleInput(): void {}
     updateValue(): void {}
@@ -32,10 +24,6 @@ vi.mock("@mariozechner/pi-tui", () => ({
     }
     invalidate(): void {}
   },
-  Spacer: class {},
-  Text: class {},
-  truncateToWidth: (text: string) => text,
-  visibleWidth: (text: string) => text.length,
 }));
 
 type Notification = { message: string; level: "info" | "warning" | "error" };

package/tests/permission-system.test.ts

@@ -92,7 +92,10 @@ function createManager(
 type MockHandler = (
   event: Record<string, unknown>,
   ctx: Record<string, unknown>,
-) => Promise<Record<string, unknown> | void> | Record<string, unknown> | void;
+) =>
+  | Promise<Record<string, unknown> | undefined>
+  | Record<string, unknown>
+  | undefined;
 
 type ExtensionHarness = {
   baseDir: string;

package/src/model-option-compatibility.ts

@@ -1,182 +0,0 @@
-import {
-  type Api,
-  type AssistantMessageEventStream,
-  getApiProvider,
-  type Context as LlmContext,
-  type Model,
-  type SimpleStreamOptions,
-} from "@mariozechner/pi-ai";
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-
-const GUARDED_TEMPERATURE_APIS = [
-  "openai-codex-responses",
-  "openai-responses",
-  "azure-openai-responses",
-] as const satisfies readonly Api[];
-const OPENAI_RESPONSES_APIS = new Set<Api>([
-  "openai-responses",
-  "azure-openai-responses",
-]);
-const TEMPERATURE_UNSUPPORTED_APIS = new Set<Api>(["openai-codex-responses"]);
-const TEMPERATURE_UNSUPPORTED_PROVIDERS = new Set<string>(["openai-codex"]);
-
-export type ApiStreamSimpleDelegate = (
-  model: Model<Api>,
-  context: LlmContext,
-  options?: SimpleStreamOptions,
-) => AssistantMessageEventStream;
-
-type GlobalWithPermissionSystemProviderGuard = typeof globalThis & {
-  __piPermissionSystemModelOptionBaseStreams?: Map<
-    string,
-    ApiStreamSimpleDelegate
-  >;
-  __piPermissionSystemModelOptionGuardedApis?: Set<string>;
-};
-
-function getBaseApiStreams(): Map<string, ApiStreamSimpleDelegate> {
-  const globalScope = globalThis as GlobalWithPermissionSystemProviderGuard;
-  if (!globalScope.__piPermissionSystemModelOptionBaseStreams) {
-    globalScope.__piPermissionSystemModelOptionBaseStreams = new Map<
-      string,
-      ApiStreamSimpleDelegate
-    >();
-  }
-  return globalScope.__piPermissionSystemModelOptionBaseStreams;
-}
-
-function getGuardedApis(): Set<string> {
-  const globalScope = globalThis as GlobalWithPermissionSystemProviderGuard;
-  if (!globalScope.__piPermissionSystemModelOptionGuardedApis) {
-    globalScope.__piPermissionSystemModelOptionGuardedApis = new Set<string>();
-  }
-  return globalScope.__piPermissionSystemModelOptionGuardedApis;
-}
-
-function normalizeIdentifier(value: string | undefined): string {
-  return (value ?? "").trim().toLowerCase();
-}
-
-function hasModelToken(modelId: string, token: string): boolean {
-  return normalizeIdentifier(modelId)
-    .split(/[^a-z0-9]+/)
-    .includes(token);
-}
-
-export function getUnsupportedTemperatureReason(
-  model: Pick<Model<Api>, "api" | "id" | "provider" | "reasoning">,
-): string | undefined {
-  if (TEMPERATURE_UNSUPPORTED_APIS.has(model.api)) {
-    return `api '${model.api}' does not support temperature`;
-  }
-
-  const provider = normalizeIdentifier(model.provider);
-  if (TEMPERATURE_UNSUPPORTED_PROVIDERS.has(provider)) {
-    return `provider '${model.provider}' does not support temperature`;
-  }
-
-  if (
-    OPENAI_RESPONSES_APIS.has(model.api) &&
-    hasModelToken(model.id, "codex")
-  ) {
-    return `model '${model.id}' does not support temperature`;
-  }
-
-  if (OPENAI_RESPONSES_APIS.has(model.api) && model.reasoning) {
-    return `reasoning model '${model.id}' accepts only the provider default temperature`;
-  }
-
-  return undefined;
-}
-
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === "object" && value !== null && !Array.isArray(value);
-}
-
-export function stripUnsupportedTemperatureFromPayload(
-  payload: unknown,
-): unknown {
-  if (!isRecord(payload) || !("temperature" in payload)) {
-    return payload;
-  }
-
-  const { temperature: _temperature, ...rest } = payload;
-  return rest;
-}
-
-function composeTemperatureSanitizer(
-  options: SimpleStreamOptions | undefined,
-  model: Model<Api>,
-): SimpleStreamOptions | undefined {
-  const reason = getUnsupportedTemperatureReason(model);
-  if (!reason && options?.temperature === undefined) {
-    return options;
-  }
-
-  if (!reason) {
-    return options;
-  }
-
-  const existingOnPayload = options?.onPayload;
-  const nextOptions: SimpleStreamOptions = options
-    ? { ...options, temperature: undefined }
-    : {};
-
-  nextOptions.onPayload = async (payload, payloadModel) => {
-    const transformedPayload = existingOnPayload
-      ? await existingOnPayload(payload, payloadModel)
-      : undefined;
-    return stripUnsupportedTemperatureFromPayload(
-      transformedPayload ?? payload,
-    );
-  };
-
-  return nextOptions;
-}
-
-function ensureModelOptionGuardForApi(pi: ExtensionAPI, api: Api): boolean {
-  const guardedApis = getGuardedApis();
-  if (guardedApis.has(api)) {
-    return true;
-  }
-
-  const baseStreams = getBaseApiStreams();
-  let baseStream = baseStreams.get(api);
-  if (!baseStream) {
-    const currentProvider = getApiProvider(api);
-    if (!currentProvider) {
-      return false;
-    }
-    baseStream = currentProvider.streamSimple as ApiStreamSimpleDelegate;
-    baseStreams.set(api, baseStream);
-  }
-
-  const providerName = `pi-permission-system-model-option-compatibility-${api.replace(/[^a-z0-9]+/gi, "-").toLowerCase()}`;
-  pi.registerProvider(providerName, {
-    api,
-    streamSimple: (model, context, options) => {
-      const typedModel = model as Model<Api>;
-      const delegate = baseStreams.get(typedModel.api);
-      if (!delegate) {
-        throw new Error(
-          `No base stream provider available for api '${typedModel.api}'.`,
-        );
-      }
-
-      return delegate(
-        typedModel,
-        context,
-        composeTemperatureSanitizer(options, typedModel),
-      );
-    },
-  });
-
-  guardedApis.add(api);
-  return true;
-}
-
-export function registerModelOptionCompatibilityGuard(pi: ExtensionAPI): void {
-  for (const api of GUARDED_TEMPERATURE_APIS) {
-    ensureModelOptionGuardForApi(pi, api);
-  }
-}