@gotgenes/pi-permission-model-judge 1.0.0 → 1.0.2

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [1.0.2](https://github.com/gotgenes/pi-packages/compare/pi-permission-model-judge-v1.0.1...pi-permission-model-judge-v1.0.2) (2026-07-21)
+
+
+### Bug Fixes
+
+* **pi-permission-model-judge:** forward resolved auth into the review model call ([9836020](https://github.com/gotgenes/pi-packages/commit/98360207d19a91edcf8e166b59dd1a9262349277)), closes [#625](https://github.com/gotgenes/pi-packages/issues/625)
+* **pi-permission-model-judge:** resolve model auth before the review call ([4c90603](https://github.com/gotgenes/pi-packages/commit/4c906031144e18c7f6b60eac5f8607e271f090f2)), closes [#625](https://github.com/gotgenes/pi-packages/issues/625)
+
+
+### Documentation
+
+* **pi-permission-model-judge:** feature the corrected dropped-prefix typo pattern ([13553d5](https://github.com/gotgenes/pi-packages/commit/13553d5c4ba8ba50a90688bd26e597a842f5f509)), closes [#625](https://github.com/gotgenes/pi-packages/issues/625)
+
+## [1.0.1](https://github.com/gotgenes/pi-packages/compare/pi-permission-model-judge-v1.0.0...pi-permission-model-judge-v1.0.1) (2026-07-20)
+
+
+### Documentation
+
+* **pi-permission-model-judge:** feature the doubled-package typo pattern ([abcfa23](https://github.com/gotgenes/pi-packages/commit/abcfa23eac678b42b2e031b0bb1092db4b601c55))
+
 ## 1.0.0 (2026-07-20)
 
 

package/README.md

@@ -49,8 +49,12 @@ Two independent config files are involved — the safety policy lives in pi-perm
    {
      "provider": "anthropic",
      "model": "claude-haiku-4-5",
-     "instructions": "Deny a path that repeats a directory segment…",
-     "typoPatterns": ["pi-permission-system/packages/pi-permission-system"]
+     "instructions": "Deny a path that repeats a package name around `packages/`, or drops the repo's `pi-packages/packages/` prefix…",
+     // Catches a doubled package segment and a dropped repository prefix.
+     "typoPatterns": [
+       "([^/]+)/packages/\\1(/|$)",
+       "development/pi/(?!pi-packages/)pi-[^/]+(/|$)"
+     ]
    }
    ```
 

package/config/config.example.json

@@ -2,10 +2,10 @@
   "$schema": "https://raw.githubusercontent.com/gotgenes/pi-packages/main/packages/pi-permission-model-judge/schemas/model-judge.schema.json",
   "provider": "anthropic",
   "model": "claude-haiku-4-5",
-  "instructions": "You review a filesystem path a tool is about to access outside the working directory. A typo path repeats a directory segment that should appear once — for example a path containing `pi-permission-system/packages/pi-permission-system`, where the first segment should be `pi-packages`. Deny only a clear typo, and in the reason state the wrong segment and the correct location so the caller can self-correct. When unsure, defer.",
+  "instructions": "You review a filesystem path a tool is about to access outside the working directory. Two common typos both point at the wrong location. (1) A doubled package segment — a package name repeated around `packages/`, for example `pi-permission-system/packages/pi-permission-system/…`, where the correct path names the package only once under the repository's `packages/` directory. (2) A dropped repository prefix — a path that jumps straight to a package directory such as `development/pi/pi-permission-system/…`, where the correct path routes through the repository's `pi-packages/packages/` directory (for example `development/pi/pi-packages/packages/pi-permission-system/…`). When the path shows either typo, deny it and give the single corrected absolute path in the reason so the caller can retry against the right location. If the path looks intentional or you are unsure, defer. Reply with strict JSON: {\"verdict\":\"deny\",\"reason\":\"…\"} to reject, or {\"verdict\":\"defer\"} otherwise.",
   "typoPatterns": [
-    "pi-permission-system/packages/pi-permission-system",
-    "pi-packages/packages/[^/]+/packages/"
+    "([^/]+)/packages/\\1(/|$)",
+    "development/pi/(?!pi-packages/)pi-[^/]+(/|$)"
   ],
   "timeoutMs": 5000
 }

package/docs/configuration.md

@@ -59,6 +59,24 @@ Only a path that matches at least one pattern is sent to the model — this is t
 An invalid regular expression is skipped with a warning.
 An empty list (the default) matches nothing, so the reviewer defers everything.
 
+Two typo shapes are worth featuring, each as its own pattern:
+
+```json
+"typoPatterns": [
+  "([^/]+)/packages/\\1(/|$)",
+  "development/pi/(?!pi-packages/)pi-[^/]+(/|$)"
+]
+```
+
+The first catches a **doubled package segment** — a package name repeated around `packages/`, e.g. `pi-permission-system/packages/pi-permission-system/…`.
+The `\1` backreference requires the segment before and after `packages/` to be identical, so it catches `<name>/packages/<name>` for every `<name>` while leaving a correct `packages/<name>/…` path untouched. (In JSON the backslash is doubled — `\\1` — so the parsed string is the regex `\1`.)
+
+The second catches a **dropped repository prefix** — a path that jumps straight to a package directory (`development/pi/pi-permission-system/…`) instead of routing through the repo's `pi-packages/packages/` directory.
+The negative lookahead `(?!pi-packages/)` exempts the correct `pi-packages` path, and `pi-[^/]+` requires a package segment after `pi-` so the sibling monorepo at `~/development/pi/pi` is left alone.
+
+Both patterns anchor the segment with `(/|$)`, not a bare trailing `/`, so a path that *ends* at the offending segment (`…/pi-permission-system`) still matches.
+Adjust the `development/pi/…` prefix to wherever your checkouts live.
+
 ### `timeoutMs`
 
 The model call is aborted after this many milliseconds, and an aborted call defers.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotgenes/pi-permission-model-judge",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Deny-first typo-path model judge — a pi-permission-system Authorizer chain link",
   "type": "module",
   "imports": {

package/src/model-review.ts

@@ -28,12 +28,26 @@ export const GENERIC_TEACHING_REASON =
 export type CompleteFn = (
   model: Model<any>,
   context: Context,
-  options?: { signal?: AbortSignal },
+  options?: {
+    signal?: AbortSignal;
+    apiKey?: string;
+    headers?: Record<string, string>;
+  },
 ) => Promise<AssistantMessage>;
 
+/**
+ * The auth resolved for a model call — structurally the `ResolvedRequestAuth`
+ * of the core `ModelRegistry`, redeclared here because that type is not
+ * re-exported from `@earendil-works/pi-coding-agent`.
+ */
+export type ResolvedRequestAuth =
+  | { ok: true; apiKey?: string; headers?: Record<string, string> }
+  | { ok: false; error: string };
+
 /** The narrow model-registry projection the reviewer needs (ISP). */
 export interface ModelRegistryLike {
   find(provider: string, modelId: string): Model<any> | undefined;
+  getApiKeyAndHeaders(model: Model<any>): Promise<ResolvedRequestAuth>;
 }
 
 /** Inputs for a single path review. */
@@ -42,6 +56,8 @@ export interface ReviewPathInputs {
   config: ModelJudgeConfig;
   model: Model<any>;
   complete: CompleteFn;
+  apiKey?: string;
+  headers?: Record<string, string>;
 }
 
 /**
@@ -70,6 +86,8 @@ export async function reviewPath(
     };
     const reply = await inputs.complete(inputs.model, context, {
       signal: controller.signal,
+      apiKey: inputs.apiKey,
+      headers: inputs.headers,
     });
     return parseVerdict(reply);
   } catch {

package/src/typo-reviewer.ts

@@ -69,14 +69,29 @@ export function createTypoReviewer(
     if (!matchesAnyTypoPattern(path, compiledFor(config))) {
       return { kind: "defer" };
     }
-    const model = deps.getRegistry()?.find(config.provider, config.model);
-    if (!model) {
+    const registry = deps.getRegistry();
+    const model = registry?.find(config.provider, config.model);
+    if (!registry || !model) {
       deps.warn?.(
         `model "${config.provider}/${config.model}" did not resolve; deferring`,
       );
       return { kind: "defer" };
     }
-    return reviewPath({ path, config, model, complete: deps.complete });
+    const auth = await registry.getApiKeyAndHeaders(model);
+    if (!auth.ok) {
+      deps.warn?.(
+        `auth for "${config.provider}/${config.model}" did not resolve (${auth.error}); deferring`,
+      );
+      return { kind: "defer" };
+    }
+    return reviewPath({
+      path,
+      config,
+      model,
+      complete: deps.complete,
+      apiKey: auth.apiKey,
+      headers: auth.headers,
+    });
   };
 }