@gotcos/glasses-server 6.44.5 → 6.44.7

package/CHANGELOG.md

@@ -1,3 +1,38 @@
+## 6.44.7
+
+One learning write: a review decision.
+
+- `POST /api/context/learning/:id/review` with `{ "decision": "dismissed" | "reopened" }`
+  appends a review-ledger row through the bridge's `learning-decide`. A
+  dismissed proposal leaves the To review set on the next read; reopened puts
+  it back. Nothing else is written: no skill, no memory, no graph. COS Control
+  0.5.191's Memories tab uses it for Dismiss and Restore proposal.
+
+## 6.44.6
+
+What /qa found in 6.44.5 before anyone installed it.
+
+- `GET /api/context/learning/review`: the strict To review set (the bridge's
+  `learning-to-review`, the same set the status block counts) as event rows,
+  one page of up to 200. 6.44.5's list approximated it with a kind filter and
+  showed "50 of 837" beside a chip that said 121.
+- Every user value now rides as one argv token (`--q=...`, `--id=...`,
+  `--entity=...`), so a search term or entity name that begins with `-` can no
+  longer be read by the bridge's argument parser as a flag.
+- An older COS bridge prints its unknown-command answer to stdout; the server
+  probed only stderr, so every learning route on such a bridge answered 503
+  instead of `cos_pipeline_not_configured`. Both are probed now.
+- A `found: false` entity answer is a 404 with a class Control can name,
+  `index_missing` or `entity_not_found`, never a 503; the null-normalizer
+  fallback says `record_not_found`.
+- `/api/context/status` answers `Cache-Control: private, no-store` like the
+  eight routes that shipped with it; it carries private counts.
+- Every learning and graph route logs the bridge failure it used to swallow,
+  and the search shape passes the bridge's own `scope` through.
+- On the COS side (same night): a JSON error exits 0 so it is parsed rather
+  than rejected, the bot-memory reach is bounded at 2.5 s so a wedged Qdrant
+  cannot blank the file stores, and entity descriptions cap at 12.
+
 ## 6.44.5
 
 Recent learning and the knowledge graph, read-only, for COS Control.
@@ -8,7 +43,7 @@ Recent learning and the knowledge graph, read-only, for COS Control.
   the command, times out, or answers `{ error }` leaves `memory` and `threads`
   exactly as they were and the two blocks absent. Nothing an existing client
   reads has changed; a client that wants the blocks checks for them.
-- Eight read routes: `GET /api/context/learning` (cursor-paged events with a
+- Seven read routes: `GET /api/context/learning` (cursor-paged events with a
   per-store coverage map), `GET /api/context/learning/status`,
   `GET /api/context/learning/:id`, `GET /api/context/graph/status`,
   `GET /api/context/graph/search`, `GET /api/context/graph/entity`,

package/README.md

@@ -425,7 +425,7 @@ coverage map), `/api/context/learning/status`, `/api/context/learning/:id`, and
 `/api/context/graph/{status,search,entity,passages}`, plus `POST
 /api/context/graph/index`, which only asks the pipeline to start a detached index
 build and answers 202. Nothing in the file tier can answer these, so they return
-503 with the bridge state there; older servers 404 them, which is how a client
+503 `cos_pipeline_not_configured` there; older servers 404 them, which is how a client
 tells the versions apart. `/api/context/status` carries `learning` and `graph`
 blocks when the bridge can produce them and omits them otherwise.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotcos/glasses-server",
-  "version": "6.44.5",
+  "version": "6.44.7",
   "description": "COS Glasses \u2014 self-hosted AI heads-up-display server for Even G2 smart glasses, powered by Claude Code, Codex, Cursor Agent CLI, or local Ollama",
   "type": "module",
   "bin": {

package/server/lib/cos-context-browser.ts

@@ -472,6 +472,8 @@ export function normalizeGraphBlock(value: unknown): GraphBlock | null {
 export const LEARNING_EVENT_ID_PATTERN = /^evt_[a-f0-9]{16}$/
 export const LEARNING_EVENT_TYPES = new Set(['captured', 'proposed', 'promotable', 'saved', 'retrieved', 'used', 'checked', 'dismissed', 'reverted', 'reopened', 'consolidated', 'previewed'])
 const LEARNING_LIST_LIMIT = 50
+/** The strict To review set is small (121 today); one page shows it whole. */
+export const LEARNING_REVIEW_LIMIT = 200
 const LEARNING_DETAIL_KEYS = ['shape', 'task', 'kind', 'layer', 'date', 'future', 'logged_times', 'memory_type', 'capture', 'source', 'content', 'before', 'after', 'rule', 'status', 'occurrences', 'threshold', 'entry', 'truncated'] as const
 
 export interface LearningEvent {
@@ -553,11 +555,11 @@ export function normalizeLearningCoverage(value: unknown): LearningCoverage {
   return out
 }
 
-export function normalizeLearningEvents(value: unknown, limit: number): {
+export function normalizeLearningEvents(value: unknown, limit: number, max = LEARNING_LIST_LIMIT): {
   events: LearningEvent[]; total: number; next_cursor: { since_ts: string; since_event_id: string } | null; coverage: LearningCoverage
 } {
   const source = asRecord(value) ?? {}
-  const cap = Math.max(1, Math.min(limit, LEARNING_LIST_LIMIT))
+  const cap = Math.max(1, Math.min(limit, max))
   const events = (Array.isArray(source.events) ? source.events : []).slice(0, cap)
     .map(item => normalizeLearningEvent(item, 240)).filter((e): e is LearningEvent => !!e)
   const cursor = asRecord(source.next_cursor)
@@ -568,6 +570,7 @@ export function normalizeLearningEvents(value: unknown, limit: number): {
     total: integerOrAbsent(source.total) ?? events.length,
     next_cursor: sinceTs && sinceId ? { since_ts: sinceTs, since_event_id: sinceId } : null,
     coverage: normalizeLearningCoverage(source.coverage),
+    ...(integerOrAbsent(source.review_count) !== undefined ? { review_count: integerOrAbsent(source.review_count) } : {}),
   }
 }
 
@@ -579,7 +582,6 @@ export function normalizeLearningEventDetail(value: unknown): (LearningEvent & {
   for (const key of LEARNING_DETAIL_KEYS) {
     const item = raw[key]
     if (item === undefined || item === null) continue
-    if (key === 'bodies' as string) continue
     if (typeof item === 'boolean') detail[key] = item
     else if (Number.isInteger(item)) detail[key] = item
     else if (typeof item === 'string') detail[key] = cleanContextText(item, 1200)
@@ -708,7 +710,7 @@ export function normalizeGraphSearch(value: unknown, limit: number): Record<stri
   return {
     items,
     total: integerOrAbsent(source.total) ?? items.length,
-    scope: 'full-index',
+    scope: stringOrAbsent(source.scope, 32) ?? 'full-index',
     index_built_at: isoOrAbsent(source.index_built_at) ?? null,
     index_state: stringOrAbsent(source.index_state, 32) ?? 'missing',
     matcher: stringOrAbsent(source.matcher, 16) ?? null,
@@ -774,6 +776,23 @@ export function normalizeGraphPassages(value: unknown): Record<string, unknown>
   }
 }
 
+/** The review decision the bridge wrote back: lesson, decision, stamp, id, who. */
+export function normalizeReviewDecision(value: unknown): Record<string, unknown> | null {
+  const source = asRecord(value)
+  const row = asRecord(source?.decision)
+  if (!row) return null
+  const decision = stringOrAbsent(row.decision, 16)
+  const lessonId = stringOrAbsent(row.lesson_id, 200)
+  if (!lessonId || (decision !== 'dismissed' && decision !== 'reopened')) return null
+  return {
+    lesson_id: lessonId,
+    decision,
+    ts: isoOrAbsent(row.ts) ?? null,
+    event_id: LEARNING_EVENT_ID_PATTERN.test(String(row.event_id ?? '')) ? String(row.event_id) : null,
+    by: stringOrAbsent(row.by, 32) ?? null,
+  }
+}
+
 export function normalizeIndexBuildKickoff(value: unknown): { started: boolean; already_running: boolean; pid: number | null; receipt: Record<string, unknown> | null } {
   const source = asRecord(value) ?? {}
   return {

package/server/lib/python-bridge.ts

@@ -55,6 +55,8 @@ export const LEARNING_COMMANDS = [
   'graph-entity',
   'graph-passages',
   'graph-index-build',
+  'learning-to-review',
+  'learning-decide',
 ] as const
 
 // The optional Python bridge is available only when the user points us at a real
@@ -226,6 +228,8 @@ function standaloneNoop(args: string[]): unknown {
     case 'graph-entity':
     case 'graph-passages':
     case 'graph-index-build':
+    case 'learning-to-review':
+    case 'learning-decide':
       return { error: 'cos_pipeline_not_configured' }
     case 'task-rows':
     case 'task-capture':
@@ -255,7 +259,10 @@ function callPythonDirect(args: string[], timeoutMs: number, input?: string): Pr
       { cwd: COS_SCRIPTS_DIR!, timeout: timeoutMs, maxBuffer: 1024 * 1024 },
       (err, stdout, stderr) => {
         if (err) {
-          const msg = stderr?.trim() || err.message
+          // The bridge prints its unknown-command answer to STDOUT and exits 1
+          // (cos_api_bridge.py), so an older checkout must be probed there too, or
+          // every learning route answers 503 instead of not-configured (QA 2026-09-06).
+          const msg = stderr?.trim() || stdout?.trim() || err.message
           if (typeof msg === 'string' && msg.includes('unknown command')) {
             return resolvePromise({ error: { code: 'cos_pipeline_not_configured', message: msg } })
           }

package/server/routes/memory.ts

@@ -13,7 +13,7 @@ import { searchMemories } from '../lib/context-library-search.js'
 function contextConfigured(): boolean {
   return contextSourceAvailable() !== null
 }
-import {
+import { normalizeReviewDecision, LEARNING_REVIEW_LIMIT,
   GRAPH_ENTITY_ID_LIMIT,
   LEARNING_EVENT_ID_PATTERN,
   MEMORY_ID_PATTERN,
@@ -35,6 +35,7 @@ export const memoryRouter = Router()
 let overviewCache: { expiresAt: number; value: ReturnType<typeof normalizeMemoryOverview> } | null = null
 
 memoryRouter.get('/context/status', async (_req, res) => {
+  noStore(res)
   if (!contextConfigured()) {
     const state = pythonBridgeState()
     res.json(normalizeContextBrowserStatus({
@@ -105,7 +106,7 @@ function sendBridgeAnswer(res: import('express').Response, data: unknown, normal
   }
   const value = normalize(data)
   if (value === null || value === undefined) {
-    res.status(404).json({ error: 'not_found' })
+    res.status(404).json({ error: 'record_not_found' })
     return
   }
   res.json(value)
@@ -124,7 +125,8 @@ memoryRouter.get('/context/learning/status', async (_req, res) => {
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
   try {
     sendBridgeAnswer(res, await callPython(['learning-status', '--no-memory'], 8_000), normalizeLearningStatus)
-  } catch {
+  } catch (error) {
+    console.warn('[context] learning bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'learning_unavailable' })
   }
 })
@@ -137,13 +139,50 @@ memoryRouter.get('/context/learning', async (req, res) => {
   const sinceTs = typeof req.query.since_ts === 'string' && Number.isFinite(Date.parse(req.query.since_ts)) ? req.query.since_ts.slice(0, 40) : ''
   const sinceId = typeof req.query.since_event_id === 'string' && LEARNING_EVENT_ID_PATTERN.test(req.query.since_event_id) ? req.query.since_event_id : ''
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
-  const args = ['learning-events', '--days', String(days), '--limit', String(limit)]
-  if (kind) args.push('--kind', kind)
-  if (sinceTs) args.push('--since-ts', sinceTs)
-  if (sinceId) args.push('--since-event-id', sinceId)
+  const args = ['learning-events', `--days=${days}`, `--limit=${limit}`]
+  if (kind) args.push(`--kind=${kind}`)
+  if (sinceTs) args.push(`--since-ts=${sinceTs}`)
+  if (sinceId) args.push(`--since-event-id=${sinceId}`)
   try {
     sendBridgeAnswer(res, await callPython(args, 8_000), value => normalizeLearningEvents(value, limit))
-  } catch {
+  } catch (error) {
+    console.warn('[context] learning bridge failure:', (error as Error).message)
+    res.status(503).json({ error: 'learning_unavailable' })
+  }
+})
+
+memoryRouter.get('/context/learning/review', async (req, res) => {
+  noStore(res)
+  // The strict To review set (learning_events.to_review) as event rows, so the
+  // chip, Doctor and the list count the same thing. Small set: one page.
+  const limit = boundedInteger(req.query.limit, LEARNING_REVIEW_LIMIT, 1, LEARNING_REVIEW_LIMIT)
+  const days = req.query.days === undefined ? null : boundedInteger(req.query.days, 3650, 1, 3650)
+  if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
+  try {
+    const args = ['learning-to-review', `--limit=${limit}`, ...(days ? [`--days=${days}`] : [])]
+    sendBridgeAnswer(res, await callPython(args, 8_000), value => normalizeLearningEvents(value, limit, LEARNING_REVIEW_LIMIT))
+  } catch (error) {
+    console.warn('[context] learning review bridge failure:', (error as Error).message)
+    res.status(503).json({ error: 'learning_unavailable' })
+  }
+})
+
+memoryRouter.post('/context/learning/:id/review', async (req, res) => {
+  noStore(res)
+  // The one learning write (6.44.7): a review decision on a lesson, appended to
+  // the review ledger by the bridge. Dismissed leaves To review, reopened
+  // returns; nothing else is touched. The lesson id is a store id, not an event id.
+  const lessonId = String(req.params.id)
+  const decision = typeof req.body?.decision === 'string' ? req.body.decision : ''
+  if (!lessonId || lessonId.length > 200 || CONTROL_CHARACTER.test(lessonId)) { res.status(400).json({ error: 'invalid_lesson_id' }); return }
+  if (decision !== 'dismissed' && decision !== 'reopened') { res.status(400).json({ error: 'invalid_decision' }); return }
+  if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
+  try {
+    const note = typeof req.body?.note === 'string' ? req.body.note.slice(0, 400) : ''
+    const answer = await callPython(['learning-decide', `--id=${lessonId}`, `--decision=${decision}`, ...(note ? [`--note=${note}`] : [])], 8_000)
+    sendBridgeAnswer(res, answer, value => normalizeReviewDecision(value))
+  } catch (error) {
+    console.warn('[context] learning decide bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'learning_unavailable' })
   }
 })
@@ -153,8 +192,9 @@ memoryRouter.get('/context/learning/:id', async (req, res) => {
   if (!LEARNING_EVENT_ID_PATTERN.test(req.params.id)) { res.status(400).json({ error: 'invalid_event_id' }); return }
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
   try {
-    sendBridgeAnswer(res, await callPython(['learning-event', '--id', req.params.id], 8_000), normalizeLearningEventDetail)
-  } catch {
+    sendBridgeAnswer(res, await callPython(['learning-event', `--id=${req.params.id}`], 8_000), normalizeLearningEventDetail)
+  } catch (error) {
+    console.warn('[context] learning bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'learning_unavailable' })
   }
 })
@@ -166,7 +206,8 @@ memoryRouter.get('/context/graph/status', async (_req, res) => {
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
   try {
     sendBridgeAnswer(res, await callPython(['graph-status'], 8_000), normalizeGraphStatus)
-  } catch {
+  } catch (error) {
+    console.warn('[context] graph bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'graph_unavailable' })
   }
 })
@@ -182,11 +223,14 @@ memoryRouter.get('/context/graph/search', async (req, res) => {
   const offset = boundedInteger(req.query.offset, 0, 0, 100_000)
   const type = typeof req.query.type === 'string' ? req.query.type.replace(/[^A-Za-z0-9_ -]/g, '').slice(0, 40) : ''
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
-  const args = ['graph-search', '--q', query, '--limit', String(limit), '--offset', String(offset)]
-  if (type) args.push('--type', type)
+  // One token per value (`--q=...`): a value beginning with `-` is then never
+  // read by argparse as a flag (QA 2026-09-06).
+  const args = ['graph-search', `--q=${query}`, `--limit=${limit}`, `--offset=${offset}`]
+  if (type) args.push(`--type=${type}`)
   try {
     sendBridgeAnswer(res, await callPython(args, 8_000), value => normalizeGraphSearch(value, limit))
-  } catch {
+  } catch (error) {
+    console.warn('[context] graph bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'graph_unavailable' })
   }
 })
@@ -202,9 +246,16 @@ memoryRouter.get('/context/graph/entity', async (req, res) => {
   const offset = boundedInteger(req.query.offset, 0, 0, 100_000)
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
   try {
-    sendBridgeAnswer(res, await callPython(['graph-entity', '--id', id, '--offset', String(offset), '--limit', String(limit)], 8_000),
-      value => normalizeGraphEntity(value))
-  } catch {
+    const answer = await callPython(['graph-entity', `--id=${id}`, `--offset=${offset}`, `--limit=${limit}`], 8_000)
+    // A no-index or unknown-entity answer is a PAYLOAD from the bridge (found: false);
+    // it becomes a 404 with the class Control renders, never a 503 (QA 2026-09-06).
+    if (bridgePayload(answer) && answer.found !== true) {
+      res.status(404).json({ error: answer.index_state === 'missing' ? 'index_missing' : 'entity_not_found' })
+      return
+    }
+    sendBridgeAnswer(res, answer, value => normalizeGraphEntity(value))
+  } catch (error) {
+    console.warn('[context] graph bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'graph_unavailable' })
   }
 })
@@ -222,11 +273,12 @@ memoryRouter.get('/context/graph/passages', async (req, res) => {
   const limit = boundedInteger(req.query.limit, 5, 1, 5)
   if (!contextConfigured()) { res.status(503).json({ error: pythonBridgeState() }); return }
   const args = entity
-    ? ['graph-passages', '--entity', entity, '--limit', String(limit)]
-    : ['graph-passages', '--relation-a', relationA, '--relation-b', relationB, '--limit', String(limit)]
+    ? ['graph-passages', `--entity=${entity}`, `--limit=${limit}`]
+    : ['graph-passages', `--relation-a=${relationA}`, `--relation-b=${relationB}`, `--limit=${limit}`]
   try {
     sendBridgeAnswer(res, await callPython(args, 8_000), normalizeGraphPassages)
-  } catch {
+  } catch (error) {
+    console.warn('[context] graph bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'graph_unavailable' })
   }
 })
@@ -245,7 +297,8 @@ memoryRouter.post('/context/graph/index', async (_req, res) => {
     const code = bridgeErrorCode(data)
     if (code) { res.status(503).json({ error: code }); return }
     res.status(202).json(normalizeIndexBuildKickoff(data))
-  } catch {
+  } catch (error) {
+    console.warn('[context] graph bridge failure:', (error as Error).message)
     res.status(503).json({ error: 'graph_unavailable' })
   }
 })