@gotcos/glasses-server 6.44.3 → 6.44.4

package/CHANGELOG.md

@@ -1,3 +1,22 @@
+## 6.44.4
+
+Stage, a finish line, and no dispatch without one.
+
+- A task row carries `stage` (planning, active or review) and `doneWhen`. Both
+  live in the tasks.md line, not a sidecar: the task id is a sha256 of the
+  normalized description, so an id-keyed store would orphan itself the first time
+  the text was edited. An unmarked row reads as planning, so nothing needed
+  migrating.
+- `PATCH /api/tasks/:id` accepts `stage` and `doneWhen`.
+- **`runTaskNow` refuses a task with no finish line**, `409 done_when_required`,
+  at the single choke point every dispatch passes through. An agent sent at a
+  task with no definition of done cannot succeed at it and cannot be judged to
+  have failed either.
+- Fixes a round-trip bug older than this release: the writer joins end-of-line
+  markers with spaces while the reader's regex allowed none between them, so a
+  row carrying both a run time and an agent marker silently lost the run time on
+  every read.
+
 ## 6.44.3
 
 A task row carries enough to show and edit it.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotcos/glasses-server",
-  "version": "6.44.3",
+  "version": "6.44.4",
   "description": "COS Glasses \u2014 self-hosted AI heads-up-display server for Even G2 smart glasses, powered by Claude Code, Codex, Cursor Agent CLI, or local Ollama",
   "type": "module",
   "bin": {

package/server/lib/task-dispatcher.ts

@@ -358,6 +358,16 @@ export async function runTaskNow(id: string, domain: string, injected?: TaskDisp
   if (row.agent_state === 'running') {
     throw new TaskRunError(409, 'task_running', 'A run is already in flight for this task.')
   }
+  // No finish line, no dispatch. An agent sent at a task with no definition of
+  // done cannot succeed at it and cannot be judged to have failed either, so
+  // this fails closed at the one choke point every dispatch passes through.
+  if (!row.done_when || !row.done_when.trim()) {
+    throw new TaskRunError(
+      409,
+      'done_when_required',
+      'Say what done looks like before running this task.',
+    )
+  }
   const runAt = parseRunAt(row.run_at)
   if (runAt && runAt.day > clock.day) {
     throw new TaskRunError(409, 'scheduled_future', 'Run now is not allowed on a future scheduled task.')

package/server/lib/task-store.ts

@@ -102,6 +102,12 @@ export interface BridgeTaskRow {
   agent_no: number | null
   section: string
   section_day: string | null
+  /** Workflow stage. null/absent means planning, the unmarked default.
+   *  Optional so new server code against an older bridge degrades to planning
+   *  rather than throwing during a partial deploy. */
+  stage?: 'planning' | 'active' | 'review' | null
+  /** The finish line. A dispatch is refused while this is empty. */
+  done_when?: string | null
 }
 
 export interface TaskFlags {
@@ -112,6 +118,10 @@ export interface TaskFlags {
   carriedOver: boolean
 }
 
+/** Board stage. Planning is the default and carries no marker in tasks.md. */
+export type TaskStage = 'planning' | 'active' | 'review'
+export const TASK_STAGES: readonly TaskStage[] = ['planning', 'active', 'review']
+
 export interface TaskBoardRow {
   id: string
   ref: string
@@ -131,6 +141,9 @@ export interface TaskBoardRow {
   runAt?: string
   section: string
   sectionDay?: string
+  stage: TaskStage
+  /** Absent until someone says what finished looks like. Gates `run`. */
+  doneWhen?: string
   due: boolean
   missed: boolean
   failed: boolean
@@ -414,6 +427,8 @@ export function projectRow(
     ...(runAt ? { runAt: new Date(taskInstant(runAt.day, runAt.minutes, tz)).toISOString() } : {}),
     section: row.section,
     ...(row.section_day ? { sectionDay: row.section_day } : {}),
+    stage: row.stage ?? 'planning',
+    ...(row.done_when ? { doneWhen: row.done_when } : {}),
     ...mark,
   }
 }
@@ -486,6 +501,26 @@ export async function setTaskText(domain: string, id: string, text: string): Pro
   await withLockRetry(() => bridge(['task-set-text', domain, id], clean))
 }
 
+/** Move a task between board stages. 'planning' clears the marker. */
+export async function setTaskStage(domain: string, id: string, stage: TaskStage): Promise<void> {
+  if (!TASK_STAGES.includes(stage)) {
+    throw new TaskRunError(422, 'invalid_stage', `stage must be one of ${TASK_STAGES.join(', ')}`)
+  }
+  await withLockRetry(() => bridge(['task-set-stage', domain, id, stage === 'planning' ? '--clear' : stage]))
+}
+
+/** Set or clear the finish line. Empty clears it, which re-blocks `run`. */
+export async function setTaskDoneWhen(domain: string, id: string, text: string): Promise<void> {
+  const clean = text.replace(/\s+/g, ' ').trim()
+  if (clean.length > 500) {
+    throw new TaskRunError(422, 'done_when_too_long', 'done_when must be 500 characters or fewer')
+  }
+  if (clean.includes('**')) {
+    throw new TaskRunError(422, 'invalid_done_when', 'done_when cannot contain ** markup')
+  }
+  await withLockRetry(() => bridge(['task-set-done-when', domain, id], clean))
+}
+
 export async function moveTask(domain: string, id: string, section: string, nowMs = Date.now()): Promise<void> {
   const { clock } = briefContext(nowMs)
   const args = ['task-move', domain, id, '--section', section]

package/server/routes/tasks.ts

@@ -19,6 +19,9 @@ import {
   taskDomains,
   tasksGate,
   workBadgeCount,
+  setTaskStage,
+  setTaskDoneWhen,
+  type TaskStage,
 } from '../lib/task-store.js'
 
 export const tasksRouter = Router()
@@ -191,8 +194,12 @@ tasksRouter.patch('/tasks/:id', async (req, res) => {
       await moveTask(domain, req.params.id, String(body.section))
     } else if ('checked' in body) {
       await checkTask({ domain, id: req.params.id, checked: body.checked === true })
+    } else if ('stage' in body) {
+      await setTaskStage(domain, req.params.id, String(body.stage) as TaskStage)
+    } else if ('doneWhen' in body) {
+      await setTaskDoneWhen(domain, req.params.id, body.doneWhen == null ? '' : String(body.doneWhen))
     } else {
-      throw new TaskRunError(400, 'invalid_patch', 'Expected text, runAt, section, or checked.')
+      throw new TaskRunError(400, 'invalid_patch', 'Expected text, runAt, section, checked, stage, or doneWhen.')
     }
     res.json({ ok: true })
   } catch (error) {