@gotcos/glasses-server 6.21.18 → 6.21.20

package/CHANGELOG.md

@@ -1,3 +1,38 @@
+## 6.21.20
+
+- Audio playback works at all. Every play button in the Control speaker review
+  returned a 404 and made no sound, on every default install, since playback
+  shipped. `res.sendFile` delegates to `send`, which defaults to
+  `dotfiles: 'ignore'` and — with no `root` set — applies that policy to the
+  WHOLE absolute path rather than to anything the request supplied. The default
+  data home is `~/.cos-glasses/data`, and `.cos-glasses` is a dot component, so
+  the file was found, confirmed to exist, then refused on the way out the door.
+  All three audio routes were affected: meeting chunks, speaker-profile samples,
+  and ext-audio samples.
+
+  The tests could not have caught this. They point `COS_DATA_DIR` at
+  `mktemp -d` — `/var/folders/...` — which cannot contain a dot component, so
+  the suite was structurally incapable of reproducing a default install and
+  stayed green while the feature was dead. The three routes now share
+  `sendAudioFile`, and `send-audio.test.ts` serves from a dot-directory on
+  purpose, over a real listener, asserting on the returned bytes.
+
+## 6.21.19
+
+- Review playback falls back to ext-audio. The 7-day archive introduced in
+  6.21.18 is FORWARD-ONLY — it starts filling when a meeting is saved under that
+  version — so on upgrade day the panel had no play buttons at all, which is what
+  Miles hit. ext-audio already holds 72 hours of unrecognised-speaker audio keyed
+  by the same raw capture index; measured across 14 real meetings, 90-100% of
+  those files correspond to a chunk the sidecar labels `Ext`. That is exactly the
+  set a reviewer most needs to hear.
+- `GET /meeting/:id/audio` merges both sources and reports `archivedChunks` and
+  `extAudioChunks` separately, because the windows differ (7 days vs 72 hours)
+  and a single retention figure would be wrong for half the list.
+- Published under its own version rather than re-cutting 6.21.18: that version is
+  already on npm, and two different artifacts sharing a version number is a
+  defect in its own right.
+
 ## 6.21.18
 
 Everything a human needs to correct who spoke, and to hear the voice before

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotcos/glasses-server",
-  "version": "6.21.18",
+  "version": "6.21.20",
   "description": "COS Glasses — self-hosted AI heads-up-display server for Even G2 smart glasses, powered by Claude Code, Codex, or Cursor Agent CLI",
   "type": "module",
   "bin": {

package/server/lib/meeting-audio-archive.ts

@@ -213,6 +213,56 @@ export function meetingAudioChunkPath(sessionId: string, chunkIndex: number): st
   return existsSync(path) ? path : null
 }
 
+/**
+ * Fallback source: audio the capture path saved for an UNRECOGNISED speaker.
+ *
+ * `ext-audio/<sessionId>/ext_chunk<N>_<ts>.wav` is written live whenever the
+ * identifier finds no match, and `<N>` is the same RAW capture index the review
+ * addresses. Verified across 14 real meetings: 90-100% of these files correspond
+ * to a chunk the sidecar labels `Ext`.
+ *
+ * This matters because the 7-day archive is FORWARD-ONLY — it starts filling
+ * when a meeting is saved under 6.21.18, so on the day of that upgrade there is
+ * nothing to play. ext-audio already holds the unidentified voices from the last
+ * 72 hours, which is exactly the set a reviewer most needs to hear.
+ *
+ * Shorter window than the archive (72h vs 7 days), so the listing reports which
+ * source a chunk came from rather than implying one retention rule.
+ */
+export function extAudioChunkPath(sessionId: string, chunkIndex: number): string | null {
+  if (!/^[A-Za-z0-9:_-]{3,96}$/.test(sessionId)) return null
+  const dir = join(dataPath('ext-audio'), sessionId.replace(/:/g, '_'))
+  if (!resolve(dir).startsWith(resolve(dataPath('ext-audio')) + '/') || !existsSync(dir)) return null
+  try {
+    // Timestamped suffix, so match on the index and take the newest.
+    const prefix = `ext_chunk${chunkIndex}_`
+    const hits = readdirSync(dir).filter(n => n.startsWith(prefix) && n.endsWith('.wav')).sort()
+    const pick = hits[hits.length - 1]
+    if (!pick) return null
+    const path = resolve(dir, pick)
+    return resolve(path).startsWith(resolve(dir) + '/') ? path : null
+  } catch {
+    return null
+  }
+}
+
+/** Raw chunk indices this session has ext-audio for, ascending. */
+export function listExtAudioChunks(sessionId: string): number[] {
+  if (!/^[A-Za-z0-9:_-]{3,96}$/.test(sessionId)) return []
+  const dir = join(dataPath('ext-audio'), sessionId.replace(/:/g, '_'))
+  if (!existsSync(dir)) return []
+  try {
+    const out = new Set<number>()
+    for (const n of readdirSync(dir)) {
+      const m = /^ext_chunk(\d+)_.*\.wav$/.exec(n)
+      if (m) out.add(Number(m[1]))
+    }
+    return [...out].sort((a, b) => a - b)
+  } catch {
+    return []
+  }
+}
+
 /** Chunk indices retained for a session, ascending. */
 export function listMeetingAudioChunks(sessionId: string): number[] {
   const dir = sessionDir(sessionId)

package/server/lib/send-audio.ts

@@ -0,0 +1,42 @@
+// Serving a retained WAV back to a reviewer.
+//
+// WHY THIS EXISTS AT ALL, because `res.sendFile(path)` looks like it would do.
+//
+// `send` (what Express delegates to) defaults to `dotfiles: 'ignore'`, and when
+// no `root` option is given it applies that policy to the ENTIRE absolute path,
+// not to the part a request supplied:
+//
+//   parts = normalize(path).split(sep)      // send/index.js — the whole path
+//   if (containsDotFile(parts)) ... error(404)
+//
+// The COS data home is `~/.cos-glasses/data` by default. `.cos-glasses` is a
+// dot component, so every audio route 404'd on every default install — the play
+// button rendered, the fetch failed, and nothing was heard. Verified directly
+// against the installed module: `{}` -> 404, `{dotfiles:'allow'}` -> resolves.
+//
+// The tests never caught it because they point `COS_DATA_DIR` at
+// `mktemp -d` (`/var/folders/...`), which structurally CANNOT contain a dot
+// component. The suite was green and the feature was dead. `send-audio.test.ts`
+// serves from a dot-directory on purpose.
+//
+// 'allow' is safe here rather than merely convenient: the dot component is ours
+// (the data home), and nothing a caller supplies can introduce one. Every route
+// resolves its path through a validator first — `sessionId` and speaker names
+// match `[A-Za-z0-9:_-]`, chunk indices are integers, and the archive helpers
+// re-check containment before returning. The path handed to this function is
+// already known to exist and to live under the data dir.
+
+import type { Response } from 'express'
+
+/**
+ * Send a WAV that has already been resolved and containment-checked.
+ *
+ * Callers must have verified the file exists; a missing file here surfaces as
+ * send's own 404 HTML rather than the route's JSON, which is exactly the
+ * confusing failure this module documents.
+ */
+export function sendAudioFile(res: Response, path: string): void {
+  res.type('audio/wav')
+  // See the file header: without this, any data home under a dot-directory 404s.
+  res.sendFile(path, { dotfiles: 'allow' })
+}

package/server/routes/meeting.ts

@@ -10,7 +10,10 @@ import { cleanTranscriptLines } from '../lib/hallucination-filter.js'
 import { durableAtomicWriteFileSync } from '../lib/atomic-fs.js'
 import { appendCorrection, pendingCorrections } from '../lib/meeting-corrections.js'
 import { isSampleFromSession, untraceableSampleCount } from '../lib/training-audio-provenance.js'
+import { sendAudioFile } from '../lib/send-audio.js'
 import {
+  extAudioChunkPath,
+  listExtAudioChunks,
   listMeetingAudioChunks,
   meetingAudioChunkPath,
   meetingAudioRetentionDays,
@@ -1151,9 +1154,18 @@ export function createMeetingRouter(deps: MeetingRouteDependencies = {}): Router
       res.status(400).json({ error: 'Invalid chunkIndex', reason: 'invalid_chunk_index' })
       return
     }
+    // Archive first, then the live ext-audio the capture path already saved for
+    // unrecognised speakers. The archive is forward-only, so without this
+    // fallback there is nothing to play on any meeting predating 6.21.18 — while
+    // 72 hours of unidentified-voice audio is sitting right there, and an
+    // unidentified voice is exactly what a reviewer needs to hear.
     const path = meetingAudioChunkPath(sessionId, chunkIndex)
+      ?? extAudioChunkPath(sessionId, chunkIndex)
     if (!path) {
-      const retained = listMeetingAudioChunks(sessionId)
+      const retained = [...new Set([
+        ...listMeetingAudioChunks(sessionId),
+        ...listExtAudioChunks(sessionId),
+      ])].sort((a, b) => a - b)
       res.status(404).json({
         error: retained.length === 0
           ? 'No audio retained for this meeting'
@@ -1167,8 +1179,7 @@ export function createMeetingRouter(deps: MeetingRouteDependencies = {}): Router
       })
       return
     }
-    res.type('audio/wav')
-    res.sendFile(path)
+    sendAudioFile(res, path)
   })
 
   /** What audio a meeting still has, so the panel can show play buttons only
@@ -1180,11 +1191,17 @@ export function createMeetingRouter(deps: MeetingRouteDependencies = {}): Router
       res.status(400).json({ error: 'Invalid sessionId', reason: 'invalid_session_id' })
       return
     }
-    const chunks = listMeetingAudioChunks(sessionId)
+    const archived = listMeetingAudioChunks(sessionId)
+    const ext = listExtAudioChunks(sessionId)
+    const chunks = [...new Set([...archived, ...ext])].sort((a, b) => a - b)
     res.json({
       sessionId,
       retained: chunks.length > 0,
       chunks,
+      // Reported separately: ext-audio runs a 72h window, the archive 7 days, so
+      // one retention number would be wrong for half the list.
+      archivedChunks: archived.length,
+      extAudioChunks: ext.length,
       // Config read, not a filesystem walk: this route used to stat every
       // retained chunk to report one number.
       retentionDays: meetingAudioRetentionDays(),

package/server/routes/voice.ts

@@ -11,6 +11,7 @@ import { getOwnerSpeakerLabel } from '../lib/profile.js'
 import { dataPath } from '../lib/data-dir.js'
 import { purgeSpeakerCalibrationRows, relabelSpeakerCalibrationRows } from '../lib/speaker-calibration-log.js'
 import { trainingSourceFor } from '../lib/training-audio-provenance.js'
+import { sendAudioFile } from '../lib/send-audio.js'
 
 // These MUST match the writer in transcribe-stream.ts, which saves under
 // dataPath(). They previously resolved relative to __dirname — i.e. inside the
@@ -471,8 +472,7 @@ voiceRouter.get('/voice/profiles/:name/sample', (req, res) => {
     })
     return
   }
-  res.type('audio/wav')
-  res.sendFile(wav)
+  sendAudioFile(res, wav)
 })
 
 // GET /api/voice/ext-audio/:sessionId/sample — hear an unidentified voice.
@@ -492,8 +492,7 @@ voiceRouter.get('/voice/ext-audio/:sessionId/sample', (req, res) => {
     })
     return
   }
-  res.type('audio/wav')
-  res.sendFile(wav)
+  sendAudioFile(res, wav)
 })
 
 // GET /api/voice/profiles — enrolled people with sample counts and provenance.