@gotcos/glasses-server 6.21.18 → 6.21.19

package/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 6.21.19
+
+- Review playback falls back to ext-audio. The 7-day archive introduced in
+  6.21.18 is FORWARD-ONLY — it starts filling when a meeting is saved under that
+  version — so on upgrade day the panel had no play buttons at all, which is what
+  Miles hit. ext-audio already holds 72 hours of unrecognised-speaker audio keyed
+  by the same raw capture index; measured across 14 real meetings, 90-100% of
+  those files correspond to a chunk the sidecar labels `Ext`. That is exactly the
+  set a reviewer most needs to hear.
+- `GET /meeting/:id/audio` merges both sources and reports `archivedChunks` and
+  `extAudioChunks` separately, because the windows differ (7 days vs 72 hours)
+  and a single retention figure would be wrong for half the list.
+- Published under its own version rather than re-cutting 6.21.18: that version is
+  already on npm, and two different artifacts sharing a version number is a
+  defect in its own right.
+
 ## 6.21.18
 
 Everything a human needs to correct who spoke, and to hear the voice before

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gotcos/glasses-server",
-  "version": "6.21.18",
+  "version": "6.21.19",
   "description": "COS Glasses — self-hosted AI heads-up-display server for Even G2 smart glasses, powered by Claude Code, Codex, or Cursor Agent CLI",
   "type": "module",
   "bin": {

package/server/lib/meeting-audio-archive.ts

@@ -213,6 +213,56 @@ export function meetingAudioChunkPath(sessionId: string, chunkIndex: number): st
   return existsSync(path) ? path : null
 }
 
+/**
+ * Fallback source: audio the capture path saved for an UNRECOGNISED speaker.
+ *
+ * `ext-audio/<sessionId>/ext_chunk<N>_<ts>.wav` is written live whenever the
+ * identifier finds no match, and `<N>` is the same RAW capture index the review
+ * addresses. Verified across 14 real meetings: 90-100% of these files correspond
+ * to a chunk the sidecar labels `Ext`.
+ *
+ * This matters because the 7-day archive is FORWARD-ONLY — it starts filling
+ * when a meeting is saved under 6.21.18, so on the day of that upgrade there is
+ * nothing to play. ext-audio already holds the unidentified voices from the last
+ * 72 hours, which is exactly the set a reviewer most needs to hear.
+ *
+ * Shorter window than the archive (72h vs 7 days), so the listing reports which
+ * source a chunk came from rather than implying one retention rule.
+ */
+export function extAudioChunkPath(sessionId: string, chunkIndex: number): string | null {
+  if (!/^[A-Za-z0-9:_-]{3,96}$/.test(sessionId)) return null
+  const dir = join(dataPath('ext-audio'), sessionId.replace(/:/g, '_'))
+  if (!resolve(dir).startsWith(resolve(dataPath('ext-audio')) + '/') || !existsSync(dir)) return null
+  try {
+    // Timestamped suffix, so match on the index and take the newest.
+    const prefix = `ext_chunk${chunkIndex}_`
+    const hits = readdirSync(dir).filter(n => n.startsWith(prefix) && n.endsWith('.wav')).sort()
+    const pick = hits[hits.length - 1]
+    if (!pick) return null
+    const path = resolve(dir, pick)
+    return resolve(path).startsWith(resolve(dir) + '/') ? path : null
+  } catch {
+    return null
+  }
+}
+
+/** Raw chunk indices this session has ext-audio for, ascending. */
+export function listExtAudioChunks(sessionId: string): number[] {
+  if (!/^[A-Za-z0-9:_-]{3,96}$/.test(sessionId)) return []
+  const dir = join(dataPath('ext-audio'), sessionId.replace(/:/g, '_'))
+  if (!existsSync(dir)) return []
+  try {
+    const out = new Set<number>()
+    for (const n of readdirSync(dir)) {
+      const m = /^ext_chunk(\d+)_.*\.wav$/.exec(n)
+      if (m) out.add(Number(m[1]))
+    }
+    return [...out].sort((a, b) => a - b)
+  } catch {
+    return []
+  }
+}
+
 /** Chunk indices retained for a session, ascending. */
 export function listMeetingAudioChunks(sessionId: string): number[] {
   const dir = sessionDir(sessionId)

package/server/routes/meeting.ts

@@ -11,6 +11,8 @@ import { durableAtomicWriteFileSync } from '../lib/atomic-fs.js'
 import { appendCorrection, pendingCorrections } from '../lib/meeting-corrections.js'
 import { isSampleFromSession, untraceableSampleCount } from '../lib/training-audio-provenance.js'
 import {
+  extAudioChunkPath,
+  listExtAudioChunks,
   listMeetingAudioChunks,
   meetingAudioChunkPath,
   meetingAudioRetentionDays,
@@ -1151,9 +1153,18 @@ export function createMeetingRouter(deps: MeetingRouteDependencies = {}): Router
       res.status(400).json({ error: 'Invalid chunkIndex', reason: 'invalid_chunk_index' })
       return
     }
+    // Archive first, then the live ext-audio the capture path already saved for
+    // unrecognised speakers. The archive is forward-only, so without this
+    // fallback there is nothing to play on any meeting predating 6.21.18 — while
+    // 72 hours of unidentified-voice audio is sitting right there, and an
+    // unidentified voice is exactly what a reviewer needs to hear.
     const path = meetingAudioChunkPath(sessionId, chunkIndex)
+      ?? extAudioChunkPath(sessionId, chunkIndex)
     if (!path) {
-      const retained = listMeetingAudioChunks(sessionId)
+      const retained = [...new Set([
+        ...listMeetingAudioChunks(sessionId),
+        ...listExtAudioChunks(sessionId),
+      ])].sort((a, b) => a - b)
       res.status(404).json({
         error: retained.length === 0
           ? 'No audio retained for this meeting'
@@ -1180,11 +1191,17 @@ export function createMeetingRouter(deps: MeetingRouteDependencies = {}): Router
       res.status(400).json({ error: 'Invalid sessionId', reason: 'invalid_session_id' })
       return
     }
-    const chunks = listMeetingAudioChunks(sessionId)
+    const archived = listMeetingAudioChunks(sessionId)
+    const ext = listExtAudioChunks(sessionId)
+    const chunks = [...new Set([...archived, ...ext])].sort((a, b) => a - b)
     res.json({
       sessionId,
       retained: chunks.length > 0,
       chunks,
+      // Reported separately: ext-audio runs a 72h window, the archive 7 days, so
+      // one retention number would be wrong for half the list.
+      archivedChunks: archived.length,
+      extAudioChunks: ext.length,
       // Config read, not a filesystem walk: this route used to stat every
       // retained chunk to report one number.
       retentionDays: meetingAudioRetentionDays(),