@google/gemini-cli 0.26.0-preview.4 → 0.27.0-nightly.20260126.cb772a5b7

package/dist/src/ui/components/shared/text-buffer.test.js

@@ -29,7 +29,18 @@ const initialState = {
     viewportHeight: 24,
     transformationsByLine: [[]],
     visualLayout: defaultVisualLayout,
+    pastedContent: {},
 };
+/**
+ * Helper to create a TextBufferState with properly calculated transformations.
+ */
+function createStateWithTransformations(partial) {
+    const state = { ...initialState, ...partial };
+    return {
+        ...state,
+        transformationsByLine: state.lines.map((l) => calculateTransformationsForLine(l)),
+    };
+}
 describe('textBufferReducer', () => {
     afterEach(() => {
         vi.restoreAllMocks();
@@ -117,6 +128,18 @@ describe('textBufferReducer', () => {
             expect(state.cursorCol).toBe(5);
         });
     });
+    describe('add_pasted_content action', () => {
+        it('should add content to pastedContent Record', () => {
+            const action = {
+                type: 'add_pasted_content',
+                payload: { id: '[Pasted Text: 6 lines]', text: 'large content' },
+            };
+            const state = textBufferReducer(initialState, action);
+            expect(state.pastedContent).toEqual({
+                '[Pasted Text: 6 lines]': 'large content',
+            });
+        });
+    });
     describe('backspace action', () => {
         it('should remove a character', () => {
             const stateWithText = {
@@ -146,6 +169,130 @@ describe('textBufferReducer', () => {
             expect(state.cursorCol).toBe(5);
         });
     });
+    describe('atomic placeholder deletion', () => {
+        describe('paste placeholders', () => {
+            it('backspace at end of paste placeholder removes entire placeholder', () => {
+                const placeholder = '[Pasted Text: 6 lines]';
+                const stateWithPlaceholder = createStateWithTransformations({
+                    lines: [placeholder],
+                    cursorRow: 0,
+                    cursorCol: placeholder.length, // cursor at end
+                    pastedContent: {
+                        [placeholder]: 'line1\nline2\nline3\nline4\nline5\nline6',
+                    },
+                });
+                const action = { type: 'backspace' };
+                const state = textBufferReducer(stateWithPlaceholder, action);
+                expect(state).toHaveOnlyValidCharacters();
+                expect(state.lines).toEqual(['']);
+                expect(state.cursorCol).toBe(0);
+                // pastedContent should be cleaned up
+                expect(state.pastedContent[placeholder]).toBeUndefined();
+            });
+            it('delete at start of paste placeholder removes entire placeholder', () => {
+                const placeholder = '[Pasted Text: 6 lines]';
+                const stateWithPlaceholder = createStateWithTransformations({
+                    lines: [placeholder],
+                    cursorRow: 0,
+                    cursorCol: 0, // cursor at start
+                    pastedContent: {
+                        [placeholder]: 'line1\nline2\nline3\nline4\nline5\nline6',
+                    },
+                });
+                const action = { type: 'delete' };
+                const state = textBufferReducer(stateWithPlaceholder, action);
+                expect(state).toHaveOnlyValidCharacters();
+                expect(state.lines).toEqual(['']);
+                expect(state.cursorCol).toBe(0);
+                // pastedContent should be cleaned up
+                expect(state.pastedContent[placeholder]).toBeUndefined();
+            });
+            it('backspace inside paste placeholder does normal deletion', () => {
+                const placeholder = '[Pasted Text: 6 lines]';
+                const stateWithPlaceholder = createStateWithTransformations({
+                    lines: [placeholder],
+                    cursorRow: 0,
+                    cursorCol: 10, // cursor in middle
+                    pastedContent: {
+                        [placeholder]: 'line1\nline2\nline3\nline4\nline5\nline6',
+                    },
+                });
+                const action = { type: 'backspace' };
+                const state = textBufferReducer(stateWithPlaceholder, action);
+                expect(state).toHaveOnlyValidCharacters();
+                // Should only delete one character
+                expect(state.lines[0].length).toBe(placeholder.length - 1);
+                expect(state.cursorCol).toBe(9);
+                // pastedContent should NOT be cleaned up (placeholder is broken)
+                expect(state.pastedContent[placeholder]).toBeDefined();
+            });
+        });
+        describe('image placeholders', () => {
+            it('backspace at end of image path removes entire path', () => {
+                const imagePath = '@test.png';
+                const stateWithImage = createStateWithTransformations({
+                    lines: [imagePath],
+                    cursorRow: 0,
+                    cursorCol: imagePath.length, // cursor at end
+                });
+                const action = { type: 'backspace' };
+                const state = textBufferReducer(stateWithImage, action);
+                expect(state).toHaveOnlyValidCharacters();
+                expect(state.lines).toEqual(['']);
+                expect(state.cursorCol).toBe(0);
+            });
+            it('delete at start of image path removes entire path', () => {
+                const imagePath = '@test.png';
+                const stateWithImage = createStateWithTransformations({
+                    lines: [imagePath],
+                    cursorRow: 0,
+                    cursorCol: 0, // cursor at start
+                });
+                const action = { type: 'delete' };
+                const state = textBufferReducer(stateWithImage, action);
+                expect(state).toHaveOnlyValidCharacters();
+                expect(state.lines).toEqual(['']);
+                expect(state.cursorCol).toBe(0);
+            });
+            it('backspace inside image path does normal deletion', () => {
+                const imagePath = '@test.png';
+                const stateWithImage = createStateWithTransformations({
+                    lines: [imagePath],
+                    cursorRow: 0,
+                    cursorCol: 5, // cursor in middle
+                });
+                const action = { type: 'backspace' };
+                const state = textBufferReducer(stateWithImage, action);
+                expect(state).toHaveOnlyValidCharacters();
+                // Should only delete one character
+                expect(state.lines[0].length).toBe(imagePath.length - 1);
+                expect(state.cursorCol).toBe(4);
+            });
+        });
+        describe('undo behavior', () => {
+            it('undo after placeholder deletion restores everything', () => {
+                const placeholder = '[Pasted Text: 6 lines]';
+                const pasteContent = 'line1\nline2\nline3\nline4\nline5\nline6';
+                const stateWithPlaceholder = createStateWithTransformations({
+                    lines: [placeholder],
+                    cursorRow: 0,
+                    cursorCol: placeholder.length,
+                    pastedContent: { [placeholder]: pasteContent },
+                });
+                // Delete the placeholder
+                const deleteAction = { type: 'backspace' };
+                const stateAfterDelete = textBufferReducer(stateWithPlaceholder, deleteAction);
+                expect(stateAfterDelete.lines).toEqual(['']);
+                expect(stateAfterDelete.pastedContent[placeholder]).toBeUndefined();
+                // Undo should restore
+                const undoAction = { type: 'undo' };
+                const stateAfterUndo = textBufferReducer(stateAfterDelete, undoAction);
+                expect(stateAfterUndo).toHaveOnlyValidCharacters();
+                expect(stateAfterUndo.lines).toEqual([placeholder]);
+                expect(stateAfterUndo.pastedContent[placeholder]).toBe(pasteContent);
+            });
+        });
+    });
     describe('undo/redo actions', () => {
         it('should undo and redo a change', () => {
             // 1. Insert text
@@ -448,6 +595,43 @@ describe('useTextBuffer', () => {
             expect(state.text).toBe('a-NEW-bc');
             expect(state.cursor).toEqual([0, 6]);
         });
+        it('insert: should use placeholder for large text paste', () => {
+            const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
+            const largeText = '1\n2\n3\n4\n5\n6';
+            act(() => result.current.insert(largeText, { paste: true }));
+            const state = getBufferState(result);
+            expect(state.text).toBe('[Pasted Text: 6 lines]');
+            expect(result.current.pastedContent['[Pasted Text: 6 lines]']).toBe(largeText);
+        });
+        it('insert: should NOT use placeholder for large text if NOT a paste', () => {
+            const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
+            const largeText = '1\n2\n3\n4\n5\n6';
+            act(() => result.current.insert(largeText, { paste: false }));
+            const state = getBufferState(result);
+            expect(state.text).toBe(largeText);
+        });
+        it('insert: should clean up pastedContent when placeholder is deleted', () => {
+            const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
+            const largeText = '1\n2\n3\n4\n5\n6';
+            act(() => result.current.insert(largeText, { paste: true }));
+            expect(result.current.pastedContent['[Pasted Text: 6 lines]']).toBe(largeText);
+            // Delete the placeholder using setText
+            act(() => result.current.setText(''));
+            expect(Object.keys(result.current.pastedContent)).toHaveLength(0);
+        });
+        it('insert: should clean up pastedContent when placeholder is removed via atomic backspace', () => {
+            const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
+            const largeText = '1\n2\n3\n4\n5\n6';
+            act(() => result.current.insert(largeText, { paste: true }));
+            expect(result.current.pastedContent['[Pasted Text: 6 lines]']).toBe(largeText);
+            // Single backspace at end of placeholder removes entire placeholder
+            act(() => {
+                result.current.backspace();
+            });
+            expect(getBufferState(result).text).toBe('');
+            // pastedContent is cleaned up when placeholder is deleted atomically
+            expect(Object.keys(result.current.pastedContent)).toHaveLength(0);
+        });
         it('newline: should create a new line and move cursor', () => {
             const { result } = renderHook(() => useTextBuffer({
                 initialText: 'ab',
@@ -849,17 +1033,19 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'h',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: 'h',
             }));
             act(() => result.current.handleInput({
                 name: 'i',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: 'i',
             }));
@@ -869,9 +1055,10 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'return',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: '\r',
             }));
@@ -881,9 +1068,10 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'j',
-                ctrl: true,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: true,
+                cmd: false,
                 insertable: false,
                 sequence: '\n',
             }));
@@ -893,9 +1081,10 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'tab',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\t',
             }));
@@ -905,9 +1094,10 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'tab',
-                ctrl: false,
-                meta: false,
                 shift: true,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\u001b[9;2u',
             }));
@@ -922,9 +1112,10 @@ describe('useTextBuffer', () => {
             act(() => result.current.move('end'));
             act(() => result.current.handleInput({
                 name: 'backspace',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\x7f',
             }));
@@ -941,25 +1132,28 @@ describe('useTextBuffer', () => {
             act(() => {
                 result.current.handleInput({
                     name: 'backspace',
-                    ctrl: false,
-                    meta: false,
                     shift: false,
+                    alt: false,
+                    ctrl: false,
+                    cmd: false,
                     insertable: false,
                     sequence: '\x7f',
                 });
                 result.current.handleInput({
                     name: 'backspace',
-                    ctrl: false,
-                    meta: false,
                     shift: false,
+                    alt: false,
+                    ctrl: false,
+                    cmd: false,
                     insertable: false,
                     sequence: '\x7f',
                 });
                 result.current.handleInput({
                     name: 'backspace',
-                    ctrl: false,
-                    meta: false,
                     shift: false,
+                    alt: false,
+                    ctrl: false,
+                    cmd: false,
                     insertable: false,
                     sequence: '\x7f',
                 });
@@ -1004,21 +1198,23 @@ describe('useTextBuffer', () => {
             act(() => result.current.move('end')); // cursor [0,2]
             act(() => result.current.handleInput({
                 name: 'left',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\x1b[D',
-            })); // cursor [0,1]
+            }));
             expect(getBufferState(result).cursor).toEqual([0, 1]);
             act(() => result.current.handleInput({
                 name: 'right',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\x1b[C',
-            })); // cursor [0,2]
+            }));
             expect(getBufferState(result).cursor).toEqual([0, 2]);
         });
         it('should strip ANSI escape codes when pasting text', () => {
@@ -1027,9 +1223,10 @@ describe('useTextBuffer', () => {
             // Simulate pasting by calling handleInput with a string longer than 1 char
             act(() => result.current.handleInput({
                 name: '',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: textWithAnsi,
             }));
@@ -1039,9 +1236,10 @@ describe('useTextBuffer', () => {
             const { result } = renderHook(() => useTextBuffer({ viewport, isValidPath: () => false }));
             act(() => result.current.handleInput({
                 name: 'return',
-                ctrl: false,
-                meta: false,
                 shift: true,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: '\r',
             })); // Simulates Shift+Enter in VSCode terminal
@@ -1064,8 +1262,14 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
                 result.current.insert(longText, { paste: true });
             });
             const state = getBufferState(result);
-            // Check that the text is the result of three concatenations.
-            expect(state.lines).toStrictEqual((longText + longText + longText).split('\n'));
+            // Check that the text is the result of three concatenations of unique placeholders.
+            // Now that ID generation is in the reducer, they are correctly unique even when batched.
+            expect(state.lines).toStrictEqual([
+                '[Pasted Text: 8 lines][Pasted Text: 8 lines #2][Pasted Text: 8 lines #3]',
+            ]);
+            expect(result.current.pastedContent['[Pasted Text: 8 lines]']).toBe(longText);
+            expect(result.current.pastedContent['[Pasted Text: 8 lines #2]']).toBe(longText);
+            expect(result.current.pastedContent['[Pasted Text: 8 lines #3]']).toBe(longText);
             const expectedCursorPos = offsetToLogicalPos(state.text, state.text.length);
             expect(state.cursor).toEqual(expectedCursorPos);
         });
@@ -1198,9 +1402,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
     describe('Input Sanitization', () => {
         const createInput = (sequence) => ({
             name: '',
-            ctrl: false,
-            meta: false,
             shift: false,
+            alt: false,
+            ctrl: false,
+            cmd: false,
             insertable: true,
             sequence,
         });
@@ -1243,9 +1448,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
             expect(largeTextWithUnsafe.length).toBeGreaterThan(5000);
             act(() => result.current.handleInput({
                 name: '',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: largeTextWithUnsafe,
             }));
@@ -1268,9 +1474,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
             expect(largeTextWithAnsi.length).toBeGreaterThan(5000);
             act(() => result.current.handleInput({
                 name: '',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: largeTextWithAnsi,
             }));
@@ -1286,9 +1493,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
             const emojis = '🐍🐳🦀🦄';
             act(() => result.current.handleInput({
                 name: '',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: emojis,
             }));
@@ -1429,9 +1637,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
             }));
             act(() => result.current.handleInput({
                 name: 'return',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: true,
                 sequence: '\r',
             }));
@@ -1445,9 +1654,10 @@ Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots
             }));
             act(() => result.current.handleInput({
                 name: 'f1',
-                ctrl: false,
-                meta: false,
                 shift: false,
+                alt: false,
+                ctrl: false,
+                cmd: false,
                 insertable: false,
                 sequence: '\u001bOP',
             }));
@@ -1994,12 +2204,14 @@ describe('Transformation Utilities', () => {
                 logEnd: 14,
                 logicalText: '@test.png',
                 collapsedText: '[Image @test.png]',
+                type: 'image',
             },
             {
                 logStart: 20,
                 logEnd: 31,
                 logicalText: '@another.jpg',
                 collapsedText: '[Image @another.jpg]',
+                type: 'image',
             },
         ];
         it('should find transformation when cursor is inside it', () => {