@google/adk 2.4.0 → 2.5.0

package/dist/cjs/sessions/database_session_service.js

@@ -41,7 +41,7 @@ __export(database_session_service_exports, {
   isStaleSessionError: () => import_stale_session_error2.isStaleSessionError
 });
 module.exports = __toCommonJS(database_session_service_exports);
-var import_env_aware_utils = require("../utils/env_aware_utils.js");
+var import_id_provider = require("../utils/id_provider.js");
 var import_logger = require("../utils/logger.js");
 var import_base_session_service = require("./base_session_service.js");
 var import_session = require("./session.js");
@@ -84,9 +84,82 @@ async function importMikroOrm() {
   } = operations);
 }
 __name(importMikroOrm, "importMikroOrm");
+const STORAGE_UPDATE_MARKER_SYMBOL = /* @__PURE__ */ Symbol.for(
+  "google.adk.session.storageUpdateMarker"
+);
+function setStorageRevisionMarker(session, revision) {
+  Object.defineProperty(session, STORAGE_UPDATE_MARKER_SYMBOL, {
+    value: revision,
+    writable: true,
+    configurable: true,
+    enumerable: false
+  });
+}
+__name(setStorageRevisionMarker, "setStorageRevisionMarker");
+function getStorageRevisionMarker(session) {
+  return session[STORAGE_UPDATE_MARKER_SYMBOL];
+}
+__name(getStorageRevisionMarker, "getStorageRevisionMarker");
+const MAX_IN_QUERY_IDS = 500;
+async function sessionMatchesStorageRevision(txEm, session, eventsComplete, totalEventCount) {
+  const sessionWhere = {
+    appName: session.appName,
+    userId: session.userId,
+    sessionId: session.id
+  };
+  const latestStorageEvent = await txEm.findOne(StorageEvent, sessionWhere, {
+    orderBy: { timestamp: "DESC", id: "DESC" }
+  });
+  if (session.events.length === 0) {
+    if (latestStorageEvent !== null) {
+      return false;
+    }
+    if (totalEventCount !== void 0 && totalEventCount !== 0) {
+      return false;
+    }
+    return true;
+  }
+  if ((latestStorageEvent == null ? void 0 : latestStorageEvent.id) !== session.events[session.events.length - 1].id) {
+    return false;
+  }
+  if (totalEventCount !== void 0) {
+    const totalStored = await txEm.count(StorageEvent, sessionWhere);
+    if (totalStored !== totalEventCount) {
+      return false;
+    }
+  }
+  const knownIds = session.events.map((e) => e.id);
+  if (knownIds.length <= MAX_IN_QUERY_IDS) {
+    const unknownEventWhere = {
+      ...sessionWhere,
+      id: { $nin: knownIds }
+    };
+    if (!eventsComplete) {
+      unknownEventWhere.timestamp = {
+        $gte: new Date(session.events[0].timestamp)
+      };
+    }
+    return await txEm.count(StorageEvent, unknownEventWhere) === 0;
+  }
+  const filter = { ...sessionWhere };
+  if (!eventsComplete) {
+    filter.timestamp = { $gte: new Date(session.events[0].timestamp) };
+  }
+  const storedEvents = await txEm.find(StorageEvent, filter, {
+    fields: ["id"]
+  });
+  const knownSet = new Set(knownIds);
+  for (const stored of storedEvents) {
+    if (!knownSet.has(stored.id)) {
+      return false;
+    }
+  }
+  return true;
+}
+__name(sessionMatchesStorageRevision, "sessionMatchesStorageRevision");
 function formatDateTime(dateOrEpochMs) {
   const date = typeof dateOrEpochMs === "number" ? new Date(dateOrEpochMs) : dateOrEpochMs;
-  return date.toISOString().replace("T", " ").slice(0, 19);
+  return date.toISOString().replace("T", " ").replace("Z", "");
 }
 __name(formatDateTime, "formatDateTime");
 function isDatabaseConnectionString(uri) {
@@ -103,14 +176,25 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
     this.initialized = false;
     if (typeof connectionStringOrOptions === "string") {
       this.connectionString = connectionStringOrOptions;
-      this.staleSession = (_a = options == null ? void 0 : options.staleSession) != null ? _a : "reject";
+      if (options) {
+        const { staleSession, ...mikroOptions } = options;
+        this.options = mikroOptions;
+        this.staleSession = staleSession != null ? staleSession : "reject";
+      } else {
+        this.staleSession = "reject";
+      }
     } else {
-      if (!connectionStringOrOptions.driver) {
+      const { staleSession: firstStaleSession, ...firstMikroOptions } = connectionStringOrOptions;
+      const { staleSession: secondStaleSession, ...secondMikroOptions } = options != null ? options : {};
+      const mergedMikroOptions = {
+        ...firstMikroOptions,
+        ...secondMikroOptions
+      };
+      if (!mergedMikroOptions.driver) {
         throw new Error("Driver is required when passing options object.");
       }
-      const { staleSession, ...mikroOptions } = connectionStringOrOptions;
-      this.options = mikroOptions;
-      this.staleSession = staleSession != null ? staleSession : "reject";
+      this.options = mergedMikroOptions;
+      this.staleSession = (_a = secondStaleSession != null ? secondStaleSession : firstStaleSession) != null ? _a : "reject";
     }
   }
   async init() {
@@ -118,7 +202,11 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
       return;
     }
     await loadMikroOrm();
-    const options = this.connectionString ? await getConnectionOptionsFromUri(this.connectionString) : { ...this.options, entities: ENTITIES };
+    const options = this.connectionString ? {
+      ...await getConnectionOptionsFromUri(this.connectionString),
+      ...this.options,
+      entities: ENTITIES
+    } : { ...this.options, entities: ENTITIES };
     this.options = options;
     this.orm = await MikroORM.init(options);
     await ensureDatabaseCreated(this.orm);
@@ -133,7 +221,7 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
   }) {
     await this.init();
     const em = this.orm.em.fork();
-    const id = sessionId || (0, import_env_aware_utils.randomUUID)();
+    const id = sessionId || (0, import_id_provider.newId)();
     const now = /* @__PURE__ */ new Date();
     const existing = await em.findOne(StorageSession, {
       id,
@@ -196,14 +284,22 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
       userStateModel.state,
       sessionState
     );
-    return (0, import_session.createSession)({
+    const session = (0, import_session.createSession)({
       id,
       appName,
       userId,
       state: mergedState,
       events: [],
-      lastUpdateTime: storageSession.createTime.getTime()
+      lastUpdateTime: storageSession.updateTime.getTime()
+    });
+    setStorageRevisionMarker(session, {
+      marker: storageSession.updateTime.toISOString(),
+      recordedLastUpdateTime: session.lastUpdateTime,
+      unverifiedWrite: true,
+      eventsComplete: true,
+      totalEventCount: 0
     });
+    return session;
   }
   async getSession({
     appName,
@@ -244,7 +340,7 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
       (userStateModel == null ? void 0 : userStateModel.state) || {},
       storageSession.state
     );
-    return (0, import_session.createSession)({
+    const session = (0, import_session.createSession)({
       id: sessionId,
       appName,
       userId,
@@ -252,6 +348,16 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
       events: storageEvents.map((se) => se.eventData),
       lastUpdateTime: storageSession.updateTime.getTime()
     });
+    const eventsComplete = (config == null ? void 0 : config.numRecentEvents) === void 0 && (config == null ? void 0 : config.afterTimestamp) === void 0;
+    const totalEventCount = eventsComplete ? session.events.length : await em.count(StorageEvent, { appName, userId, sessionId });
+    setStorageRevisionMarker(session, {
+      marker: storageSession.updateTime.toISOString(),
+      recordedLastUpdateTime: session.lastUpdateTime,
+      unverifiedWrite: false,
+      eventsComplete,
+      totalEventCount
+    });
+    return session;
   }
   async listSessions({
     appName,
@@ -264,7 +370,7 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
     await this.init();
     const em = this.orm.em.fork();
     const where = { appName };
-    if (userId) {
+    if (userId !== void 0) {
       where.userId = userId;
     }
     const orderBy = order === "asc" ? { updateTime: "ASC", id: "ASC" } : order === "desc" ? { updateTime: "DESC", id: "ASC" } : void 0;
@@ -313,7 +419,7 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
     const appStateModel = await em.findOne(StorageAppState, { appName });
     const appState = (appStateModel == null ? void 0 : appStateModel.state) || {};
     const userStateMap = {};
-    if (userId) {
+    if (userId !== void 0) {
       const u = await em.findOne(StorageUserState, { appName, userId });
       if (u) userStateMap[userId] = u.state;
     } else {
@@ -325,7 +431,7 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
     const sessions = storageSessions.map((ss) => {
       const uState = userStateMap[ss.userId] || {};
       const merged = (0, import_base_session_service.mergeStates)(appState, uState, ss.state);
-      return (0, import_session.createSession)({
+      const session = (0, import_session.createSession)({
         id: ss.id,
         appName: ss.appName,
         userId: ss.userId,
@@ -333,6 +439,13 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
         events: [],
         lastUpdateTime: ss.updateTime.getTime()
       });
+      setStorageRevisionMarker(session, {
+        marker: ss.updateTime.toISOString(),
+        recordedLastUpdateTime: session.lastUpdateTime,
+        unverifiedWrite: false,
+        eventsComplete: false
+      });
+      return session;
     });
     return { sessions, ...paginationMeta };
   }
@@ -350,11 +463,13 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
     session,
     event
   }) {
+    var _a, _b;
     await this.init();
     const em = this.orm.em.fork();
     if (event.partial) {
       return event;
     }
+    const stateDelta = (_b = (_a = event.actions) == null ? void 0 : _a.stateDelta) != null ? _b : {};
     const trimmedEvent = (0, import_base_session_service.trimTempDeltaState)(event);
     let sessionWasStale = false;
     await em.transactional(async (txEm) => {
@@ -370,11 +485,37 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
       if (!storageSession) {
         throw new Error(`Session ${session.id} not found for appendEvent`);
       }
-      if (storageSession.updateTime.getTime() > session.lastUpdateTime) {
+      const storageUpdateTime = storageSession.updateTime.getTime();
+      const storageUpdateMarker = storageSession.updateTime.toISOString();
+      const rev = getStorageRevisionMarker(session);
+      const callerMutatedLastUpdateTime = rev !== void 0 && rev.recordedLastUpdateTime !== session.lastUpdateTime;
+      let isStale = false;
+      if (rev !== void 0 && !callerMutatedLastUpdateTime) {
+        if (rev.marker === storageUpdateMarker) {
+          session.lastUpdateTime = storageUpdateTime;
+        } else if (rev.unverifiedWrite && storageUpdateTime % 1e3 === 0 && Math.abs(storageUpdateTime - rev.recordedLastUpdateTime) < 1e3 && await sessionMatchesStorageRevision(
+          txEm,
+          session,
+          rev.eventsComplete,
+          rev.totalEventCount
+        )) {
+          session.lastUpdateTime = storageUpdateTime;
+        } else {
+          isStale = true;
+        }
+      } else if (rev !== void 0) {
+        isStale = storageUpdateTime > session.lastUpdateTime;
+      } else if (storageUpdateTime > session.lastUpdateTime) {
+        if (await sessionMatchesStorageRevision(txEm, session, false)) {
+          session.lastUpdateTime = storageUpdateTime;
+        } else {
+          isStale = true;
+        }
+      }
+      if (isStale) {
         if (this.staleSession === "reject") {
-          throw new import_stale_session_error.StaleSessionError(
-            `The last_update_time provided in the session object ${formatDateTime(session.lastUpdateTime)} is earlier than the update_time in the storage_session ${formatDateTime(storageSession.updateTime)}. Please check if it is a stale session.`
-          );
+          const message = storageUpdateTime > session.lastUpdateTime ? `The last_update_time provided in the session object ${formatDateTime(session.lastUpdateTime)} is earlier than the update_time in the storage_session ${formatDateTime(storageSession.updateTime)}. Please check if it is a stale session.` : `The session object with last_update_time ${formatDateTime(session.lastUpdateTime)} does not match the storage_session revision with update_time ${formatDateTime(storageSession.updateTime)}. Please check if it is a stale session.`;
+          throw new import_stale_session_error.StaleSessionError(message);
         }
         sessionWasStale = true;
       }
@@ -453,9 +594,32 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
         userStateModel.state,
         storageSession.state
       );
+      for (const source of [session.state, stateDelta]) {
+        for (const [key, value] of Object.entries(source)) {
+          if (key.startsWith(import_state.State.TEMP_PREFIX)) {
+            newMergedState[key] = value;
+          }
+        }
+      }
       session.state = newMergedState;
+      const isNewEvent = !existingStorageEvent;
       (0, import_base_session_service.upsertSessionEvent)(session, event);
       session.lastUpdateTime = storageSession.updateTime.getTime();
+      let nextTotalEventCount;
+      if (!callerMutatedLastUpdateTime && !isStale) {
+        if ((rev == null ? void 0 : rev.totalEventCount) !== void 0) {
+          nextTotalEventCount = rev.totalEventCount + (isNewEvent ? 1 : 0);
+        } else if ((rev == null ? void 0 : rev.eventsComplete) === true) {
+          nextTotalEventCount = session.events.length;
+        }
+      }
+      setStorageRevisionMarker(session, {
+        marker: storageSession.updateTime.toISOString(),
+        recordedLastUpdateTime: session.lastUpdateTime,
+        unverifiedWrite: true,
+        eventsComplete: !callerMutatedLastUpdateTime && (rev == null ? void 0 : rev.eventsComplete) === true && !isStale,
+        totalEventCount: nextTotalEventCount
+      });
     });
     if (sessionWasStale) {
       try {
@@ -470,6 +634,14 @@ const _DatabaseSessionService = class _DatabaseSessionService extends import_bas
         );
         session.events = storageEvents.map((se) => se.eventData);
         (0, import_base_session_service.upsertSessionEvent)(session, event);
+        const lastRev = getStorageRevisionMarker(session);
+        if (lastRev) {
+          setStorageRevisionMarker(session, {
+            ...lastRev,
+            eventsComplete: true,
+            totalEventCount: session.events.length
+          });
+        }
       } catch (e) {
         const message = e instanceof Error ? e.message : String(e);
         import_logger.logger.warn(

package/dist/cjs/sessions/db/operations.js

@@ -312,8 +312,77 @@ async function getConnectionOptionsFromUri(uri) {
 }
 __name(getConnectionOptionsFromUri, "getConnectionOptionsFromUri");
 async function ensureDatabaseCreated(orm) {
+  var _a;
   await orm.schema.ensureDatabase();
-  await orm.schema.update({ safe: true });
+  const entityMetadata = [...orm.getMetadata().getAll().values()].filter(
+    (meta) => !meta.embeddable && !meta.virtual && !meta.view
+  );
+  if (entityMetadata.length === 0) {
+    return;
+  }
+  const platform = orm.driver.getPlatform();
+  const schemaHelper = platform.getSchemaHelper();
+  if (typeof (schemaHelper == null ? void 0 : schemaHelper.getAllTables) !== "function") {
+    await orm.schema.create();
+    return;
+  }
+  const connection = orm.driver.getConnection();
+  const defaultSchema = platform.getDefaultSchemaName();
+  const configSchema = orm.config.get("schema");
+  const dbName = orm.config.get("dbName");
+  const isCurrentSchema = /* @__PURE__ */ __name((schemaName) => !schemaName || schemaName === defaultSchema || defaultSchema === void 0 && schemaName === dbName, "isCurrentSchema");
+  const tableKey = /* @__PURE__ */ __name((tableName, schemaName) => {
+    const schemaPart = !schemaName || isCurrentSchema(schemaName) ? "" : schemaName;
+    return `${schemaPart}.${tableName}`.toLowerCase();
+  }, "tableKey");
+  const listedTables = await schemaHelper.getAllTables(connection);
+  const listedTableKeys = new Set(
+    listedTables.map((table) => tableKey(table.table_name, table.schema_name))
+  );
+  const seenTableKeys = /* @__PURE__ */ new Set();
+  const existingTableNames = [];
+  let missingCount = 0;
+  for (const meta of entityMetadata) {
+    const schemaName = (_a = meta.schema) != null ? _a : configSchema;
+    const key = tableKey(meta.tableName, schemaName);
+    if (seenTableKeys.has(key)) {
+      continue;
+    }
+    seenTableKeys.add(key);
+    let exists = listedTableKeys.has(key);
+    if (!exists && defaultSchema === void 0 && !isCurrentSchema(schemaName) && typeof schemaHelper.tableExists === "function") {
+      exists = await schemaHelper.tableExists(
+        connection,
+        meta.tableName,
+        schemaName
+      );
+    }
+    if (exists) {
+      existingTableNames.push(
+        schemaName && schemaName !== defaultSchema ? `${schemaName}.${meta.tableName}` : meta.tableName
+      );
+    } else {
+      missingCount++;
+    }
+  }
+  if (missingCount === 0) {
+    return;
+  }
+  if (existingTableNames.length === 0) {
+    await orm.schema.create();
+    return;
+  }
+  const schemaGenConfig = orm.config.get("schemaGenerator");
+  const previousSkipTables = schemaGenConfig.skipTables;
+  schemaGenConfig.skipTables = [
+    ...previousSkipTables != null ? previousSkipTables : [],
+    ...existingTableNames
+  ];
+  try {
+    await orm.schema.create();
+  } finally {
+    schemaGenConfig.skipTables = previousSkipTables;
+  }
 }
 __name(ensureDatabaseCreated, "ensureDatabaseCreated");
 async function validateDatabaseSchemaVersion(orm) {

package/dist/cjs/sessions/db/schema.js

@@ -98,6 +98,7 @@ const storageAppStateSchema = new import_core.EntitySchema({
     state: { type: "json" },
     updateTime: {
       type: "datetime",
+      length: EVENT_TIMESTAMP_PRECISION,
       fieldName: "update_time",
       onCreate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onCreate"),
       onUpdate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onUpdate")
@@ -121,6 +122,7 @@ const storageUserStateSchema = new import_core.EntitySchema({
     state: { type: "json" },
     updateTime: {
       type: "datetime",
+      length: EVENT_TIMESTAMP_PRECISION,
       fieldName: "update_time",
       onCreate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onCreate"),
       onUpdate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onUpdate")
@@ -146,11 +148,13 @@ const storageSessionSchema = new import_core.EntitySchema({
     state: { type: "json" },
     createTime: {
       type: "datetime",
+      length: EVENT_TIMESTAMP_PRECISION,
       fieldName: "create_time",
       onCreate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onCreate")
     },
     updateTime: {
       type: "datetime",
+      length: EVENT_TIMESTAMP_PRECISION,
       fieldName: "update_time",
       onCreate: /* @__PURE__ */ __name(() => /* @__PURE__ */ new Date(), "onCreate")
     }

package/dist/cjs/sessions/in_memory_session_service.js

@@ -30,7 +30,7 @@ __export(in_memory_session_service_exports, {
 });
 module.exports = __toCommonJS(in_memory_session_service_exports);
 var import_lodash_es = require("lodash-es");
-var import_env_aware_utils = require("../utils/env_aware_utils.js");
+var import_id_provider = require("../utils/id_provider.js");
 var import_logger = require("../utils/logger.js");
 var import_base_session_service = require("./base_session_service.js");
 var import_session = require("./session.js");
@@ -72,7 +72,7 @@ const _InMemorySessionService = class _InMemorySessionService extends import_bas
     const session = (0, import_session.createSession)({
       // Surrounding whitespace is dropped so that a later lookup by the bare
       // id finds the session, and a blank id gets a generated one.
-      id: (sessionId == null ? void 0 : sessionId.trim()) || (0, import_env_aware_utils.randomUUID)(),
+      id: (sessionId == null ? void 0 : sessionId.trim()) || (0, import_id_provider.newId)(),
       appName,
       userId,
       state: filteredState,

package/dist/cjs/sessions/vertex_ai_session_service.js

@@ -41,6 +41,7 @@ module.exports = __toCommonJS(vertex_ai_session_service_exports);
 var import_vertexai = require("@google-cloud/vertexai");
 var import_compacted_event = require("../events/compacted_event.js");
 var import_experimental = require("../utils/experimental.js");
+var import_error_utils = require("../utils/error_utils.js");
 var import_logger = require("../utils/logger.js");
 var import_vertex_ai_utils = require("../utils/vertex_ai_utils.js");
 var import_partial_copy = require("../utils/partial_copy.js");
@@ -335,9 +336,16 @@ let VertexAiSessionService = class extends import_base_session_service.BaseSessi
     if (!session) {
       return;
     }
-    await this.sessions.delete({
-      name: `reasoningEngines/${reasoningEngineId}/sessions/${sessionId}`
-    });
+    try {
+      await this.sessions.delete({
+        name: `reasoningEngines/${reasoningEngineId}/sessions/${sessionId}`
+      });
+    } catch (error) {
+      import_logger.logger.error(
+        `Error deleting session ${sessionId}: ${(0, import_error_utils.formatError)(error)}`
+      );
+      throw error;
+    }
   }
   async appendEvent({
     session,

package/dist/cjs/skills/loader.js

@@ -105,7 +105,7 @@ async function loadDir(directoryPath) {
         }
         await walk(fullPath);
       } else if (entry.isFile()) {
-        const relativePath = path.relative(directoryPath, fullPath);
+        const relativePath = path.relative(directoryPath, fullPath).split(path.sep).join("/");
         if (IGNORED_EXTENSIONS.has(path.extname(entry.name))) {
           continue;
         }
@@ -133,7 +133,7 @@ const FRONTMATTER_PATTERN = /^---[ \t]*\r?\n(?:([\s\S]*?)\r?\n)??---[ \t]*(?:\r?
 function parseFrontmatterYaml(content) {
   var _a;
   const text = content.startsWith(FRONTMATTER_BOM) ? content.slice(FRONTMATTER_BOM.length) : content;
-  if (!text.startsWith("---")) {
+  if (!/^---[ \t]*(?:\r?\n|$)/.test(text)) {
     throw new import_input_validation_error.InputValidationError(
       "SKILL.md must start with YAML frontmatter (---)"
     );
@@ -146,20 +146,27 @@ function parseFrontmatterYaml(content) {
   }
   const frontmatterStr = (_a = match[1]) != null ? _a : "";
   const body = text.slice(match[0].length).trim();
-  try {
-    const parsed = yaml.load(frontmatterStr);
-    if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) {
+  const hasYamlContent = frontmatterStr.split(/\r?\n/).some((line) => {
+    const trimmed = line.trim();
+    return trimmed.length > 0 && !trimmed.startsWith("#");
+  });
+  let parsed = null;
+  if (hasYamlContent) {
+    try {
+      parsed = yaml.load(frontmatterStr);
+    } catch (e) {
       throw new import_input_validation_error.InputValidationError(
-        "SKILL.md frontmatter must be a YAML mapping"
+        `Invalid YAML in frontmatter: ${e.message}`,
+        { cause: e }
       );
     }
-    return { raw: parsed, body };
-  } catch (e) {
+  }
+  if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) {
     throw new import_input_validation_error.InputValidationError(
-      `Invalid YAML in frontmatter: ${e.message}`,
-      { cause: e }
+      "Invalid YAML in frontmatter: SKILL.md frontmatter must be a YAML mapping"
     );
   }
+  return { raw: parsed, body };
 }
 __name(parseFrontmatterYaml, "parseFrontmatterYaml");
 function validateFrontmatter(raw) {
@@ -234,22 +241,16 @@ async function validateSkillDir(skillDir) {
   } catch (e) {
     return [e.message];
   }
-  try {
-    const keys = Object.keys(skill.frontmatter);
-    const unknown = keys.filter((k) => !ALLOWED_FRONTMATTER_KEYS.has(k));
-    if (unknown.length > 0) {
-      problems.push(
-        `Unknown frontmatter fields: [${unknown.sort().join(", ")}]`
-      );
-    }
-    const dirName = path.basename(resolvedDir);
-    if (dirName !== skill.frontmatter.name) {
-      problems.push(
-        `Skill name '${skill.frontmatter.name}' does not match directory name '${dirName}'.`
-      );
-    }
-  } catch (e) {
-    problems.push(e.message);
+  const keys = Object.keys(skill.frontmatter);
+  const unknown = keys.filter((k) => !ALLOWED_FRONTMATTER_KEYS.has(k));
+  if (unknown.length > 0) {
+    problems.push(`Unknown frontmatter fields: [${unknown.sort().join(", ")}]`);
+  }
+  const dirName = path.basename(resolvedDir);
+  if (dirName !== skill.frontmatter.name) {
+    problems.push(
+      `Skill name '${skill.frontmatter.name}' does not match directory name '${dirName}'.`
+    );
   }
   return problems;
 }
@@ -352,7 +353,7 @@ function loadSkillFromZipBuffer(zipBuffer) {
       );
     }
   }
-  let skillMdContent = "";
+  let skillMdContent;
   for (const entry of entries) {
     if (entry.isDirectory) continue;
     if (entry.entryName.toLowerCase() === "skill.md") {
@@ -360,7 +361,7 @@ function loadSkillFromZipBuffer(zipBuffer) {
       break;
     }
   }
-  if (!skillMdContent) {
+  if (skillMdContent === void 0) {
     throw new import_not_found_error.NotFoundError("SKILL.md not found in zipped filesystem.");
   }
   const { raw, body } = parseFrontmatterYaml(skillMdContent);