@google-cloud/promisify 1.0.4 → 2.0.3

package/CHANGELOG.md

@@ -4,6 +4,44 @@
 
 [1]: https://www.npmjs.com/package/nodejs-promisify?activeTab=versions
 
+### [2.0.3](https://www.github.com/googleapis/nodejs-promisify/compare/v2.0.2...v2.0.3) (2020-09-04)
+
+
+### Bug Fixes
+
+* allow excluding accessor methods ([#228](https://www.github.com/googleapis/nodejs-promisify/issues/228)) ([114d8bc](https://www.github.com/googleapis/nodejs-promisify/commit/114d8bcef7093bdfda195a15e0c2f376195fd3fc))
+
+### [2.0.2](https://www.github.com/googleapis/nodejs-promisify/compare/v2.0.1...v2.0.2) (2020-07-06)
+
+
+### Bug Fixes
+
+* update node issue template ([#204](https://www.github.com/googleapis/nodejs-promisify/issues/204)) ([a2ba8d8](https://www.github.com/googleapis/nodejs-promisify/commit/a2ba8d8e45ef03d093d987292a467696745fc9fd))
+
+### [2.0.1](https://www.github.com/googleapis/nodejs-promisify/compare/v2.0.0...v2.0.1) (2020-05-08)
+
+
+### Bug Fixes
+
+* apache license URL ([#468](https://www.github.com/googleapis/nodejs-promisify/issues/468)) ([#191](https://www.github.com/googleapis/nodejs-promisify/issues/191)) ([0edc724](https://www.github.com/googleapis/nodejs-promisify/commit/0edc7246c53d25d9dd220b813561bcee97250783))
+
+## [2.0.0](https://www.github.com/googleapis/nodejs-promisify/compare/v1.0.4...v2.0.0) (2020-03-23)
+
+
+### ⚠ BREAKING CHANGES
+
+* update to latest version of gts/typescript (#183)
+* drop Node 8 from engines field (#184)
+
+### Features
+
+* drop Node 8 from engines field ([#184](https://www.github.com/googleapis/nodejs-promisify/issues/184)) ([7e6d3c5](https://www.github.com/googleapis/nodejs-promisify/commit/7e6d3c54066d89530ed25c7f9722efd252f43fb8))
+
+
+### Build System
+
+* update to latest version of gts/typescript ([#183](https://www.github.com/googleapis/nodejs-promisify/issues/183)) ([9c3ed12](https://www.github.com/googleapis/nodejs-promisify/commit/9c3ed12c12f4bb1e17af7440c6371c4cefddcd59))
+
 ### [1.0.4](https://www.github.com/googleapis/nodejs-promisify/compare/v1.0.3...v1.0.4) (2019-12-05)
 
 

package/README.md

@@ -14,6 +14,9 @@
 A simple utility for promisifying functions and classes.
 
 
+A comprehensive list of changes in each version may be found in
+[the CHANGELOG](https://github.com/googleapis/nodejs-promisify/blob/master/CHANGELOG.md).
+
 * [Google Cloud Common Promisify Node.js Client API Reference][client-docs]
 
 * [github.com/googleapis/nodejs-promisify](https://github.com/googleapis/nodejs-promisify)
@@ -89,6 +92,27 @@ has instructions for running the samples.
 The [Google Cloud Common Promisify Node.js Client API Reference][client-docs] documentation
 also contains samples.
 
+## Supported Node.js Versions
+
+Our client libraries follow the [Node.js release schedule](https://nodejs.org/en/about/releases/).
+Libraries are compatible with all current _active_ and _maintenance_ versions of
+Node.js.
+
+Client libraries targetting some end-of-life versions of Node.js are available, and
+can be installed via npm [dist-tags](https://docs.npmjs.com/cli/dist-tag).
+The dist-tags follow the naming convention `legacy-(version)`.
+
+_Legacy Node.js versions are supported as a best effort:_
+
+* Legacy versions will not be tested in continuous integration.
+* Some security patches may not be able to be backported.
+* Dependencies will not be kept up-to-date, and features will not be backported.
+
+#### Legacy tags available
+
+* `legacy-8`: install client libraries from this dist-tag for versions
+  compatible with Node.js 8.
+
 ## Versioning
 
 This library follows [Semantic Versioning](http://semver.org/).
@@ -112,6 +136,12 @@ More Information: [Google Cloud Platform Launch Stages][launch_stages]
 
 Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/nodejs-promisify/blob/master/CONTRIBUTING.md).
 
+Please note that this `README.md`, the `samples/README.md`,
+and a variety of configuration files in this repository (including `.nycrc` and `tsconfig.json`)
+are generated from a central template. To edit one of these files, make an edit
+to its template in this
+[directory](https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/node_library).
+
 ## License
 
 Apache Version 2.0

package/build/src/index.js

@@ -1,18 +1,7 @@
 "use strict";
-// Copyright 2014 Google LLC
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+/* eslint-disable prefer-rest-params */
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.callbackifyAll = exports.callbackify = exports.promisifyAll = exports.promisify = void 0;
 /**
  * Wraps a callback style function to conditionally return a promise.
  *
@@ -29,7 +18,6 @@ function promisify(originalMethod, options) {
     const slice = Array.prototype.slice;
     // tslint:disable-next-line:no-any
     const wrapper = function () {
-        const context = this;
         let last;
         for (last = arguments.length - 1; last >= 0; last--) {
             const arg = arguments[last];
@@ -39,7 +27,7 @@ function promisify(originalMethod, options) {
             if (typeof arg !== 'function') {
                 break; // non-callback last argument found.
             }
-            return originalMethod.apply(context, arguments);
+            return originalMethod.apply(this, arguments);
         }
         // peel trailing undefined.
         const args = slice.call(arguments, 0, last + 1);
@@ -48,8 +36,8 @@ function promisify(originalMethod, options) {
         // Because dedupe will likely create a single install of
         // @google-cloud/common to be shared amongst all modules, we need to
         // localize it at the Service level.
-        if (context && context.Promise) {
-            PromiseCtor = context.Promise;
+        if (this && this.Promise) {
+            PromiseCtor = this.Promise;
         }
         return new PromiseCtor((resolve, reject) => {
             // tslint:disable-next-line:no-any
@@ -66,7 +54,7 @@ function promisify(originalMethod, options) {
                     resolve(callbackArgs);
                 }
             });
-            originalMethod.apply(context, args);
+            originalMethod.apply(this, args);
         });
     };
     wrapper.promisified_ = true;
@@ -86,9 +74,10 @@ function promisifyAll(Class, options) {
     const ownPropertyNames = Object.getOwnPropertyNames(Class.prototype);
     const methods = ownPropertyNames.filter(methodName => {
         // clang-format off
-        return (typeof Class.prototype[methodName] === 'function' && // is it a function?
-            !/(^_|(Stream|_)|promise$)|^constructor$/.test(methodName) && // is it promisable?
-            exclude.indexOf(methodName) === -1); // is it blacklisted?
+        return (!exclude.includes(methodName) &&
+            typeof Class.prototype[methodName] === 'function' && // is it a function?
+            !/(^_|(Stream|_)|promise$)|^constructor$/.test(methodName) // is it promisable?
+        );
         // clang-format on
     });
     methods.forEach(methodName => {
@@ -113,12 +102,11 @@ function callbackify(originalMethod) {
     }
     // tslint:disable-next-line:no-any
     const wrapper = function () {
-        const context = this;
         if (typeof arguments[arguments.length - 1] !== 'function') {
-            return originalMethod.apply(context, arguments);
+            return originalMethod.apply(this, arguments);
         }
         const cb = Array.prototype.pop.call(arguments);
-        originalMethod.apply(context, arguments).then(
+        originalMethod.apply(this, arguments).then(
         // tslint:disable-next-line:no-any
         (res) => {
             res = Array.isArray(res) ? res : [res];
@@ -143,9 +131,10 @@ Class, options) {
     const ownPropertyNames = Object.getOwnPropertyNames(Class.prototype);
     const methods = ownPropertyNames.filter(methodName => {
         // clang-format off
-        return (typeof Class.prototype[methodName] === 'function' && // is it a function?
-            !/^_|(Stream|_)|^constructor$/.test(methodName) && // is it callbackifyable?
-            exclude.indexOf(methodName) === -1); // is it blacklisted?
+        return (!exclude.includes(methodName) &&
+            typeof Class.prototype[methodName] === 'function' && // is it a function?
+            !/^_|(Stream|_)|^constructor$/.test(methodName) // is it callbackifyable?
+        );
         // clang-format on
     });
     methods.forEach(methodName => {

package/package.json

@@ -1,25 +1,28 @@
 {
   "name": "@google-cloud/promisify",
-  "version": "1.0.4",
+  "version": "2.0.3",
   "description": "A simple utility for promisifying functions and classes.",
   "main": "build/src/index.js",
   "types": "build/src/index.d.ts",
   "repository": "googleapis/nodejs-promisify",
   "scripts": {
-    "test": "nyc mocha build/test",
+    "test": "c8 mocha build/test",
     "lint": "gts check",
-    "clean": "gts clean",
     "compile": "tsc -p .",
     "fix": "gts fix",
     "prepare": "npm run compile",
     "pretest": "npm run compile",
-    "posttest": "npm run lint",
     "docs": "compodoc src/",
     "presystem-test": "npm run compile",
     "samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
     "system-test": "mocha build/system-test",
     "docs-test": "linkinator docs",
-    "predocs-test": "npm run docs"
+    "predocs-test": "npm run docs",
+    "prelint": "cd samples; npm link ../; npm install",
+    "clean": "gts clean",
+    "precompile": "gts clean",
+    "api-extractor": "api-extractor run --local",
+    "api-documenter": "api-documenter yaml --input-folder=temp"
   },
   "keywords": [],
   "files": [
@@ -30,21 +33,22 @@
   "license": "Apache-2.0",
   "devDependencies": {
     "@compodoc/compodoc": "^1.1.9",
-    "@types/mocha": "^5.2.4",
+    "@types/mocha": "^8.0.0",
     "@types/node": "^10.5.2",
-    "@types/sinon": "^7.0.0",
+    "@types/sinon": "^9.0.0",
+    "c8": "^7.0.0",
+    "chai": "^4.2.0",
     "codecov": "^3.0.4",
-    "gts": "^1.0.0",
-    "hard-rejection": "^2.0.0",
-    "intelli-espower-loader": "^1.0.1",
-    "linkinator": "^1.5.0",
-    "mocha": "^6.0.0",
-    "nyc": "^14.0.0",
-    "sinon": "^7.0.0",
-    "source-map-support": "^0.5.6",
-    "typescript": "3.6.4"
+    "gts": "^2.0.0",
+    "hard-rejection": "^2.1.0",
+    "linkinator": "^2.0.0",
+    "mocha": "^8.0.0",
+    "sinon": "^9.0.0",
+    "typescript": "^3.8.3",
+    "@microsoft/api-documenter": "^7.8.10",
+    "@microsoft/api-extractor": "^7.8.10"
   },
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=10"
   }
 }