@google-cloud/nodejs-common 2.4.0 → 2.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@google-cloud/nodejs-common",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "A NodeJs common library for solutions based on Cloud Functions",
   "author": "Google Inc.",
   "license": "Apache-2.0",

package/src/apis/gmail.js

@@ -73,6 +73,9 @@ class Gmail extends GoogleApiClient {
         message.push(`${key}: ${value}`);
       }
     });
+    if (options.type) {
+      message.push(`content-type: ${options.type}`);
+    }
     if (message.length === 0)
       throw new Error(`Can not get email from ${options}`);
     message.push('\n');

package/src/apis/search_ads.js

@@ -183,6 +183,7 @@ class SearchAds extends GoogleApiClient {
     const selectedColumns = {};
     const getSelectedColumn = (column) => {
       if (columnIds.indexOf(column.id) > -1) {
+        column.safeName = changeStringToBigQuerySafe(column.name);
         selectedColumns[column.id] = column;
       }
     }
@@ -193,6 +194,12 @@ class SearchAds extends GoogleApiClient {
       (await this.listCustomColumns(customerId, loginCustomerId))
         .forEach(getSelectedColumn);
     }
+    if (Object.keys(selectedColumns).length < columnIds.length) {
+      const missing = columnIds.filter(
+        (id) => Object.keys(selectedColumns).indexOf(id) === -1
+      );
+      throw new Error(`Fail to find custom column(s): ${missing.join()}.`);
+    }
     return columnIds.map((columnId) => selectedColumns[columnId]);
   }
 
@@ -208,11 +215,10 @@ class SearchAds extends GoogleApiClient {
   async getCustomColumnsConvertor(customerId, loginCustomerId, query) {
     const customerColumns = await this.getCustomColumnsFromQuery(
       customerId, loginCustomerId, query);
-    const columnConvertors = customerColumns.map(({ name, valueType }) => {
+    const columnConvertors = customerColumns.map(({ safeName, valueType }) => {
       return (obj) => {
-        const key = changeStringToBigQuerySafe(name);
         const value = obj[`${valueType.toLowerCase()}Value`];
-        return { [key]: value };
+        return { [safeName]: value };
       };
     });
     const convertor = (customerColumns) => {

package/src/components/scheduler.js

@@ -160,9 +160,15 @@ class CloudScheduler {
     const requestPrefix = `projects/${projectId}/locations`;
     const jobs = locations.map(async (location) => {
       const request = { parent: `${requestPrefix}/${location}` };
-      const response = await this.instance.projects.locations.jobs.list(request);
-      if (!response.data.jobs) return [];
-      return response.data.jobs.map((job) => job.name);
+      try {
+        const response =
+          await this.instance.projects.locations.jobs.list(request);
+        if (!response.data.jobs) return [];
+        return response.data.jobs.map((job) => job.name);
+      } catch (error) {
+        console.warn(`Failed to list jobs for ${location}`, error);
+        return [];
+      }
     });
     // Waits for all jobs names and flattens nested job name arrays, however
     // there is no 'flat' available in current Cloud Functions runtime.