@google-cloud/nodejs-common 1.4.9-alpha → 1.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@google-cloud/nodejs-common",
-  "version": "1.4.9-alpha",
+  "version": "1.5.0",
   "description": "A NodeJs common library for solutions based on Cloud Functions",
   "author": "Google Inc.",
   "license": "Apache-2.0",

package/src/apis/dfa_reporting.js

@@ -34,7 +34,7 @@ const API_SCOPES = Object.freeze([
   'https://www.googleapis.com/auth/dfareporting',
   'https://www.googleapis.com/auth/dfatrafficking',
 ]);
-const API_VERSION = 'v3.5';
+const API_VERSION = 'v4';
 
 /**
  * Configuration for preparing conversions for Campaign Manager, includes:
@@ -65,7 +65,7 @@ let InsertConversionsConfig;
 /**
  * List of properties that will be take from the data file as elements of a
  * conversion.
- * See https://developers.google.com/doubleclick-advertisers/rest/v3.5/Conversion
+ * See https://developers.google.com/doubleclick-advertisers/rest/v4/Conversion
  * @type {Array<string>}
  */
 const PICKED_PROPERTIES = [
@@ -216,9 +216,9 @@ class DfaReporting {
    * ConversionStatus object. This function extras failed lines and error
    * messages based on the 'errors'.
    * For 'ConversionStatus', see:
-   *   https://developers.google.com/doubleclick-advertisers/rest/v3.5/ConversionStatus
+   *   https://developers.google.com/doubleclick-advertisers/rest/v4/ConversionStatus
    * For 'ConversionError', see:
-   *   https://developers.google.com/doubleclick-advertisers/rest/v3.5/ConversionStatus#ConversionError
+   *   https://developers.google.com/doubleclick-advertisers/rest/v4/ConversionStatus#ConversionError
    * @param {!BatchResult} batchResult
    * @param {!Array<!Schema$ConversionStatus>} statuses
    * @param {!Array<string>} lines The original input data.
@@ -284,7 +284,7 @@ class DfaReporting {
    * Runs a report and return the file Id. As an asynchronized process, the
    * returned file Id will be a placeholder until the status changes to
    * 'REPORT_AVAILABLE' in the response of `getFile`.
-   * @see https://developers.google.com/doubleclick-advertisers/rest/v3.5/reports/run
+   * @see https://developers.google.com/doubleclick-advertisers/rest/v4/reports/run
    *
    * @param {{
    *   accountId:(string|undefined),
@@ -306,9 +306,9 @@ class DfaReporting {
 
   /**
    * Returns file url from a report. If the report status is 'REPORT_AVAILABLE',
-   * then return the apiUrl from the response; if the status is 'PROCESSING',
-   * returns undefined; otherwise throws an error.
-   * @see https://developers.google.com/doubleclick-advertisers/rest/v3.5/reports/get
+   * then return the apiUrl from the response; if the status is 'PROCESSING' or
+   * 'QUEUED', returns undefined as it is unfinished; otherwise throws an error.
+   * @see https://developers.google.com/doubleclick-advertisers/rest/v4/reports/get
    *
    * @param {{
    *   accountId:(string|undefined),
@@ -326,8 +326,8 @@ class DfaReporting {
       reportId: config.reportId,
       fileId: config.fileId,
     });
-    const {data} = response;
-    if (data.status === 'PROCESSING') return;
+    const { data } = response;
+    if (data.status === 'PROCESSING' || data.status === 'QUEUED') return;
     if (data.status === 'REPORT_AVAILABLE') return data.urls.apiUrl;
     throw new Error(`Unsupported report status: ${data.status}`);
   }