@google-cloud/nodejs-common 1.2.1-beta → 1.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@google-cloud/nodejs-common",
3
- "version": "1.2.1-beta",
3
+ "version": "1.3.0",
4
4
  "description": "A NodeJs common library for solutions based on Cloud Functions",
5
5
  "author": "Google Inc.",
6
6
  "license": "Apache-2.0",
@@ -829,14 +829,10 @@ class GoogleAds {
829
829
  validate_only: this.debugMode, // when true makes no changes
830
830
  enable_match_rate_range_preview: true,
831
831
  });
832
- try {
833
- const { resource_name: resourceName } =
834
- await customer.offlineUserDataJobs.createOfflineUserDataJob(request);
835
- this.logger.info('Created OfflineUserDataJob:', resourceName);
836
- return resourceName;
837
- } catch (error) {
838
- this.logger.error(error);
839
- }
832
+ const { resource_name: resourceName } =
833
+ await customer.offlineUserDataJobs.createOfflineUserDataJob(request);
834
+ this.logger.info('Created OfflineUserDataJob:', resourceName);
835
+ return resourceName;
840
836
  }
841
837
 
842
838
  /**
@@ -860,12 +856,10 @@ class GoogleAds {
860
856
  enable_partial_failure: true,
861
857
  enable_warnings: true,
862
858
  });
863
- // console.log(request);
864
859
  const response = await customer.
865
860
  offlineUserDataJobs.addOfflineUserDataJobOperations(request);
866
- // console.log(response);
867
- console.log('Request size:', JSON.stringify(request).length);
868
- console.log('Time used:', new Date().getTime() - start);
861
+ this.logger.debug(`Added ${records.length} records in (ms):`,
862
+ new Date().getTime() - start);
869
863
  return response;
870
864
  }
871
865
 
@@ -883,15 +877,11 @@ class GoogleAds {
883
877
  resource_name: jobResourceName,
884
878
  validate_only: false,//this.debugMode,
885
879
  });
886
- try {
887
- const rawResponse = await customer.
880
+ const rawResponse = await customer.
888
881
  offlineUserDataJobs.runOfflineUserDataJob(request);
889
- const response = lodash.pick(rawResponse, ['name', 'done', 'error']);
890
- console.log(response);
891
- return response;
892
- } catch (e) {
893
- console.log(e);
894
- }
882
+ const response = lodash.pick(rawResponse, ['name', 'done', 'error']);
883
+ this.logger.debug('runOfflineUserDataJob response: ', response);
884
+ return response;
895
885
  }
896
886
 
897
887
  /**