@goodie-forms/core 1.2.6-alpha → 1.3.0

package/package.json

@@ -1,6 +1,16 @@
 {
   "name": "@goodie-forms/core",
-  "version": "1.2.6-alpha",
+  "version": "1.3.0",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/iGoodie/goodie-forms"
+  },
+  "author": {
+    "name": "Taha Anılcan Metinyurt",
+    "email": "igoodie@programmer.net",
+    "url": "https://github.com/iGoodie"
+  },
+  "license": "CC BY-SA 4.0",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/field/FieldPath.ts

@@ -95,6 +95,7 @@ export namespace FieldPath {
     }
     return true;
   }
+
   export function isDescendant(parentPath: Segments, childPath: Segments) {
     if (parentPath.length >= childPath.length) return false;
 

package/src/field/Reconcile.ts

@@ -73,24 +73,29 @@ export namespace Reconcile {
   export function arrayDiff<T>(
     prev: readonly T[],
     next: readonly T[],
-    equals: (a: T, b: T) => boolean,
-    filter?: (a: T) => boolean,
+    opts?: {
+      equals?: (a: T, b: T) => boolean;
+      include?: (a: T) => boolean;
+    },
   ) {
     const added: T[] = [];
     const removed: T[] = [];
     const unchanged: T[] = [];
 
+    const equals = (a: T, b: T) => (opts?.equals ? opts.equals(a, b) : a === b);
+    const include = (a: T) => (opts?.include ? opts.include(a) : true);
+
     for (const n of next) {
       if (prev.some((p) => equals(p, n))) {
-        if (filter?.(n) ?? true) unchanged.push(n);
+        if (include(n)) unchanged.push(n);
       } else {
-        if (filter?.(n) ?? true) added.push(n);
+        if (include(n)) added.push(n);
       }
     }
 
     for (const p of prev) {
       if (!next.some((n) => equals(p, n))) {
-        if (filter?.(p) ?? true) removed.push(p);
+        if (include(p)) removed.push(p);
       }
     }
 

package/src/form/FormController.ts

@@ -116,8 +116,7 @@ export class FormController<TOutput extends object> {
   }
 
   get isValid() {
-    // TODO: Does it still count valid while validating?
-    return this._issues.length === 0;
+    return this.isValidating || this._issues.length === 0;
   }
 
   get isValidating() {
@@ -273,11 +272,9 @@ export class FormController<TOutput extends object> {
     _result: StandardSchemaV1.Result<TOutput>,
     path: TPath,
   ) {
-    const diff = Reconcile.arrayDiff(
-      this._issues,
-      _result.issues ?? [],
-      Reconcile.deepEqual,
-      (issue) => {
+    const diff = Reconcile.arrayDiff(this._issues, _result.issues ?? [], {
+      equals: Reconcile.deepEqual,
+      include: (issue) => {
         if (issue.path == null) return false;
         const issuePath = FieldPath.normalize(issue.path);
         return (
@@ -285,7 +282,7 @@ export class FormController<TOutput extends object> {
           FieldPath.isDescendant(path, issuePath)
         );
       },
-    );
+    });
 
     removeBy(this._issues, (issue) => diff.removed.includes(issue));
 
@@ -314,11 +311,9 @@ export class FormController<TOutput extends object> {
     }
 
     // Append non-registered issues too
-    const diff = Reconcile.arrayDiff(
-      this._issues,
-      result.issues ?? [],
-      Reconcile.deepEqual,
-    );
+    const diff = Reconcile.arrayDiff(this._issues, result.issues ?? [], {
+      equals: Reconcile.deepEqual,
+    });
     diff.added.forEach((issue) => this._issues.push(issue));
 
     this.setValidating(false);

package/src/form/FormField.ts

@@ -182,6 +182,9 @@ export class FormField<TOutput extends object, TValue> {
     }
   }
 
+  // TODO: impl
+  // private modifyInitialData() {}
+
   setValue(value: TValue, opts?: Parameters<typeof this.modifyData>[1]) {
     return this.modifyData((data) => {
       FieldPath.setValue(data as TOutput, this.path, value as never);