@gooddollar/goodprotocol 1.0.10 → 1.0.13-beta.1

package/test/staking/DonationsStaking.test.ts

@@ -57,7 +57,9 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
     const goodFundManagerFactory = await ethers.getContractFactory(
       "GoodFundManager"
     );
-    goodCompoundStakingFactory = await getStakingFactory("GoodCompoundStaking");
+    goodCompoundStakingFactory = await getStakingFactory(
+      "GoodCompoundStakingV2"
+    );
 
     const daiFactory = await ethers.getContractFactory("DAIMock");
     let {
@@ -216,6 +218,7 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
     expect(totalStakedBeforeStake).to.be.equal(0);
     expect(totalStakedAfterStake).to.be.gt(totalStakedBeforeStake);
   });
+
   it("it should stake donations with DAI", async () => {
     let stakeAmount = ethers.utils.parseEther("10");
     await dai["mint(address,uint256)"](donationsStaking.address, stakeAmount);
@@ -226,6 +229,13 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
       stakeAmount
     );
   });
+
+  it("it should reverted when there is no token to stake", async () => {
+    await expect(donationsStaking.stakeDonations()).to.be.revertedWith(
+      "no stakingToken to stake"
+    );
+  });
+
   it("it should stake donations with ETH according to 0.3% of pool", async () => {
     let stakeAmount = ethers.utils.parseEther("20");
     const pairContract = await ethers.getContractAt(
@@ -261,6 +271,7 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
     expect(stakeAmount).to.be.gt(maxAmount);
     expect(stakeAmount.sub(maxAmount)).to.be.equal(ethBalanceAfterStake); // check leftover ETH in contract
   });
+
   it("withdraw should reverted if caller not avatar", async () => {
     const tx = await donationsStaking
       .connect(staker)
@@ -268,6 +279,7 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
       .catch(e => e);
     expect(tx.message).to.have.string("only avatar can call this method");
   });
+
   it("it should withdraw donationStaking when caller is avatar and return funds to avatar", async () => {
     const totalStakedBeforeEnd = await donationsStaking.totalStaked();
     const avatarDaiBalanceBeforeEnd = await dai.balanceOf(avatar);
@@ -303,16 +315,9 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
 
     expect(totalStakedAfterEnd).to.be.equal(0);
   });
+
   it("it should set stakingContract when avatar call it ", async () => {
     let stakeAmount = ethers.utils.parseEther("6000"); // Max swap amount is around 5964 with current liquidity level so we should set it to higher number in order to test functionality
-    const donationsStakingFactory = await ethers.getContractFactory(
-      "DonationsStaking",
-      {
-        libraries: {
-          UniswapV2SwapHelper: swapHelper.address
-        }
-      }
-    );
 
     await dai["mint(address,uint256)"](donationsStaking.address, stakeAmount);
     await donationsStaking.stakeDonations();
@@ -340,7 +345,7 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
       .then(async contract => {
         await contract.init(
           bat.address,
-          cDAI.address,
+          cBat.address,
           nameService.address,
           "Good BAT",
           "gBAT",
@@ -351,12 +356,7 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
         );
         return contract;
       });
-    //let encodedData = donationsStakingFactory.interface.encodeFunctionData(
-    //  "setStakingContract",
-    //  [simpleStaking.address, [NULL_ADDRESS, bat.address]]
-    //);
-    //
-    //await genericCall(donationsStaking.address, encodedData);
+
     await donationsStaking.setStakingContract(simpleStaking.address, [
       NULL_ADDRESS,
       bat.address
@@ -388,4 +388,9 @@ describe("DonationsStaking - DonationStaking contract that receives funds in ETH
     ); // It should send leftover stakingToken to avatar after swap to ETH in safeAmount
     expect(stakingAmountBeforeSet).to.be.gt(safeAmount); // maxSafeAmount must be smaller than actualstaking amount so we can verify that we hit the limit for transaction amount at once
   });
+
+  it("it should return version of DonationsStaking properly", async () => {
+    const version = await donationsStaking.getVersion();
+    expect(version).to.be.equal("2.0.0");
+  });
 });

package/test/staking/GoodAaveStakingFactory.test.ts

@@ -50,36 +50,38 @@ describe("AaveStakingFactory", () => {
     await dao.setDAOAddress("AAVE", aave.address);
     let swapHelper = await ethers
       .getContractFactory("UniswapV2SwapHelper")
-      .then((_) => _.deploy());
+      .then(_ => _.deploy());
 
     stakingFactory = (await ethers
       .getContractFactory("AaveStakingFactory", {
-        libraries: { UniswapV2SwapHelper: swapHelper.address },
+        libraries: { UniswapV2SwapHelper: swapHelper.address }
       })
-      .then((_) => _.deploy())) as AaveStakingFactory;
+      .then(_ => _.deploy())) as AaveStakingFactory;
   });
 
-  it("should create proxy clone", async () => {
-    const res = await (
-      await stakingFactory.clone(usdc.address, ethers.constants.HashZero)
-    ).wait();
-    const log = res.events.find((_) => _.event === "Deployed");
-    const detAddress = await stakingFactory.predictAddress(
-      usdc.address,
-      ethers.constants.HashZero
-    );
+  // it("should create proxy clone", async () => {
+  //   const res = await (
+  //     await stakingFactory.clone(usdc.address, ethers.constants.HashZero)
+  //   ).wait();
+  //   const log = res.events.find((_) => _.event === "Deployed");
+  //   const detAddress = await stakingFactory.predictAddress(
+  //     usdc.address,
+  //     ethers.constants.HashZero
+  //   );
 
-    expect(log).to.not.empty;
-    expect(log.args.proxy).to.equal(detAddress);
-    expect(log.args.token).to.equal(usdc.address);
-  });
+  //   expect(log).to.not.empty;
+  //   expect(log.args.proxy).to.equal(detAddress);
+  //   expect(log.args.token).to.equal(usdc.address);
+  // });
 
   it("should create and initialize clone", async () => {
     const ns = await ethers
       .getContractFactory("NameService")
-      .then((_) => _.deploy());
+      .then(_ => _.deploy());
     const res = await (
-      await stakingFactory.cloneAndInit(
+      await stakingFactory[
+        "cloneAndInit(address,address,address,uint64,address,address,address,address[])"
+      ](
         usdc.address,
         lendingPool.address,
         dao.nameService.address,
@@ -90,8 +92,9 @@ describe("AaveStakingFactory", () => {
         [usdc.address, dai]
       )
     ).wait();
-    const log = res.events.find((_) => _.event === "Deployed");
+    const log = res.events.find(_ => _.event === "Deployed");
     const detAddress = await stakingFactory.predictAddress(
+      await stakingFactory.impl(),
       usdc.address,
       ethers.utils.solidityKeccak256(
         ["address", "address", "uint64", "address", "address", "address"],
@@ -101,7 +104,7 @@ describe("AaveStakingFactory", () => {
           5760,
           stakingFactory.address,
           incentiveController.address,
-          aaveUsdOracle.address,
+          aaveUsdOracle.address
         ]
       )
     );
@@ -111,12 +114,12 @@ describe("AaveStakingFactory", () => {
 
     //check initialization
     const staking: GoodAaveStaking = (await ethers.getContractAt(
-      "GoodAaveStaking",
+      "GoodAaveStakingV2",
       detAddress
     )) as GoodAaveStaking;
     expect(await staking.iToken()).to.equal(lendingPool.address);
     expect(await staking.token()).to.equal(usdc.address);
-    expect(await staking.name()).to.equal("GoodAaveStaking USDC");
-    expect(await staking.symbol()).to.equal("gUSDC");
+    expect(await staking.name()).to.equal("GoodAaveStakingV2 USDC");
+    expect(await staking.symbol()).to.equal("gaUSDC");
   });
 });

package/test/staking/SimpleDAIStaking.test.ts

@@ -97,7 +97,9 @@ describe("SimpleDAISTAking - staking with cDAI mocks", () => {
     );
     compUsdOracle = await compUsdOracleFactory.deploy();
 
-    goodCompoundStakingFactory = await getStakingFactory("GoodCompoundStaking");
+    goodCompoundStakingFactory = await getStakingFactory(
+      "GoodCompoundStakingV2"
+    );
 
     deployStaking = async (token, itoken) => {
       return goodCompoundStakingFactory.deploy().then(async contract => {
@@ -1256,16 +1258,6 @@ describe("SimpleDAISTAking - staking with cDAI mocks", () => {
     );
   });
 
-  it("should not withdraw interest if the recipient specified by the owner is the staking contract", async () => {
-    await advanceBlocks(BLOCK_INTERVAL);
-    await setDAOAddress("FUND_MANAGER", founder.address);
-    const error = await goodCompoundStaking
-      .collectUBIInterest(goodCompoundStaking.address)
-      .catch(e => e);
-    await setDAOAddress("FUND_MANAGER", goodFundManager.address);
-    expect(error.message).to.be.not.empty;
-  });
-
   it("should pause the contract", async () => {
     let encodedCall = goodCompoundStakingFactory.interface.encodeFunctionData(
       "pause",

package/test/staking/StakingRewards.test.ts

@@ -1,7 +1,7 @@
 import { ethers, upgrades } from "hardhat";
 import { BigNumber, Contract } from "ethers";
 import { expect } from "chai";
-import { GoodMarketMaker, GoodCompoundStaking } from "../../types";
+import { GoodMarketMaker } from "../../types";
 import {
   createDAO,
   increaseTime,
@@ -56,7 +56,9 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
     const goodFundManagerFactory = await ethers.getContractFactory(
       "GoodFundManager"
     );
-    goodCompoundStakingFactory = await getStakingFactory("GoodCompoundStaking");
+    goodCompoundStakingFactory = await getStakingFactory(
+      "GoodCompoundStakingV2"
+    );
     goodCompoundStakingTestFactory = await getStakingFactory(
       "GoodCompoundStakingTest"
     );
@@ -307,11 +309,13 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
     await dai
       .connect(staker)
       .approve(goodCompoundStaking.address, stakingAmount);
-    const totalEffectiveStakesBeforeStake =
-      await goodCompoundStaking.totalEffectiveStakes();
+    const totalEffectiveStakesBeforeStake = await goodCompoundStaking
+      .getStats()
+      .then(_ => _[3]);
     await goodCompoundStaking.connect(staker).stake(stakingAmount, 100, false);
-    const totalEffectiveStakesAfterStake =
-      await goodCompoundStaking.totalEffectiveStakes();
+    const totalEffectiveStakesAfterStake = await goodCompoundStaking
+      .getStats()
+      .then(_ => _[3]);
     await goodCompoundStaking
       .connect(staker)
       .withdrawStake(stakingAmount, false);
@@ -326,11 +330,13 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
     await dai
       .connect(staker)
       .approve(goodCompoundStaking.address, stakingAmount);
-    const totalEffectiveStakesBeforeStake =
-      await goodCompoundStaking.totalEffectiveStakes();
+    const totalEffectiveStakesBeforeStake = await goodCompoundStaking
+      .getStats()
+      .then(_ => _[3]);
     await goodCompoundStaking.connect(staker).stake(stakingAmount, 0, false);
-    const totalEffectiveStakesAfterStake =
-      await goodCompoundStaking.totalEffectiveStakes();
+    const totalEffectiveStakesAfterStake = await goodCompoundStaking
+      .getStats()
+      .then(_ => _[3]);
     await goodCompoundStaking
       .connect(staker)
       .withdrawStake(stakingAmount, false);
@@ -1452,7 +1458,7 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
     expect(activeContractsCount).to.be.equal(activeContractsCountAfterRemoved);
   });
   it("it should distribute rewards correctly when there is multiple stakers", async () => {
-    const simpleStaking1 = (await goodCompoundStakingTestFactory.deploy(
+    const simpleStaking1 = await goodCompoundStakingTestFactory.deploy(
       bat.address,
       cBat.address,
       nameService.address,
@@ -1462,7 +1468,7 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
       batUsdOracle.address,
       compUsdOracle.address,
       [bat.address, dai.address]
-    )) as GoodCompoundStaking;
+    );
     const currentBlock = await ethers.provider.getBlockNumber();
     const rewardsPerBlock = BN.from("1000");
     let encodedData = goodFundManager.interface.encodeFunctionData(
@@ -1624,7 +1630,7 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
     await genericCall(goodFundManager.address, encodedData, avatar, 0);
   });
   it("it should get staking reward even reward amount is too low", async () => {
-    const simpleStaking1 = (await goodCompoundStakingTestFactory.deploy(
+    const simpleStaking1 = await goodCompoundStakingTestFactory.deploy(
       bat.address,
       cBat.address,
       nameService.address,
@@ -1634,7 +1640,7 @@ describe("StakingRewards - staking with cDAI mocks and get Rewards in GoodDollar
       batUsdOracle.address,
       compUsdOracle.address,
       [bat.address, dai.address]
-    )) as GoodCompoundStaking;
+    );
 
     const currentBlock = await ethers.provider.getBlockNumber();
     const rewardsPerBlock = BN.from("100");

package/test/staking/SwapHelper.test.ts

@@ -46,7 +46,9 @@ describe("SwapHelper - Helper library for swap on the Uniswap", () => {
     const swapHelperTestFactory = await ethers.getContractFactory(
       "SwapHelperTest"
     );
-    goodCompoundStakingFactory = await getStakingFactory("GoodCompoundStaking");
+    goodCompoundStakingFactory = await getStakingFactory(
+      "GoodCompoundStakingV2"
+    );
     goodCompoundStakingTestFactory = await getStakingFactory(
       "GoodCompoundStakingTest"
     );
@@ -210,6 +212,7 @@ describe("SwapHelper - Helper library for swap on the Uniswap", () => {
       ["100", simpleStaking.address, 0, 10000, true]
     );
     await genericCall(goodFundManager.address, encodedData, avatar, 0);
+    console.log({ redeemedAmount, safeAmount });
     expect(reserve[0].sub(currentReserve[0])).to.be.lt(currentGains[1]);
     expect(currentReserve[0].sub(reserve[0])).to.be.equal(redeemedAmount);
   });

package/test/staking/UsdcAaveStaking.test.ts

@@ -8,7 +8,7 @@ import { createDAO, deployUniswap, getStakingFactory } from "../helpers";
 const BN = ethers.BigNumber;
 export const NULL_ADDRESS = ethers.constants.AddressZero;
 
-describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
+describe("UsdcAaveStakingV2 - staking with USDC mocks to AAVE interface", () => {
   let dai: Contract;
   let usdc: Contract;
   let pair: Contract, uniswapRouter: Contract;
@@ -29,7 +29,6 @@ describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
     lendingPool,
     setDAOAddress,
     genericCall,
-    goodReserve,
     goodAaveStakingFactory;
   before(async () => {
     [founder, staker, ...signers] = await ethers.getSigners();
@@ -39,7 +38,7 @@ describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
     const goodFundManagerFactory = await ethers.getContractFactory(
       "GoodFundManager"
     );
-    goodAaveStakingFactory = await getStakingFactory("GoodAaveStaking");
+    goodAaveStakingFactory = await getStakingFactory("GoodAaveStakingV2");
 
     const lendingPoolFactory = await ethers.getContractFactory(
       "LendingPoolMock"
@@ -56,10 +55,8 @@ describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
       marketMaker: mm,
       daiAddress,
       genericCall: gc,
-      COMP,
-      reserve
+      COMP
     } = await createDAO();
-    goodReserve = reserve;
     dai = await ethers.getContractAt("DAIMock", daiAddress);
     avatar = av;
     controller = ctrl;
@@ -240,8 +237,9 @@ describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
     expect(gdBalanceAfterCollectInterest.gt(gdBalanceBeforeCollectInterest));
   });
 
-  it("it should collectRewards while collecting interest from aToken if there some earned reward as stkAAVE", async () => {
+  it("it should collect stkAAVE to Avatar when collecting interest", async () => {
     const stakingAmount = ethers.utils.parseUnits("100", 6);
+    const avatarBalance = await aave.balanceOf(avatar);
     await goodAaveStaking.stake(stakingAmount, "0", false);
     const currentGainsAfterStake = await goodAaveStaking.currentGains(
       false,
@@ -278,7 +276,24 @@ describe("UsdcAaveStaking - staking with USDC mocks to AAVE interface", () => {
     );
     expect(currentGainsAfterEarnRewards[4]).to.be.equal(0); // stkAAVE rewards shouldnt count as gain
     expect(currentGainsAfterCollectInterest[4]).to.be.equal("0");
-    expect(await aave.balanceOf(goodReserve.address)).gt(0);
+    expect(await aave.balanceOf(avatar)).gt(avatarBalance);
+  });
+
+  it("should be able to transfer staked tokens", async () => {
+    const stakingAmount = ethers.utils.parseUnits("100", 6);
+
+    await goodAaveStaking.connect(staker).stake(stakingAmount, 0, false);
+
+    await lendingPool.giveInterestToUser("1500", goodAaveStaking.address); // increase interest by calling giveInterestToUser
+
+    await expect(
+      goodAaveStaking
+        .connect(staker)
+        .transfer(signers[0].address, stakingAmount)
+    ).not.reverted;
+    expect(await goodAaveStaking.balanceOf(signers[0].address)).to.eq(
+      stakingAmount
+    );
   });
   async function addLiquidity(
     token0: Contract,

package/test/ubi/UBIScheme.e2e.test.ts

@@ -83,7 +83,7 @@ describe("UBIScheme - network e2e tests", () => {
       "GoodFundManager"
     );
     const goodCompoundStakingFactory = await getStakingFactory(
-      "GoodCompoundStaking"
+      "GoodCompoundStakingV2"
     );
     const deployedDAO = await createDAO();
     let {

package/test/utils/ProtocolUpgrade.test.ts

@@ -197,7 +197,7 @@ describe("ProtocolUpgrade - Upgrade old protocol contracts to new ones", () => {
       deployment["test-mainnet"].GoodReserveCDai
     );
     newStakingContract = await ethers.getContractAt(
-      "GoodCompoundStaking",
+      "GoodCompoundStakingV2",
       deployment["test-mainnet"].StakingContracts[0][0]
     );
     stakingAmountOfNewDonationStaking =

package/artifacts/contracts/staking/aave/AaveStakingFactoryV2.sol/AaveStakingFactoryV2.dbg.json

@@ -1,4 +0,0 @@
-{
-  "_format": "hh-sol-dbg-1",
-  "buildInfo": "../../../../build-info/432071a069fa44ffd3a7f92eee83d72e.json"
-}