@gooddata/sdk-ui 11.42.0-alpha.3 → 11.42.0-alpha.4

package/esm/execution/warningPartialResult/partialDataWarning.js

@@ -3,6 +3,44 @@ import { executionResultLimitTypeToKind } from "@gooddata/sdk-model";
 import { messages } from "./messages.js";
 const COMPACT_FORMAT_THRESHOLD = 10000;
 const COMPACT_FORMATTING_OPTIONS = { style: "decimal", notation: "compact" };
+// Canonical order in which limit break kinds appear in the combined messages.
+const KIND_ORDER = ["columns", "cells", "rows"];
+const VALUE_KEYS = {
+    columns: { limit: "columnLimit", overflow: "columnOverflow" },
+    cells: { limit: "cellLimit", overflow: "cellOverflow" },
+    rows: { limit: "rowLimit", overflow: "rowOverflow" },
+};
+// Maps the set of broken limit kinds (in canonical order, comma-joined) to its message pair.
+const MESSAGES_BY_KINDS = {
+    columns: {
+        withOverflow: messages.columnsDescription,
+        unknownTotal: messages.columnsDescriptionUnknownTotal,
+    },
+    cells: {
+        withOverflow: messages.cellsDescription,
+        unknownTotal: messages.cellsDescriptionUnknownTotal,
+    },
+    rows: {
+        withOverflow: messages.rowsDescription,
+        unknownTotal: messages.rowsDescriptionUnknownTotal,
+    },
+    "columns,rows": {
+        withOverflow: messages.columnsRowsDescription,
+        unknownTotal: messages.columnsRowsDescriptionUnknownTotal,
+    },
+    "columns,cells": {
+        withOverflow: messages.columnsCellsDescription,
+        unknownTotal: messages.columnsCellsDescriptionUnknownTotal,
+    },
+    "cells,rows": {
+        withOverflow: messages.cellsRowsDescription,
+        unknownTotal: messages.cellsRowsDescriptionUnknownTotal,
+    },
+    "columns,cells,rows": {
+        withOverflow: messages.columnsCellsRowsDescription,
+        unknownTotal: messages.columnsCellsRowsDescriptionUnknownTotal,
+    },
+};
 function getLimitBreakKind(limitBreak) {
     return executionResultLimitTypeToKind(limitBreak.limitType);
 }
@@ -30,72 +68,32 @@ function getLimitBreaksByKind(limitBreaks) {
         return result;
     }, {});
 }
-function getRowsAndColumnsDetailMessage(rowLimitBreak, columnLimitBreak, intl) {
-    const values = {
-        rowLimit: formatLimit(rowLimitBreak, intl),
-        columnLimit: formatLimit(columnLimitBreak, intl),
-        rowOverflow: formatOverflow(rowLimitBreak, intl),
-        columnOverflow: formatOverflow(columnLimitBreak, intl),
-    };
-    if (values.rowOverflow && values.columnOverflow) {
-        return { ...messages.rowsColumnsDescription, values };
-    }
-    if (values.rowOverflow) {
-        return { ...messages.rowsColumnsDescriptionUnknownColumnTotal, values };
-    }
-    if (values.columnOverflow) {
-        return { ...messages.rowsColumnsDescriptionUnknownRowTotal, values };
-    }
-    return { ...messages.rowsColumnsDescriptionUnknownTotal, values };
-}
-function getRowsDetailMessage(rowLimitBreak, intl) {
-    const values = {
-        rowLimit: formatLimit(rowLimitBreak, intl),
-        rowOverflow: formatOverflow(rowLimitBreak, intl),
-    };
-    return {
-        ...(values.rowOverflow ? messages.rowsDescription : messages.rowsDescriptionUnknownTotal),
-        values,
-    };
-}
-function getColumnsDetailMessage(columnLimitBreak, intl) {
-    const values = {
-        columnLimit: formatLimit(columnLimitBreak, intl),
-        columnOverflow: formatOverflow(columnLimitBreak, intl),
-    };
-    return {
-        ...(values.columnOverflow ? messages.columnsDescription : messages.columnsDescriptionUnknownTotal),
-        values,
-    };
-}
-function getCellsDetailMessage(cellLimitBreak, intl) {
-    const values = {
-        cellLimit: formatLimit(cellLimitBreak, intl),
-        cellOverflow: formatOverflow(cellLimitBreak, intl),
-    };
-    return {
-        ...(values.cellOverflow ? messages.cellsDescription : messages.cellsDescriptionUnknownTotal),
-        values,
-    };
+function buildValues(byKind, presentKinds, intl) {
+    const values = {};
+    presentKinds.forEach((kind) => {
+        const limitBreak = byKind[kind];
+        const keys = VALUE_KEYS[kind];
+        values[keys.limit] = formatLimit(limitBreak, intl);
+        values[keys.overflow] = formatOverflow(limitBreak, intl);
+    });
+    return values;
 }
 /**
  * @internal
  */
 export function getPartialDataWarningMessage(limitBreaks, intl) {
     const byKind = getLimitBreaksByKind(limitBreaks);
-    const rowLimitBreak = byKind.rows;
-    const columnLimitBreak = byKind.columns;
-    if (rowLimitBreak) {
-        return columnLimitBreak
-            ? getRowsAndColumnsDetailMessage(rowLimitBreak, columnLimitBreak, intl)
-            : getRowsDetailMessage(rowLimitBreak, intl);
-    }
-    if (columnLimitBreak) {
-        return getColumnsDetailMessage(columnLimitBreak, intl);
-    }
-    const cellLimitBreak = byKind.cells;
-    if (cellLimitBreak) {
-        return getCellsDetailMessage(cellLimitBreak, intl);
+    const presentKinds = KIND_ORDER.filter((kind) => byKind[kind]);
+    const messagePair = MESSAGES_BY_KINDS[presentKinds.join(",")];
+    if (!messagePair) {
+        return messages.description;
     }
-    return messages.description;
+    const values = buildValues(byKind, presentKinds, intl);
+    // Overflow can only be rendered when it is known for every broken limit; otherwise the
+    // warning omits the exact amounts and falls back to the "unknown total" wording.
+    const allOverflowsKnown = presentKinds.every((kind) => values[VALUE_KEYS[kind].overflow] !== undefined);
+    return {
+        ...(allOverflowsKnown ? messagePair.withOverflow : messagePair.unknownTotal),
+        values,
+    };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gooddata/sdk-ui",
-  "version": "11.42.0-alpha.3",
+  "version": "11.42.0-alpha.4",
   "description": "GoodData.UI SDK - Core",
   "license": "MIT",
   "author": "GoodData Corporation",
@@ -42,9 +42,9 @@
     "ts-invariant": "0.10.3",
     "tslib": "2.8.1",
     "uuid": "11.1.1",
-    "@gooddata/sdk-backend-spi": "11.42.0-alpha.3",
-    "@gooddata/sdk-model": "11.42.0-alpha.3",
-    "@gooddata/util": "11.42.0-alpha.3"
+    "@gooddata/sdk-backend-spi": "11.42.0-alpha.4",
+    "@gooddata/sdk-model": "11.42.0-alpha.4",
+    "@gooddata/util": "11.42.0-alpha.4"
   },
   "devDependencies": {
     "@microsoft/api-documenter": "^7.17.0",
@@ -87,13 +87,13 @@
     "typescript": "5.9.3",
     "vitest": "4.1.8",
     "vitest-dom": "0.1.1",
-    "@gooddata/eslint-config": "11.42.0-alpha.3",
-    "@gooddata/i18n-toolkit": "11.42.0-alpha.3",
-    "@gooddata/oxlint-config": "11.42.0-alpha.3",
-    "@gooddata/reference-workspace": "11.42.0-alpha.3",
-    "@gooddata/sdk-backend-base": "11.42.0-alpha.3",
-    "@gooddata/sdk-backend-mockingbird": "11.42.0-alpha.3",
-    "@gooddata/stylelint-config": "11.42.0-alpha.3"
+    "@gooddata/eslint-config": "11.42.0-alpha.4",
+    "@gooddata/i18n-toolkit": "11.42.0-alpha.4",
+    "@gooddata/oxlint-config": "11.42.0-alpha.4",
+    "@gooddata/reference-workspace": "11.42.0-alpha.4",
+    "@gooddata/sdk-backend-base": "11.42.0-alpha.4",
+    "@gooddata/sdk-backend-mockingbird": "11.42.0-alpha.4",
+    "@gooddata/stylelint-config": "11.42.0-alpha.4"
   },
   "peerDependencies": {
     "react": "^18.0.0 || ^19.0.0",