@gooddata/sdk-ui-dashboard 11.43.0-alpha.3 → 11.43.0-alpha.4

package/esm/presentation/widget/insight/configuration/InsightAlertConfig/hooks/useSaveAlertToBackend.js

@@ -4,17 +4,6 @@ import { omit } from "lodash-es";
 import { isAllValuesAttributeFilter, } from "@gooddata/sdk-model";
 import { useCreateAlert } from "./useCreateAlert.js";
 import { useUpdateAlert } from "./useUpdateAlert.js";
-/**
- * @internal
- * @param onCreateSuccess - callback to be called when alert is created successfully
- * @param onCreateError - callback to be called when alert creation fails
- * @param onUpdateSuccess - callback to be called when alert is updated successfully
- * @param onUpdateError - callback to be called when alert update fails
- * @param onPauseSuccess - callback to be called when alert is paused successfully
- * @param onPauseError - callback to be called when alert pausing fails
- * @param onResumeSuccess - callback to be called when alert is resumed successfully
- * @param onResumeError - callback to be called when alert resuming fails
- */
 export function useSaveAlertToBackend({ onCreateSuccess, onCreateError, onUpdateSuccess, onUpdateError, onPauseSuccess, onPauseError, onResumeSuccess, onResumeError, }) {
     const alertCreator = useCreateAlert({
         onSuccess: (alert) => onCreateSuccess?.(alert),
@@ -56,8 +45,8 @@ function sanitizeAutomation(automationToSave) {
     let automation = {
         ...automationToSave,
     };
-    // We want to omit the cronDescription as it is a variable created on backend that cannot
-    // be overriden and BE has hard time handling it with each PUT
+    // cronDescription is a variable created on backend that cannot be overridden and BE has hard time
+    // handling it with each PUT
     if (automation.schedule) {
         automation.schedule = omit(automation.schedule, ["cronDescription"]);
     }
@@ -75,10 +64,6 @@ function sanitizeAutomation(automationToSave) {
     }
     return automation;
 }
-/**
- * Strip noop filters that have no effect on execution and should not appear in alert email notifications.
- * - "All values" attribute filters are always stripped.
- */
 function removeNoopFiltersFromAlertFilters(filters) {
     return filters.filter((filter) => !isAllValuesAttributeFilter(filter));
 }

package/esm/presentation/widget/insight/configuration/InsightAlertsNew.js

@@ -18,9 +18,9 @@ import { selectInsightByWidgetRef } from "../../../../model/store/insights/insig
 import { selectCanCreateAutomation, selectCanManageWorkspace, } from "../../../../model/store/permissions/permissionsSelectors.js";
 import { selectExecutionTimestamp } from "../../../../model/store/ui/uiSelectors.js";
 import { selectCurrentUser } from "../../../../model/store/user/userSelectors.js";
-import { AlertDeleteDialog } from "../../../automations/_staging/alerting/DefaultAlertingDialog/components/AlertDeleteDialog.js";
-import { messages } from "../../../automations/_staging/alerting/DefaultAlertingDialog/messages.js";
-import { getSupportedInsightMeasuresByInsight } from "../../../automations/_staging/alerting/DefaultAlertingDialog/utils/items.js";
+import { AlertDeleteDialog } from "../../../automations/alerting/DefaultAlertingDialog/components/AlertDeleteDialog.js";
+import { messages } from "../../../automations/alerting/DefaultAlertingDialog/messages.js";
+import { getSupportedInsightMeasuresByInsight } from "../../../automations/alerting/DefaultAlertingDialog/utils/items.js";
 import { DASHBOARD_HEADER_OVERLAYS_Z_INDEX } from "../../../constants/zIndex.js";
 import { AlertsList } from "./InsightAlertConfig/AlertsList.js";
 import { useSaveAlertToBackend } from "./InsightAlertConfig/hooks/useSaveAlertToBackend.js";

package/esm/sdk-ui-dashboard.d.ts

@@ -3748,6 +3748,20 @@ export declare const DEFAULT_MESSAGES: Record<string, ITranslations>;
 export declare const DEFAULT_TAB_ID = "defaultTabId";
 
 /**
+ * Default implementation of the alerting create/edit dialog.
+ *
+ * This component is a pure consumer of `AutomationsContext` and `AlertingDialogContext`: it reads
+ * org/workspace data and per-dialog state from those contexts rather than from the dashboard store.
+ * It must therefore be rendered within an `AutomationsContextProvider` (and, for the create/edit
+ * flow, an `AlertingDialogContextProvider`). Inside a `Dashboard`, the alerting connector supplies
+ * both providers above the `AlertingDialogComponent` slot — so the default component, and any
+ * wholesale slot replacement, inherit the contexts automatically and require no extra wiring.
+ *
+ * The providers are intentionally hoisted above the slot rather than built inside this component:
+ * that is what lets a wholesale replacement receive the same contexts (see the Phase-2 boundary in
+ * `docs/tasks/26Q1 - Automation Dialog Separation.md`). Rendering this component outside those
+ * providers throws at runtime.
+ *
  * @alpha
  */
 export declare function DefaultAlertingDialog(props: IAlertingDialogProps): JSX.Element;
@@ -5581,8 +5595,11 @@ export declare interface IAlertingDialogProps {
      * Widget to be used for alert.
      *
      * Note: this is available only when alerting for widget, not dashboard.
+     * Typed as IWidget (not ExtendedDashboardWidget) because the dialog only
+     * supports insight widgets; custom widgets and nested layouts are not valid
+     * alert targets and were silently discarded at the connector boundary anyway.
      */
-    widget?: ExtendedDashboardWidget;
+    widget?: IWidget;
     /**
      * Insight to be used for alert.
      *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gooddata/sdk-ui-dashboard",
-  "version": "11.43.0-alpha.3",
+  "version": "11.43.0-alpha.4",
   "description": "GoodData SDK - Dashboard Component",
   "license": "LicenseRef-LICENSE",
   "author": "GoodData Corporation",
@@ -60,19 +60,19 @@
     "ts-invariant": "0.10.3",
     "tslib": "2.8.1",
     "uuid": "11.1.1",
-    "@gooddata/sdk-backend-spi": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui": "11.43.0-alpha.3",
-    "@gooddata/sdk-backend-base": "11.43.0-alpha.3",
-    "@gooddata/sdk-model": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-charts": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-ext": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-filters": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-geo": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-kit": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-pivot": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-theme-provider": "11.43.0-alpha.3",
-    "@gooddata/sdk-ui-vis-commons": "11.43.0-alpha.3",
-    "@gooddata/util": "11.43.0-alpha.3"
+    "@gooddata/sdk-backend-base": "11.43.0-alpha.4",
+    "@gooddata/sdk-backend-spi": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-charts": "11.43.0-alpha.4",
+    "@gooddata/sdk-model": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-ext": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-filters": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-geo": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-kit": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-pivot": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-theme-provider": "11.43.0-alpha.4",
+    "@gooddata/sdk-ui-vis-commons": "11.43.0-alpha.4",
+    "@gooddata/util": "11.43.0-alpha.4"
   },
   "devDependencies": {
     "@microsoft/api-documenter": "^7.17.0",
@@ -118,12 +118,12 @@
     "typescript": "5.9.3",
     "vitest": "4.1.8",
     "vitest-dom": "0.1.1",
-    "@gooddata/eslint-config": "11.43.0-alpha.3",
-    "@gooddata/i18n-toolkit": "11.43.0-alpha.3",
-    "@gooddata/oxlint-config": "11.43.0-alpha.3",
-    "@gooddata/reference-workspace": "11.43.0-alpha.3",
-    "@gooddata/sdk-backend-mockingbird": "11.43.0-alpha.3",
-    "@gooddata/stylelint-config": "11.43.0-alpha.3"
+    "@gooddata/eslint-config": "11.43.0-alpha.4",
+    "@gooddata/i18n-toolkit": "11.43.0-alpha.4",
+    "@gooddata/oxlint-config": "11.43.0-alpha.4",
+    "@gooddata/reference-workspace": "11.43.0-alpha.4",
+    "@gooddata/sdk-backend-mockingbird": "11.43.0-alpha.4",
+    "@gooddata/stylelint-config": "11.43.0-alpha.4"
   },
   "peerDependencies": {
     "react": "^18.0.0 || ^19.0.0",

package/styles/css/dashboard.css

@@ -1201,33 +1201,33 @@
   width: 800px;
 }
 
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog {
   padding: 0;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-management-dialog-title {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-management-dialog-title {
   margin: 0;
   padding: var(--gd-spacing-20px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-content {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-content {
   margin: 0;
   padding: var(--gd-spacing-20px) var(--gd-spacing-20px) 0 var(--gd-spacing-20px);
   width: 100%;
   background-color: var(--gd-palette-complementary-0-from-theme, #fcfcfd);
   height: 475px;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-content-divider--no-spacing {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-content-divider--no-spacing {
   margin: 0;
   padding: 0;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons {
   margin: 0;
   padding: var(--gd-spacing-20px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons-inner {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons-inner {
   display: flex;
   gap: var(--gd-spacing-10px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-button {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-button {
   margin: 0;
 }
 

package/styles/css/drillSelect.css

@@ -40,55 +40,6 @@
   overscroll-behavior: contain;
   padding: 0 0 10px 0;
 }
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item {
-  display: flex;
-  align-items: center;
-  height: 27px;
-  padding: 0 10px;
-  cursor: pointer;
-  text-decoration: none;
-  background: none;
-  border: none;
-  width: 100%;
-}
-.gd-drill-modal-picker-selector-list .gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item {
-  padding: 4px 10px;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item p {
-  font-family: var(--gd-font-family, gdcustomfont, Avenir, "Helvetica Neue", arial, sans-serif);
-  font-size: 12px;
-  text-overflow: ellipsis;
-  overflow: hidden;
-  white-space: nowrap;
-  color: var(--gd-palette-complementary-8, #464e56);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item p span {
-  color: var(--gd-palette-complementary-5, #b0beca);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item .gd-drill-modal-picker-icon-wrapper {
-  height: 100%;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item svg {
-  margin-left: 4px;
-  margin-right: 4px;
-  width: 12px;
-  height: 100%;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item:hover {
-  background: var(--gd-palette-complementary-2, #ebeff4) !important;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item:hover span {
-  color: var(--gd-palette-complementary-9-from-theme);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled {
-  cursor: default;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled p {
-  color: var(--gd-palette-complementary-5);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled:hover {
-  background: none !important;
-}
 
 .gd-drill-to-url-modal-picker {
   padding: 2px 0 0 10px;

package/styles/css/drillSelect.css.map

@@ -1 +1 @@
-{"version":3,"sourceRoot":"","sources":["../../node_modules/@gooddata/sdk-ui-kit/styles/scss/mixins.scss","../../node_modules/@gooddata/sdk-ui-kit/styles/scss/Bubble/_variables.scss","../../node_modules/@gooddata/sdk-ui-kit/styles/scss/Button/_variables.scss","../scss/drillSelect.scss","../scss/_zIndexes.scss","../../node_modules/@gooddata/sdk-ui-kit/styles/scss/variables.scss"],"names":[],"mappings":"AA0HA;AA4DA;ACjLA;AAAA;AAAA;ACDA;AAAA;AAAA;ACEA;EACI;EACA,SCaW;EDZX;EACA;EACA;;;AAGJ;EACI;EACA;EACA;EACA;EACA;EACA;EAEA,YFPA;;AEWA;EACI;EACA;EACA;EACA;EACA;EACA;EACA;EACA;EACA;;AAGJ;EACI;EACA;EACA;EACA;;AAGJ;EACI;EACA;EACA,QAxBU;EAyBV;EACA;EACA;EACA;EACA;EACA;;AAEA;EACI;;AAGJ;EACI,aE0CM;EFzCN;EACA;EACA;EACA;EACA;;AAEA;EACI;;AAIR;EACI;;AAGJ;EACI;EACA;EACA;EACA;;AAGJ;EAEI;;AAEA;EACI;;AAIR;EACI;;AAEA;EACI;;AAGJ;EAEI;;;AAMhB;EACI;;;AAGJ;EACI;EACA;EACA;EACA;EACA;EACA;;AAGI;EACI,SC1GS;ED2GT;EACA","file":"drillSelect.css"}
+{"version":3,"sourceRoot":"","sources":["../../node_modules/@gooddata/sdk-ui-kit/styles/scss/mixins.scss","../../node_modules/@gooddata/sdk-ui-kit/styles/scss/Bubble/_variables.scss","../../node_modules/@gooddata/sdk-ui-kit/styles/scss/Button/_variables.scss","../scss/drillSelect.scss","../scss/_zIndexes.scss"],"names":[],"mappings":"AA0HA;AA4DA;ACjLA;AAAA;AAAA;ACDA;AAAA;AAAA;ACCA;EACI;EACA,SCcW;EDbX;EACA;EACA;;;AAGJ;EACI;EACA;EACA;EACA;EACA;EACA;EAEA,YFNA;;AEQA;EACI;EACA;EACA;EACA;EACA;EACA;EACA;EACA;EACA;;AAGJ;EACI;EACA;EACA;EACA;;;AAIR;EACI;;;AAGJ;EACI;EACA;EACA;EACA;EACA;EACA;;AAGI;EACI,SCzCS;ED0CT;EACA","file":"drillSelect.css"}

package/styles/css/main.css

@@ -25300,33 +25300,33 @@ figure {
   width: 800px;
 }
 
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog {
   padding: 0;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-management-dialog-title {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-management-dialog-title {
   margin: 0;
   padding: var(--gd-spacing-20px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-content {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-notifications-channels-content {
   margin: 0;
   padding: var(--gd-spacing-20px) var(--gd-spacing-20px) 0 var(--gd-spacing-20px);
   width: 100%;
   background-color: var(--gd-palette-complementary-0-from-theme, #fcfcfd);
   height: 475px;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-content-divider--no-spacing {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-content-divider--no-spacing {
   margin: 0;
   padding: 0;
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons {
   margin: 0;
   padding: var(--gd-spacing-20px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons-inner {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-buttons-inner {
   display: flex;
   gap: var(--gd-spacing-10px);
 }
-.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-button {
+.overlay.gd-dialog--no-padding.gd-dialog.gd-notifications-channels-management-dialog .gd-button {
   margin: 0;
 }
 
@@ -29534,18 +29534,16 @@ figure {
 }
 @media only screen and (max-width: 320px), only screen and (max-width: 640px) {
   .dash-header-options-button {
-    width: 45px;
+    width: 46px;
     align-self: stretch;
     padding: 0;
+    font-size: 20px;
     border-radius: 0;
     border-width: 0 0 0 1px;
-    font-size: 20px;
+    border-style: solid;
     background: var(--gd-dashboards-title-backgroundColor, var(--gd-palette-complementary-0, #fff));
     border-color: var(--gd-dashboards-title-borderColor, var(--gd-palette-complementary-3, #dde4eb));
   }
-  .dash-header-options-button, .dash-header-options-button:hover, .dash-header-options-button:active, .dash-header-options-button:focus {
-    box-shadow: none;
-  }
 }
 @media only screen and (min-width:641px) {
   .dash-header-options-button {
@@ -29879,55 +29877,6 @@ figure {
   overscroll-behavior: contain;
   padding: 0 0 10px 0;
 }
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item {
-  display: flex;
-  align-items: center;
-  height: 27px;
-  padding: 0 10px;
-  cursor: pointer;
-  text-decoration: none;
-  background: none;
-  border: none;
-  width: 100%;
-}
-.gd-drill-modal-picker-selector-list .gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item {
-  padding: 4px 10px;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item p {
-  font-family: var(--gd-font-family, gdcustomfont, Avenir, "Helvetica Neue", arial, sans-serif);
-  font-size: 12px;
-  text-overflow: ellipsis;
-  overflow: hidden;
-  white-space: nowrap;
-  color: var(--gd-palette-complementary-8, #464e56);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item p span {
-  color: var(--gd-palette-complementary-5, #b0beca);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item .gd-drill-modal-picker-icon-wrapper {
-  height: 100%;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item svg {
-  margin-left: 4px;
-  margin-right: 4px;
-  width: 12px;
-  height: 100%;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item:hover {
-  background: var(--gd-palette-complementary-2, #ebeff4) !important;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item:hover span {
-  color: var(--gd-palette-complementary-9-from-theme);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled {
-  cursor: default;
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled p {
-  color: var(--gd-palette-complementary-5);
-}
-.gd-drill-modal-picker-dropdown .gd-drill-modal-picker-list-item.is-disabled:hover {
-  background: none !important;
-}
 
 .gd-drill-to-url-modal-picker {
   padding: 2px 0 0 10px;