@gooddata/sdk-ui-dashboard 11.36.0-alpha.3 → 11.36.0-alpha.7

package/esm/presentation/shareDialog/DefaultShareDialog.d.ts

@@ -3,4 +3,4 @@ import { type IShareDialogProps } from "./types.js";
 /**
  * @alpha
  */
-export declare function DefaultShareDialog({ workspace, backend, isVisible, sharedObject, currentUser, isLockingSupported, isCurrentUserWorkspaceManager, currentUserPermissions, dashboardFilters, isShareGrantHidden, applyShareGrantOnSelect, showDashboardShareLink, isGranteeShareLoading, onApply, onCancel, onError, onInteraction, onShareLinkCopy }: IShareDialogProps): ReactElement | null;
+export declare function DefaultShareDialog({ workspace, backend, isVisible, sharedObject, currentUser, isLockingSupported, isCurrentUserWorkspaceManager, currentUserPermissions, dashboardFilters, dashboardParameters, isShareGrantHidden, applyShareGrantOnSelect, showDashboardShareLink, isGranteeShareLoading, onApply, onCancel, onError, onInteraction, onShareLinkCopy }: IShareDialogProps): ReactElement | null;

package/esm/presentation/shareDialog/DefaultShareDialog.js

@@ -8,7 +8,7 @@ import { selectLocale } from "../../model/store/config/configSelectors.js";
 /**
  * @alpha
  */
-export function DefaultShareDialog({ workspace, backend, isVisible, sharedObject, currentUser, isLockingSupported, isCurrentUserWorkspaceManager, currentUserPermissions, dashboardFilters, isShareGrantHidden, applyShareGrantOnSelect, showDashboardShareLink, isGranteeShareLoading, onApply, onCancel, onError, onInteraction, onShareLinkCopy, }) {
+export function DefaultShareDialog({ workspace, backend, isVisible, sharedObject, currentUser, isLockingSupported, isCurrentUserWorkspaceManager, currentUserPermissions, dashboardFilters, dashboardParameters, isShareGrantHidden, applyShareGrantOnSelect, showDashboardShareLink, isGranteeShareLoading, onApply, onCancel, onError, onInteraction, onShareLinkCopy, }) {
     const locale = useDashboardSelector(selectLocale);
     const intl = useIntl();
     const labels = useMemo(() => ({
@@ -26,5 +26,5 @@ export function DefaultShareDialog({ workspace, backend, isVisible, sharedObject
     if (!isVisible) {
         return null;
     }
-    return (_jsx(ShareDialog, { locale: locale, backend: backend, workspace: workspace, sharedObject: sharedObject, currentUser: currentUser, onApply: onApply, onCancel: onCancel, onError: onError, isLockingSupported: isLockingSupported, labels: labels, isCurrentUserWorkspaceManager: isCurrentUserWorkspaceManager, currentUserPermissions: currentUserPermissions, dashboardFilters: dashboardFilters, isShareGrantHidden: isShareGrantHidden, applyShareGrantOnSelect: applyShareGrantOnSelect, showDashboardShareLink: showDashboardShareLink, isGranteeShareLoading: isGranteeShareLoading, onInteraction: onInteraction, onShareLinkCopy: onShareLinkCopy }));
+    return (_jsx(ShareDialog, { locale: locale, backend: backend, workspace: workspace, sharedObject: sharedObject, currentUser: currentUser, onApply: onApply, onCancel: onCancel, onError: onError, isLockingSupported: isLockingSupported, labels: labels, isCurrentUserWorkspaceManager: isCurrentUserWorkspaceManager, currentUserPermissions: currentUserPermissions, dashboardFilters: dashboardFilters, dashboardParameters: dashboardParameters, isShareGrantHidden: isShareGrantHidden, applyShareGrantOnSelect: applyShareGrantOnSelect, showDashboardShareLink: showDashboardShareLink, isGranteeShareLoading: isGranteeShareLoading, onInteraction: onInteraction, onShareLinkCopy: onShareLinkCopy }));
 }

package/esm/presentation/shareDialog/types.d.ts

@@ -1,6 +1,6 @@
 import { type ComponentType } from "react";
 import { type IAnalyticalBackend } from "@gooddata/sdk-backend-spi";
-import { type FilterContextItem, type IUser } from "@gooddata/sdk-model";
+import { type FilterContextItem, type IDashboardParameter, type IUser } from "@gooddata/sdk-model";
 import { type GoodDataSdkError } from "@gooddata/sdk-ui";
 import { type CurrentUserPermissions, type IShareDialogInteractionData, type ISharedObject, type ISharingApplyPayload as ISharingDialogApplyPayload } from "@gooddata/sdk-ui-kit";
 /**
@@ -48,6 +48,10 @@ export interface IShareDialogProps {
      * Dashboard filters
      */
     dashboardFilters: FilterContextItem[];
+    /**
+     * Dashboard parameters
+     */
+    dashboardParameters?: IDashboardParameter[];
     /**
      * Is share grant hidden?
      */

package/esm/presentation/widget/insight/configuration/DrillTargets/useInvalidFilteringParametersIdentifiers.d.ts

@@ -1,3 +1,3 @@
-import { type IAttributeFilter, type IDashboardAttributeFilterConfig } from "@gooddata/sdk-model";
+import { type IAttributeFilter, type IDashboardAttributeFilterConfig, type IDashboardMeasureValueFilter, type IMeasureValueFilter } from "@gooddata/sdk-model";
 import { type UrlDrillTarget } from "../../../../drill/types.js";
-export declare function useInvalidFilteringParametersIdentifiers(urlDrillTarget: UrlDrillTarget | undefined, insightFilters: IAttributeFilter[] | undefined, dashboardFilters: IAttributeFilter[] | undefined, attributeFilterConfigs: IDashboardAttributeFilterConfig[] | undefined): string[];
+export declare function useInvalidFilteringParametersIdentifiers(urlDrillTarget: UrlDrillTarget | undefined, insightFilters: IAttributeFilter[] | undefined, dashboardFilters: IAttributeFilter[] | undefined, dashboardMeasureValueFilters: IDashboardMeasureValueFilter[] | undefined, insightMeasureValueFilters: IMeasureValueFilter[] | undefined, enableInsightMeasureValueFilters: boolean, attributeFilterConfigs: IDashboardAttributeFilterConfig[] | undefined): string[];

package/esm/presentation/widget/insight/configuration/DrillTargets/useInvalidFilteringParametersIdentifiers.js

@@ -2,16 +2,20 @@
 import { useMemo } from "react";
 import { uniq } from "lodash-es";
 import { areObjRefsEqual, filterObjRef, idRef, } from "@gooddata/sdk-model";
-import { getDashboardAttributeFilterPlaceholdersFromUrl, getInsightAttributeFilterPlaceholdersFromUrl, } from "@gooddata/sdk-model/internal";
+import { getDashboardAttributeFilterPlaceholdersFromUrl, getDashboardMeasureValueFilterPlaceholdersFromUrl, getInsightAttributeFilterPlaceholdersFromUrl, getInsightMeasureValueFilterPlaceholdersFromUrl, } from "@gooddata/sdk-model/internal";
 import { useDashboardSelector } from "../../../../../model/react/DashboardStoreProvider.js";
-import { selectAllCatalogDisplayFormsMap } from "../../../../../model/store/catalog/catalogSelectors.js";
+import { selectAllCatalogDisplayFormsMap, selectAllCatalogMeasuresMap, } from "../../../../../model/store/catalog/catalogSelectors.js";
+import { dashboardMeasureValueFilterMatchesIdentifier, insightMeasureValueFilterMatchesIdentifier, } from "../../../../../model/utils/measureValueFilterUtils.js";
 import { isDrillToCustomUrlConfig } from "../../../../drill/types.js";
-export function useInvalidFilteringParametersIdentifiers(urlDrillTarget, insightFilters, dashboardFilters, attributeFilterConfigs) {
+export function useInvalidFilteringParametersIdentifiers(urlDrillTarget, insightFilters, dashboardFilters, dashboardMeasureValueFilters, insightMeasureValueFilters, enableInsightMeasureValueFilters, attributeFilterConfigs) {
     const displayForms = useDashboardSelector(selectAllCatalogDisplayFormsMap);
+    const measures = useDashboardSelector(selectAllCatalogMeasuresMap);
     return useMemo(() => {
         if (isDrillToCustomUrlConfig(urlDrillTarget)) {
             const dashboardAttributeFilterParameters = getDashboardAttributeFilterPlaceholdersFromUrl(urlDrillTarget.customUrl);
             const insightAttributeFilterParameters = getInsightAttributeFilterPlaceholdersFromUrl(urlDrillTarget.customUrl);
+            const dashboardMeasureValueFilterParameters = getDashboardMeasureValueFilterPlaceholdersFromUrl(urlDrillTarget.customUrl);
+            const insightMeasureValueFilterParameters = getInsightMeasureValueFilterPlaceholdersFromUrl(urlDrillTarget.customUrl);
             const invalidDashboardParameters = dashboardAttributeFilterParameters
                 .filter(({ identifier }) => {
                 // parameter is invalid if either it points to display form that no longer exists
@@ -40,8 +44,35 @@ export function useInvalidFilteringParametersIdentifiers(urlDrillTarget, insight
                 });
             })
                 .map(({ identifier }) => identifier);
-            return uniq([...invalidDashboardParameters, ...invalidInsightParameters]);
+            const invalidDashboardMvfParameters = dashboardMeasureValueFilterParameters
+                .filter(({ identifier }) => {
+                return !dashboardMeasureValueFilters?.some((filter) => dashboardMeasureValueFilterMatchesIdentifier(filter.dashboardMeasureValueFilter.measure, identifier, measures));
+            })
+                .map(({ identifier }) => identifier);
+            const invalidInsightMvfParameters = enableInsightMeasureValueFilters
+                ? insightMeasureValueFilterParameters
+                    .filter(({ identifier }) => {
+                    return !insightMeasureValueFilters?.some((filter) => insightMeasureValueFilterMatchesIdentifier(filter.measureValueFilter.measure, identifier));
+                })
+                    .map(({ identifier }) => identifier)
+                : insightMeasureValueFilterParameters.map(({ identifier }) => identifier);
+            return uniq([
+                ...invalidDashboardParameters,
+                ...invalidInsightParameters,
+                ...invalidDashboardMvfParameters,
+                ...invalidInsightMvfParameters,
+            ]);
         }
         return [];
-    }, [displayForms, urlDrillTarget, insightFilters, dashboardFilters, attributeFilterConfigs]);
+    }, [
+        displayForms,
+        measures,
+        urlDrillTarget,
+        insightFilters,
+        dashboardFilters,
+        dashboardMeasureValueFilters,
+        insightMeasureValueFilters,
+        enableInsightMeasureValueFilters,
+        attributeFilterConfigs,
+    ]);
 }

package/esm/presentation/widget/insight/configuration/InsightAlertConfig/EditAlert.js

@@ -2,7 +2,7 @@ import { Fragment as _Fragment, jsx as _jsx, jsxs as _jsxs } from "react/jsx-run
 // (C) 2022-2026 GoodData Corporation
 import { FormattedMessage, defineMessages, useIntl } from "react-intl";
 import { Bubble, BubbleHoverTrigger, Button, Input, Message, } from "@gooddata/sdk-ui-kit";
-import { AlertAttributeSelectOld } from "../../../../alerting/DefaultAlertingDialog/components/AlertAttributeSelectOld.js";
+import { AlertAttributeSelect } from "../../../../alerting/DefaultAlertingDialog/components/AlertAttributeSelect.js";
 import { AlertComparisonOperatorSelect } from "../../../../alerting/DefaultAlertingDialog/components/AlertComparisonOperatorSelect.js";
 import { AlertComparisonPeriodSelect } from "../../../../alerting/DefaultAlertingDialog/components/AlertComparisonPeriodSelect.js";
 import { AlertDestinationSelect } from "../../../../alerting/DefaultAlertingDialog/components/AlertDestinationSelect.js";
@@ -72,7 +72,7 @@ export function EditAlert({ alert, execResult, isNewAlert, hasAlerts, destinatio
             : intl.formatMessage({ id: "insightAlert.config.editAlert" }), onClose: onClose, onBack: hasAlerts ? onCancel : undefined, children: _jsxs("div", { className: "gd-edit-alert", children: [
                 _jsxs("div", { className: "gd-edit-alert__form", children: [
                         _jsxs("div", { className: "gd-edit-alert__form-content", children: [
-                                _jsx("label", { htmlFor: "alert.measure", className: "gd-edit-alert__measure-label", children: _jsx(FormattedMessage, { id: "insightAlert.config.when" }) }), _jsx(AlertMeasureSelect, { selectedMeasure: selectedMeasure, onMeasureChange: changeMeasure, measures: measures, overlayPositionType: overlayPositionType, id: "alert.measure" }), Boolean(canManageAttributes) && (_jsx(_Fragment, { children: _jsx(AlertAttributeSelectOld, { id: "alert.attribute", selectedAttribute: selectedAttribute, selectedValue: selectedValue, onAttributeChange: changeAttribute, attributes: attributes, catalogAttributes: catalogAttributes, catalogDateDatasets: catalogDateDatasets, getAttributeValues: getAttributeValues, isResultLoading: isResultLoading }) })), showFilterInfo ? (_jsxs("div", { className: "gd-edit-alert__measure-info", children: [Boolean(selectedComparator?.granularity) && (_jsx(FormattedMessage, { tagName: "span", id: "insightAlert.config.for.filter", values: {
+                                _jsx("label", { htmlFor: "alert.measure", className: "gd-edit-alert__measure-label", children: _jsx(FormattedMessage, { id: "insightAlert.config.when" }) }), _jsx(AlertMeasureSelect, { selectedMeasure: selectedMeasure, onMeasureChange: changeMeasure, measures: measures, overlayPositionType: overlayPositionType, id: "alert.measure" }), Boolean(canManageAttributes) && (_jsx(_Fragment, { children: _jsx(AlertAttributeSelect, { id: "alert.attribute", selectedAttribute: selectedAttribute, selectedValue: selectedValue, onAttributeChange: changeAttribute, attributes: attributes, catalogAttributes: catalogAttributes, catalogDateDatasets: catalogDateDatasets, getAttributeValues: getAttributeValues, isResultLoading: isResultLoading, showLabel: true, closeOnParentScroll: true }) })), showFilterInfo ? (_jsxs("div", { className: "gd-edit-alert__measure-info", children: [Boolean(selectedComparator?.granularity) && (_jsx(FormattedMessage, { tagName: "span", id: "insightAlert.config.for.filter", values: {
                                                 granularity: [
                                                     intl.formatMessage({ id: "granularity.this_keyword" }),
                                                     translateGranularity(intl, selectedComparator?.granularity),

package/esm/presentation/widget/insight/configuration/InsightAlertConfig/hooks/useInsightWidgetAlerting.js

@@ -6,7 +6,6 @@ import { useToastMessage } from "@gooddata/sdk-ui-kit";
 import { convertCurrentUserToAutomationRecipient } from "../../../../../../_staging/automation/index.js";
 import { refreshAutomations } from "../../../../../../model/commands/scheduledEmail.js";
 import { useDashboardDispatch, useDashboardSelector, } from "../../../../../../model/react/DashboardStoreProvider.js";
-import { useWidgetAlertFilters } from "../../../../../../model/react/filtering/useWidgetAlertFilters.js";
 import { DEFAULT_MAX_AUTOMATIONS } from "../../../../../../model/react/useDashboardAutomations/constants.js";
 import { useDashboardUserInteraction } from "../../../../../../model/react/useDashboardUserInteraction.js";
 import { useWorkspaceUsers } from "../../../../../../model/react/useWorkspaceUsers.js";
@@ -27,6 +26,7 @@ import { messages } from "../../../../../alerting/DefaultAlertingDialog/messages
 import { createDefaultAlert } from "../../../../../alerting/DefaultAlertingDialog/utils/convertors.js";
 import { getMeasureFormatsFromExecution } from "../../../../../alerting/DefaultAlertingDialog/utils/getters.js";
 import { getSupportedInsightAttributesByInsight, getSupportedInsightMeasuresByInsight, } from "../../../../../alerting/DefaultAlertingDialog/utils/items.js";
+import { useWidgetAutomationFilters } from "../../../../../scheduledEmail/hooks/useWidgetAutomationFilters.js";
 export const useInsightWidgetAlerting = ({ widget, closeInsightWidgetMenu }) => {
     const { addSuccess, addError } = useToastMessage();
     const { automationInteraction } = useDashboardUserInteraction();
@@ -98,10 +98,7 @@ export const useInsightWidgetAlerting = ({ widget, closeInsightWidgetMenu }) =>
             addError(messages.alertSaveError);
         },
     });
-    const { result: widgetFilters, status: widgetFiltersStatus } = useWidgetAlertFilters({
-        widget,
-        insight,
-    });
+    const { result: widgetFilters, status: widgetFiltersStatus } = useWidgetAutomationFilters(widget, insight);
     const locale = useDashboardSelector(selectLocale);
     const settings = useDashboardSelector(selectSettings);
     const supportedAttributes = useMemo(() => getSupportedInsightAttributesByInsight(insight, catalogDateDatasets), [insight, catalogDateDatasets]);
@@ -163,11 +160,11 @@ export const useInsightWidgetAlerting = ({ widget, closeInsightWidgetMenu }) =>
         defaultNotificationChannelId,
         supportedMeasures,
         widgetFilters,
-        widgetFiltersStatus,
         addError,
         currentUser,
         users,
         usersStatus,
+        widgetFiltersStatus,
         measureFormatMap,
     ]);
     useEffect(() => {

package/esm/presentation/widget/insight/configuration/InsightAlerts.js

@@ -1,13 +1,5 @@
 import { jsx as _jsx } from "react/jsx-runtime";
-// (C) 2022-2026 GoodData Corporation
-import { useDashboardSelector } from "../../../../model/react/DashboardStoreProvider.js";
-import { selectEnableAutomationFilterContext } from "../../../../model/store/config/configSelectors.js";
 import { InsightAlertsNew } from "./InsightAlertsNew.js";
-import { InsightAlertsOld } from "./InsightAlertsOld.js";
 export function InsightAlerts({ widget, onClose, onGoBack }) {
-    const enableAutomationFilters = useDashboardSelector(selectEnableAutomationFilterContext);
-    if (enableAutomationFilters) {
-        return _jsx(InsightAlertsNew, { widget: widget, onClose: onClose, onGoBack: onGoBack });
-    }
-    return _jsx(InsightAlertsOld, { widget: widget, onClose: onClose, onGoBack: onGoBack });
+    return _jsx(InsightAlertsNew, { widget: widget, onClose: onClose, onGoBack: onGoBack });
 }

package/esm/presentation/widget/insight/configuration/InsightDrillConfigPanel/useInsightDrillConfigPanel.js

@@ -8,7 +8,6 @@ import { addDrillDownForInsightWidget, modifyDrillDownForInsightWidget, modifyDr
 import { useDashboardDispatch, useDashboardSelector, } from "../../../../../model/react/DashboardStoreProvider.js";
 import { selectAllowMultipleInteractionsPerAttributeAndMeasure, selectSupportsAttributeHierarchies, } from "../../../../../model/store/backendCapabilities/backendCapabilitiesSelectors.js";
 import { selectAllCatalogAttributeHierarchies } from "../../../../../model/store/catalog/catalogSelectors.js";
-import { selectEnableImplicitDrillToUrl } from "../../../../../model/store/config/configSelectors.js";
 import { selectDrillTargetsByWidgetRef } from "../../../../../model/store/drillTargets/drillTargetsSelectors.js";
 import { selectInsightByRef } from "../../../../../model/store/insights/insightsSelectors.js";
 import { selectWidgetByRef } from "../../../../../model/store/tabs/layout/layoutSelectors.js";
@@ -22,7 +21,7 @@ const messages = defineMessages({
     added: { id: "messages.drill.InteractionConfiguredSuccess" },
     modified: { id: "messages.drill.InteractionUpdatedSuccess" },
 });
-const mergeDrillConfigItems = (drillConfigItems, globalDrillDownItems, drillToUrlItems, incompleteItems, enableImplicitDrillToUrl) => {
+const mergeDrillConfigItems = (drillConfigItems, globalDrillDownItems, drillToUrlItems, incompleteItems) => {
     return incompleteItems.reduce((acc, incompleteItem) => {
         const found = acc.findIndex((item) => item.localIdentifier === incompleteItem.localIdentifier);
         if (found === -1) {
@@ -34,11 +33,7 @@ const mergeDrillConfigItems = (drillConfigItems, globalDrillDownItems, drillToUr
             }
         }
         return acc;
-    }, [
-        ...(globalDrillDownItems ?? []),
-        ...(enableImplicitDrillToUrl ? (drillToUrlItems ?? []) : []),
-        ...(drillConfigItems ?? []),
-    ]);
+    }, [...(globalDrillDownItems ?? []), ...(drillToUrlItems ?? []), ...(drillConfigItems ?? [])]);
 };
 const getUnusedDrillTargets = (availableDrillTargets, mergedItems, allowMultipleInteractionsPerAttributeAndMeasure, supportsAttributeHierarchies) => {
     if (allowMultipleInteractionsPerAttributeAndMeasure && supportsAttributeHierarchies) {
@@ -65,7 +60,6 @@ export const useInsightDrillConfigPanel = (props) => {
     const widget = useDashboardSelector(selectWidgetByRef(widgetRef));
     invariant(isInsightWidget(widget), "must be insight widget");
     const insight = useDashboardSelector(selectInsightByRef(widget.insight));
-    const enableImplicitDrillToUrl = useDashboardSelector(selectEnableImplicitDrillToUrl);
     const { drills: widgetDrills } = widget;
     const { incompleteItems, deleteIncompleteItem, onChangeItem, onOriginSelect, completeItem, isItemNew } = useIncompleteItems({ widgetDrills });
     const { addSuccess } = useToastMessage();
@@ -96,8 +90,8 @@ export const useInsightDrillConfigPanel = (props) => {
             : [];
     }, [widgetDrillToUrls, availableDrillTargets, widget]);
     const mergedItems = useMemo(() => {
-        return mergeDrillConfigItems(drillItems, globalDrillDownItems, drillToUrlItems, incompleteItems, enableImplicitDrillToUrl);
-    }, [drillItems, globalDrillDownItems, drillToUrlItems, incompleteItems, enableImplicitDrillToUrl]);
+        return mergeDrillConfigItems(drillItems, globalDrillDownItems, drillToUrlItems, incompleteItems);
+    }, [drillItems, globalDrillDownItems, drillToUrlItems, incompleteItems]);
     const { activeDrillItemLocalId } = useDrillFiltersSubview();
     const selectedDrillItem = useMemo(() => mergedItems.find((item) => item.localIdentifier === activeDrillItemLocalId), [activeDrillItemLocalId, mergedItems]);
     const originSelectorItems = useMemo(() => getUnusedDrillTargets(availableDrillTargets, mergedItems, allowMultipleInteractionsPerAttributeAndMeasure, supportsAttributeHierarchies), [