@gooddata/sdk-code-convertors 11.67.0-alpha.3 → 11.67.0

package/esm/execution/buildAfmExecution.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"buildAfmExecution.d.ts","sourceRoot":"","sources":["../../src/execution/buildAfmExecution.ts"],"names":[],"mappings":"AAgBA,OAAO,KAAK,EAGR,KAAK,EAIR,MAAM,+BAA+B,CAAC;AAGvC,OAAO,EAAE,KAAK,cAAc,EAAE,KAAK,kBAAkB,EAAE,MAAM,aAAa,CAAC;AA4C3E,cAAc;AACd,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,cAAc,EAAE,KAAK,EAAE,KAAK,GAAG,kBAAkB,CAkB5F"}
+{"version":3,"file":"buildAfmExecution.d.ts","sourceRoot":"","sources":["../../src/execution/buildAfmExecution.ts"],"names":[],"mappings":"AAgBA,OAAO,KAAK,EAGR,KAAK,EAIR,MAAM,+BAA+B,CAAC;AAGvC,OAAO,EAAE,KAAK,cAAc,EAAE,KAAK,kBAAkB,EAAE,MAAM,aAAa,CAAC;AAgD3E,cAAc;AACd,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,cAAc,EAAE,KAAK,EAAE,KAAK,GAAG,kBAAkB,CAkB5F"}

package/esm/execution/buildAfmExecution.js

@@ -1,7 +1,7 @@
 // (C) 2024-2026 GoodData Corporation
 import { convertBucketToTitle } from "../utils/convertBucketToTitle.js";
 import { mapDateAttribute, mapDateDataset } from "../utils/dateUtils.js";
-import { parseDateValues, yamlConditionToMatch } from "../utils/filterUtils.js";
+import { foldLegacyEmptyValuesWithFilter, parseDateValues, yamlConditionToMatch, } from "../utils/filterUtils.js";
 import { getFullField } from "../utils/sharedUtils.js";
 import { isAbsoluteDateFilter, isAllTimeDateFilter, isArbitraryTextFilter, isArithmeticMetricField, isAttributeField, isAttributeSort, isCalculatedMetricField, isComputedAttributeReference, isDateFilter, isInlineMetricField, isMatchTextFilter, isMetricAllValueFilter, isMetricComparisonValueFilter, isMetricField, isMetricRangeValueFilter, isMetricValueFilterWithConditions, isNegativeAttributeFilter, isPoPMetricField, isPositiveAttributeFilter, isPreviousPeriodField, isRankingFilter, isRelativeDateFilter, isSimpleMetricSort, } from "../utils/typeGuards.js";
 import { createIdentifier, createLocalIdentifier } from "../utils/yamlUtils.js";
@@ -206,7 +206,9 @@ function buildFilters(entities, filters_by) {
     }
     const filters = [];
     Object.keys(filters_by ?? {}).forEach((key) => {
-        const filter = filters_by[key];
+        const queryFilter = filters_by[key];
+        // The same for the insight-level and the metric-level date filter, as in deploy
+        const filter = isDateFilter(queryFilter) ? foldLegacyEmptyValuesWithFilter(queryFilter) : queryFilter;
         if (isAbsoluteDateFilter(filter)) {
             filters.push({
                 absoluteDateFilter: {

package/esm/schemas/types.d.ts

@@ -1,5 +1,5 @@
 /**
- * Hand-curated public types from the AAC schema provided by @gooddata/sdk-code-schemas.
+ * Hand-curated public types from the AAC schema provided by `@gooddata/sdk-code-schemas`.
  * This file isolates api-extractor from the generated metadata.ts internals
  * (which contain anonymous union members like Visualisation1-22, Id4-16, etc.).
  */

package/esm/to/yamlVisualisationToDeclarative.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"yamlVisualisationToDeclarative.d.ts","sourceRoot":"","sources":["../../src/to/yamlVisualisationToDeclarative.ts"],"names":[],"mappings":"AAEA,OAAO,EACH,KAAK,8BAA8B,EACnC,KAAK,6BAA6B,EACrC,MAAM,4BAA4B,CAAC;AACpC,OAAO,KAAK,EASR,MAAM,EAMN,YAAY,EAIZ,KAAK,EAEL,KAAK,EACL,aAAa,EAEhB,MAAM,+BAA+B,CAAC;AACvC,OAAO,EAGH,KAAK,uBAAuB,EAE5B,KAAK,OAAO,EACZ,KAAK,QAAQ,EAIb,KAAK,SAAS,EACd,KAAK,MAAM,EAKd,MAAM,qBAAqB,CAAC;AAyB7B,OAAO,EAAe,KAAK,cAAc,EAAE,MAAM,aAAa,CAAC;AAkC/D,gBAAgB;AAChB,MAAM,MAAM,uBAAuB,GAAG,IAAI,CACtC,QAAQ,CAAC,SAAS,CAAC,EACnB,kBAAkB,GAAG,YAAY,GAAG,SAAS,GAAG,SAAS,GAAG,OAAO,GAAG,wBAAwB,GAAG,QAAQ,CAC5G,GAAG;IACA,OAAO,EAAE,MAAM,CAAC;CACnB,CAAC;AAGF,cAAc;AACd,wBAAgB,8BAA8B,CAC1C,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB,8BAA8B,CAoChC;AAED,cAAc;AACd,wBAAgB,iCAAiC,CAC7C,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB,6BAA6B,CAQ/B;AAiGD,gBAAgB;AAChB,wBAAgB,uBAAuB,CACnC,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB;IACC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,KAAK,EAAE,uBAAuB,CAAC,OAAO,CAAC,CAAC;IACxC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,SAAS,EAAE,KAAK,CAAC;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC1D,sBAAsB,CAAC,EAAE,uBAAuB,CAAC;CACpD,CAmBA;AAuQD,gBAAgB;AAChB,wBAAgB,sBAAsB,CAClC,OAAO,EAAE,KAAK,GAAG,SAAS,EAC1B,MAAM,EAAE,aAAa,CAAC,OAAO,CAAC,CAAC,QAAQ,CAAC,GACzC,SAAS,EAAE,CA4Bb;AAogBD,gBAAgB;AAChB,wBAAgB,wBAAwB,CACpC,QAAQ,EAAE,cAAc,EACxB,UAAU,EAAE,YAAY,GAAG,MAAM,EAAE,GAAG,SAAS,EAC/C,sBAAsB,GAAE,uBAA4B,EAGpD,mBAAmB,UAAQ,GAC5B;IACC,OAAO,EAAE,OAAO,EAAE,CAAC;IACnB,sBAAsB,EAAE,uBAAuB,GAAG,SAAS,CAAC;CAC/D,CAsBA;AAID,gBAAgB;AAChB,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,KAAK,EAAE,YAAK,EAAE,mBAAmB,EAAE,MAAM,GAAG,MAAM,EAAE,CASxG;AAID,gBAAgB;AAChB,wBAAgB,wBAAwB,CACpC,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB;IACC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,SAAS,EAAE,KAAK,CAAC;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC1D,gBAAgB,EAAE,uBAAuB,CAAC;CAC7C,CAuDA"}
+{"version":3,"file":"yamlVisualisationToDeclarative.d.ts","sourceRoot":"","sources":["../../src/to/yamlVisualisationToDeclarative.ts"],"names":[],"mappings":"AAEA,OAAO,EACH,KAAK,8BAA8B,EACnC,KAAK,6BAA6B,EACrC,MAAM,4BAA4B,CAAC;AACpC,OAAO,KAAK,EASR,MAAM,EAMN,YAAY,EAIZ,KAAK,EAEL,KAAK,EACL,aAAa,EAEhB,MAAM,+BAA+B,CAAC;AACvC,OAAO,EAGH,KAAK,uBAAuB,EAE5B,KAAK,OAAO,EACZ,KAAK,QAAQ,EAIb,KAAK,SAAS,EACd,KAAK,MAAM,EAKd,MAAM,qBAAqB,CAAC;AAyB7B,OAAO,EAAe,KAAK,cAAc,EAAE,MAAM,aAAa,CAAC;AAuC/D,gBAAgB;AAChB,MAAM,MAAM,uBAAuB,GAAG,IAAI,CACtC,QAAQ,CAAC,SAAS,CAAC,EACnB,kBAAkB,GAAG,YAAY,GAAG,SAAS,GAAG,SAAS,GAAG,OAAO,GAAG,wBAAwB,GAAG,QAAQ,CAC5G,GAAG;IACA,OAAO,EAAE,MAAM,CAAC;CACnB,CAAC;AAGF,cAAc;AACd,wBAAgB,8BAA8B,CAC1C,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB,8BAA8B,CAoChC;AAED,cAAc;AACd,wBAAgB,iCAAiC,CAC7C,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB,6BAA6B,CAQ/B;AAiGD,gBAAgB;AAChB,wBAAgB,uBAAuB,CACnC,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB;IACC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,KAAK,EAAE,uBAAuB,CAAC,OAAO,CAAC,CAAC;IACxC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,SAAS,EAAE,KAAK,CAAC;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC1D,sBAAsB,CAAC,EAAE,uBAAuB,CAAC;CACpD,CAmBA;AAuQD,gBAAgB;AAChB,wBAAgB,sBAAsB,CAClC,OAAO,EAAE,KAAK,GAAG,SAAS,EAC1B,MAAM,EAAE,aAAa,CAAC,OAAO,CAAC,CAAC,QAAQ,CAAC,GACzC,SAAS,EAAE,CA4Bb;AAwgBD,gBAAgB;AAChB,wBAAgB,wBAAwB,CACpC,QAAQ,EAAE,cAAc,EACxB,UAAU,EAAE,YAAY,GAAG,MAAM,EAAE,GAAG,SAAS,EAC/C,sBAAsB,GAAE,uBAA4B,EAGpD,mBAAmB,UAAQ,GAC5B;IACC,OAAO,EAAE,OAAO,EAAE,CAAC;IACnB,sBAAsB,EAAE,uBAAuB,GAAG,SAAS,CAAC;CAC/D,CAsBA;AAID,gBAAgB;AAChB,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,KAAK,EAAE,YAAK,EAAE,mBAAmB,EAAE,MAAM,GAAG,MAAM,EAAE,CASxG;AAID,gBAAgB;AAChB,wBAAgB,wBAAwB,CACpC,QAAQ,EAAE,cAAc,EACxB,KAAK,EAAE,aAAa,GACrB;IACC,OAAO,EAAE,uBAAuB,CAAC,SAAS,CAAC,CAAC;IAC5C,SAAS,EAAE,KAAK,CAAC;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC1D,gBAAgB,EAAE,uBAAuB,CAAC;CAC7C,CAuDA"}

package/esm/to/yamlVisualisationToDeclarative.js

@@ -27,11 +27,11 @@ import { BucketsType } from "../types.js";
 import { convertBucketToTitle } from "../utils/convertBucketToTitle.js";
 import { mapDateAttribute, mapDateDataset } from "../utils/dateUtils.js";
 import { CoreErrorCode, newError } from "../utils/errors.js";
-import { parseDateValues, yamlConditionToMatch } from "../utils/filterUtils.js";
+import { foldLegacyEmptyValuesWithFilter, parseDateValues, yamlConditionToMatch, } from "../utils/filterUtils.js";
 import { convertGranularity } from "../utils/granularityUtils.js";
 import { mapLocationLabel } from "../utils/locationUtils.js";
 import { assertUnreachable, convertIdToTitle, getFullBucket, getFullField } from "../utils/sharedUtils.js";
-import { isAbsoluteDateFilter, isArbitraryTextFilter, isArithmeticMetricField, isAttributeField, isAttributeSort, isCalculatedMetricField, isInlineMetricField, isMatchTextFilter, isMetricAllValueFilter, isMetricComparisonValueFilter, isMetricField, isMetricRangeValueFilter, isMetricSort, isMetricValueFilterWithConditions, isNegativeAttributeFilter, isPoPMetricField, isPositiveAttributeFilter, isPreviousPeriodField, isRankingFilter, isRelativeDateFilter, parseReferenceObject, } from "../utils/typeGuards.js";
+import { isAbsoluteDateFilter, isArbitraryTextFilter, isArithmeticMetricField, isAttributeField, isAttributeSort, isCalculatedMetricField, isDateFilter, isInlineMetricField, isMatchTextFilter, isMetricAllValueFilter, isMetricComparisonValueFilter, isMetricField, isMetricRangeValueFilter, isMetricSort, isMetricValueFilterWithConditions, isNegativeAttributeFilter, isPoPMetricField, isPositiveAttributeFilter, isPreviousPeriodField, isRankingFilter, isRelativeDateFilter, parseReferenceObject, } from "../utils/typeGuards.js";
 import { yamlVisTypeToVisualizationUrl } from "../utils/visualisationTypeMap.js";
 import { createIdentifier, createLocalIdentifier } from "../utils/yamlUtils.js";
 /** @public */
@@ -769,6 +769,10 @@ function yamlFilterToDeclarative(entities, key, filter,
 // Only view-level (report/layer) filters need a localIdentifier so their displayAsLabel can be
 // correlated via attributeFilterConfigs. Measure-scoped filters must NOT carry one.
 assignFilterLocalId) {
+    // The same for the insight-level and the metric-level date filter
+    if (isDateFilter(filter)) {
+        filter = foldLegacyEmptyValuesWithFilter(filter);
+    }
     if (isAbsoluteDateFilter(filter)) {
         return yamlAbsoluteDateFilterToDeclarative(entities, filter, assignFilterLocalId);
     }

package/esm/utils/filterUtils.d.ts

@@ -1,3 +1,4 @@
+import type { DateFilter } from "@gooddata/sdk-code-schemas/v1";
 import type { MatchFilterOperator } from "@gooddata/sdk-model";
 import { type ExportEntities, type FromEntities } from "../types.js";
 import type { TextFilterCondition } from "./typeGuards.js";
@@ -7,4 +8,15 @@ export declare function yamlConditionToMatch(condition: TextFilterCondition): {
     operator: MatchFilterOperator;
     negativeSelection: boolean;
 };
+/**
+ * Before the date filter carried its own `empty_values`, the mode was stored as an attribute filter on the
+ * date label with the single value `""`: `include` meant "only", `exclude` meant "exclude". Pull and AD
+ * still read that shape; deploy must not write it, because the backend executes it next to the date
+ * filter's default of excluding empty values, and the two cancel out.
+ *
+ * Returns the date filter with such a `with:` entry folded into `empty_values` and removed. An explicit
+ * `empty_values` wins, the entry is dropped either way. A `""` mixed with other values, or on a label
+ * that is not of the date filter's dataset, or several `""` markers, is an ordinary filter and stays.
+ */
+export declare function foldLegacyEmptyValuesWithFilter(filter: DateFilter): DateFilter;
 //# sourceMappingURL=filterUtils.d.ts.map

package/esm/utils/filterUtils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"filterUtils.d.ts","sourceRoot":"","sources":["../../src/utils/filterUtils.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,qBAAqB,CAAC;AAE/D,OAAO,EAAE,KAAK,cAAc,EAAE,KAAK,YAAY,EAAE,MAAM,aAAa,CAAC;AAGrE,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,iBAAiB,CAAC;AAE3D,wBAAgB,eAAe,CAC3B,QAAQ,EAAE,YAAY,GAAG,cAAc,EACvC,KAAK,EAAE,MAAM,EACb,MAAM,EAAE,CAAC,MAAM,GAAG,MAAM,GAAG,OAAO,CAAC,EAAE,SAkBxC;AAED,wBAAgB,oBAAoB,CAAC,QAAQ,EAAE,mBAAmB,EAAE,iBAAiB,CAAC,EAAE,OAAO,GAAG,MAAM,CAYvG;AAED,wBAAgB,oBAAoB,CAAC,SAAS,EAAE,mBAAmB,GAAG;IAClE,QAAQ,EAAE,mBAAmB,CAAC;IAC9B,iBAAiB,EAAE,OAAO,CAAC;CAC9B,CAkBA"}
+{"version":3,"file":"filterUtils.d.ts","sourceRoot":"","sources":["../../src/utils/filterUtils.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAgC,UAAU,EAAE,MAAM,+BAA+B,CAAC;AAC9F,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,qBAAqB,CAAC;AAE/D,OAAO,EAAE,KAAK,cAAc,EAAE,KAAK,YAAY,EAAE,MAAM,aAAa,CAAC;AAGrE,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,iBAAiB,CAAC;AAE3D,wBAAgB,eAAe,CAC3B,QAAQ,EAAE,YAAY,GAAG,cAAc,EACvC,KAAK,EAAE,MAAM,EACb,MAAM,EAAE,CAAC,MAAM,GAAG,MAAM,GAAG,OAAO,CAAC,EAAE,SAkBxC;AAED,wBAAgB,oBAAoB,CAAC,QAAQ,EAAE,mBAAmB,EAAE,iBAAiB,CAAC,EAAE,OAAO,GAAG,MAAM,CAYvG;AAED,wBAAgB,oBAAoB,CAAC,SAAS,EAAE,mBAAmB,GAAG;IAClE,QAAQ,EAAE,mBAAmB,CAAC;IAC9B,iBAAiB,EAAE,OAAO,CAAC;CAC9B,CAkBA;AAUD;;;;;;;;;GASG;AACH,wBAAgB,+BAA+B,CAAC,MAAM,EAAE,UAAU,GAAG,UAAU,CAyB9E"}

package/esm/utils/filterUtils.js

@@ -49,3 +49,50 @@ function convertDateValues(gran, values) {
         .map((v) => parseGranularityValue(granularity, v))
         .filter((v) => v !== null && v !== undefined);
 }
+/**
+ * Before the date filter carried its own `empty_values`, the mode was stored as an attribute filter on the
+ * date label with the single value `""`: `include` meant "only", `exclude` meant "exclude". Pull and AD
+ * still read that shape; deploy must not write it, because the backend executes it next to the date
+ * filter's default of excluding empty values, and the two cancel out.
+ *
+ * Returns the date filter with such a `with:` entry folded into `empty_values` and removed. An explicit
+ * `empty_values` wins, the entry is dropped either way. A `""` mixed with other values, or on a label
+ * that is not of the date filter's dataset, or several `""` markers, is an ordinary filter and stays.
+ */
+export function foldLegacyEmptyValuesWithFilter(filter) {
+    const withFilters = filter.with;
+    if (!withFilters) {
+        return filter;
+    }
+    const datasetId = filter.using.split("/").pop();
+    const legacy = Object.entries(withFilters).flatMap(([key, withFilter]) => {
+        const mode = legacyEmptyValuesMode(withFilter, datasetId);
+        return mode ? [{ key, mode }] : [];
+    });
+    // Two markers on one date filter have no single mode to fold into, so none is folded
+    if (legacy.length !== 1) {
+        return filter;
+    }
+    const legacyKeys = new Set(legacy.map(({ key }) => key));
+    const remaining = Object.fromEntries(Object.entries(withFilters).filter(([key]) => !legacyKeys.has(key)));
+    const { with: _with, ...rest } = filter;
+    return {
+        ...rest,
+        ...(Object.keys(remaining).length > 0 ? { with: remaining } : {}),
+        ...(filter.empty_values ? {} : { empty_values: legacy[0].mode }),
+    };
+}
+function legacyEmptyValuesMode(filter, datasetId) {
+    // A date label id is `<dataset id>.<granularity>`; the dataset id may itself contain dots, so compare
+    // it whole rather than up to the first dot.
+    const labelId = filter.using.split("/").pop() ?? "";
+    const granularity = datasetId && labelId.startsWith(`${datasetId}.`) ? labelId.slice(datasetId.length + 1) : "";
+    if (!granularity || granularity.includes(".")) {
+        return undefined;
+    }
+    const isOnlyEmpty = (values) => values?.length === 1 && values[0] === "";
+    if (isOnlyEmpty(filter.state?.include)) {
+        return "only";
+    }
+    return isOnlyEmpty(filter.state?.exclude) ? "exclude" : undefined;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gooddata/sdk-code-convertors",
-  "version": "11.67.0-alpha.3",
+  "version": "11.67.0",
   "description": "GoodData AAC declarative converters",
   "license": "MIT",
   "author": "GoodData",
@@ -26,21 +26,22 @@
   "dependencies": {
     "uuid": "11.1.1",
     "yaml": "2.9.1",
-    "@gooddata/api-client-tiger": "11.67.0-alpha.3",
-    "@gooddata/sdk-code-schemas": "11.67.0-alpha.3",
-    "@gooddata/sdk-model": "11.67.0-alpha.3"
+    "@gooddata/api-client-tiger": "11.67.0",
+    "@gooddata/sdk-model": "11.67.0",
+    "@gooddata/sdk-code-schemas": "11.67.0"
   },
   "devDependencies": {
     "@microsoft/api-extractor": "7.59.2",
     "@typescript-eslint/eslint-plugin": "8.58.0",
     "@typescript-eslint/parser": "8.58.0",
     "dependency-cruiser": "17.3.10",
-    "eslint": "^9.39.2",
+    "eslint": "^10.14.0",
     "eslint-plugin-headers": "1.3.3",
     "eslint-plugin-import-esm": "3.0.1",
     "eslint-plugin-jsdoc": "65.4.2",
     "eslint-plugin-no-barrel-files": "1.2.2",
     "eslint-plugin-sonarjs": "4.2.2",
+    "eslint-plugin-tsdoc": "0.5.4",
     "npm-run-all": "4.1.5",
     "oxfmt": "0.68.0",
     "oxlint": "1.83.0",
@@ -48,8 +49,8 @@
     "oxlint-tsgolint": "7.0.2001",
     "typescript": "7.0.2",
     "vitest": "5.0.4",
-    "@gooddata/oxlint-config": "11.67.0-alpha.3",
-    "@gooddata/eslint-config": "11.67.0-alpha.3"
+    "@gooddata/oxlint-config": "11.67.0",
+    "@gooddata/eslint-config": "11.67.0"
   },
   "scripts": {
     "_phase:build": "npm run build",