@gooddata/sdk-backend-tiger 11.35.0-alpha.5 → 11.35.0-alpha.6

package/esm/__version.d.ts

@@ -1,3 +1,3 @@
-export declare const LIB_VERSION = "11.35.0-alpha.5";
+export declare const LIB_VERSION = "11.35.0-alpha.6";
 export declare const LIB_DESCRIPTION = "GoodData Backend SPI implementation for GoodData Cloud and GoodData.CN";
 export declare const LIB_NAME = "@gooddata/sdk-backend-tiger";

package/esm/__version.js

@@ -1,5 +1,5 @@
 // (C) 2021 GoodData Corporation
 // DO NOT CHANGE THIS FILE, IT IS RE-GENERATED ON EVERY BUILD
-export const LIB_VERSION = "11.35.0-alpha.5";
+export const LIB_VERSION = "11.35.0-alpha.6";
 export const LIB_DESCRIPTION = "GoodData Backend SPI implementation for GoodData Cloud and GoodData.CN";
 export const LIB_NAME = "@gooddata/sdk-backend-tiger";

package/esm/backend/workspace/dashboards/index.d.ts

@@ -1,6 +1,7 @@
 import { type IDashboardExportImageOptions, type IDashboardExportPdfOptions, type IDashboardExportPresentationOptions, type IDashboardExportRawOptions, type IDashboardExportTabularOptions, type IDashboardReferences, type IDashboardSummaryWorkflowStartResult, type IDashboardSummaryWorkflowStatusResult, type IDashboardWithReferences, type IDashboardsQuery, type IExportResult, type IGetDashboardOptions, type IGetDashboardPluginOptions, type IRawExportCustomOverrides, type IWorkspaceDashboardsService, type SupportedDashboardReferenceTypes } from "@gooddata/sdk-backend-spi";
-import { type FilterContextItem, type IDashboard, type IDashboardAttributeFilterConfig, type IDashboardBase, type IDashboardDefinition, type IDashboardFilterView, type IDashboardFilterViewSaveRequest, type IDashboardObjectIdentity, type IDashboardPermissions, type IDashboardPlugin, type IDashboardPluginDefinition, type IDashboardWidget, type IDateFilter, type IExecutionDefinition, type IFilter, type IFilterContext, type IListedDashboard, type IObjectCertificationWrite, type IWidget, type ObjRef } from "@gooddata/sdk-model";
+import { type FilterContextItem, type IDashboard, type IDashboardAttributeFilterConfig, type IDashboardBase, type IDashboardDefinition, type IDashboardFilterView, type IDashboardFilterViewSaveRequest, type IDashboardObjectIdentity, type IDashboardPermissions, type IDashboardPlugin, type IDashboardPluginDefinition, type IDashboardTab, type IDashboardWidget, type IDateFilter, type IExecutionDefinition, type IFilter, type IFilterContext, type IListedDashboard, type IObjectCertificationWrite, type IWidget, type ObjRef } from "@gooddata/sdk-model";
 import { type FiltersByTab, type TigerAuthenticatedCallGuard } from "../../../types/index.js";
+export declare function getDeletedDashboardTabs(originalTabs: IDashboardTab[], updatedTabs: IDashboardTab[]): IDashboardTab<IDashboardWidget>[];
 export declare class TigerWorkspaceDashboards implements IWorkspaceDashboardsService {
     private readonly authCall;
     readonly workspace: string;
@@ -80,6 +81,7 @@ export declare class TigerWorkspaceDashboards implements IWorkspaceDashboardsSer
     private processDashboardTabsFilterContexts;
     private processFilterContextUpdate;
     private updateFilterContext;
+    private deleteFilterContext;
     private getFilterContext;
     private prepareMetadata;
 }

package/esm/backend/workspace/dashboards/index.js

@@ -1,10 +1,10 @@
 // (C) 2020-2026 GoodData Corporation
-import { isEmpty, isEqual } from "lodash-es";
+import { differenceBy, isEmpty, isEqual } from "lodash-es";
 import { invariant } from "ts-invariant";
 import { v4 as uuid } from "uuid";
 import { AnalyticalDashboardModelV2, MetadataUtilities, ValidateRelationsHeader, isDashboardPluginsItem, isDataSetItem, isVisualizationObjectsItem, } from "@gooddata/api-client-tiger";
 import { ActionsApi_GetDependentEntitiesGraph, ActionsApi_SetCertification, } from "@gooddata/api-client-tiger/endpoints/actions";
-import { DashboardsApi_CreateEntityAnalyticalDashboards, DashboardsApi_DeleteEntityAnalyticalDashboards, DashboardsApi_GetAllEntitiesAnalyticalDashboards, DashboardsApi_GetEntityAnalyticalDashboards, DashboardsApi_PatchEntityAnalyticalDashboards, DashboardsApi_UpdateEntityAnalyticalDashboards, EntitiesApi_CreateEntityDashboardPlugins, EntitiesApi_DeleteEntityDashboardPlugins, EntitiesApi_GetAllEntitiesDashboardPlugins, EntitiesApi_GetAllEntitiesLabels, EntitiesApi_GetEntityDashboardPlugins, EntitiesApi_GetEntityWorkspaces, FilterContextApi_CreateEntityFilterContexts, FilterContextApi_GetEntityFilterContexts, FilterContextApi_UpdateEntityFilterContexts, FilterViewsApi_CreateEntityFilterViews, FilterViewsApi_DeleteEntityFilterViews, FilterViewsApi_GetAllEntitiesFilterViews, FilterViewsApi_GetEntityFilterViews, FilterViewsApi_PatchEntityFilterViews, } from "@gooddata/api-client-tiger/endpoints/entitiesObjects";
+import { DashboardsApi_CreateEntityAnalyticalDashboards, DashboardsApi_DeleteEntityAnalyticalDashboards, DashboardsApi_GetAllEntitiesAnalyticalDashboards, DashboardsApi_GetEntityAnalyticalDashboards, DashboardsApi_PatchEntityAnalyticalDashboards, DashboardsApi_UpdateEntityAnalyticalDashboards, EntitiesApi_CreateEntityDashboardPlugins, EntitiesApi_DeleteEntityDashboardPlugins, EntitiesApi_GetAllEntitiesDashboardPlugins, EntitiesApi_GetAllEntitiesLabels, EntitiesApi_GetEntityDashboardPlugins, EntitiesApi_GetEntityWorkspaces, FilterContextApi_CreateEntityFilterContexts, FilterContextApi_DeleteEntityFilterContexts, FilterContextApi_GetEntityFilterContexts, FilterContextApi_UpdateEntityFilterContexts, FilterViewsApi_CreateEntityFilterViews, FilterViewsApi_DeleteEntityFilterViews, FilterViewsApi_GetAllEntitiesFilterViews, FilterViewsApi_GetEntityFilterViews, FilterViewsApi_PatchEntityFilterViews, } from "@gooddata/api-client-tiger/endpoints/entitiesObjects";
 import { ExportApi_CreateDashboardExportRequest, ExportApi_CreateImageExport, ExportApi_CreatePdfExport, ExportApi_CreateRawExport, ExportApi_CreateSlidesExport, ExportApi_GetMetadata, ExportApi_GetSlidesExportMetadata, } from "@gooddata/api-client-tiger/endpoints/export";
 import { ProfileApi_GetCurrent } from "@gooddata/api-client-tiger/endpoints/profile";
 import { NotSupported, UnexpectedError, walkLayout, } from "@gooddata/sdk-backend-spi";
@@ -27,6 +27,9 @@ import { getSettingsForCurrentUser } from "../settings/index.js";
 import { buildDashboardPermissions } from "./dashboardPermissions.js";
 import { DashboardsQuery } from "./dashboardsQuery.js";
 import { resolveWidgetFilters, resolveWidgetFiltersWithMultipleDateFilters } from "./widgetFilters.js";
+export function getDeletedDashboardTabs(originalTabs, updatedTabs) {
+    return differenceBy(originalTabs, updatedTabs, "localIdentifier");
+}
 export class TigerWorkspaceDashboards {
     authCall;
     workspace;
@@ -284,7 +287,28 @@ export class TigerWorkspaceDashboards {
          * and return just `convertDashboard(result.data, filterContext);` below
          */
         const { id, type } = result.data.data;
-        return this.getDashboard(idRef(id, type));
+        // This should ideally be named `updatedDashboard`, but this name is already taken above.
+        const dashboard = await this.getDashboard(idRef(id, type));
+        /**
+         * Perform a side-effect cleanup that deletes filter contexts of the deleted dashboard tabs. This should ideally be done
+         * on the backend, but due to complicated implementation it has been agreed per LX-2173 to be done on the frontend for now.
+         * Remove this if the backend handles this cleanup properly in the future.
+         *
+         * Currently the backend only cleans up filter contexts of tabs when the dashboard is deleted, but not when individual
+         * dashboard tabs are deleted, leaving orphaned filter contexts in the DB. Note that such orphans persist even when
+         * the whole dashboard is deleted, because on dashboard deletion, the backend cleans only filter contexts of _current_ tabs.
+         *
+         * The following code prevents the creation of new filter-context orphans.
+         */
+        getDeletedDashboardTabs(originalDashboard.tabs ?? [], dashboard.tabs ?? [])
+            .map(({ filterContext }) => filterContext)
+            .filter(isFilterContext)
+            .forEach((filterContext) => {
+            this.deleteFilterContext(filterContext).catch((error) => {
+                console.warn(`Failed to cleanup orphaned filter context`, filterContext.ref, error);
+            });
+        });
+        return dashboard;
     };
     /**
      * Starts AI dashboard summary workflow.
@@ -1020,6 +1044,13 @@ export class TigerWorkspaceDashboards {
         });
         return convertFilterContextFromBackend(result.data);
     };
+    deleteFilterContext = async (filterContext) => {
+        await this.authCall((client) => FilterContextApi_DeleteEntityFilterContexts(client.axios, client.basePath, {
+            workspaceId: this.workspace,
+            // Note that `this.authCall` is not actually used. See `objRefToIdentifier()` implementation for details.
+            objectId: objRefToIdentifier(filterContext.ref, this.authCall),
+        }));
+    };
     getFilterContext = async (filterContextRef) => {
         const filterContextId = objRefToIdentifier(filterContextRef, this.authCall);
         const result = await this.authCall((client) => {

package/esm/backend/workspace/genAI/ChatConversations.d.ts

@@ -16,7 +16,7 @@ export declare class ChatConversationsService implements IChatConversations {
     });
     getConversationItemsQuery(): IChatConversationItemsQuery;
     create(): Promise<IChatConversation>;
-    update(conversationId: string, update: Partial<Pick<IChatConversation, "title">>): Promise<IChatConversation>;
+    update(conversationId: string, update: Partial<Pick<IChatConversation, "title" | "pinned">>): Promise<IChatConversation>;
     delete(conversationId: string): Promise<void>;
     generateTitle(conversationId: string): Promise<IChatConversation>;
     getConversation(conversationId: string): Promise<IChatConversation>;

package/esm/convertors/fromBackend/analyticalDashboards/v2/AnalyticalDashboardConverter.js

@@ -94,6 +94,7 @@ function convertDashboardTabContent(tab, filterContext) {
         attributeFilterConfigs: cloneWithSanitizedIdsTyped(tab.attributeFilterConfigs),
         measureValueFilterConfigs: cloneWithSanitizedIdsTyped(tab.measureValueFilterConfigs),
         filterGroupsConfig: cloneWithSanitizedIds(tab.filterGroupsConfig),
+        parameters: tab.parameters?.map(convertDashboardParameter),
     };
 }
 function convertDashboardTab(tab, filterContextsList, filterContextOverride) {

package/esm/convertors/fromBackend/genAIConvertor.js

@@ -13,6 +13,7 @@ export function convertChatConversationFromBackend(conversation) {
         createdAt: conversation.createdAt,
         updatedAt: conversation.lastActivityAt,
         title: conversation.title ?? undefined,
+        pinned: conversation.pinned,
     };
 }
 export function convertChatConversationItemFromBackend(item, responses, dateNormalizer, locale, timezone) {

package/esm/convertors/toBackend/AnalyticalDashboardConverter.js

@@ -73,6 +73,7 @@ function convertDashboardTabToBackend(tab, filterContextRef, useWidgetLocalIdent
         attributeFilterConfigs: cloneWithSanitizedIdsTyped(tab.attributeFilterConfigs),
         measureValueFilterConfigs: cloneWithSanitizedIdsTyped(tab.measureValueFilterConfigs),
         filterGroupsConfig: cloneWithSanitizedIds(tab.filterGroupsConfig),
+        parameters: tab.parameters?.map(convertDashboardParameterToBackend),
     };
 }
 /**
@@ -92,6 +93,7 @@ export function convertAnalyticalDashboard(dashboard, filterContextRef, useWidge
     let effectiveDateFilterConfigs = dashboard.dateFilterConfigs;
     let effectiveAttributeFilterConfigs = dashboard.attributeFilterConfigs;
     let effectiveMeasureValueFilterConfigs = dashboard.measureValueFilterConfigs;
+    let effectiveParameters = dashboard.parameters;
     if (dashboard.tabs && dashboard.tabs.length > 0) {
         const effectiveTab = dashboard.tabs[0];
         // Use tab's properties for root-level (backward compatibility)
@@ -100,6 +102,7 @@ export function convertAnalyticalDashboard(dashboard, filterContextRef, useWidge
         effectiveDateFilterConfigs = effectiveTab.dateFilterConfigs;
         effectiveAttributeFilterConfigs = effectiveTab.attributeFilterConfigs;
         effectiveMeasureValueFilterConfigs = effectiveTab.measureValueFilterConfigs;
+        effectiveParameters = effectiveTab.parameters;
     }
     const layout = convertLayout(false, removeWidgetIdentifiersInLayout(effectiveLayout, useWidgetLocalIdentifiers));
     const result = {
@@ -110,7 +113,7 @@ export function convertAnalyticalDashboard(dashboard, filterContextRef, useWidge
         filterContextRef: cloneWithSanitizedIds(filterContextRef),
         layout: cloneWithSanitizedIdsTyped(layout),
         plugins: dashboard.plugins?.map(convertDashboardPluginLinkToBackend),
-        parameters: dashboard.parameters?.map(convertDashboardParameterToBackend),
+        parameters: effectiveParameters?.map(convertDashboardParameterToBackend),
         disableCrossFiltering: dashboard.disableCrossFiltering,
         disableUserFilterReset: dashboard.disableUserFilterReset,
         disableUserFilterSave: dashboard.disableUserFilterSave,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gooddata/sdk-backend-tiger",
-  "version": "11.35.0-alpha.5",
+  "version": "11.35.0-alpha.6",
   "description": "GoodData Backend SPI implementation for GoodData Cloud and GoodData.CN",
   "license": "MIT",
   "author": "GoodData",
@@ -33,12 +33,12 @@
     "ts-invariant": "0.10.3",
     "tslib": "2.8.1",
     "uuid": "11.1.0",
-    "@gooddata/api-client-tiger": "11.35.0-alpha.5",
-    "@gooddata/sdk-backend-base": "11.35.0-alpha.5",
-    "@gooddata/sdk-backend-spi": "11.35.0-alpha.5",
-    "@gooddata/sdk-model": "11.35.0-alpha.5",
-    "@gooddata/sdk-code-convertors": "11.35.0-alpha.5",
-    "@gooddata/util": "11.35.0-alpha.5"
+    "@gooddata/api-client-tiger": "11.35.0-alpha.6",
+    "@gooddata/sdk-backend-base": "11.35.0-alpha.6",
+    "@gooddata/sdk-code-convertors": "11.35.0-alpha.6",
+    "@gooddata/sdk-model": "11.35.0-alpha.6",
+    "@gooddata/sdk-backend-spi": "11.35.0-alpha.6",
+    "@gooddata/util": "11.35.0-alpha.6"
   },
   "devDependencies": {
     "@gooddata/fixtures": "3.3.12",
@@ -65,10 +65,10 @@
     "oxlint-tsgolint": "0.11.4",
     "typescript": "5.9.3",
     "vitest": "4.1.0",
-    "@gooddata/eslint-config": "11.35.0-alpha.5",
-    "@gooddata/catalog-export": "11.35.0-alpha.5",
-    "@gooddata/reference-workspace": "11.35.0-alpha.5",
-    "@gooddata/oxlint-config": "11.35.0-alpha.5"
+    "@gooddata/catalog-export": "11.35.0-alpha.6",
+    "@gooddata/eslint-config": "11.35.0-alpha.6",
+    "@gooddata/reference-workspace": "11.35.0-alpha.6",
+    "@gooddata/oxlint-config": "11.35.0-alpha.6"
   },
   "scripts": {
     "_phase:build": "npm run build",
@@ -79,7 +79,7 @@
     "build-check": "tsgo",
     "build-dynamic-files": "bash scripts/build.sh --genFilesOnly",
     "build-ts": "tsgo -p tsconfig.build.json",
-    "clean": "../../common/scripts/clean-command-state.sh && rm -rf ci dist esm coverage *.log tsconfig.tsbuildinfo",
+    "clean": "../../common/scripts/clean-command-state.sh && rm -rf ci dist esm coverage temp *.log tsconfig.tsbuildinfo",
     "clear-recordings": "./scripts/clear-recordings.sh",
     "create-ref-workspaces": "node ./tests/reference_workspace/create_test_workspaces.mjs",
     "delete-ref-workspaces": "node ./tests/reference_workspace/delete_test_workspaces.mjs",