@goodandready/dsh-plugin-notify 0.4.3 → 0.4.5

package/CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.5] - 2026-10-19
+
+### Fixed
+- **Detached Logger Binding** (#62, GitHub #3): Guard logger method invocations with `safeLog(ctx, message)` binding receiver `this` (`fn.call(logger, message)`) to prevent `TypeError: this is not a function` in Cordis 0.2 `LoggerService`.
+- **Object Settings Persistence** (#62, GitHub #3): Decompose non-leaf object configuration fields (`webhooks`, `dnd`, `webPush`) into individual leaf paths (`['webhooks', key]`) and save atomically via `scope.mutate(ops)` with fallback to `scope.set`, passing `dsh-settings` volatile path validation.
+- **Session Events & Title Cascade** (#62, GitHub #3): Add `eventsOf(session)` supporting append-only `session.log`, `session.eventsSnapshot`, and `session.snapshotEvents()`; add `cachedTitle(session)` reading projected title cache from disk (`storages/session_projcache/sessions/<id>.json`), preventing fallback to raw UUIDs.
+- **Session Navigation Priority** (#62, GitHub #3): Target `uiWorkspace.openSession(sessionId)` as the primary navigation service in `navigateToSession` with graceful fallbacks.
+
+## [0.4.4] - 2026-10-15
+
+### Fixed
+- **Client config form lookup** (#61): Query `ctx.configForms` strictly by canonical entry id `plugin-notify` (`ROW_ID`) rather than attempting fallback queries to scoped package name `@goodandready/dsh-plugin-notify`, fixing unresolvable configuration lookups in the settings panel.
+
 ## [0.4.3] - 2026-10-15
 
 ### Fixed

package/lib/client.js

@@ -260,15 +260,33 @@ window.__ModuleLoader__.load({
     function navigateToSession(ctx, sessionId) {
       if (!sessionId) return
       try {
-        if (ctx && ctx.sessions && typeof ctx.sessions.activate === 'function') {
-          ctx.sessions.activate(sessionId)
+        const ws = (ctx && typeof ctx.get === 'function' ? ctx.get('uiWorkspace') : null) || ctx?.uiWorkspace
+        if (ws && typeof ws.openSession === 'function') {
+          ws.openSession(sessionId)
           return
         }
       } catch (_err) {
-        // best effort: session navigation fallback
+        // best effort: uiWorkspace navigation fallback
+      }
+      try {
+        const s = (ctx && typeof ctx.get === 'function' ? ctx.get('sessions') : null) || ctx?.sessions
+        if (s && typeof s.activate === 'function') {
+          s.activate(sessionId)
+          return
+        }
+        if (s && typeof s.open === 'function') {
+          s.open(sessionId)
+          return
+        }
+      } catch (_err) {
+        // best effort: session service fallback
       }
       if (typeof window !== 'undefined' && window.location) {
-        window.location.hash = `session-${sessionId}`
+        try {
+          window.location.hash = `session-${sessionId}`
+        } catch (_err) {
+          // best effort: location hash update fallback
+        }
       }
     }
 
@@ -371,11 +389,9 @@ window.__ModuleLoader__.load({
       const timer = setInterval(() => {
         tries++
         try {
-          if (ctx && ctx.sessions && typeof ctx.sessions.activate === 'function') {
-            ctx.sessions.activate(sessionId)
-            clearInterval(timer)
-            return
-          }
+          navigateToSession(ctx, sessionId)
+          clearInterval(timer)
+          return
         } catch (_err) {
           // retry until the budget is exhausted
         }
@@ -675,22 +691,17 @@ window.__ModuleLoader__.load({
         }
       }
 
-      // In DSH 0.2.x configForms is keyed strictly by entry id (ROW_ID = 'plugin-notify').
-      // Hold both candidates and prefer ROW_ID whenever it is ready or NS is unavailable.
-      const [scopeRow, scopeNS] = React.useMemo(
-        () => (ctx && ctx.configForms ? [ctx.configForms.get(ROW_ID), ctx.configForms.get(NS)] : [undefined, undefined]),
+      // In DSH configForms is keyed by entry id (ROW_ID = 'plugin-notify').
+      // Query ROW_ID directly; no entry id in the environment has the package name.
+      const scope = React.useMemo(
+        () => (ctx && ctx.configForms ? ctx.configForms.get(ROW_ID) : undefined),
         [ctx],
       )
-      const useSnap = (scope) => React.useSyncExternalStore(
+      const snapshot = React.useSyncExternalStore(
         React.useMemo(() => (cb) => (scope ? scope.subscribe(cb) : () => {}), [scope]),
         React.useCallback(() => (scope ? scope.getSnapshot() : { status: 'loading' }), [scope]),
         React.useCallback(() => ({ status: 'loading' }), []),
       )
-      const snapRow = useSnap(scopeRow)
-      const snapNS = useSnap(scopeNS)
-      const useRow = scopeRow && (snapRow.status === 'ready' || snapNS.status !== 'ready')
-      const scope = useRow ? scopeRow : (scopeNS || scopeRow)
-      const snapshot = useRow ? snapRow : (scopeNS ? snapNS : snapRow)
 
       React.useEffect(() => { ensureStyles() }, [])
 
@@ -747,9 +758,33 @@ window.__ModuleLoader__.load({
           includeDuration: !!draft.includeDuration,
           excludeSessionPrefixes: splitList(draft.excludePrefixes),
         }
+        const ops = []
         for (const [k, v] of Object.entries(payload)) {
-          try { await scope.set(k, v) }
-          catch (e) { broken.push(k + ': ' + (e && e.message || String(e))) }
+          if (v !== null && typeof v === 'object' && !Array.isArray(v)) {
+            for (const [subKey, subVal] of Object.entries(v)) {
+              ops.push({ op: 'set', path: [k, subKey], value: subVal })
+            }
+          } else {
+            ops.push({ op: 'set', path: [k], value: v })
+          }
+        }
+
+        if (scope && typeof scope.mutate === 'function') {
+          try {
+            const ok = await scope.mutate(ops)
+            if (ok === false) broken.push('mutate refused by host')
+          } catch (e) {
+            broken.push(e && e.message || String(e))
+          }
+        } else if (scope && typeof scope.set === 'function') {
+          for (const op of ops) {
+            try {
+              if (op.path.length === 1) await scope.set(op.path[0], op.value)
+              else await scope.set(op.path.join('.'), op.value)
+            } catch (e) {
+              broken.push(op.path.join('.') + ': ' + (e && e.message || String(e)))
+            }
+          }
         }
         setSaving(false)
         if (broken.length) { setErr(t('settings.saveFailed') + broken.join('; ')); return }
@@ -909,9 +944,7 @@ window.__ModuleLoader__.load({
       let currentSettings = {}
       if (ctx.configForms) {
         try {
-          const candidates = [ctx.configForms.get(ROW_ID), ctx.configForms.get(NS)]
-          const ready = candidates.find((s) => s && s.getSnapshot && s.getSnapshot().status === 'ready')
-          const scope = ready || candidates[0]
+          const scope = ctx.configForms.get(ROW_ID)
           if (scope && typeof scope.subscribe === 'function') {
             scope.subscribe(() => {
               const snap = scope.getSnapshot ? scope.getSnapshot() : null

package/lib/index.js

@@ -741,6 +741,18 @@ function mountWebServer(targetCtx, hostCtx, getConfig) {
     return cleanup;
 }
 
+export function safeLog(ctx, message) {
+    try {
+        const logger = ctx?.logger;
+        const fn = logger?.debug ?? logger?.info;
+        if (typeof fn === 'function') {
+            fn.call(logger, message);
+        }
+    } catch {
+        // best effort: logger call must never throw or disrupt execution
+    }
+}
+
 export function apply(ctx, config = {}) {
     let getConfig = () => unwrapConfig(config ?? {});
 
@@ -827,7 +839,7 @@ export function apply(ctx, config = {}) {
         const cfg = unwrapConfig(getConfig());
         const dnd = cfg.dnd;
         if (inDnd(dnd)) {
-            (ctx?.logger?.debug ?? ctx?.logger?.info)?.(`[plugin-notify] ${n.kind} · ${n.title} · session ${n.sessionId} · DND (${dnd?.start}-${dnd?.end}), logged only`);
+            safeLog(ctx, `[plugin-notify] ${n.kind} · ${n.title} · session ${n.sessionId} · DND (${dnd?.start}-${dnd?.end}), logged only`);
             return;
         }
         const timeoutMs = cfg.timeoutMs ?? 5000;
@@ -863,7 +875,7 @@ export function apply(ctx, config = {}) {
                     ctx?.logger?.warn?.(`[plugin-notify] web push dispatch failed: ${String(error)}`);
                 });
             } else {
-                (ctx?.logger?.debug ?? ctx?.logger?.info)?.(`[plugin-notify] ${n.kind} · session ${n.sessionId} · web push skipped (clients connected)`);
+                safeLog(ctx, `[plugin-notify] ${n.kind} · session ${n.sessionId} · web push skipped (clients connected)`);
             }
         }
     };
@@ -926,7 +938,7 @@ function send(ctx, n, webhooks, timeoutMs, local, includeSession, includeDuratio
     const text = renderText(n, includeSession, includeDuration);
     const signal = AbortSignal.timeout(timeoutMs);
     const channels = Object.keys(webhooks);
-    (ctx?.logger?.debug ?? ctx?.logger?.info)?.(`[plugin-notify] ${n.kind} · ${n.title} · session ${n.sessionId} · channels ${channels.join(',') || 'none'} · local ${local}`);
+    safeLog(ctx, `[plugin-notify] ${n.kind} · ${n.title} · session ${n.sessionId} · channels ${channels.join(',') || 'none'} · local ${local}`);
     const post = (channel, url, body) => {
         fetch(url, {
             method: 'POST',
@@ -1034,20 +1046,90 @@ export function textOf(content) {
     return out;
 }
 
+export function eventsOf(session) {
+    const pick = (v) => Array.isArray(v) ? v : (v && Array.isArray(v.entries) ? v.entries : null);
+    try {
+        for (const key of ['events', 'log', 'eventsSnapshot', 'history']) {
+            const raw = session?.[key];
+            const direct = pick(raw);
+            if (direct) return direct;
+            if (typeof raw === 'function') {
+                const got = pick(raw.call(session));
+                if (got) return got;
+            }
+        }
+        if (typeof session?.snapshotEvents === 'function') {
+            const got = pick(session.snapshotEvents());
+            if (got) return got;
+        }
+    } catch (_err) {
+        // best effort: session events resolution fallback
+    }
+    return [];
+}
+
+export function cachedTitle(session) {
+    const id = String(session?.id ?? '');
+    if (!id) return '';
+    try {
+        const home = process.env.DSH_HOME || path.join(process.env.USERPROFILE || process.env.HOME || '', '.dsh');
+        const projPath = path.join(home, 'storages', 'session_projcache', 'sessions', `${id}.json`);
+        if (fs.existsSync(projPath)) {
+            const content = fs.readFileSync(projPath, 'utf8');
+            const doc = JSON.parse(content);
+            const raw = doc?.record?.rows?.title ?? doc?.rows?.title;
+            const val = typeof raw === 'string' ? raw : (raw && typeof raw.val === 'string' ? raw.val : '');
+            if (val && typeof val === 'string') return val.trim();
+        }
+    } catch (_err) {
+        // best effort: session projcache file read fallback
+    }
+    return '';
+}
+
 export function sessionTitle(session) {
-    const events = Array.isArray(session?.events) ? session.events : [];
+    if (typeof session?.title === 'string' && session.title.trim()) {
+        return session.title.trim();
+    }
+    const headerTitle = session?.header?.title;
+    if (typeof headerTitle === 'string' && headerTitle.trim()) {
+        return headerTitle.trim();
+    }
+    if (headerTitle && typeof headerTitle.val === 'string' && headerTitle.val.trim()) {
+        return headerTitle.val.trim();
+    }
+    const rowsTitle = session?.rows?.title;
+    if (typeof rowsTitle === 'string' && rowsTitle.trim()) {
+        return rowsTitle.trim();
+    }
+    if (rowsTitle && typeof rowsTitle.val === 'string' && rowsTitle.val.trim()) {
+        return rowsTitle.val.trim();
+    }
+
+    const events = eventsOf(session);
+    for (const event of events) {
+        if (event && event.type === 'session/title' && event.data?.title) {
+            const t = String(event.data.title).replace(/\s+/g, ' ').trim();
+            if (t) return t.length > 60 ? `${t.slice(0, 60)}…` : t;
+        }
+    }
     for (const event of events) {
         if (event && event.type === 'user/message') {
             const text = textOf(event.data?.content).replace(/\s+/g, ' ').trim();
-            if (text)
-                return text.length > 60 ? `${text.slice(0, 60)}…` : text;
+            if (text) return text.length > 60 ? `${text.slice(0, 60)}…` : text;
         }
     }
+
+    const cached = cachedTitle(session);
+    if (cached) {
+        return cached.length > 60 ? `${cached.slice(0, 60)}…` : cached;
+    }
+
     return String(session?.id ?? 'session');
 }
 
 export function summarizeTurn(session, turn) {
-    const events = Array.isArray(session?.events) ? session.events : [];
+    const events = eventsOf(session);
     let toolCalls = 0;
     let lastText = '';
     // Reverse iteration: events for current turn are at the end of the events array

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-plugin-notify",
-  "version": "0.4.3",
+  "version": "0.4.5",
   "description": "DSH plugin: audio chimes, cross-session toasts, desktop push, IM webhooks, and web push (PWA) for turn completion, errors, and approvals.",
   "license": "MIT",
   "type": "module",
@@ -40,14 +40,14 @@
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
-    "@deepseek-ai/dsh-session": "^0.1.7-rc.2 || ^0.2.0-rc.1",
-    "@deepseek-ai/dsh-credentials": "^0.1.7-rc.2 || ^0.2.0-rc.1",
+    "@deepseek-ai/dsh-session": "^0.1.7-rc.2 || ^0.2.0-rc.1 || ^0.2.0-rc.2",
+    "@deepseek-ai/dsh-credentials": "^0.1.7-rc.2 || ^0.2.0-rc.1 || ^0.2.0-rc.2",
     "@deepseek-ai/schemastery": "^3.18.4"
   },
   "devDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
-    "@deepseek-ai/dsh-session": "^0.1.0-rc.6",
-    "@deepseek-ai/dsh-credentials": "^0.1.0-rc.8",
+    "@deepseek-ai/dsh-session": "^0.1.7-rc.2",
+    "@deepseek-ai/dsh-credentials": "^0.1.7-rc.2",
     "@deepseek-ai/schemastery": "^3.18.4",
     "web-push": "^3.6.7"
   },