@goodandready/dsh-plugin-notify 0.4.0 → 0.4.1

package/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.1] - 2026-10-10
+
+### Fixed
+- **Settings registration namespace & Desktop crash protection** (#55): Use canonical `ENTRY_ID = 'plugin-notify'` instead of scoped package name in `settings.register`; wrap call with `try / catch` logging warning instead of throwing `TypeError` in DSH Desktop.
+- **Settings form slot binding** (#54): Bind UI `settings.plugin.item` slot `key` to `ROW_ID` (`'plugin-notify'`), and prioritize `ROW_ID` in `configForms` candidates over legacy `NS`.
+- **Dynamic settings observation** (#48): Make describe settings fallback reactive: observe `loader/volatile-update`, `settings/document-updated`, and `settings/updated` to dynamically refresh settings when edited in UI or external config.
+- **Config unboxing guarantee** (#47): Guarantee `getConfig()` always unwraps volatile boxes via `unwrapConfig(config ?? {})`, preventing `TypeError` during `session/event` event unboxing.
+- **DSH 0.2.0-rc.1 clean activation & volatile schema** (#42): Guarantee clean activation on DSH 0.2.0-rc.1 when `settings.register` is absent; confirm all user-facing fields in `Config` have `.volatile()` markers.
+
 ## [0.4.0] - 2026-10-05
 
 ### Added

package/lib/client.js

@@ -675,11 +675,10 @@ window.__ModuleLoader__.load({
         }
       }
 
-      // dsh 0.1 keys the settings scope by package name; 0.2 keys it by the
-      // composition row id. get() always returns a controller, so hold BOTH and
-      // use whichever reports ready (the other stays permanently unavailable).
-      const [scopeNS, scopeRow] = React.useMemo(
-        () => (ctx && ctx.configForms ? [ctx.configForms.get(NS), ctx.configForms.get(ROW_ID)] : [undefined, undefined]),
+      // In DSH 0.2.x configForms is keyed strictly by entry id (ROW_ID = 'plugin-notify').
+      // Hold both candidates and prefer ROW_ID whenever it is ready or NS is unavailable.
+      const [scopeRow, scopeNS] = React.useMemo(
+        () => (ctx && ctx.configForms ? [ctx.configForms.get(ROW_ID), ctx.configForms.get(NS)] : [undefined, undefined]),
         [ctx],
       )
       const useSnap = (scope) => React.useSyncExternalStore(
@@ -687,11 +686,11 @@ window.__ModuleLoader__.load({
         React.useCallback(() => (scope ? scope.getSnapshot() : { status: 'loading' }), [scope]),
         React.useCallback(() => ({ status: 'loading' }), []),
       )
-      const snapNS = useSnap(scopeNS)
       const snapRow = useSnap(scopeRow)
-      const rowWins = scopeRow && snapNS.status !== 'ready' && snapRow.status === 'ready'
-      const scope = rowWins ? scopeRow : scopeNS
-      const snapshot = rowWins ? snapRow : snapNS
+      const snapNS = useSnap(scopeNS)
+      const useRow = scopeRow && (snapRow.status === 'ready' || snapNS.status !== 'ready')
+      const scope = useRow ? scopeRow : (scopeNS || scopeRow)
+      const snapshot = useRow ? snapRow : (scopeNS ? snapNS : snapRow)
 
       React.useEffect(() => { ensureStyles() }, [])
 
@@ -905,7 +904,7 @@ window.__ModuleLoader__.load({
         })
         ctx.slots.inject('settings.plugin.item', () => {
           ctx.slots.register(
-            { name: 'settings.plugin.item', key: NS, locale: NS, order: 40, inject: () => ({ ctx }) },
+            { name: 'settings.plugin.item', key: ROW_ID, locale: NS, order: 40, inject: () => ({ ctx }) },
             (props) => React.createElement(NotifyCard, { ...props, ctx }),
           )
         })
@@ -916,7 +915,7 @@ window.__ModuleLoader__.load({
       let currentSettings = {}
       if (ctx.configForms) {
         try {
-          const candidates = [ctx.configForms.get(NS), ctx.configForms.get(ROW_ID)]
+          const candidates = [ctx.configForms.get(ROW_ID), ctx.configForms.get(NS)]
           const ready = candidates.find((s) => s && s.getSnapshot && s.getSnapshot().status === 'ready')
           const scope = ready || candidates[0]
           if (scope && typeof scope.subscribe === 'function') {

package/lib/index.js

@@ -10,6 +10,8 @@ import { credentialRef } from '@deepseek-ai/dsh-credentials';
 export const name = '@goodandready/dsh-plugin-notify';
 /** Settings namespace shared with the Web settings card. */
 export const NS = '@goodandready/dsh-plugin-notify';
+/** Canonical entry id matching cordis.patch.yml */
+export const ENTRY_ID = 'plugin-notify';
 
 // Session firehose + credentials (webhook URL refs) + settings scope for the card + webServer for SSE events + connection for authentication.
 export const inject = ['sessions', 'credentials', 'settings', 'webServer', 'connection'];
@@ -734,7 +736,7 @@ function mountWebServer(targetCtx, hostCtx, getConfig) {
 }
 
 export function apply(ctx, config = {}) {
-    let getConfig = () => config ?? {};
+    let getConfig = () => unwrapConfig(config ?? {});
 
     let webServerMounted = false;
     let unmountWebServer = null;
@@ -768,22 +770,48 @@ export function apply(ctx, config = {}) {
     if (typeof ctx.inject === 'function') {
         ctx.inject(['settings'], (sctx) => {
             if (typeof sctx.settings?.register === 'function') {
-                const scope = sctx.settings.register(NS, Config, { base: config ?? {} });
-                getConfig = () => scope.get() ?? config ?? {};
-                return;
+                try {
+                    const scope = sctx.settings.register(ENTRY_ID, Config, { base: config ?? {} });
+                    getConfig = () => (scope ? unwrapConfig(scope.get() ?? config ?? {}) : unwrapConfig(config ?? {}));
+                    return;
+                } catch (err) {
+                    ctx?.logger?.warn?.(`[plugin-notify] settings.register('${ENTRY_ID}') failed, falling back to describe: ${String(err)}`);
+                }
+            }
+            let currentRow = (() => { try { return sctx.settings?.describe?.().find((r) => r && (r.ns === ENTRY_ID || r.ns === NS)); } catch { return null; } })();
+            const refreshSettings = () => {
+                try {
+                    const next = sctx.settings?.describe?.().find((r) => r && (r.ns === ENTRY_ID || r.ns === NS));
+                    if (next) currentRow = next;
+                } catch {
+                    // best effort
+                }
+            };
+            if (typeof ctx.on === 'function') {
+                ctx.on('settings/document-updated', refreshSettings);
+                ctx.on('loader/volatile-update', refreshSettings);
+                ctx.on('settings/updated', refreshSettings);
+            }
+            if (typeof sctx.settings?.on === 'function') {
+                try { sctx.settings.on('update', refreshSettings); } catch { /* ignore */ }
             }
-            const row = (() => { try { return sctx.settings?.describe?.().find((r) => r && r.ns === NS); } catch { return null; } })();
             const scope = {
-              get: () => row?.value ?? config ?? {},
+              get: () => {
+                refreshSettings();
+                return currentRow?.value ?? config ?? {};
+              },
               replace: async (next) => {
                 try {
-                  return await sctx.settings?.replace?.(NS, next, row?.revision);
+                  const targetNs = sctx.settings?.describe?.().some((r) => r && r.ns === ENTRY_ID) ? ENTRY_ID : NS;
+                  const res = await sctx.settings?.replace?.(targetNs, next, currentRow?.revision);
+                  refreshSettings();
+                  return res;
                 } catch (err) {
                   ctx?.logger?.warn?.(`[plugin-notify] settings replace failed: ${String(err)}`);
                 }
               },
             };
-            getConfig = () => scope.get() ?? config ?? {};
+            getConfig = () => (scope ? unwrapConfig(scope.get() ?? config ?? {}) : unwrapConfig(config ?? {}));
         });
         ctx.inject(['webServer'], (wctx) => tryMountWebServer(wctx))
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-plugin-notify",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "DSH plugin: audio chimes, cross-session toasts, desktop push, IM webhooks, and web push (PWA) for turn completion, errors, and approvals.",
   "license": "MIT",
   "type": "module",