@goodandready/dsh-plugin-notify 0.3.3 → 0.3.4

package/CHANGELOG.md

@@ -4,7 +4,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## 0.3.3
+## [0.3.4] - 2026-09-24
+
+### Fixed
+- **Memory Leak in Turn Tracking (#32)**: Added TTL-based cleanup (30m max age) for stale `turnStarts` entries with automatic pruning on turn events.
+- **SSE Connection Drops on Reverse Proxies (#33)**: Added periodic 25s keepalive ping comments (`: ping\n\n`) on `/dsh-plugin-notify/events` with unreferenced timer and automatic dead socket removal.
+- **Reverse Iteration in Session Summarization (#34)**: Optimized `summarizeTurn` from O(N) forward iteration to reverse iteration with early break once the turn assistant message is found.
+- **String Content Handling in textOf (#35)**: Fixed `textOf(content)` to properly return string content when passed a primitive string or strings within content arrays.
+
+### Documented
+- **Architectural Exception for Client Bundle (#36)**: Formally documented the conscious >600-line monolithic bundle exception for `lib/client.js` in `docs/design/DESIGN.md` in accordance with DSH `ModuleLoader` architecture.
+
+## [0.3.3] - 2026-09-24
 
 ### Fixed
 - The settings card no longer waits for the removed `settingsScope` service. It uses `configForms` on current DeepSeek Harness (#37).

package/lib/index.js

@@ -52,9 +52,24 @@ function isExcludedSession(sessionId, prefixes) {
 
 const DEFAULT_EVENTS = ['task_done', 'error', 'approval_requested'];
 /** Per-session last `turn/start` epoch ms, for turn-duration reporting. */
-const turnStarts = new Map();
+export const turnStarts = new Map();
 const warnedLegacyUrls = new Set();
 
+/**
+ * Purge turnStarts entries older than maxAgeMs (default 2 hours) to prevent
+ * memory leaks from abandoned or cancelled sessions.
+ */
+export function cleanupTurnStarts(maxAgeMs = 7200000, now = Date.now()) {
+    let deleted = 0;
+    for (const [sid, start] of turnStarts.entries()) {
+        if (now - start > maxAgeMs) {
+            turnStarts.delete(sid);
+            deleted++;
+        }
+    }
+    return deleted;
+}
+
 /** Resolve a config value to a webhook URL: credential ref (preferred), env fallback, or legacy raw URL. */
 export async function resolveWebhookValue(ctx, refOrUrl) {
     if (!refOrUrl || typeof refOrUrl !== 'string') return '';
@@ -87,7 +102,21 @@ export async function resolveWebhooks(ctx, webhooks = {}) {
     return out;
 }
 
-const sseClients = new Set();
+export const sseClients = new Set();
+
+export function sendSseHeartbeat() {
+    if (sseClients.size === 0) return 0;
+    let sent = 0;
+    for (const res of sseClients) {
+        try {
+            res.write(': ping\n\n');
+            sent++;
+        } catch {
+            sseClients.delete(res);
+        }
+    }
+    return sent;
+}
 
 function isLoopback(address) {
     if (!address) return false;
@@ -179,10 +208,17 @@ function mountWebServer(targetCtx) {
         path: '/dsh-plugin-notify/events',
         handler: (req, res) => handleSseConnection(req, res),
     };
+    const startHeartbeat = () => {
+        const timer = setInterval(() => sendSseHeartbeat(), 25000);
+        timer?.unref?.();
+        return () => clearInterval(timer);
+    };
     if (typeof targetCtx.effect === 'function') {
         targetCtx.effect(() => targetCtx.webServer.register(routeDef), 'dsh-plugin-notify: sse events');
+        targetCtx.effect(startHeartbeat, 'dsh-plugin-notify: sse heartbeat');
     } else {
         targetCtx.webServer.register(routeDef);
+        startHeartbeat();
     }
 }
 
@@ -247,6 +283,9 @@ export function apply(ctx, config = {}) {
         const excludeSessionPrefixes = cfg.excludeSessionPrefixes ?? [];
 
         if (event.type === 'turn/start') {
+            if (turnStarts.size > 100) {
+                cleanupTurnStarts();
+            }
             turnStarts.set(String(session.id), Date.now());
             return;
         }
@@ -388,10 +427,14 @@ function reasonLabel(reason) {
     }
 }
 
-function textOf(content) {
+export function textOf(content) {
+    if (typeof content === 'string') return content;
+    if (!Array.isArray(content)) return '';
     let out = '';
     for (const block of content) {
-        if (typeof block === 'object' && block !== null && block.type === 'text') {
+        if (typeof block === 'string') {
+            out += block;
+        } else if (typeof block === 'object' && block !== null && block.type === 'text') {
             const text = block.text;
             if (typeof text === 'string')
                 out += text;
@@ -400,27 +443,40 @@ function textOf(content) {
     return out;
 }
 
-function sessionTitle(session) {
-    for (const event of session.events) {
-        if (event.type === 'user/message') {
-            const text = textOf(event.data.content).replace(/\s+/g, ' ').trim();
+export function sessionTitle(session) {
+    const events = Array.isArray(session?.events) ? session.events : [];
+    for (const event of events) {
+        if (event && event.type === 'user/message') {
+            const text = textOf(event.data?.content).replace(/\s+/g, ' ').trim();
             if (text)
                 return text.length > 60 ? `${text.slice(0, 60)}…` : text;
         }
     }
-    return String(session.id);
+    return String(session?.id ?? 'session');
 }
 
-function summarizeTurn(session, turn) {
+export function summarizeTurn(session, turn) {
+    const events = Array.isArray(session?.events) ? session.events : [];
     let toolCalls = 0;
     let lastText = '';
-    for (const event of session.events) {
-        if (event.type === 'tool/call' && event.data.turn === turn)
+    // Reverse iteration: events for current turn are at the end of the events array
+    for (let i = events.length - 1; i >= 0; i--) {
+        const event = events[i];
+        if (!event || !event.data) continue;
+        if (event.data.turn !== turn) {
+            if (typeof event.data.turn === 'number' && event.data.turn < turn) {
+                break;
+            }
+            continue;
+        }
+        if (event.type === 'tool/call') {
             toolCalls += 1;
-        if (event.type === 'assistant/message' && event.data.turn === turn) {
-            const text = textOf(event.data.message.content);
-            if (text)
+        }
+        if (event.type === 'assistant/message' && !lastText) {
+            const text = textOf(event.data.message?.content);
+            if (text) {
                 lastText = text;
+            }
         }
     }
     const parts = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-plugin-notify",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "DSH plugin: audio chimes, cross-session toasts, desktop push, and IM webhooks for turn completion, errors, and approvals.",
   "license": "MIT",
   "type": "module",