@goodandready/dsh-key-rotation 0.8.69 → 0.8.70

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.8.70 - 2026-10-20
+
+### Bug Fixes
+- **Fix Fatal Crash in sweepExpired & Isolate Clone Metadata (#513, GitHub #26)**:
+  - Guarded `sweepExpired` in `lib/pool.js` and the periodic sweep timer in `lib/index.js` with `if (!st || !(st.failedUntil instanceof Map)) continue;` to safely skip non-pool-state values.
+  - Isolated clone route metadata tracking inside `CloneLifecycleManager` (`this.knownClones`) rather than polluting `poolState` with `Set` objects (`${provider}:clones`).
+  - Added regression test `test/github-issue-26-sweep-expired.test.mjs` verifying `sweepExpired` robustness with heterogeneous data and clean `poolState` boundaries.
+
 ## 0.8.69 - 2026-10-19
 
 ### Features

package/lib/clone-lifecycle.js

@@ -101,20 +101,37 @@ export class CloneLifecycleManager {
     this.concurrencyTracker = concurrencyTracker;
     this.logger = logger || console;
     this.drainingClones = new Map(); // cloneId -> { provider, ref, startedAt, timer }
+    this.knownClones = new Map(); // provider -> Set<string>
   }
 
   /**
    * Evaluates previous vs current expected clones for a provider.
    * If a clone was removed, marks it draining instead of instantly destroying it.
    * @param {string} provider
-   * @param {Set<string>|string[]} prevClones
+   * @param {Set<string>|string[]} [prevClones]
    * @param {Set<string>|string[]} currentClones
-   * @param {Function} onDeregister callback when draining completes and route is safe to remove
+   * @param {Function} [onDeregister] callback when draining completes and route is safe to remove
    */
-  reconcileClones(provider, prevClones, currentClones, onDeregister) {
+  reconcileClones(provider, prevOrCurrent, currentOrDeregister, maybeDeregister) {
+    let prevClones;
+    let currentClones;
+    let onDeregister;
+
+    if (currentOrDeregister instanceof Set || Array.isArray(currentOrDeregister)) {
+      prevClones = prevOrCurrent;
+      currentClones = currentOrDeregister;
+      onDeregister = maybeDeregister;
+    } else {
+      prevClones = this.knownClones.get(provider) ?? [];
+      currentClones = prevOrCurrent;
+      onDeregister = currentOrDeregister;
+    }
+
     const prevSet = prevClones instanceof Set ? prevClones : new Set(prevClones || []);
     const currSet = currentClones instanceof Set ? currentClones : new Set(currentClones || []);
 
+    this.knownClones.set(provider, currSet);
+
     for (const cloneId of prevSet) {
       if (!currSet.has(cloneId)) {
         this.startDrain(cloneId, provider, onDeregister);

package/lib/index.js

@@ -232,6 +232,7 @@ export function apply(ctx, config = {}) {
     const id = setInterval(() => {
       const now = Date.now();
       for (const st of poolState.values()) {
+        if (!st || !(st.failedUntil instanceof Map)) continue;
         for (const [ref, until] of [...(st.failedUntil?.entries() ?? [])]) {
           if (until <= now && !st.probedAt?.has(ref)) {
             st.events.push({ at: until, ref, reason: 'probe', cooldownMs: 0, type: 'probe' });

package/lib/pool-builder.js

@@ -285,8 +285,7 @@ export function cleanupRemovedProviders({
   if (cloneLifecycle && typeof cloneLifecycle.reconcileClones === 'function') {
     for (const p of cfg.providers ?? []) {
       const liveClones = new Set([...expectedClones].filter(c => c.startsWith(`${p.provider}-`)));
-      cloneLifecycle.reconcileClones(p.provider, poolState.get(`${p.provider}:clones`) ?? [], liveClones);
-      poolState.set(`${p.provider}:clones`, liveClones);
+      cloneLifecycle.reconcileClones(p.provider, liveClones);
     }
   }
 }

package/lib/pool.js

@@ -226,6 +226,7 @@ export function sweepExpired(poolState, now = Date.now(), activeRefs = null, quo
   let cleared = 0;
   const activeSet = activeRefs ? new Set(activeRefs) : null;
   for (const st of poolState.values()) {
+    if (!st || !(st.failedUntil instanceof Map)) continue;
     // #338: decay penalty failCounts for stable keys in maintenance sweep
     decayPenalties({ state: st }, now);
     for (const [ref, until] of [...st.failedUntil.entries()]) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.69",
+  "version": "0.8.70",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [