@goodandready/dsh-key-rotation 0.8.58 → 0.8.59

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 0.8.59 - 2026-10-14
+
+### Refactored & Cleaned
+- **Legacy Settings Registration Removed (#482)**:
+  - Deleted dead legacy `settings.register` branch in `lib/index.js`, fixing static configuration liveness to use standard `createConfigReader`.
+- **Dead Subscriptions & Settings Fallbacks Removed (#482)**:
+  - Removed dead `ctx.on('config')` subscription in `lib/config-compat.js`.
+  - Removed unreachable legacy `settings.get` fallback in `createProviderProfilesReader` in favor of standard `settings.describe`.
+- **Test Harness Synchronization (#482)**:
+  - Updated test fixtures for modern descriptor caching and multi-listener lifecycle events.
+
 ## 0.8.58 - 2026-10-13
 
 ### Fixed

package/lib/config-compat.js

@@ -10,11 +10,9 @@ export function createConfigReader(config, ctx) {
     if (typeof ctx.effect === 'function') {
       ctx.effect(() => ctx.on('settings/document-updated', markDirty));
       ctx.effect(() => ctx.on('loader/volatile-update', markDirty));
-      ctx.effect(() => ctx.on('config', markDirty));
     } else {
       ctx.on('settings/document-updated', markDirty);
       ctx.on('loader/volatile-update', markDirty);
-      ctx.on('config', markDirty);
     }
   }
 
@@ -68,23 +66,13 @@ export function createProviderProfilesReader(ctx, namespace) {
       return held;
     }
     const settings = ctx?.get?.('settings');
-    if (!settings) return null;
-    if (typeof settings.get === 'function') {
-      try {
-        held = settings.get(namespace)?.providers ?? null;
-        dirty = false;
-      } catch (_) {
-        held = null;
-        dirty = false;
-      }
-    } else {
-      try {
-        held = settings.describe({ redactSecrets: true }).find(row => row.ns === namespace)?.value?.providers ?? null;
-        dirty = false;
-      } catch (_) {
-        held = null;
-        dirty = false;
-      }
+    if (!settings || typeof settings.describe !== 'function') return null;
+    try {
+      held = settings.describe({ redactSecrets: true }).find(row => row.ns === namespace)?.value?.providers ?? null;
+      dirty = false;
+    } catch (_) {
+      held = null;
+      dirty = false;
     }
     return held;
   };

package/lib/index.js

@@ -178,7 +178,7 @@ function registerConfigBridge(ctx, getCloneIds) {
 export function apply(ctx, config = {}) {
   const logger = getLogger(ctx);
   const readEntryConfig = createConfigReader(config, ctx);
-  let getConfig = readEntryConfig;
+  const getConfig = readEntryConfig;
   const verboseLoggingOn = () => {
     try { return Boolean(getConfig()?.verboseLogging); } catch (_) { return false; }
   };
@@ -501,15 +501,4 @@ export function apply(ctx, config = {}) {
     return next();
   }), 'dsh-key-rotation: agent/request-error');
 
-  ctx.inject(['settings'], (sctx) => {
-    const settingsSvc = sctx.get('settings');
-    // Modern SettingsForms already owns this Loader entry's volatile Config.
-    // Legacy SettingsProvider instead needs a plain namespace registration.
-    if (typeof settingsSvc?.register !== 'function') return;
-    const scope = settingsSvc.register(NS, SettingsSchema, { base: readEntryConfig() });
-    getConfig = () => scope.get() ?? readEntryConfig();
-    if (typeof sctx?.effect === 'function') {
-      sctx.effect(() => () => { getConfig = readEntryConfig; });
-    }
-  });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.58",
+  "version": "0.8.59",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [