@goodandready/dsh-key-rotation 0.8.54 → 0.8.56

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 0.8.56 - 2026-10-12
+
+### Fixed
+- **Prevent Soft Transient Errors from Triggering Key Quarantine (#473)**:
+  - In `lib/rotate.js`, soft failures (`TIMEOUT`, 5xx, socket disconnects) no longer increment `failCounts` nor trigger the 30-minute `brokenUntil` quarantine.
+  - Synchronized `rotate.js` quarantine checks with `recordFailure` in `lib/pool.js` which deliberately excludes soft failures from exponential penalties.
+  - Added unit test coverage verifying soft failures do not trip quarantine while 3 hard failures correctly trigger recoverable quarantine.
+
+## 0.8.55 - 2026-10-11
+
+### Fixed
+- **Cleaned Dead Exports and Test-Only Smells (#471)**:
+  - Removed unwired exports `getModelTokenUsage` and `getModelTokenRemaining` from `lib/model-quota.js`. Internal logic and status routes use `getModelQuotaStatus(pool, ref, now)`.
+  - Removed test-only export `isSoftFailureCode` from `lib/pool.js`.
+  - Wired `activeModelPools` into `/dsh-key-rotation/status` response keys object as `modelPools`.
+  - Cleaned dead-export and test references across the repository.
+
 ## 0.8.54 - 2026-10-11
 
 ### Added

package/lib/model-quota.js

@@ -139,18 +139,7 @@ function readQuota(pool, ref, quotaResetWindow, now) {
   return { used, resetAt, open: true, stored: true };
 }
 
-/** Tokens consumed by `ref` in `pool` during the current window (0 = none/unlimited). */
-export function getModelTokenUsage(pool, ref, now) {
-  if (getModelTokenLimit(pool, ref) === null) return 0;
-  return readQuota(pool, ref, undefined, now).used;
-}
 
-/** Remaining tokens, or null when the credential is unlimited in this pool. */
-export function getModelTokenRemaining(pool, ref, now) {
-  const limit = getModelTokenLimit(pool, ref);
-  if (limit === null) return null;
-  return Math.max(0, limit - readQuota(pool, ref, undefined, now).used);
-}
 
 /**
  * Quota status for one credential in one model pool (status/health APIs).

package/lib/ops-status.js

@@ -119,6 +119,7 @@ ctx.effect(() => ctx.webServer.register({
           paused: isKeyPaused(pool, ref),
           revoked: isKeyRevoked(pool, ref),
           modelQuota,
+          modelPools: activeModelPools.map(mp => mp.base),
         });
       }
       const basePool = pool.basePool ?? (runtime.index ? basePoolForBase(runtime.index, pool.base) : null);

package/lib/pool.js

@@ -96,11 +96,6 @@ export const SOFT_FAILURE_CODES = new Set([
   'SERVER', 'TIMEOUT', 'TRANSPORT', 'EMPTY_RESPONSE', '500', '502', '503', '504',
 ]);
 
-/** True if failure code or message represents a soft/transient drop. */
-export function isSoftFailureCode(code) {
-  if (!code) return false;
-  return SOFT_FAILURE_CODES.has(String(code).toUpperCase());
-}
 
 /** Ref name validator. Same rule lib/index.js enforces in PUT/DELETE /key. */
 const REF_RE = /^[A-Za-z_][A-Za-z0-9_]*$/;

package/lib/rotate.js

@@ -242,9 +242,10 @@ export function createRotate(deps) {
           }
         } else {
           pool.state.authFailCounts.delete(targetRef);
-          if (!isQuota) {
-            const _fc = (pool.state.failCounts.get(targetRef) ?? 0) + 1;
-            pool.state.failCounts.set(targetRef, _fc);
+          // Soft/transient errors (TIMEOUT, 5xx, socket) do not count toward quarantine (#473).
+          // recordFailure already maintains pool.state.failCounts accurately for non-soft failures.
+          if (!isQuota && !cls.soft) {
+            const _fc = pool.state.failCounts.get(targetRef) ?? 0;
             if (_fc >= 3 && !pool.state.brokenUntil.has(targetRef)) {
               const quarantineMs = 1800000;
               pool.state.brokenUntil.set(targetRef, Date.now() + quarantineMs);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.54",
+  "version": "0.8.56",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [