@goodandready/dsh-key-rotation 0.8.22 → 0.8.23

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to `@goodandready/dsh-key-rotation` are documented here.
 User-facing feature notes also appear in README (en is source of truth).
 
+## 0.8.23 - 2026-09-23
+
+### Fixed
+- **Fix settings cache invalidation on Cordis traceable Proxies (#350)**:
+  - Removed `settings !== owner` reference equality check in `createProviderProfilesReader` (`lib/config-compat.js`). In Cordis, `ctx.get('settings')` creates and returns a fresh traceable `Proxy` wrapper on every single invocation, which was constantly triggering `dirty = true` and invalidating the cache per-request.
+  - Subscribed to `internal/service` event (for service name `'settings'`) alongside `settings/document-updated` to safely invalidate cache upon service replacement without comparing proxy identities.
+  - Added regression test suite verifying that when `ctx.get('settings')` returns a new `Proxy` instance on every call, 100 subsequent invocations of `buildRuntime()` or `readProfiles()` execute strictly 1 call to `settings.get()`.
+
 ## 0.8.22 - 2026-09-23
 
 ### Performance

package/lib/config-compat.js

@@ -45,36 +45,45 @@ export function createConfigReader(config, ctx) {
 // Modern settings owns descriptors rather than the removed get(namespace) API.
 // Cache by document invalidation; clone-producing describe() and tree-materializing
 // settings.get() on 0.1.7+ must not execute on every request.
+// Invalidation occurs strictly on settings/document-updated or internal/service ('settings').
+// Never compare ctx.get('settings') by reference: Cordis wraps services in fresh
+// traceable Proxies on every get() call, which would invalidate the cache on every request.
 export function createProviderProfilesReader(ctx, namespace) {
-  let dirty = true, held = null, owner;
+  let dirty = true, held = null;
   const markDirty = () => { dirty = true; };
   if (typeof ctx?.effect === 'function') {
     ctx.effect(() => ctx.on('settings/document-updated', markDirty));
+    ctx.effect(() => ctx.on('internal/service', (name) => {
+      if (!name || name === 'settings') markDirty();
+    }));
   } else if (typeof ctx?.on === 'function') {
     ctx.on('settings/document-updated', markDirty);
+    ctx.on('internal/service', (name) => {
+      if (!name || name === 'settings') markDirty();
+    });
   }
 
   return () => {
+    if (!dirty) {
+      return held;
+    }
     const settings = ctx?.get?.('settings');
-    if (settings !== owner) { owner = settings; dirty = true; }
     if (!settings) return null;
-    if (dirty) {
-      if (typeof settings.get === 'function') {
-        try {
-          held = settings.get(namespace)?.providers ?? null;
-          dirty = false;
-        } catch (_) {
-          held = null;
-          dirty = false;
-        }
-      } else {
-        try {
-          held = settings.describe({ redactSecrets: true }).find(row => row.ns === namespace)?.value?.providers ?? null;
-          dirty = false;
-        } catch (_) {
-          held = null;
-          dirty = false;
-        }
+    if (typeof settings.get === 'function') {
+      try {
+        held = settings.get(namespace)?.providers ?? null;
+        dirty = false;
+      } catch (_) {
+        held = null;
+        dirty = false;
+      }
+    } else {
+      try {
+        held = settings.describe({ redactSecrets: true }).find(row => row.ns === namespace)?.value?.providers ?? null;
+        dirty = false;
+      } catch (_) {
+        held = null;
+        dirty = false;
       }
     }
     return held;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.22",
+  "version": "0.8.23",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [