@goodandready/dsh-key-rotation 0.8.21 → 0.8.23

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to `@goodandready/dsh-key-rotation` are documented here.
 User-facing feature notes also appear in README (en is source of truth).
 
+## 0.8.23 - 2026-09-23
+
+### Fixed
+- **Fix settings cache invalidation on Cordis traceable Proxies (#350)**:
+  - Removed `settings !== owner` reference equality check in `createProviderProfilesReader` (`lib/config-compat.js`). In Cordis, `ctx.get('settings')` creates and returns a fresh traceable `Proxy` wrapper on every single invocation, which was constantly triggering `dirty = true` and invalidating the cache per-request.
+  - Subscribed to `internal/service` event (for service name `'settings'`) alongside `settings/document-updated` to safely invalidate cache upon service replacement without comparing proxy identities.
+  - Added regression test suite verifying that when `ctx.get('settings')` returns a new `Proxy` instance on every call, 100 subsequent invocations of `buildRuntime()` or `readProfiles()` execute strictly 1 call to `settings.get()`.
+
+## 0.8.22 - 2026-09-23
+
+### Performance
+- **Cache settings and volatile configuration on hot path (#350)**:
+  - Cached `settings.get(PIAI_NS)` calls in `createProviderProfilesReader` (`lib/config-compat.js`) with invalidation on `settings/document-updated`. In DSH 0.1.7-alpha.2+, `settings.get(ns)` materializes the tree via `dsh-config-editor` and `structuredClone`, taking hundreds of milliseconds and blocking the Node.js event loop when called on every request.
+  - Cached `createConfigReader` (`lib/config-compat.js`) across request hot paths using `settings/document-updated`, `loader/volatile-update`, and `config` invalidation listeners, eliminating expensive recursive traversal of volatile config objects on every request.
+  - Added regression test suite verifying N calls to `buildRuntime` without settings modifications yield exactly 1 invocation of `settings.get`.
+
 ## 0.8.21 - 2026-09-23
 
 ### Fixed

package/lib/config-compat.js

@@ -1,7 +1,23 @@
 // Decode modern volatile Config references while retaining stable identities for
 // the request hot path. Legacy cores pass ordinary resolved configuration.
-export function createConfigReader(config) {
+// If ctx is provided, invalidation listeners cache the unwrapped tree so the hot
+// path never recursively walks volatile nodes on unchanged configuration.
+export function createConfigReader(config, ctx) {
   let previous;
+  let dirty = true;
+  if (ctx && typeof ctx.on === 'function') {
+    const markDirty = () => { dirty = true; };
+    if (typeof ctx.effect === 'function') {
+      ctx.effect(() => ctx.on('settings/document-updated', markDirty));
+      ctx.effect(() => ctx.on('loader/volatile-update', markDirty));
+      ctx.effect(() => ctx.on('config', markDirty));
+    } else {
+      ctx.on('settings/document-updated', markDirty);
+      ctx.on('loader/volatile-update', markDirty);
+      ctx.on('config', markDirty);
+    }
+  }
+
   const read = (value, held) => {
     if (value && typeof value.get === 'function') value = value.get();
     if (!value || typeof value !== 'object') return value;
@@ -15,27 +31,60 @@ export function createConfigReader(config) {
     }
     return same ? held : next;
   };
-  return () => (previous = read(config, previous));
+
+  return () => {
+    if (ctx && !dirty && previous !== undefined) {
+      return previous;
+    }
+    previous = read(config, previous);
+    dirty = false;
+    return previous;
+  };
 }
 
 // Modern settings owns descriptors rather than the removed get(namespace) API.
-// Cache by document invalidation; clone-producing describe() must not rebuild
-// every key pool on every request.
+// Cache by document invalidation; clone-producing describe() and tree-materializing
+// settings.get() on 0.1.7+ must not execute on every request.
+// Invalidation occurs strictly on settings/document-updated or internal/service ('settings').
+// Never compare ctx.get('settings') by reference: Cordis wraps services in fresh
+// traceable Proxies on every get() call, which would invalidate the cache on every request.
 export function createProviderProfilesReader(ctx, namespace) {
-  let dirty = true, held = null, owner;
-  ctx.effect(() => ctx.on('settings/document-updated', () => { dirty = true; }));
+  let dirty = true, held = null;
+  const markDirty = () => { dirty = true; };
+  if (typeof ctx?.effect === 'function') {
+    ctx.effect(() => ctx.on('settings/document-updated', markDirty));
+    ctx.effect(() => ctx.on('internal/service', (name) => {
+      if (!name || name === 'settings') markDirty();
+    }));
+  } else if (typeof ctx?.on === 'function') {
+    ctx.on('settings/document-updated', markDirty);
+    ctx.on('internal/service', (name) => {
+      if (!name || name === 'settings') markDirty();
+    });
+  }
+
   return () => {
-    const settings = ctx.get('settings');
-    if (settings !== owner) { owner = settings; dirty = true; }
+    if (!dirty) {
+      return held;
+    }
+    const settings = ctx?.get?.('settings');
     if (!settings) return null;
     if (typeof settings.get === 'function') {
-      try { return settings.get(namespace)?.providers ?? null; } catch (_) { return null; }
-    }
-    if (dirty) {
+      try {
+        held = settings.get(namespace)?.providers ?? null;
+        dirty = false;
+      } catch (_) {
+        held = null;
+        dirty = false;
+      }
+    } else {
       try {
         held = settings.describe({ redactSecrets: true }).find(row => row.ns === namespace)?.value?.providers ?? null;
         dirty = false;
-      } catch (_) { held = null; }
+      } catch (_) {
+        held = null;
+        dirty = false;
+      }
     }
     return held;
   };

package/lib/index.js

@@ -157,7 +157,7 @@ function registerConfigBridge(ctx, getCloneIds) {
 
 export function apply(ctx, config = {}) {
   const logger = getLogger(ctx);
-  const readEntryConfig = createConfigReader(config);
+  const readEntryConfig = createConfigReader(config, ctx);
   getConfig = readEntryConfig;
   const readProfiles = createProviderProfilesReader(ctx, PIAI_NS);
   registerConfigBridge(ctx, () => buildRuntime().cloneIds);
@@ -553,6 +553,8 @@ export function apply(ctx, config = {}) {
     if (typeof settingsSvc?.register !== 'function') return;
     const scope = settingsSvc.register(NS, SettingsSchema, { base: readEntryConfig() });
     getConfig = () => scope.get() ?? readEntryConfig();
-    sctx.effect(() => () => { getConfig = readEntryConfig; });
+    if (typeof sctx?.effect === 'function') {
+      sctx.effect(() => () => { getConfig = readEntryConfig; });
+    }
   });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.21",
+  "version": "0.8.23",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [