@goodandready/dsh-key-rotation 0.8.14 → 0.8.16

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to `@goodandready/dsh-key-rotation` are documented here.
 User-facing feature notes also appear in README (en is source of truth).
 
+## 0.8.16 - 2026-09-20
+
+### Fixed
+- **Header chip translation scope (#330, GitHub #7 / PR #8)**: `KeyRotationHeaderChip` in `lib/client.js` now accepts props and resolves translator `resolveT(props)` before opening popover, preventing `ReferenceError: t is not defined` and fixing disappearance on first click. Header slot registration includes `locale: NS`.
+- **Live bulk key testing & bounded concurrency (#330, GitHub #9 / PR #10)**: "Test all keys" now executes live API probes (`probe: 'models'`) identically to individual testing via unified `runKeyTests()`, eliminating false-positive green status on invalid keys. Requests are serialized (concurrency 1) to avoid bursting endpoints, mutex `testRunRef` guards duplicate clicks, and returned failure error codes (`tr.code`) are displayed in the UI.
+
+## 0.8.15 - 2026-09-20
+
+### Fixed
+- **Settings on the plugin's own page**: the plugin-list seat `plugins.item` is the one
+  the current core (0.1.6-alpha.2) renders as the plugin's page with its configuration;
+  the row seat alone leaves the page without the form. `KeyRotationCard` is now
+  registered there too (`id: 'dsh-key-rotation'`, order 60) with a **static** label —
+  the label is resolved while the page renders, and a locale lookup there aborts the
+  whole client batch. The row seat and the legacy `settings.plugin.item` card stay as
+  fallbacks.
+- The authoring test no longer forbids every hardcoded label: it now requires the
+  list-seat label to be static while the card body keeps using `t(...)`.
+
 ## 0.8.14 - 2026-09-19
 
 ### Fixed

package/lib/client.js

@@ -737,6 +737,7 @@ window.__ModuleLoader__.load({
           }
         };
       }, [confirmModal]);
+      const testRunRef = React.useRef(false);
       const [testing, setTesting] = React.useState('');
       const [testResult, setTestResult] = React.useState({});
       const [testAllProvider, setTestAllProvider] = React.useState('');
@@ -750,30 +751,59 @@ window.__ModuleLoader__.load({
         else if (providers[u.index]) { const keys=[...providers[u.index].keys]; keys.splice(Math.min(u.kIndex, keys.length), 0, u.key); providers[u.index] = { ...providers[u.index], keys }; }
         return { ...cur, providers };
       }); };
-      const doTest = (ref) => {
-        setTesting(ref); setTestResult((m) => ({ ...m, [ref]: null }));
-        // #212: real API probe (models is free on most providers), not just presence
-        fetch('/dsh-key-rotation/test', { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ ref, probe: 'models' }) })
-          .then((r) => r.json())
-          .then((data) => setTestResult((m) => ({ ...m, [ref]: data })))
-          .catch((e) => setTestResult((m) => ({ ...m, [ref]: { ok: false, message: String(e?.message ?? e) } })))
-          .finally(() => setTesting(''));
+      // Both buttons must run the same live probe, never a presence-only check.
+      // Serialize probes: a large pool must not burst /models requests. The ref
+      // also guards repeated clicks before React has rendered disabled buttons.
+      const runKeyTests = async (refs, providerId = '') => {
+        if (testRunRef.current || refs.length === 0) return;
+        testRunRef.current = true;
+        setTestAllProvider(providerId);
+        setTestResult((m) => {
+          const next = { ...m };
+          for (const ref of refs) next[ref] = null;
+          return next;
+        });
+        if (providerId) setTestingProgress((m) => ({ ...m, [providerId]: '0/' + refs.length }));
+        try {
+          let completed = 0;
+          for (const ref of refs) {
+            setTesting(ref);
+            let result;
+            try {
+              const response = await fetch('/dsh-key-rotation/test', {
+                method: 'POST',
+                headers: { 'content-type': 'application/json' },
+                body: JSON.stringify({ ref, probe: 'models' }),
+              });
+              const data = await response.json();
+              if (!response.ok) {
+                result = { ok: false, code: data?.error?.code || ('http-' + response.status),
+                  message: data?.error?.message || data?.message };
+              } else if (typeof data?.ok !== 'boolean') {
+                result = { ok: false, code: 'invalid-response' };
+              } else {
+                result = data;
+              }
+            } catch (e) {
+              result = { ok: false, code: 'error', message: String(e?.message ?? e) };
+            }
+            setTestResult((m) => ({ ...m, [ref]: result }));
+            completed++;
+            if (providerId) setTestingProgress((m) => ({ ...m, [providerId]: completed + '/' + refs.length }));
+          }
+        } finally {
+          setTesting('');
+          setTestAllProvider('');
+          testRunRef.current = false;
+        }
       };
+      const doTest = (ref) => runKeyTests([ref]);
       const doTestAll = (providerId) => {
         if (!val || !Array.isArray(val.providers)) return;
         const entry = val.providers.find((p) => p.provider === providerId);
         if (!entry || !Array.isArray(entry.keys)) return;
-        const refs = entry.keys.filter((k) => k && typeof k === 'string' && k.length > 0);
-        setTestAllProvider(providerId);
-        Promise.all(refs.map((ref) =>
-          fetch('/dsh-key-rotation/test', { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ ref }) })
-            .then((r) => r.json())
-            .then((data) => ({ ref, data }))
-            .catch((e) => ({ ref, data: { ok: false, message: String(e?.message ?? e) } }))
-        )).then((results) => {
-          setTestResult((m) => { const nm = { ...m }; for (const { ref, data } of results) nm[ref] = data; return nm; });
-          setTestAllProvider('');
-        });
+        const refs = [...new Set(entry.keys.filter((k) => typeof k === 'string' && k.trim().length > 0))];
+        return runKeyTests(refs, providerId);
       };
 
       const load = React.useCallback(() => {
@@ -1203,12 +1233,13 @@ window.__ModuleLoader__.load({
           const tr = testResult[key];
           if (tr) meta.push(h('span', { key: 'tr', className: 'krot-tail',
             title: (tr.message || (tr.ok ? t('testOk') : t('testFail')))
+              + (!tr.ok && tr.code ? ' · ' + tr.code : '')
               + (tr.ok && tr.modelsCount ? ' · ' + tr.modelsCount + ' models' : '')
               + (tr.ok && tr.latencyMs ? ' · ' + tr.latencyMs + 'ms' : ''),
             style: { color: tr.ok ? 'var(--dsw-alias-state-success-primary)' : 'var(--dsw-alias-state-error-primary)', fontWeight: 700 } },
-            tr.ok ? (tr.modelsCount ? tr.modelsCount + 'm' : '✓') : '✕'));
+            tr.ok ? (tr.modelsCount ? tr.modelsCount + 'm' : '✓') : ('✕' + (tr.code ? ' ' + tr.code : ''))));
           // #219: last probe from the sandbox cache, greyed when older than 24h
-          else if (probeCache && probeCache[key]) {
+          else if (!Object.prototype.hasOwnProperty.call(testResult, key) && probeCache && probeCache[key]) {
             const pc = probeCache[key];
             const stale = Date.now() - (pc.at ?? 0) > 86400000;
             meta.push(h('span', { key: 'pc', className: 'krot-tail',
@@ -1216,7 +1247,7 @@ window.__ModuleLoader__.load({
               style: { opacity: stale ? 0.4 : 0.7, color: pc.ok ? 'var(--dsw-alias-state-success-primary)' : 'var(--dsw-alias-state-error-primary)' } },
               (pc.ok ? '✓' : '✕') + (pc.latencyMs ? ' ' + pc.latencyMs + 'ms' : '')));
           }
-          meta.push(h('button', { key: 't', className: 'krot-btn', onClick: () => doTest(key), disabled: testing === key, title: t('testKey') }, testing === key ? '…' : t('testKey')));
+          meta.push(h('button', { key: 't', className: 'krot-btn', onClick: () => doTest(key), disabled: Boolean(testing || testAllProvider), title: t('testKey') }, testing === key ? '…' : t('testKey')));
           // #223: broken keys get a one-click live re-test + auto-unbreak
           if (info && info.broken) {
             meta.push(h('button', { key: 'rt', className: 'krot-btn', onClick: () => retestBroken(key), title: t('retestBroken') }, t('retestBroken')));
@@ -1429,7 +1460,7 @@ window.__ModuleLoader__.load({
               danger: false,
               onConfirm: () => doReset(entry.provider),
             }), { disabled: !(providerStatus && providerStatus.switches > 0) || resetting === entry.provider, title: t('resetCooldown') }),
-            btn(testAllProvider === entry.provider ? (testingProgress[entry.provider] ? t('testingAllProgress').replace('{n}', testingProgress[entry.provider].split('/')[0]).replace('{total}', testingProgress[entry.provider].split('/')[1]) : t('testing')) : t('testAll'), () => doTestAll(entry.provider), { disabled: testAllProvider === entry.provider, title: t('testAll') }),
+            btn(testAllProvider === entry.provider ? (testingProgress[entry.provider] ? t('testingAllProgress').replace('{n}', testingProgress[entry.provider].split('/')[0]).replace('{total}', testingProgress[entry.provider].split('/')[1]) : t('testing')) : t('testAll'), () => doTestAll(entry.provider), { disabled: Boolean(testing || testAllProvider), title: t('testAll') }),
             exportCsv,
           ),
         );
@@ -1701,7 +1732,8 @@ window.__ModuleLoader__.load({
     // #201 header chip: one dot + counts for all pools. Green = all healthy,
     // amber = some keys cooling, red = a pool fully exhausted. Click opens the
     // same summary the floating dashboard shows.
-    function KeyRotationHeaderChip() {
+    function KeyRotationHeaderChip(props) {
+      const t = resolveT(props);
       const [snap, setSnap] = React.useState(null);
       const [open, setOpen] = React.useState(false);
       const ref = React.useRef(null);
@@ -1747,7 +1779,7 @@ window.__ModuleLoader__.load({
         h('button', {
           type: 'button',
           className: 'krot-header-chip',
-          title: 'Key Rotation',
+          title: t('title'),
           onClick: () => setOpen((v) => !v),
         },
           h('span', { style: { width: '8px', height: '8px', borderRadius: '50%', background: color, flex: 'none', boxShadow: `0 0 6px ${color}` } }),
@@ -1756,7 +1788,7 @@ window.__ModuleLoader__.load({
         ),
         open ? h('div', { className: 'krot-popover' },
           h('div', { className: 'krot-pop-title' }, t('headerPoolsTitle')),
-          !poolEntries.length ? h('div', { style: { fontSize: '12px', color: 'var(--dsw-alias-label-tertiary)' } }, 'No active pools') : null,
+          !poolEntries.length ? h('div', { style: { fontSize: '12px', color: 'var(--dsw-alias-label-tertiary)' } }, t('noActivePools')) : null,
           poolEntries.map(([name, p]) => {
             const c = p.exhausted ? 'var(--dsw-alias-state-error-primary)' : (p.healthy < p.total ? 'var(--dsw-alias-state-warning-primary)' : 'var(--dsw-alias-state-success-primary)');
             return h('div', { key: name, className: 'krot-pop-row' },
@@ -1780,7 +1812,7 @@ window.__ModuleLoader__.load({
         try {
           ctx.slots.inject('conversation.session.header.utilities', () =>
             ctx.slots.register(
-              { name: 'conversation.session.header.utilities', id: 'dsh-key-rotation-header-chip', order: 6 },
+              { name: 'conversation.session.header.utilities', id: 'dsh-key-rotation-header-chip', order: 6, locale: NS },
               KeyRotationHeaderChip,
             ));
         } catch { /* slot not available in this build */ }
@@ -1815,8 +1847,17 @@ window.__ModuleLoader__.load({
       }
       // #275: card only — no top-level sidebar row. The host sidebar is a
       // shared flat list; a duplicate row wastes a slot and confuses Settings.
-      // Row seat first (the seat the current core renders), legacy seat after it.
+      // Plugin-list seat (plugins.item) first: it is what the current core
+      // (0.1.6-alpha.2) renders as the plugin's own page with its configuration. The
+      // label is a static string on purpose — it is resolved while the page renders,
+      // and a locale lookup there would take the whole client batch down with it.
       try {
+        ctx.slots.inject('plugins.item', () =>
+          ctx.slots.register(
+            { name: 'plugins.item', id: ROW_ID, order: 60, label: () => 'Key Rotation', locale: NS, inject: () => ({ ctx }) },
+            KeyRotationCard,
+          ));
+        // Row seat and the legacy seat stay as fallbacks.
         ctx.slots.inject('plugins.row.config', () =>
           ctx.slots.register(
             { name: 'plugins.row.config', key: ROW_CONFIG_KEY, locale: NS, inject: () => ({ ctx }) },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-key-rotation",
-  "version": "0.8.14",
+  "version": "0.8.16",
   "packageManager": "pnpm@10.33.2",
   "description": "Per-provider API key rotation for DeepSeek Harness: a key pool per provider, auto-created clone routes, and switching to the next key on quota/rate-limit errors. Includes a Settings section (Key Rotation) to edit the key pools, cooldown and switch codes.",
   "keywords": [