@goodandready/dsh-goal 0.2.30 → 0.2.32

package/lib/goal-engine-constants.js

@@ -192,6 +192,12 @@ export function buildSnapshot(goal, sid, engine) {
       enableMilestoneDependencies: engine.enableMilestoneDependencies ?? true,
       soundScheme: engine.soundScheme ?? 'default',
       enableVoiceAnnouncements: engine.enableVoiceAnnouncements ?? false,
+      enableMilestoneCompaction: engine.enableMilestoneCompaction ?? true,
+      parentGoalId: null,
+      parentSessionId: null,
+      isSubGoal: false,
+      subGoals: [],
+      breadcrumbs: [],
       operatorQuery: null,
       waitingForOperator: false,
     };
@@ -253,6 +259,12 @@ export function buildSnapshot(goal, sid, engine) {
     enableMilestoneDependencies: engine.enableMilestoneDependencies ?? true,
     soundScheme: engine.soundScheme ?? 'default',
     enableVoiceAnnouncements: engine.enableVoiceAnnouncements ?? false,
+    enableMilestoneCompaction: engine.enableMilestoneCompaction ?? true,
+    parentGoalId: goal.parentGoalId || null,
+    parentSessionId: goal.parentSessionId || null,
+    isSubGoal: Boolean(goal.parentGoalId || goal.isSubGoal),
+    subGoals: Array.isArray(goal.subGoals) ? goal.subGoals : [],
+    breadcrumbs: typeof engine.getSubGoalBreadcrumbs === "function" ? engine.getSubGoalBreadcrumbs(sid) : [],
     operatorQuery: goal.operatorQuery || null,
     waitingForOperator: Boolean(goal.waitingForOperator),
   };

package/lib/goal-engine.js

@@ -1,4 +1,6 @@
 import { verifyMilestoneAcceptance } from './engine-verification.js';
+import { getEngineGoalDiff } from './engine-diff.js';
+import { syncGoalToKanban, syncMilestoneStatusToKanban, handleKanbanCardMoved } from './engine-kanban-sync.js';
 import { askOperatorQuery, answerOperatorQuery } from './engine-operator-query.js';
 import { GoalMode, GoalState, MilestoneStatus, formatElapsed, formatETA, detectLanguage, sessionIdOf, calculateElapsedSeconds, calculateRemainingSeconds, buildSnapshot, getSafeCwd } from './goal-engine-constants.js';
 import { getGitCurrentCommit, exportReportMarkdown, exportReportGitHubPR, createMilestoneCheckpoint, rollbackToCheckpoint, saveGoalArtifact } from './engine-reports.js';
@@ -11,8 +13,10 @@ import { parseIssueRef, parseIssueChecklist, syncMilestoneWithIssue } from './en
 import { generateRetrospectiveData } from './engine-retrospective.js';
 import { generatePreplanDraft } from './engine-templates.js';
 import { pruneInactiveSessions, addNudgeToGoal, consumeGoalNudge, extendGoalBudget, setGoalMode, pauseGoal, resumeGoal, cancelGoal } from './engine-sessions.js';
+import { compactMilestone, estimateCompactionSavings } from './engine-compaction.js';
+import { spawnSubGoal, completeSubGoal, syncSubGoalToParent, getSubGoalBreadcrumbs, getSubGoalsList } from './engine-subgoals.js';
 
-export { GoalMode, GoalState, MilestoneStatus, formatElapsed, formatETA, detectLanguage, sessionIdOf, matchMilestone, parseIssueChecklist, getGitCurrentCommit, exportReportMarkdown, exportReportGitHubPR, createMilestoneCheckpoint, rollbackToCheckpoint, saveGoalArtifact };
+export { GoalMode, GoalState, MilestoneStatus, formatElapsed, formatETA, detectLanguage, sessionIdOf, matchMilestone, parseIssueChecklist, getGitCurrentCommit, exportReportMarkdown, exportReportGitHubPR, createMilestoneCheckpoint, rollbackToCheckpoint, saveGoalArtifact, compactMilestone, estimateCompactionSavings, spawnSubGoal, completeSubGoal, getSubGoalBreadcrumbs, getSubGoalsList };
 
 /**
  * Isolated Goal Management Engine for DeepSeek Harness
@@ -31,8 +35,8 @@ export class GoalEngine {
       enableLiveActivityFeed: options.enableLiveActivityFeed ?? true, enablePreplanning: options.enablePreplanning ?? true,
       autoBranchOnGoalStart: options.autoBranchOnGoalStart ?? true, enablePostGoalRetrospective: options.enablePostGoalRetrospective ?? true,
       autoScaleBudgetNearCompletion: options.autoScaleBudgetNearCompletion ?? false, enableTemplatesDrawer: options.enableTemplatesDrawer ?? true,
-      enableMilestoneDependencies: options.enableMilestoneDependencies ?? true, soundScheme: options.soundScheme ?? 'default',
-      enableVoiceAnnouncements: options.enableVoiceAnnouncements ?? false, approvalGate: options.approvalGate || null,
+      enableMilestoneDependencies: options.enableMilestoneDependencies ?? true, soundScheme: options.soundScheme ?? 'default', enableKanbanSync: options.enableKanbanSync ?? true, ctx: options.ctx || null, kanbanService: options.kanbanService || null, kanbanStore: options.kanbanStore || null,
+      enableVoiceAnnouncements: options.enableVoiceAnnouncements ?? false, enableMilestoneCompaction: options.enableMilestoneCompaction ?? true, approvalGate: options.approvalGate || null,
       checkApproval: options.checkApproval || null, maxSessions: options.maxSessions ?? 100,
     });
     this.goals = new Map();
@@ -56,10 +60,7 @@ export class GoalEngine {
   flushSync() { this.store.flushSync(); }
   saveStateToDisk() { this.flushSync(); }
 
-  subscribe(callback) {
-    this.listeners.add(callback);
-    return () => this.listeners.delete(callback);
-  }
+  subscribe(callback) { this.listeners.add(callback); return () => this.listeners.delete(callback); }
 
   emit(sessionId = 'default', immediate = false) {
     this.scheduleSave(immediate);
@@ -74,21 +75,9 @@ export class GoalEngine {
     }
   }
 
-  recordProgress(sessionId = 'default') {
-    this.stallCounters.set(sessionId || 'default', 0);
-  }
-
-  incrementStallCount(sessionId = 'default') {
-    const sid = sessionId || 'default';
-    const current = this.stallCounters.get(sid) || 0;
-    const next = current + 1;
-    this.stallCounters.set(sid, next);
-    return next;
-  }
-
-  getStallCount(sessionId = 'default') {
-    return this.stallCounters.get(sessionId || 'default') || 0;
-  }
+  recordProgress(sessionId = 'default') { this.stallCounters.set(sessionId || 'default', 0); }
+  incrementStallCount(sessionId = 'default') { const sid = sessionId || 'default'; const n = (this.stallCounters.get(sid) || 0) + 1; this.stallCounters.set(sid, n); return n; }
+  getStallCount(sessionId = 'default') { return this.stallCounters.get(sessionId || 'default') || 0; }
 
   updateConfig(config = {}) {
     const rawMax = config.defaultMaxIterations ?? config.maxIterations;
@@ -102,7 +91,7 @@ export class GoalEngine {
         }
       }
     }
-    const boolKeys = ['autoDrive', 'enableSound', 'showQuickLaunchButton', 'autoCheckpointOnMilestone', 'enableLiveActivityFeed', 'enablePreplanning', 'autoBranchOnGoalStart', 'enablePostGoalRetrospective', 'autoScaleBudgetNearCompletion', 'enableTemplatesDrawer', 'enableMilestoneDependencies', 'enableVoiceAnnouncements'];
+    const boolKeys = ['autoDrive', 'enableSound', 'showQuickLaunchButton', 'autoCheckpointOnMilestone', 'enableLiveActivityFeed', 'enablePreplanning', 'autoBranchOnGoalStart', 'enablePostGoalRetrospective', 'autoScaleBudgetNearCompletion', 'enableTemplatesDrawer', 'enableMilestoneDependencies', 'enableVoiceAnnouncements', 'enableMilestoneCompaction'];
     for (const k of boolKeys) if (typeof config[k] === 'boolean') this[k] = config[k];
     if (typeof config.consecutiveToolFailureLimit === 'number') this.consecutiveToolFailureLimit = Math.max(0, config.consecutiveToolFailureLimit);
     if (typeof config.maxTokenBudget === 'number') this.maxTokenBudget = Math.max(0, config.maxTokenBudget);
@@ -180,7 +169,7 @@ export class GoalEngine {
       title: cleanTitle,
       description: options.description?.trim() || '',
       lang: options.lang || detectLanguage(cleanTitle),
-      cwd: options.cwd ? getSafeCwd(options.cwd) : null,
+      cwd: options.cwd ? getSafeCwd(options.cwd, options.allowedRoots || this.allowedRoots || []) : null,
       mode: initialMode,
       state: initialState,
       startedAt: now,
@@ -193,7 +182,7 @@ export class GoalEngine {
       budgetWarningTriggered: false,
       budgetAutoScaled: false,
       gitStartCommit: gitCommit || null,
-      gitBranch: null,
+      gitBranch: options.gitBranch || options.branchName || null,
       gitParentBranch: null,
       pendingNudge: null,
       nudges: [],
@@ -206,6 +195,10 @@ export class GoalEngine {
       issueRef: parseIssueRef(cleanTitle),
       operatorQuery: null,
       waitingForOperator: false,
+      parentGoalId: options.parentGoalId || null,
+      parentSessionId: options.parentSessionId || null,
+      isSubGoal: Boolean(options.parentGoalId),
+      subGoals: [],
       tokensUsage: { promptTokens: 0, completionTokens: 0, totalTokens: 0 },
       logs: [{
         timestamp: now,
@@ -303,19 +296,18 @@ export class GoalEngine {
         m.status = MilestoneStatus.COMPLETED;
       }
     }
+    if (goal.parentSessionId) syncSubGoalToParent(this, sid, summary);
     this.stallCounters.delete(sid);
     this.toolFailureCounters.delete(sid);
     this.emit(sid, true);
     return this.getSnapshot(sid);
   }
 
-  setMilestones(milestonesList, sessionId = 'default') {
-    this.addMilestones(milestonesList, true, sessionId);
-    return this.getSnapshot(sessionId);
-  }
+  setMilestones(milestonesList, sessionId = 'default') { this.addMilestones(milestonesList, true, sessionId); return this.getSnapshot(sessionId); }
 
   addMilestones(milestonesList, shouldEmit = true, sessionId = 'default') {
-    const sid = sessionId || 'default';
+    const sid = typeof shouldEmit === 'string' ? shouldEmit : (sessionId || 'default');
+    const shouldEmitFlag = typeof shouldEmit === 'boolean' ? shouldEmit : true;
     const goal = this.goals.get(sid);
     if (!goal || !Array.isArray(milestonesList)) return [];
 
@@ -325,7 +317,7 @@ export class GoalEngine {
     }
     this.recordProgress(sid);
     recordActivity(goal, { type: 'milestone', tool: 'addMilestones', status: 'success', details: `Added ${newMilestones.length} milestones` });
-    if (shouldEmit) this.emit(sid);
+    if (shouldEmitFlag) this.emit(sid);
     return newMilestones;
   }
 
@@ -359,8 +351,10 @@ export class GoalEngine {
 
     const prevStatus = res.prevStatus;
     recordActivity(goal, { type: 'milestone', tool: 'updateMilestone', status: 'success', details: `${id} -> ${status}` });
+    if (this.enableKanbanSync) syncMilestoneStatusToKanban(target, { goal, ctx: this.ctx, store: this.kanbanStore, kanbanService: this.kanbanService }).catch(() => {});
 
     if (target.status === MilestoneStatus.COMPLETED && prevStatus !== MilestoneStatus.COMPLETED) {
+      if (this.enableMilestoneCompaction !== false) compactMilestone(target, { goal, cwd: goal.cwd });
       if (this.autoCheckpointOnMilestone) {
         const commitHash = createMilestoneCheckpoint(target, sid);
         if (commitHash) {
@@ -435,9 +429,7 @@ export class GoalEngine {
     return true;
   }
 
-  getElapsedSeconds(sessionId = 'default') {
-    return calculateElapsedSeconds(this.goals.get(sessionId || 'default'));
-  }
+  getElapsedSeconds(sessionId = 'default') { return calculateElapsedSeconds(this.goals.get(sessionId || 'default')); }
 
   addTokenUsage(usage, sessionId = 'default') {
     if (!usage || typeof usage !== 'object') return;
@@ -467,19 +459,9 @@ export class GoalEngine {
     this.emit(sid);
   }
 
-  getEstimatedRemainingSeconds(sessionId = 'default') {
-    const sid = sessionId || 'default';
-    return calculateRemainingSeconds(this.goals.get(sid), this.getElapsedSeconds(sid));
-  }
-
-  getSnapshot(sessionId = 'default') {
-    const sid = sessionId || 'default';
-    return buildSnapshot(this.goals.get(sid), sid, this);
-  }
-
-  getGoalSnapshot(sessionId = 'default') {
-    return this.getSnapshot(sessionId);
-  }
+  getEstimatedRemainingSeconds(sessionId = 'default') { const sid = sessionId || 'default'; return calculateRemainingSeconds(this.goals.get(sid), this.getElapsedSeconds(sid)); }
+  getSnapshot(sessionId = 'default') { const sid = sessionId || 'default'; return buildSnapshot(this.goals.get(sid), sid, this); }
+  getGoalSnapshot(sessionId = 'default') { return this.getSnapshot(sessionId); }
 
   getStatePromptInjection(sessionId = 'default') {
     const sid = sessionId || 'default';
@@ -579,8 +561,17 @@ export class GoalEngine {
     return res;
   }
 
+  getDiff(sessionId = 'default', options = {}) { return getEngineGoalDiff(this, sessionId, options); }
+  syncKanban(sessionId = 'default', options = {}) { return syncGoalToKanban(this, sessionId, options); }
+  handleKanbanCardMove(payload = {}, sessionId = 'default') { return handleKanbanCardMoved(this, payload, sessionId); }
+
   isPlanMode(sessionId = 'default') {
     const goal = this.goals.get(sessionId || 'default');
     return Boolean(goal && (goal.mode === GoalMode.PLAN || goal.state === GoalState.PLANNING));
   }
+  spawnSubGoal(options = {}, sessionId = 'default') { return spawnSubGoal(this, sessionId, options); }
+  completeSubGoal(sessionId, summary = '') { return completeSubGoal(this, sessionId, summary); }
+  getSubGoals(sessionId = 'default') { return getSubGoalsList(this, sessionId); }
+  getSubGoalBreadcrumbs(sessionId = 'default') { return getSubGoalBreadcrumbs(this, sessionId); }
+  getCompactionSavings(sessionId = 'default') { const g = this.goals.get(sessionId || 'default'); return estimateCompactionSavings(g?.milestones || [], g?.lang || 'en'); }
 }

package/lib/index.js

@@ -143,13 +143,6 @@ export function apply(ctx, config = {}) {
     logger.warn?.('[dsh-goal] Legacy migration check failed:', migErr.message);
   }
 
-  // Register addon tools: goal_milestones and goal_checklist
-  registerTools(ctx, {
-    milestoneManager,
-    goalsService: safeService(ctx, "goals"),
-    logger,
-  });
-
   // Support fallback engine for tests or non-core environments
   let fallbackEngine = null;
   if (!safeService(ctx, "goals")) {
@@ -168,12 +161,22 @@ export function apply(ctx, config = {}) {
       autoScaleBudgetNearCompletion: currentSettings.autoScaleBudgetNearCompletion,
       enableTemplatesDrawer: currentSettings.enableTemplatesDrawer,
       enableMilestoneDependencies: currentSettings.enableMilestoneDependencies,
+      enableMilestoneCompaction: currentSettings.enableMilestoneCompaction,
       approvalGate: safeService(ctx, "approvalGate"),
       logger,
     });
+    ctx.goalEngine = fallbackEngine;
     registerPlanModeGuard(ctx, { engine: fallbackEngine, logger });
   }
 
+  // Register addon tools: goal_milestones, goal_checklist, goal_spawn_subgoal
+  registerTools(ctx, {
+    milestoneManager,
+    goalsService: safeService(ctx, "goals"),
+    engine: fallbackEngine,
+    logger,
+  });
+
   // 1. One-click auto-updater registration (Issue #99)
   if (ctx?.webServer?.register) {
     if (typeof ctx?.effect === 'function') {

package/lib/routes.js

@@ -383,6 +383,28 @@ export function registerRoutes(ctx, {
           }));
         }
 
+        // GET /dsh-goal/diff
+        if (req.method === 'GET' && (pathname === '/dsh-goal/diff' || pathname === '/dsh-goal/diff/')) {
+          const rejection = getRequestRejection(req, { ctx });
+          if (rejection !== undefined) {
+            res.statusCode = rejection;
+            return res.end(JSON.stringify({ error: rejection === 401 ? 'Unauthorized: authentication required' : 'Forbidden: untrusted caller origin' }));
+          }
+          const sid = sessionIdOf(req, 'default');
+          const target = url.searchParams.get('target') || undefined;
+          const base = url.searchParams.get('base') || undefined;
+          const file = url.searchParams.get('file') || undefined;
+          const cwd = url.searchParams.get('cwd') || undefined;
+
+          if (engine) {
+            const diffResult = engine.getDiff(sid, { target, base, file, cwd });
+            res.statusCode = diffResult.ok ? 200 : 400;
+            return res.end(JSON.stringify(diffResult));
+          }
+          res.statusCode = 404;
+          return res.end(JSON.stringify({ ok: false, error: 'Goal engine unavailable' }));
+        }
+
         // POST /dsh-goal/action
         // CSRF & Same-Origin guard
         if (req.method === 'POST' && (pathname === '/dsh-goal/action' || pathname === '/dsh-goal/action/')) {
@@ -429,7 +451,7 @@ export function registerRoutes(ctx, {
             body += chunk;
           };
 
-          const onEnd = () => {
+          const onEnd = async () => {
             if (limitExceeded) return;
             try {
               const data = JSON.parse(body || '{}');
@@ -829,6 +851,53 @@ export function registerRoutes(ctx, {
                   res.statusCode = 200;
                   return res.end(JSON.stringify({ ok: true, templates: getTemplatesCatalogue() }));
 
+                case 'kanban_move': {
+                  if (engine) {
+                    result = engine.handleKanbanCardMove(data, sid);
+                    if (!result.ok) res.statusCode = 400;
+                  } else {
+                    res.statusCode = 404;
+                    result = { ok: false, error: 'Goal engine unavailable' };
+                  }
+                  break;
+                }
+
+                case 'kanban_sync': {
+                  if (engine) {
+                    result = await engine.syncKanban(sid, { ctx });
+                    if (!result.ok && !result.skipped) res.statusCode = 400;
+                  } else {
+                    res.statusCode = 404;
+                    result = { ok: false, error: 'Goal engine unavailable' };
+                  }
+                  break;
+                }
+
+                case 'spawn_subgoal': {
+                  const subTitle = typeof data.title === 'string' ? data.title.trim() : '';
+                  if (!subTitle) {
+                    res.statusCode = 400;
+                    return res.end(JSON.stringify({ error: 'Sub-goal title is required' }));
+                  }
+                  if (engine) {
+                    const spawnRes = engine.spawnSubGoal({
+                      title: subTitle,
+                      prompt: data.prompt || data.description,
+                      maxIterations: data.maxIterations ?? data.max_iterations,
+                      inheritContext: data.inheritContext ?? data.inherit_context,
+                    }, sid);
+                    if (!spawnRes.ok) {
+                      res.statusCode = 400;
+                      return res.end(JSON.stringify({ error: spawnRes.error || 'Failed to spawn sub-goal' }));
+                    }
+                    result = spawnRes;
+                  } else {
+                    res.statusCode = 404;
+                    result = { ok: false, error: 'Goal engine unavailable' };
+                  }
+                  break;
+                }
+
                 case 'instantiate_template': {
                   const tplId = data.templateId || data.id;
                   if (!tplId) {
@@ -870,6 +939,7 @@ export function registerRoutes(ctx, {
           '/dsh-goal/events': ['GET'],
           '/dsh-goal/templates': ['GET'],
           '/dsh-goal/state': ['GET'],
+          '/dsh-goal/diff': ['GET'],
           '/dsh-goal/action': ['POST'],
         };
         const cleanPath = pathname.replace(/\/+$/, '') || '/';

package/lib/tools.js

@@ -376,5 +376,74 @@ export function registerTools(ctx, { milestoneManager, goalsService, logger = co
       output: JSON_OUTPUT,
       execute: handleGoalAskOperator,
     });
+
+    // Tool 7: goal_spawn_subgoal (Issue #170)
+    const handleGoalSpawnSubgoal = async (args = {}, toolCtx = {}) => {
+      const parentSessionId = args.goalId || args.goal_id || resolveGoalId(toolCtx);
+      const title = args.title || args.goal;
+      if (!title || typeof title !== 'string' || !title.trim()) {
+        throw new Error('Field "title" is required and must be a non-empty string');
+      }
+
+      const engine = ctx.goalEngine || (ctx.get && ctx.get('goalEngine'));
+      if (engine && typeof engine.spawnSubGoal === 'function') {
+        const res = engine.spawnSubGoal({
+          title: title.trim(),
+          prompt: args.prompt || args.description,
+          maxIterations: args.max_iterations ?? args.maxIterations,
+          inheritContext: args.inherit_context ?? args.inheritContext,
+        }, parentSessionId);
+
+        if (!res.ok) {
+          throw new Error(`Failed to spawn sub-goal: ${res.error}`);
+        }
+
+        return {
+          ok: true,
+          parentGoalId: res.parentGoalId,
+          parentSessionId: res.parentSessionId,
+          subGoalId: res.subGoalId,
+          childSessionId: res.childSessionId,
+          title: title.trim(),
+          message: 'Sub-goal spawned with isolated execution context. Complete sub-milestones and invoke goal_finish to conclude.',
+        };
+      }
+
+      return {
+        ok: true,
+        parentSessionId,
+        title: title.trim(),
+        message: 'Sub-goal registered (fallback mode).',
+      };
+    };
+
+    safeRegister({
+      name: 'goal_spawn_subgoal',
+      description: 'Spawn a child sub-goal with isolated context and task checklist (#170). When all sub-milestones are completed, invoking goal_finish returns deliverables and control to the parent goal.',
+      parameters: {
+        type: 'object',
+        properties: {
+          title: {
+            type: 'string',
+            description: 'Clear, actionable title of the sub-goal',
+          },
+          prompt: {
+            type: 'string',
+            description: 'Optional context, detailed instructions, or constraints for the sub-goal',
+          },
+          max_iterations: {
+            type: 'number',
+            description: 'Maximum iteration budget for the sub-goal (default: 15)',
+          },
+          inherit_context: {
+            type: 'boolean',
+            description: 'Whether the child sub-goal inherits parent goal context summary (default: true)',
+          },
+        },
+        required: ['title'],
+      },
+      output: JSON_OUTPUT,
+      execute: handleGoalSpawnSubgoal,
+    });
   });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-goal",
-  "version": "0.2.30",
+  "version": "0.2.32",
   "description": "Core Goal Addon (Token Budget, Milestones, Git Snapshots & Retrospective Reports) for DeepSeek Harness",
   "type": "module",
   "main": "./lib/index.js",