@goodandready/dsh-goal 0.2.17 → 0.2.18

package/lib/card-form-state.js

@@ -10,9 +10,19 @@ export const DEFAULT_SETTINGS = {
   showQuickLaunchButton: true,
   consecutiveToolFailureLimit: 3,
   enableBrowserNotifications: true,
+  maxTokenBudget: 0,
+  budgetWarningThreshold: 80,
+  autoCheckpointOnMilestone: false,
   storagePath: '',
 };
 
+export const NUMERIC_FIELDS = {
+  maxIterations: 1,
+  consecutiveToolFailureLimit: 0,
+  maxTokenBudget: 0,
+  budgetWarningThreshold: 0,
+};
+
 /**
  * Parse numeric settings field:
  * - empty string / null / undefined -> undefined (reset override)
@@ -50,28 +60,14 @@ export function getFieldStatus(field, draftValue, snap) {
   let invalid = false;
   let isDirty = false;
 
-  if (field === 'maxIterations') {
+  if (field in NUMERIC_FIELDS) {
     if (draftValue !== undefined) {
       if (draftValue === '') {
         invalid = false;
         isDirty = userVal !== undefined;
       } else {
-        const parsed = parseNumberField(draftValue, 1);
-        if (Number.isNaN(parsed)) {
-          invalid = true;
-          isDirty = true;
-        } else {
-          isDirty = parsed !== (userVal !== undefined ? userVal : baseVal);
-        }
-      }
-    }
-  } else if (field === 'consecutiveToolFailureLimit') {
-    if (draftValue !== undefined) {
-      if (draftValue === '') {
-        invalid = false;
-        isDirty = userVal !== undefined;
-      } else {
-        const parsed = parseNumberField(draftValue, 0);
+        const min = NUMERIC_FIELDS[field];
+        const parsed = parseNumberField(draftValue, min);
         if (Number.isNaN(parsed)) {
           invalid = true;
           isDirty = true;
@@ -86,7 +82,7 @@ export function getFieldStatus(field, draftValue, snap) {
       isDirty = cleanVal !== (userVal !== undefined ? userVal : (baseVal || ''));
     }
   } else {
-    // boolean fields (autoDrive, enableSound, showQuickLaunchButton, enableBrowserNotifications)
+    // boolean fields (autoDrive, enableSound, showQuickLaunchButton, enableBrowserNotifications, autoCheckpointOnMilestone)
     if (draftValue !== undefined) {
       isDirty = Boolean(draftValue) !== (userVal !== undefined ? Boolean(userVal) : Boolean(baseVal));
     }
@@ -119,6 +115,9 @@ export function computeSavePlan(draft, snap) {
     'showQuickLaunchButton',
     'consecutiveToolFailureLimit',
     'enableBrowserNotifications',
+    'maxTokenBudget',
+    'budgetWarningThreshold',
+    'autoCheckpointOnMilestone',
     'storagePath',
   ];
 
@@ -129,17 +128,11 @@ export function computeSavePlan(draft, snap) {
     if (status.invalid) continue;
 
     if (status.isDirty) {
-      if (f === 'maxIterations') {
-        if (draft[f] === '') {
-          writes.push([f, undefined]);
-        } else {
-          writes.push([f, parseNumberField(draft[f], 1)]);
-        }
-      } else if (f === 'consecutiveToolFailureLimit') {
+      if (f in NUMERIC_FIELDS) {
         if (draft[f] === '') {
           writes.push([f, undefined]);
         } else {
-          writes.push([f, parseNumberField(draft[f], 0)]);
+          writes.push([f, parseNumberField(draft[f], NUMERIC_FIELDS[f])]);
         }
       } else if (f === 'storagePath') {
         const clean = typeof draft[f] === 'string' ? draft[f].trim() : '';

package/lib/client.js

@@ -3794,153 +3794,125 @@ window.__ModuleLoader__.load({
     // --- SETTINGS FORM LOGIC ---
 
     const DEFAULT_SETTINGS = {
-
       maxIterations: 25,
-
       autoDrive: true,
-
       enableSound: true,
-
       showQuickLaunchButton: true,
-
       consecutiveToolFailureLimit: 3,
-
       enableBrowserNotifications: true,
-
+      maxTokenBudget: 0,
+      budgetWarningThreshold: 80,
+      autoCheckpointOnMilestone: false,
+      storagePath: '',
     };
 
-    function parseNumberField(raw) {
+    const NUMERIC_FIELDS = {
+      maxIterations: 1,
+      consecutiveToolFailureLimit: 0,
+      maxTokenBudget: 0,
+      budgetWarningThreshold: 0,
+    };
 
+    function parseNumberField(raw, min = 1) {
       if (raw === '' || raw === null || raw === undefined) {
-
         return undefined;
-
       }
-
       const n = Number(raw);
-
-      if (!Number.isFinite(n) || n < 1 || !Number.isInteger(n)) {
-
+      if (!Number.isFinite(n) || n < min || !Number.isInteger(n)) {
         return NaN;
-
       }
-
       return n;
-
     }
 
     function getFieldStatus(field, draftValue, snap) {
-
       const baseVal = snap?.base?.[field] ?? DEFAULT_SETTINGS[field];
-
       const userVal = snap?.user?.[field];
-
       const effectiveVal = snap?.value?.[field] ?? baseVal;
 
       const isOverridden = userVal !== undefined && userVal !== null;
-
       const currentVal = draftValue !== undefined ? draftValue : effectiveVal;
 
       let invalid = false;
-
       let isDirty = false;
 
-      if (field === 'maxIterations') {
-
+      if (field in NUMERIC_FIELDS) {
         if (draftValue !== undefined) {
-
           if (draftValue === '') {
-
             invalid = false;
-
             isDirty = userVal !== undefined;
-
           } else {
-
-            const parsed = parseNumberField(draftValue);
-
+            const min = NUMERIC_FIELDS[field];
+            const parsed = parseNumberField(draftValue, min);
             if (Number.isNaN(parsed)) {
-
               invalid = true;
-
               isDirty = true;
-
             } else {
-
               isDirty = parsed !== (userVal !== undefined ? userVal : baseVal);
-
             }
-
           }
-
         }
-
+      } else if (field === 'storagePath') {
+        if (draftValue !== undefined) {
+          const cleanVal = typeof draftValue === 'string' ? draftValue.trim() : '';
+          isDirty = cleanVal !== (userVal !== undefined ? userVal : (baseVal || ''));
+        }
       } else {
-
         if (draftValue !== undefined) {
-
           isDirty = Boolean(draftValue) !== (userVal !== undefined ? Boolean(userVal) : Boolean(baseVal));
-
         }
-
       }
 
       return {
-
         value: currentVal,
-
         baseValue: baseVal,
-
         userValue: userVal,
-
         isOverridden,
-
         isDirty,
-
         invalid,
-
       };
-
     }
 
     function computeSavePlan(draft, snap) {
-
       if (!draft) return [];
 
-      const fields = ['maxIterations', 'autoDrive', 'enableSound', 'showQuickLaunchButton'];
+      const fields = [
+        'maxIterations',
+        'autoDrive',
+        'enableSound',
+        'showQuickLaunchButton',
+        'consecutiveToolFailureLimit',
+        'enableBrowserNotifications',
+        'maxTokenBudget',
+        'budgetWarningThreshold',
+        'autoCheckpointOnMilestone',
+        'storagePath',
+      ];
 
       const writes = [];
 
       for (const f of fields) {
-
         if (draft[f] === undefined) continue;
 
         const status = getFieldStatus(f, draft[f], snap);
-
         if (status.invalid) continue;
 
         if (status.isDirty) {
-
-          if (f === 'maxIterations' && draft[f] === '') {
-
-            writes.push([f, undefined]);
-
-          } else if (f === 'maxIterations') {
-
-            writes.push([f, parseNumberField(draft[f])]);
-
+          if (f in NUMERIC_FIELDS) {
+            if (draft[f] === '') {
+              writes.push([f, undefined]);
+            } else {
+              writes.push([f, parseNumberField(draft[f], NUMERIC_FIELDS[f])]);
+            }
+          } else if (f === 'storagePath') {
+            const clean = typeof draft[f] === 'string' ? draft[f].trim() : '';
+            writes.push([f, clean ? clean : undefined]);
           } else {
-
             writes.push([f, Boolean(draft[f])]);
-
           }
-
         }
-
       }
 
       return writes;
-
     }
 
     // --- SETTINGS CARD ---
@@ -4138,17 +4110,11 @@ window.__ModuleLoader__.load({
       };
 
       const resetFieldToDefault = (field) => {
-
-        if (field === 'maxIterations') {
-
+        if (field in NUMERIC_FIELDS) {
           edit(field, '');
-
         } else {
-
           edit(field, snap?.base?.[field] ?? DEFAULT_SETTINGS[field]);
-
         }
-
       };
 
       const save = async () => {
@@ -4612,7 +4578,7 @@ window.__ModuleLoader__.load({
 
                                     title: t('resetField') || 'Reset to default',
 
-                                    onClick: () => edit('consecutiveToolFailureLimit', snap?.base?.consecutiveToolFailureLimit ?? DEFAULT_SETTINGS.consecutiveToolFailureLimit),
+                                    onClick: () => resetFieldToDefault('consecutiveToolFailureLimit'),
 
                                   },
 
@@ -4644,7 +4610,7 @@ window.__ModuleLoader__.load({
 
                           className: 'dsh-goal-card-input',
 
-                          onChange: (e) => edit('consecutiveToolFailureLimit', parseNumberField(e.target.value)),
+                          onChange: (e) => edit('consecutiveToolFailureLimit', e.target.value),
 
                         }),
 
@@ -4680,7 +4646,7 @@ window.__ModuleLoader__.load({
                                     type: 'button',
                                     className: 'dsh-goal-btn-inline-reset',
                                     title: t('resetField') || 'Reset to default',
-                                    onClick: () => edit('maxTokenBudget', snap?.base?.maxTokenBudget ?? DEFAULT_SETTINGS.maxTokenBudget),
+                                    onClick: () => resetFieldToDefault('maxTokenBudget'),
                                   },
                                   React.createElement(IconRotateCcw, { size: 12 }),
                                   t('resetField') || 'Default'
@@ -4697,7 +4663,7 @@ window.__ModuleLoader__.load({
                           value: budgetStatus.value !== undefined ? String(budgetStatus.value) : '',
                           disabled,
                           className: 'dsh-goal-card-input',
-                          onChange: (e) => edit('maxTokenBudget', parseNumberField(e.target.value)),
+                          onChange: (e) => edit('maxTokenBudget', e.target.value),
                         })
                       ),
 
@@ -4721,7 +4687,7 @@ window.__ModuleLoader__.load({
                                     type: 'button',
                                     className: 'dsh-goal-btn-inline-reset',
                                     title: t('resetField') || 'Reset to default',
-                                    onClick: () => edit('budgetWarningThreshold', snap?.base?.budgetWarningThreshold ?? DEFAULT_SETTINGS.budgetWarningThreshold),
+                                    onClick: () => resetFieldToDefault('budgetWarningThreshold'),
                                   },
                                   React.createElement(IconRotateCcw, { size: 12 }),
                                   t('resetField') || 'Default'
@@ -4738,7 +4704,7 @@ window.__ModuleLoader__.load({
                           value: budgetWarnStatus.value !== undefined ? String(budgetWarnStatus.value) : '',
                           disabled,
                           className: 'dsh-goal-card-input',
-                          onChange: (e) => edit('budgetWarningThreshold', parseNumberField(e.target.value)),
+                          onChange: (e) => edit('budgetWarningThreshold', e.target.value),
                         })
                       ),
 

package/lib/index.js

@@ -1,6 +1,17 @@
 import path from 'node:path';
 import os from 'node:os';
 import z from '@deepseek-ai/schemastery';
+// Polyfill volatile schema modifier if running against schemastery < 3.18.4
+if (typeof z.Schema?.prototype?.volatile !== 'function') {
+  const proto = z.Schema ? z.Schema.prototype : (typeof z === 'function' ? Object.getPrototypeOf(z.string?.() || {}) : null);
+  if (proto && typeof proto.extra === 'function' && typeof proto.volatile !== 'function') {
+    proto.volatile = function volatile() {
+      if (this.meta?.volatile) throw new TypeError('volatile schema is already wrapped');
+      return this.extra('volatile', true);
+    };
+  }
+}
+
 import { AddonStore } from './addon-store.js';
 import { TokenBudgetGuard } from './token-budget-guard.js';
 import { GitSnapshotManager } from './git-snapshot-manager.js';
@@ -70,27 +81,28 @@ export function safeService(ctx, name) {
 
 export function apply(ctx, config = {}) {
   const sseClients = new Map();
+  const cfg = plainConfig(config || {});
 
   let currentSettings = {
-    maxIterations: config?.maxIterations ?? 25,
-    autoDrive: config?.autoDrive ?? true,
-    enableSound: config?.enableSound ?? true,
-    showQuickLaunchButton: config?.showQuickLaunchButton ?? true,
-    consecutiveToolFailureLimit: config?.consecutiveToolFailureLimit ?? 3,
-    enableBrowserNotifications: config?.enableBrowserNotifications ?? true,
-    maxTokenBudget: config?.maxTokenBudget ?? 0,
-    budgetWarningThreshold: config?.budgetWarningThreshold ?? 80,
-    autoCheckpointOnMilestone: config?.autoCheckpointOnMilestone ?? false,
-    enableLiveActivityFeed: config?.enableLiveActivityFeed ?? true,
-    enablePreplanning: config?.enablePreplanning ?? true,
-    autoBranchOnGoalStart: config?.autoBranchOnGoalStart ?? true,
-    enablePostGoalRetrospective: config?.enablePostGoalRetrospective ?? true,
-    autoScaleBudgetNearCompletion: config?.autoScaleBudgetNearCompletion ?? false,
-    enableTemplatesDrawer: config?.enableTemplatesDrawer ?? true,
-    enableMilestoneDependencies: config?.enableMilestoneDependencies ?? true,
-    soundScheme: config?.soundScheme ?? 'default',
-    enableVoiceAnnouncements: config?.enableVoiceAnnouncements ?? false,
-    storagePath: config?.storagePath,
+    maxIterations: cfg?.maxIterations ?? 25,
+    autoDrive: cfg?.autoDrive ?? true,
+    enableSound: cfg?.enableSound ?? true,
+    showQuickLaunchButton: cfg?.showQuickLaunchButton ?? true,
+    consecutiveToolFailureLimit: cfg?.consecutiveToolFailureLimit ?? 3,
+    enableBrowserNotifications: cfg?.enableBrowserNotifications ?? true,
+    maxTokenBudget: cfg?.maxTokenBudget ?? 0,
+    budgetWarningThreshold: cfg?.budgetWarningThreshold ?? 80,
+    autoCheckpointOnMilestone: cfg?.autoCheckpointOnMilestone ?? false,
+    enableLiveActivityFeed: cfg?.enableLiveActivityFeed ?? true,
+    enablePreplanning: cfg?.enablePreplanning ?? true,
+    autoBranchOnGoalStart: cfg?.autoBranchOnGoalStart ?? true,
+    enablePostGoalRetrospective: cfg?.enablePostGoalRetrospective ?? true,
+    autoScaleBudgetNearCompletion: cfg?.autoScaleBudgetNearCompletion ?? false,
+    enableTemplatesDrawer: cfg?.enableTemplatesDrawer ?? true,
+    enableMilestoneDependencies: cfg?.enableMilestoneDependencies ?? true,
+    soundScheme: cfg?.soundScheme ?? 'default',
+    enableVoiceAnnouncements: cfg?.enableVoiceAnnouncements ?? false,
+    storagePath: cfg?.storagePath,
   };
 
   const defaultStorageDir = process.env.DSH_HOME || path.join(os.homedir(), '.dsh');
@@ -298,6 +310,23 @@ export function apply(ctx, config = {}) {
     if (typeof patch.storagePath === 'string' && patch.storagePath.trim()) {
       addonStore.setStoragePath(patch.storagePath.trim());
     }
+    if (fallbackEngine && typeof fallbackEngine.updateConfig === 'function') {
+      fallbackEngine.updateConfig({
+        defaultMaxIterations: currentSettings.maxIterations,
+        autoDrive: currentSettings.autoDrive,
+        consecutiveToolFailureLimit: currentSettings.consecutiveToolFailureLimit,
+        maxTokenBudget: currentSettings.maxTokenBudget,
+        budgetWarningThreshold: currentSettings.budgetWarningThreshold,
+        autoCheckpointOnMilestone: currentSettings.autoCheckpointOnMilestone,
+        enableLiveActivityFeed: currentSettings.enableLiveActivityFeed,
+        enablePreplanning: currentSettings.enablePreplanning,
+        autoBranchOnGoalStart: currentSettings.autoBranchOnGoalStart,
+        enablePostGoalRetrospective: currentSettings.enablePostGoalRetrospective,
+        autoScaleBudgetNearCompletion: currentSettings.autoScaleBudgetNearCompletion,
+        enableTemplatesDrawer: currentSettings.enableTemplatesDrawer,
+        enableMilestoneDependencies: currentSettings.enableMilestoneDependencies,
+      });
+    }
   };
 
   // DSH hands the plugin the entry config, whose .volatile() fields hold Volatile

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-goal",
-  "version": "0.2.17",
+  "version": "0.2.18",
   "description": "Core Goal Addon (Token Budget, Milestones, Git Snapshots & Retrospective Reports) for DeepSeek Harness",
   "type": "module",
   "main": "./lib/index.js",