@goodandready/dsh-goal 0.2.15 → 0.2.17

package/lib/client.js

@@ -5228,16 +5228,9 @@ window.__ModuleLoader__.load({
             GoalSettingsCard,
           );
 
-          registerSlotSafe(
-            'settings.plugin.item',
-            {
-              name: 'settings.plugin.item',
-              key: NS,
-              locale: NS,
-              inject: () => ({ ctx, scope: configForms }),
-            },
-            GoalSettingsCard,
-          );
+          // settings.plugin.item is gone: it was retired before DSH 0.1.7-rc.2, so
+          // it only mounted GoalSettingsCard a second time on a seat that no longer
+          // exists. plugins.item and plugins.row.config above cover both releases.
 
           return () => {
             for (const dispose of disposers) {
@@ -5305,16 +5298,8 @@ window.__ModuleLoader__.load({
           GoalSettingsCard,
         );
 
-        registerSlotSafe(
-          'settings.plugin.item',
-          {
-            name: 'settings.plugin.item',
-            key: NS,
-            locale: NS,
-            inject: () => ({ ctx, scope: configForms }),
-          },
-          GoalSettingsCard,
-        );
+        // settings.plugin.item is gone for the same reason: retired before DSH
+        // 0.1.7-rc.2, it mounted GoalSettingsCard a second time on a dead seat.
       }
     };
 

package/lib/index.js

@@ -18,27 +18,38 @@ export const inject = ['webServer', 'settings'];
 const NS = 'dsh-goal';
 
 export const Config = z.object({
-  maxIterations: z.number().default(25).description('Safety limit: max autonomous iterations per goal'),
-  autoDrive: z.boolean().default(true).description('Automatically continue the loop after each turn'),
-  enableSound: z.boolean().default(true).description('Play synthesized audio chime on goal completion or failure'),
-  showQuickLaunchButton: z.boolean().default(true).description('Show quick launch goal button above composer dock'),
-  consecutiveToolFailureLimit: z.number().default(3).description('Auto-pause goal if N consecutive turns encounter tool execution errors (0 to disable)'),
-  enableBrowserNotifications: z.boolean().default(true).description('Show desktop notifications on goal completion or failure'),
-  maxTokenBudget: z.number().default(0).description('Maximum token budget per goal session (0 to disable)'),
-  budgetWarningThreshold: z.number().default(80).description('Percentage of token budget consumed before model warning injection (e.g. 80)'),
-  autoCheckpointOnMilestone: z.boolean().default(false).description('Automatically create git commit checkpoint upon milestone completion'),
-  enableLiveActivityFeed: z.boolean().default(true).description('Display compact recent tool and control activity feed in details modal'),
-  enablePreplanning: z.boolean().default(true).description('Generate initial draft plan for approval before launching autonomous turns'),
-  autoBranchOnGoalStart: z.boolean().default(true).description('Automatically create dedicated isolated git branch for goal execution'),
-  enablePostGoalRetrospective: z.boolean().default(true).description('Generate structured retrospective and analytics card upon goal completion'),
-  autoScaleBudgetNearCompletion: z.boolean().default(false).description('Automatically grant token buffer extension if budget reaches 100% near completion'),
-  enableTemplatesDrawer: z.boolean().default(true).description('Provide pre-configured engineering goal templates in UI drawer'),
-  enableMilestoneDependencies: z.boolean().default(true).description('Enforce milestone dependency ordering and block premature execution'),
-  soundScheme: z.string().default('default').description('Audio theme for status and milestone notifications'),
-  enableVoiceAnnouncements: z.boolean().default(false).description('Use Web Speech API for voice announcements on milestone events'),
-  storagePath: z.string().default('').description('Custom filesystem path for persistent state storage'),
+  maxIterations: z.number().default(25).volatile().description('Safety limit: max autonomous iterations per goal'),
+  autoDrive: z.boolean().default(true).volatile().description('Automatically continue the loop after each turn'),
+  enableSound: z.boolean().default(true).volatile().description('Play synthesized audio chime on goal completion or failure'),
+  showQuickLaunchButton: z.boolean().default(true).volatile().description('Show quick launch goal button above composer dock'),
+  consecutiveToolFailureLimit: z.number().default(3).volatile().description('Auto-pause goal if N consecutive turns encounter tool execution errors (0 to disable)'),
+  enableBrowserNotifications: z.boolean().default(true).volatile().description('Show desktop notifications on goal completion or failure'),
+  maxTokenBudget: z.number().default(0).volatile().description('Maximum token budget per goal session (0 to disable)'),
+  budgetWarningThreshold: z.number().default(80).volatile().description('Percentage of token budget consumed before model warning injection (e.g. 80)'),
+  autoCheckpointOnMilestone: z.boolean().default(false).volatile().description('Automatically create git commit checkpoint upon milestone completion'),
+  enableLiveActivityFeed: z.boolean().default(true).volatile().description('Display compact recent tool and control activity feed in details modal'),
+  enablePreplanning: z.boolean().default(true).volatile().description('Generate initial draft plan for approval before launching autonomous turns'),
+  autoBranchOnGoalStart: z.boolean().default(true).volatile().description('Automatically create dedicated isolated git branch for goal execution'),
+  enablePostGoalRetrospective: z.boolean().default(true).volatile().description('Generate structured retrospective and analytics card upon goal completion'),
+  autoScaleBudgetNearCompletion: z.boolean().default(false).volatile().description('Automatically grant token buffer extension if budget reaches 100% near completion'),
+  enableTemplatesDrawer: z.boolean().default(true).volatile().description('Provide pre-configured engineering goal templates in UI drawer'),
+  enableMilestoneDependencies: z.boolean().default(true).volatile().description('Enforce milestone dependency ordering and block premature execution'),
+  soundScheme: z.string().default('default').volatile().description('Audio theme for status and milestone notifications'),
+  enableVoiceAnnouncements: z.boolean().default(false).volatile().description('Use Web Speech API for voice announcements on milestone events'),
+  storagePath: z.string().default('').volatile().description('Custom filesystem path for persistent state storage'),
 });
 
+// DSH serves a namespace's settings form from the volatile fields of its profile
+// entry schema, and a volatile field holds a Volatile box rather than its value.
+// Unwrap before any caller reads one, and read lazily: the Loader mutates the
+// boxes in place and re-announces them with loader/volatile-update.
+export function plainConfig(value) {
+  if (value === null || typeof value !== 'object') return value
+  if (Array.isArray(value)) return value.map(plainConfig)
+  if (typeof value.get === 'function') return plainConfig(value.get())
+  return Object.fromEntries(Object.entries(value).map(([k, v]) => [k, plainConfig(v)]))
+}
+
 /**
  * Safely access a service from Cordis context without throwing if un-injected.
  * @param {any} ctx
@@ -58,7 +69,6 @@ export function safeService(ctx, name) {
 }
 
 export function apply(ctx, config = {}) {
-  let settingsScope = null;
   const sseClients = new Map();
 
   let currentSettings = {
@@ -290,31 +300,26 @@ export function apply(ctx, config = {}) {
     }
   };
 
-  if (typeof ctx?.inject === 'function') {
-    ctx.inject(['settings'], (sctx) => {
-      try {
-        const scope = sctx.settings?.register?.(NS, Config, { base: currentSettings });
-        if (scope) {
-          settingsScope = scope;
-          if (typeof scope.get === 'function') {
-            applySettings(scope.get());
-          }
-          if (typeof scope.subscribe === 'function') {
-            sctx.effect?.(() => {
-              const off = scope.subscribe(() => {
-                if (typeof scope.get === 'function') applySettings(scope.get());
-              });
-              return () => {
-                if (typeof off === 'function') off();
-                settingsScope = null;
-              };
-            }, 'dsh-goal: settings subscription');
-          }
+  // DSH hands the plugin the entry config, whose .volatile() fields hold Volatile
+  // boxes. The settings service re-merges that config and announces it with
+  // loader/volatile-update, which both 0.1.7-rc.2 and 0.2.0 emit. settings.register
+  // exists in neither release, so the scope it returned never existed and every
+  // setting changed in the card had no effect on the running engine.
+  const readEntrySettings = () => plainConfig(config || {});
+  applySettings(readEntrySettings());
+
+  if (typeof ctx?.on === 'function') {
+    try {
+      ctx.on('loader/volatile-update', () => {
+        try {
+          applySettings(readEntrySettings());
+        } catch (err) {
+          logger.warn?.('dsh-goal: settings refresh failed:', err?.message || err);
         }
-      } catch (err) {
-        logger.warn?.('Settings register skipped:', err.message);
-      }
-    });
+      });
+    } catch (err) {
+      logger.warn?.('dsh-goal: volatile-update subscription failed:', err?.message || err);
+    }
   }
 
   if (typeof ctx?.effect === 'function') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-goal",
-  "version": "0.2.15",
+  "version": "0.2.17",
   "description": "Core Goal Addon (Token Budget, Milestones, Git Snapshots & Retrospective Reports) for DeepSeek Harness",
   "type": "module",
   "main": "./lib/index.js",
@@ -55,14 +55,14 @@
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
     "@deepseek-ai/dsh-host-webserver": "^0.1.7-rc.2 || ^0.2.0-rc.1",
-    "@deepseek-ai/schemastery": "^3.18.1",
+    "@deepseek-ai/schemastery": "^3.18.4",
     "@deepseek-ai/dsh-goal": "^0.1.7-rc.2 || ^0.2.0-rc.1"
   },
   "devDependencies": {
-    "@deepseek-ai/schemastery": "^3.18.1"
+    "@deepseek-ai/schemastery": "^3.18.4"
   },
   "dependencies": {
-    "@deepseek-ai/schemastery": "^3.18.1"
+    "@deepseek-ai/schemastery": "^3.18.4"
   },
   "peerDependenciesMeta": {
     "@deepseek-ai/dsh-goal": {