@goodandready/dsh-goal 0.2.12 → 0.2.14

package/lib/routes.js

@@ -3,6 +3,7 @@ import path from 'node:path';
 import { MilestoneStatus, detectLanguage, sessionIdOf } from './goal-engine-constants.js';
 import { saveGoalArtifact, rollbackToCheckpoint } from './engine-reports.js';
 import { getTemplatesCatalogue, instantiateTemplate } from './engine-templates.js';
+import { parseIssueChecklist } from './engine-issue-sync.js';
 
 export function isLoopback(value) {
   if (!value) return false;
@@ -84,71 +85,86 @@ export function getSafeCwd(requestedCwd, allowedRoots = []) {
 
 /**
  * Register webServer HTTP routes and SSE stream for DSH Goal
- * @param {any} ctx Cordis context
- * @param {object} deps Dependencies
- * @param {any} deps.engine GoalEngine instance
- * @param {Function} deps.getConfig Function returning current config
- * @param {Function} deps.stopRunningAgents Stop agents function
- * @param {Function} deps.resumeActiveAgent Resume agent function
- * @param {Map} deps.sessionAgents Session agent map
- * @param {Map} [deps.sseClients] SSE clients map (sid -> Set)
  */
 export function registerRoutes(ctx, {
   engine,
+  goalsService,
   getConfig,
   stopRunningAgents,
   resumeActiveAgent,
   sessionAgents,
   sseClients = new Map(),
-}) {
-  // Subscribe to engine changes for realtime Server-Sent Events broadcasting
-  engine.subscribe((snapshot, sid) => {
-    const clients = sseClients.get(sid);
-    if (clients && clients.size > 0) {
-      const payload = `data: ${JSON.stringify(snapshot)}\n\n`;
-      for (const clientRes of Array.from(clients)) {
-        try {
-          clientRes.write(payload);
-        } catch (err) {
-          clients.delete(clientRes);
-          try { clientRes.end(); } catch (e) { /* closed */ }
-        }
-      }
-      if (clients.size === 0) sseClients.delete(sid);
-    }
-    if (sid !== 'default' && sseClients.has('default')) {
-      const defClients = sseClients.get('default');
-      if (defClients && defClients.size > 0) {
+  addonStore,
+  budgetGuard,
+  snapshotManager,
+  milestoneManager,
+  logger = console,
+} = {}) {
+  // Subscribe to engine if provided (backward compatibility)
+  if (engine && typeof engine.subscribe === 'function') {
+    engine.subscribe((snapshot, sid) => {
+      const clients = sseClients.get(sid);
+      if (clients && clients.size > 0) {
         const payload = `data: ${JSON.stringify(snapshot)}\n\n`;
-        for (const clientRes of Array.from(defClients)) {
+        for (const clientRes of Array.from(clients)) {
           try {
             clientRes.write(payload);
           } catch (err) {
-            defClients.delete(clientRes);
+            clients.delete(clientRes);
             try { clientRes.end(); } catch (e) { /* closed */ }
           }
         }
-        if (defClients.size === 0) sseClients.delete('default');
+        if (clients.size === 0) sseClients.delete(sid);
+      }
+      if (sid !== 'default' && sseClients.has('default')) {
+        const defClients = sseClients.get('default');
+        if (defClients && defClients.size > 0) {
+          const payload = `data: ${JSON.stringify(snapshot)}\n\n`;
+          for (const clientRes of Array.from(defClients)) {
+            try {
+              clientRes.write(payload);
+            } catch (err) {
+              defClients.delete(clientRes);
+              try { clientRes.end(); } catch (e) { /* closed */ }
+            }
+          }
+          if (defClients.size === 0) sseClients.delete('default');
+        }
+      }
+    });
+  }
+
+  const broadcastEvent = (event, data) => {
+    const payload = `event: ${event}\ndata: ${JSON.stringify(data)}\n\n`;
+    for (const clientSet of sseClients.values()) {
+      if (clientSet instanceof Set) {
+        for (const res of clientSet) {
+          try { res.write(payload); } catch (e) { clientSet.delete(res); }
+        }
+      } else if (clientSet && typeof clientSet.write === 'function') {
+        try { clientSet.write(payload); } catch (e) { /* closed */ }
       }
     }
-  });
+  };
 
-  ctx.effect(() => {
-    if (!ctx.webServer?.register) return () => {};
+  const setupWebServer = () => {
+    if (!ctx?.webServer?.register) return () => {};
 
     // Keepalive ping timer for SSE connections (every 20s)
     const keepaliveTimer = setInterval(() => {
       for (const [sid, clients] of sseClients.entries()) {
-        for (const res of Array.from(clients)) {
-          try {
-            res.write(': keepalive\n\n');
-          } catch (err) {
-            clients.delete(res);
-            try { res.end(); } catch (e) { /* closed */ }
+        if (clients instanceof Set) {
+          for (const res of Array.from(clients)) {
+            try {
+              res.write(': keepalive\n\n');
+            } catch (err) {
+              clients.delete(res);
+              try { res.end(); } catch (e) { /* closed */ }
+            }
+          }
+          if (clients.size === 0) {
+            sseClients.delete(sid);
           }
-        }
-        if (clients.size === 0) {
-          sseClients.delete(sid);
         }
       }
     }, 20000);
@@ -165,36 +181,48 @@ export function registerRoutes(ctx, {
         if (req.method === 'GET' && (pathname === '/dsh-goal/events' || pathname === '/dsh-goal/events/')) {
           if (!isTrustedCaller(req)) {
             res.statusCode = 403;
-            res.setHeader('Content-Type', 'application/json; charset=utf-8');
+            if (typeof res.setHeader === 'function') res.setHeader('Content-Type', 'application/json; charset=utf-8');
             return res.end(JSON.stringify({ error: 'Forbidden: untrusted caller origin' }));
           }
           const sid = sessionIdOf(req, 'default');
-          res.writeHead(200, {
-            'Content-Type': 'text/event-stream',
-            'Cache-Control': 'no-cache, no-transform',
-            'Connection': 'keep-alive',
-            'X-Accel-Buffering': 'no',
-          });
+          if (typeof res.writeHead === 'function') {
+            res.writeHead(200, {
+              'Content-Type': 'text/event-stream',
+              'Cache-Control': 'no-cache, no-transform',
+              'Connection': 'keep-alive',
+              'X-Accel-Buffering': 'no',
+            });
+          } else {
+            res.statusCode = 200;
+            if (typeof res.setHeader === 'function') {
+              res.setHeader('Content-Type', 'text/event-stream');
+              res.setHeader('Cache-Control', 'no-cache, no-transform');
+            }
+          }
 
           if (!sseClients.has(sid)) {
             sseClients.set(sid, new Set());
           }
           sseClients.get(sid).add(res);
 
-          const initialSnap = engine.getSnapshot(sid);
+          const initialSnap = engine ? engine.getSnapshot(sid) : { sessionId: sid, hasActiveGoal: false, status: 'IDLE' };
           res.write(`data: ${JSON.stringify(initialSnap)}\n\n`);
 
-          req.on('close', () => {
-            const set = sseClients.get(sid);
-            if (set) {
-              set.delete(res);
-              if (set.size === 0) sseClients.delete(sid);
-            }
-          });
+          if (typeof req.on === 'function') {
+            req.on('close', () => {
+              const set = sseClients.get(sid);
+              if (set) {
+                set.delete(res);
+                if (set.size === 0) sseClients.delete(sid);
+              }
+            });
+          }
           return;
         }
 
-        res.setHeader('Content-Type', 'application/json; charset=utf-8');
+        if (typeof res.setHeader === 'function') {
+          res.setHeader('Content-Type', 'application/json; charset=utf-8');
+        }
 
         // GET /dsh-goal/templates
         if (req.method === 'GET' && (pathname === '/dsh-goal/templates' || pathname === '/dsh-goal/templates/')) {
@@ -214,7 +242,15 @@ export function registerRoutes(ctx, {
           }
           const sid = sessionIdOf(req, 'default');
           res.statusCode = 200;
-          return res.end(JSON.stringify(engine.getSnapshot(sid)));
+          if (engine) {
+            return res.end(JSON.stringify(engine.getSnapshot(sid)));
+          }
+          return res.end(JSON.stringify({
+            sessionId: sid,
+            hasActiveGoal: false,
+            state: 'IDLE',
+            milestones: [],
+          }));
         }
 
         // POST /dsh-goal/action
@@ -251,18 +287,18 @@ export function registerRoutes(ctx, {
           const MAX_PAYLOAD_BYTES = 256 * 1024;
           let limitExceeded = false;
 
-          req.on('data', (chunk) => {
+          const onData = (chunk) => {
             bodySize += chunk.length;
             if (bodySize > MAX_PAYLOAD_BYTES) {
               limitExceeded = true;
-              req.pause();
+              if (typeof req.pause === 'function') req.pause();
               res.statusCode = 413;
               return res.end(JSON.stringify({ error: 'Payload too large: max 256 KB allowed' }));
             }
             body += chunk;
-          });
+          };
 
-          req.on('end', () => {
+          const onEnd = () => {
             if (limitExceeded) return;
             try {
               const data = JSON.parse(body || '{}');
@@ -292,17 +328,32 @@ export function registerRoutes(ctx, {
                   }
                   const detectedLang = data.lang || detectLanguage(cleanTitle);
                   const conf = typeof getConfig === 'function' ? getConfig() : { maxIterations: 25 };
-                  result = engine.startGoal(cleanTitle, {
-                    description: typeof description === 'string' ? description.trim() : '',
-                    maxIterations: conf.maxIterations || 25,
-                    lang: detectedLang,
-                    cwd: safeStartCwd,
-                    issueBody: data.issueBody,
-                  }, sid);
+
+                  if (engine) {
+                    result = engine.startGoal(cleanTitle, {
+                      description: typeof description === 'string' ? description.trim() : '',
+                      maxIterations: conf.maxIterations || 25,
+                      lang: detectedLang,
+                      cwd: safeStartCwd,
+                      issueBody: data.issueBody,
+                    }, sid);
+                  } else {
+                    let parsedMilestones = [];
+                    if (data.issueBody) {
+                      parsedMilestones = parseIssueChecklist(data.issueBody);
+                    }
+                    result = {
+                      title: cleanTitle,
+                      sessionId: sid,
+                      hasActiveGoal: true,
+                      state: 'RUNNING',
+                      milestones: parsedMilestones,
+                    };
+                  }
 
                   const startPrompt = detectedLang === 'zh'
-                    ? `🎯 目标已确立：“${cleanTitle}”。请立即通过 goal_set_milestones 制定工作计划（3-7个具体步骤）并开始执行。`
-                    : `🎯 Goal established: "${cleanTitle}". Immediately formulate a work plan (3-7 concrete steps) via tool goal_set_milestones and start executing it.`;
+                    ? `🎯 目标已确立：“${cleanTitle}”。请立即通过 goal_milestones 制定工作计划并开始执行。`
+                    : `🎯 Goal established: "${cleanTitle}". Formulate milestones via goal_milestones and proceed.`;
 
                   if (typeof resumeActiveAgent === 'function') {
                     resumeActiveAgent(startPrompt, sid);
@@ -316,40 +367,52 @@ export function registerRoutes(ctx, {
                     res.statusCode = 400;
                     return res.end(JSON.stringify({ error: 'Nudge text cannot be empty' }));
                   }
-                  result = engine.nudge(text, sid);
-                  if (data.resume) {
-                    engine.resume(sid);
-                    const prompt = engine.getStatePromptInjection(sid);
-                    if (typeof resumeActiveAgent === 'function') {
-                      resumeActiveAgent(prompt, sid);
+                  if (engine) {
+                    result = engine.nudge(text, sid);
+                    if (data.resume) {
+                      engine.resume(sid);
+                      const prompt = engine.getStatePromptInjection(sid);
+                      if (typeof resumeActiveAgent === 'function') {
+                        resumeActiveAgent(prompt, sid);
+                      }
                     }
+                  } else {
+                    result = { nudged: true, text };
                   }
                   break;
                 }
 
                 case 'pause':
-                  result = engine.pause(reason || 'Paused by user interface', sid);
+                  if (engine) {
+                    result = engine.pause(reason || 'Paused by user interface', sid);
+                  }
                   if (typeof stopRunningAgents === 'function') {
                     stopRunningAgents(sid);
                   }
                   break;
 
                 case 'resume':
-                  result = engine.resume(sid);
+                  if (engine) {
+                    result = engine.resume(sid);
+                  }
                   if (typeof resumeActiveAgent === 'function') {
                     resumeActiveAgent(undefined, sid);
                   }
                   break;
 
                 case 'cancel':
-                  result = engine.cancel(reason || 'Goal cancelled by user', sid);
+                  if (engine) {
+                    result = engine.cancel(reason || 'Goal cancelled by user', sid);
+                  }
                   if (typeof stopRunningAgents === 'function') {
                     stopRunningAgents(sid);
                   }
                   break;
 
                 case 'clear':
-                  result = engine.clear(sid);
+                  if (engine) {
+                    result = engine.clear(sid);
+                  }
                   if (typeof stopRunningAgents === 'function') {
                     stopRunningAgents(sid);
                   }
@@ -368,12 +431,21 @@ export function registerRoutes(ctx, {
                     res.statusCode = 400;
                     return res.end(JSON.stringify({ error: `Invalid status: ${status}. Must be one of: ${validStatuses.join(', ')}` }));
                   }
-                  const ok = engine.updateMilestone(milestoneId, status, notes, sid, data.checklist);
-                  if (!ok) {
-                    res.statusCode = 404;
-                    return res.end(JSON.stringify({ error: `Milestone with id "${milestoneId}" not found` }));
+                  if (engine) {
+                    const ok = engine.updateMilestone(milestoneId, status, notes, sid, data.checklist);
+                    if (!ok) {
+                      res.statusCode = 404;
+                      return res.end(JSON.stringify({ error: `Milestone with id "${milestoneId}" not found` }));
+                    }
+                    result = engine.getSnapshot(sid);
+                  } else if (milestoneManager) {
+                    const ok = milestoneManager.updateMilestone(sid, milestoneId, { status, notes });
+                    if (!ok) {
+                      res.statusCode = 404;
+                      return res.end(JSON.stringify({ error: `Milestone with id "${milestoneId}" not found` }));
+                    }
+                    result = { ok: true, milestones: milestoneManager.getMilestones(sid) };
                   }
-                  result = engine.getSnapshot(sid);
                   break;
                 }
 
@@ -382,26 +454,40 @@ export function registerRoutes(ctx, {
                     res.statusCode = 400;
                     return res.end(JSON.stringify({ error: 'milestoneId and itemIndex are required' }));
                   }
-                  const ok = engine.toggleChecklistItem(milestoneId, data.itemIndex, data.done, sid);
-                  if (!ok) {
-                    res.statusCode = 404;
-                    return res.end(JSON.stringify({ error: `Milestone checklist item not found` }));
+                  if (engine) {
+                    const ok = engine.toggleChecklistItem(milestoneId, data.itemIndex, data.done, sid);
+                    if (!ok) {
+                      res.statusCode = 404;
+                      return res.end(JSON.stringify({ error: `Milestone checklist item not found` }));
+                    }
+                    result = engine.getSnapshot(sid);
+                  } else if (milestoneManager) {
+                    const ok = milestoneManager.toggleChecklistItem(sid, milestoneId, data.itemIndex, data.done);
+                    if (!ok) {
+                      res.statusCode = 404;
+                      return res.end(JSON.stringify({ error: `Milestone checklist item not found` }));
+                    }
+                    result = { ok: true, milestones: milestoneManager.getMilestones(sid) };
                   }
-                  result = engine.getSnapshot(sid);
                   break;
                 }
 
                 case 'extend_budget': {
                   const addTokens = data.addTokens || 50000;
-                  const ok = engine.extendBudget(addTokens, sid);
-                  if (!ok) {
-                    res.statusCode = 404;
-                    return res.end(JSON.stringify({ error: 'No active goal found to extend budget' }));
-                  }
-                  if (typeof resumeActiveAgent === 'function') {
-                    resumeActiveAgent(undefined, sid);
+                  if (engine) {
+                    const ok = engine.extendBudget(addTokens, sid);
+                    if (!ok) {
+                      res.statusCode = 404;
+                      return res.end(JSON.stringify({ error: 'No active goal found to extend budget' }));
+                    }
+                    if (typeof resumeActiveAgent === 'function') {
+                      resumeActiveAgent(undefined, sid);
+                    }
+                    result = engine.getSnapshot(sid);
+                  } else if (budgetGuard) {
+                    budgetGuard.extendBudget(sid, addTokens);
+                    result = { ok: true, extendedBy: addTokens };
                   }
-                  result = engine.getSnapshot(sid);
                   break;
                 }
 
@@ -411,7 +497,7 @@ export function registerRoutes(ctx, {
                     res.statusCode = 400;
                     return res.end(JSON.stringify({ error: 'commit hash is required for rollback' }));
                   }
-                  const sessionGoal = engine.getGoal(sid);
+                  const sessionGoal = engine ? engine.getGoal(sid) : null;
                   const allowedRoots = [process.cwd()];
                   if (process.env.DSH_WORKSPACE_ROOT) {
                     allowedRoots.push(process.env.DSH_WORKSPACE_ROOT);
@@ -432,17 +518,17 @@ export function registerRoutes(ctx, {
                     res.statusCode = 500;
                     return res.end(JSON.stringify({ error: `Failed to rollback to checkpoint ${commit}` }));
                   }
-                  result = engine.getSnapshot(sid);
+                  result = engine ? engine.getSnapshot(sid) : { ok: true, rolledBack: commit };
                   break;
                 }
 
                 case 'save_artifact': {
-                  const snap = engine.getSnapshot(sid);
-                  if (!snap || !snap.hasActiveGoal) {
+                  const snap = engine ? engine.getSnapshot(sid) : null;
+                  if (engine && (!snap || !snap.hasActiveGoal)) {
                     res.statusCode = 404;
                     return res.end(JSON.stringify({ error: 'No active goal to save artifact for' }));
                   }
-                  const sessionGoal = engine.getGoal(sid);
+                  const sessionGoal = engine ? engine.getGoal(sid) : null;
                   const allowedRoots = [process.cwd()];
                   if (process.env.DSH_WORKSPACE_ROOT) {
                     allowedRoots.push(process.env.DSH_WORKSPACE_ROOT);
@@ -458,32 +544,38 @@ export function registerRoutes(ctx, {
                     res.statusCode = 400;
                     return res.end(JSON.stringify({ error: 'Invalid or non-existent working directory' }));
                   }
-                  const artifact = saveGoalArtifact(snap, safeCwd);
+                  const artifact = saveGoalArtifact(snap || { objective: 'Goal Report' }, safeCwd);
                   if (!artifact) {
                     res.statusCode = 500;
                     return res.end(JSON.stringify({ error: 'Failed to write goal artifact to disk' }));
                   }
                   res.statusCode = 200;
-                  return res.end(JSON.stringify({ ok: true, artifact, state: snap }));
+                  return res.end(JSON.stringify({ ok: true, artifact, state: snap || {} }));
                 }
 
                 case 'intervene': {
-                  result = engine.intervene(data, sid);
-                  if (data.resume) {
-                    engine.resume(sid);
-                    const prompt = engine.getStatePromptInjection(sid);
-                    if (typeof resumeActiveAgent === 'function') {
-                      resumeActiveAgent(prompt, sid);
+                  if (engine) {
+                    result = engine.intervene(data, sid);
+                    if (data.resume) {
+                      engine.resume(sid);
+                      const prompt = engine.getStatePromptInjection(sid);
+                      if (typeof resumeActiveAgent === 'function') {
+                        resumeActiveAgent(prompt, sid);
+                      }
                     }
+                  } else {
+                    result = { intervened: true };
                   }
                   break;
                 }
 
                 case 'preplan_approve': {
-                  result = engine.approvePreplan(sid);
-                  const prompt = engine.getStatePromptInjection(sid);
-                  if (typeof resumeActiveAgent === 'function') {
-                    resumeActiveAgent(prompt, sid);
+                  if (engine) {
+                    result = engine.approvePreplan(sid);
+                    const prompt = engine.getStatePromptInjection(sid);
+                    if (typeof resumeActiveAgent === 'function') {
+                      resumeActiveAgent(prompt, sid);
+                    }
                   }
                   break;
                 }
@@ -491,20 +583,22 @@ export function registerRoutes(ctx, {
                 case 'branch_action': {
                   const op = String(data.operation || data.branchOperation || 'merge').toLowerCase();
                   const targetBranch = String(data.targetBranch || 'main');
-                  if (op === 'merge') {
-                    const ok = engine.mergeGoalBranch(targetBranch, sid);
-                    if (!ok) {
-                      res.statusCode = 500;
-                      return res.end(JSON.stringify({ error: `Failed to merge goal branch into ${targetBranch}` }));
-                    }
-                  } else if (op === 'discard') {
-                    const ok = engine.discardGoalBranch(targetBranch, sid);
-                    if (!ok) {
-                      res.statusCode = 500;
-                      return res.end(JSON.stringify({ error: 'Failed to discard goal branch' }));
+                  if (engine) {
+                    if (op === 'merge') {
+                      const ok = engine.mergeGoalBranch(targetBranch, sid);
+                      if (!ok) {
+                        res.statusCode = 500;
+                        return res.end(JSON.stringify({ error: `Failed to merge goal branch into ${targetBranch}` }));
+                      }
+                    } else if (op === 'discard') {
+                      const ok = engine.discardGoalBranch(targetBranch, sid);
+                      if (!ok) {
+                        res.statusCode = 500;
+                        return res.end(JSON.stringify({ error: 'Failed to discard goal branch' }));
+                      }
                     }
+                    result = engine.getSnapshot(sid);
                   }
-                  result = engine.getSnapshot(sid);
                   break;
                 }
 
@@ -533,12 +627,19 @@ export function registerRoutes(ctx, {
               }
 
               res.statusCode = 200;
-              return res.end(JSON.stringify({ ok: true, state: result || engine.getSnapshot(sid) }));
+              return res.end(JSON.stringify({ ok: true, state: result || (engine ? engine.getSnapshot(sid) : {}) }));
             } catch (parseErr) {
               res.statusCode = 400;
               return res.end(JSON.stringify({ error: parseErr.message }));
             }
-          });
+          };
+
+          if (typeof req.on === 'function') {
+            req.on('data', onData);
+            req.on('end', onEnd);
+          } else {
+            onEnd();
+          }
           return;
         }
 
@@ -552,7 +653,7 @@ export function registerRoutes(ctx, {
         const allowedMethods = KNOWN_ROUTES[cleanPath];
         if (allowedMethods && !allowedMethods.includes(req.method)) {
           res.statusCode = 405;
-          res.setHeader('Allow', allowedMethods.join(', '));
+          if (typeof res.setHeader === 'function') res.setHeader('Allow', allowedMethods.join(', '));
           return res.end(JSON.stringify({ error: `Method Not Allowed: use ${allowedMethods.join(', ')}` }));
         }
 
@@ -565,15 +666,25 @@ export function registerRoutes(ctx, {
       clearInterval(keepaliveTimer);
       if (typeof unreg === 'function') unreg();
       for (const clients of sseClients.values()) {
-        for (const res of clients) {
-          try {
-            res.end();
-          } catch (err) {
-            // Already closed
+        if (clients instanceof Set) {
+          for (const res of clients) {
+            try { res.end(); } catch (err) { /* closed */ }
           }
         }
       }
       sseClients.clear();
     };
-  }, 'dsh-goal: HTTP WebServer Routes & SSE');
+  };
+
+  let cleanup = null;
+  if (typeof ctx?.effect === 'function') {
+    cleanup = ctx.effect(() => setupWebServer(), 'dsh-goal: HTTP WebServer Routes & SSE');
+  } else {
+    cleanup = setupWebServer();
+  }
+
+  return {
+    broadcastEvent,
+    cleanup,
+  };
 }