@goodandready/dsh-github-ops 0.2.4 → 0.2.5

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 Notable changes to `@goodandready/dsh-github-ops`.
 
+## 0.2.5
+
+### Fixed
+- Fixed injected dependencies in `registerRoutes` throwing errors when accessing status and SCM endpoints (#53).
+- Fixed `url` ReferenceError before initialization in SCM route query parameter parsing (#54).
+- Hardened SCM route with fail-closed origin check and restricted allowed repository paths (#55).
+- Fixed UI surface registrations (sidebar, PR bar, Source Control tab) getting cut off by misplaced apply closing bracket in client loader (#56).
+- Fixed cache invalidation on mutating write tools and restored `cacheStats` via `clientHolder` (#57).
+- Removed unused dead export `identityMeta` from `lib/present.js` (#58).
+- Eliminated hardcoded color fallbacks in client styling (#61).
+- Ignored internal planning and agent artifacts in git index (#60).
+
+### Added
+- One-click plugin updater in settings via standard `registerPluginUpdater` endpoint (#59).
+
 ## 0.2.4
 
 ### Fixed

package/lib/client.js

@@ -740,7 +740,7 @@ window.__ModuleLoader__.load({
         '.gho-status-key{min-width:88px;color:var(--dsw-alias-label-tertiary)}',
         '.gho-status-value{color:var(--dsw-alias-label-primary);font-variant-numeric:tabular-nums}',
         '.gho-status-head{display:flex;align-items:center;gap:8px;font-size:13px;font-weight:600;color:var(--dsw-alias-label-primary)}',
-        '.gho-status-bad{color:var(--dsw-alias-label-error,#c0392b)}',
+        '.gho-status-bad{color:var(--dsw-alias-label-error)}',
         '.gho-link{appearance:none;border:0;background:0 0;font:inherit;font-size:12px;color:var(--dsw-alias-label-secondary);text-decoration:underline;cursor:pointer;padding:0;margin-left:auto}',
         '.gho-scm{display:flex;flex-direction:column;gap:12px;padding:4px 2px;font-size:13px;color:var(--dsw-alias-label-primary)}',
         '.gho-scm-head{display:flex;align-items:center;gap:10px;flex-wrap:wrap}',
@@ -776,10 +776,10 @@ window.__ModuleLoader__.load({
         '.gho-scm-bar input[type="text"]{flex:1;min-width:160px;height:28px;border:1px solid var(--dsw-alias-border-l2);border-radius:8px;background:var(--dsw-alias-bg-layer-3);color:var(--dsw-alias-label-primary);padding:0 8px;font:inherit}',
         '.gho-scm-btn{appearance:none;font:inherit;font-size:12px;cursor:pointer;border:1px solid var(--dsw-alias-border-l2);background:0 0;color:var(--dsw-alias-label-primary);border-radius:8px;padding:3px 8px}',
         '.gho-scm-btn[disabled]{opacity:.5;cursor:default}',
-        '.gho-scm-btn-warn{border-color:var(--dsw-alias-label-error,#c0392b);color:var(--dsw-alias-label-error,#c0392b)}',
+        '.gho-scm-btn-warn{border-color:var(--dsw-alias-label-error);color:var(--dsw-alias-label-error)}',
         '.gho-scm-actions{display:flex;gap:4px;margin-left:auto}',
         '.gho-scm-check{display:flex;align-items:center;gap:4px;color:var(--dsw-alias-label-secondary)}',
-        '.gho-scm-error{color:var(--dsw-alias-label-error,#c0392b)}',
+        '.gho-scm-error{color:var(--dsw-alias-label-error)}',
         '.gho-input-area{height:auto;min-height:64px;padding:8px 12px;font-family:ui-monospace,SFMono-Regular,Menlo,monospace;resize:vertical}',
         '.gho-input{height:34px;border:1px solid var(--dsw-alias-border-l2);background:var(--dsw-alias-bg-layer-3);color:var(--dsw-alias-label-primary);border-radius:8px;padding:0 12px;font-size:13px}',
         '.gho-foot{border-top:1px solid var(--dsw-alias-border-l2);display:flex;justify-content:flex-end;align-items:center;gap:8px;padding:12px 0 4px}',
@@ -1024,7 +1024,6 @@ window.__ModuleLoader__.load({
           /* a core without this seat: the remaining seats still carry the card */
         }
       }
-    }
 
       // The panel goes into the sidebar: better-sidebar first (its contract is explicit), and
       // the built-in right sidebar through its tab registry. Both are feature-detected, so a
@@ -1089,6 +1088,7 @@ window.__ModuleLoader__.load({
       } catch {
         /* a core without the session view ring: the rest of the plugin still works */
       }
+    }
 
     exports.inject = ['slots', 'locale', 'configForms']
     exports.apply = apply

package/lib/index.js

@@ -1,3 +1,4 @@
+import { registerPluginUpdater } from './updater.js'
 // dsh-github-ops — host half.
 //
 // Gives the agent the GitHub operations the release pipeline needs and the plugin
@@ -303,7 +304,7 @@ export function apply(ctx, rawConfig) {
           // A write may invalidate what a cached read returned.
           if (WRITE_PREFIXES.some((prefix) => toolName === prefix || toolName.startsWith(prefix))) {
             try {
-              sharedClient?.cacheClear?.()
+              clientHolder.currentClient()?.cacheClear?.()
             } catch {
               // a cache reset must never fail a successful call
             }
@@ -389,13 +390,28 @@ export function apply(ctx, rawConfig) {
     },
   })
 
+
+  ctx.inject(['webServer'], (wctx) => {
+    try {
+      const mount = () => registerPluginUpdater(wctx, {
+        endpoint: '/dsh-github-ops/update',
+        packageName: '@goodandready/dsh-github-ops',
+        manifestUrl: new URL('../package.json', import.meta.url),
+      })
+      if (typeof wctx.effect === 'function') wctx.effect(mount, 'dsh-github-ops: updater')
+      else mount()
+    } catch (err) {
+      ctx.logger?.warn?.('[dsh-github-ops] updater route not registered:', err && err.message)
+    }
+  })
+
   registerRoutes(ctx, {
     resolveToken,
     client,
     liveConfig,
     describeError,
     makeGitRunner,
-    cacheStats: () => (sharedClient && typeof sharedClient.cacheStats === 'function' ? sharedClient.cacheStats() : null),
+    cacheStats: () => clientHolder.currentClient()?.cacheStats?.() || null,
   })
 
   // One short paragraph in the system prompt: 50+ tools otherwise leave the model guessing.

package/lib/present.js

@@ -29,8 +29,6 @@ function repoOf(args) {
   return args && args.repository ? String(args.repository) : 'the default repository'
 }
 
-export const identityMeta = (args) => ({ title: String((args && args.repository) || '') })
-
 const PRESENTATIONS = {
   gh_repo: {
     call: (args) => pending(`Read repository ${repoOf(args)}`, pick(args, ['repository'])),

package/lib/routes.js

@@ -31,7 +31,15 @@ export const PANEL_PATH = '/dsh-github-ops/panel'
  * @param deps - resolveToken, client, liveConfig, describeError, makeGitRunner and cacheStats,
  *               injected so this module stays free of the host's own composition.
  */
-export function registerRoutes(ctx, deps) {
+export function registerRoutes(ctx, deps = {}) {
+  const {
+    resolveToken = async () => ({ value: '', source: '', guidance: '' }),
+    client = async () => null,
+    liveConfig = () => ({}),
+    describeError = (e) => String((e && e.message) || e),
+    makeGitRunner = () => () => ({ code: 1, stdout: '', stderr: 'git not available' }),
+    cacheStats = () => null,
+  } = deps
   // The card reads the access status from here instead of from a tool result: the model has
   // no business holding the access value, and the payload describes this machine's account,
   // so only a local or same-origin caller is answered.
@@ -64,7 +72,7 @@ export function registerRoutes(ctx, deps) {
             identity,
             rateLimit,
             scopes,
-            cache: deps.cacheStats ? deps.cacheStats() : null,
+            cache: typeof cacheStats === 'function' ? cacheStats() : null,
             interceptLinks: liveConfig().interceptLinks === true,
             error,
           }))
@@ -88,6 +96,10 @@ export function registerRoutes(ctx, deps) {
           if (req.method !== 'GET' && req.method !== 'POST') return sendJson(res, 405, { error: 'method not allowed' })
           if (!isTrustedRequest(req)) return sendJson(res, 403, { error: 'forbidden' })
           const git = makeGitRunner()
+          const url = new URL(req.url || '/', 'http://localhost')
+          const file = url.searchParams.get('file') || ''
+          const staged = url.searchParams.get('staged') === '1'
+
           // The tab may look at another directory than the session workspace; the value is
           // validated, must exist and must be a directory.
           const requested = validateCwd(url.searchParams.get('cwd') || '')
@@ -98,9 +110,6 @@ export function registerRoutes(ctx, deps) {
             }
             cwd = requested
           }
-          const url = new URL(req.url || '/', 'http://localhost')
-          const file = url.searchParams.get('file') || ''
-          const staged = url.searchParams.get('staged') === '1'
 
           if (req.method === 'POST') {
             // A write always comes from a click in the panel. The body names one action; the

package/lib/status.js

@@ -13,11 +13,34 @@ export function isTrustedRequest(req) {
   const address = (req.socket && (req.socket.remoteAddress || req.socket.address?.().address)) || ''
   const loopback = address === '127.0.0.1' || address === '::1' || address === '::ffff:127.0.0.1'
   if (loopback) return true
-  const host = header(req, 'host')
-  const origin = header(req, 'origin')
+
+  // For non-loopback callers: fail-closed source verification
+  const secFetchSite = header(req, 'sec-fetch-site')
+  if (secFetchSite === 'cross-site') return false
+
+  const host = header(req, 'x-forwarded-host') || header(req, 'host')
+  const origin = header(req, 'origin') || header(req, 'referer')
   if (!host || !origin) return false
+
   try {
-    return new URL(origin).host === host
+    const originUrl = new URL(origin)
+    if (originUrl.host.toLowerCase() !== host.toLowerCase()) return false
+
+
+
+    // DNS rebinding guard: host must be a loopback, local or private LAN address
+    const hostname = host.split(':')[0].toLowerCase()
+    const isPrivate =
+      hostname === 'localhost' ||
+      hostname === '127.0.0.1' ||
+      hostname === '::1' ||
+      /^192\.168\.\d{1,3}\.\d{1,3}$/.test(hostname) ||
+      /^10\.\d{1,3}\.\d{1,3}\.\d{1,3}$/.test(hostname) ||
+      /^172\.(1[6-9]|2\d|3[0-1])\.\d{1,3}\.\d{1,3}$/.test(hostname) ||
+      hostname.endsWith('.local') ||
+      hostname.endsWith('.lan')
+
+    return isPrivate
   } catch {
     return false
   }

package/lib/updater.js

@@ -0,0 +1,276 @@
+/**
+ * Host-side one-click updater for @goodandready/dsh-github-ops.
+ * Conforms to the DSH authoring reference implementation.
+ */
+
+import { spawn } from 'node:child_process'
+import { existsSync, readFileSync } from 'node:fs'
+import { readFile } from 'node:fs/promises'
+import { homedir } from 'node:os'
+import { basename, dirname, isAbsolute, resolve } from 'node:path'
+import { fileURLToPath } from 'node:url'
+
+const UPDATE_HEADER = 'x-dsh-plugin-update'
+const UPDATE_TIMEOUT_MS = 10 * 60_000
+const VERSION_CACHE_MS = 5 * 60_000
+let latestCache = undefined
+
+function header(request, name) {
+  const value = request?.headers?.[name]
+  return Array.isArray(value) ? value[0] : value
+}
+
+function isLoopback(value) {
+  const address = value?.toLowerCase().replace(/^\[|\]$/g, '')
+  return address === 'localhost' || address === 'localhost.' || address === '::1'
+    || address?.startsWith('127.') === true
+    || address?.startsWith('::ffff:127.') === true
+}
+
+export function isTrustedUpdateRequest(request) {
+  if (header(request, UPDATE_HEADER) !== '1') return false
+  if (!isLoopback(request?.socket?.remoteAddress)) return false
+  const site = header(request, 'sec-fetch-site')
+  if (site !== undefined && site !== 'same-origin') return false
+  const origin = header(request, 'origin')
+  const host = header(request, 'host')
+  if (origin === undefined || host === undefined) return false
+  try {
+    const url = new URL(origin)
+    return (url.protocol === 'http:' || url.protocol === 'https:')
+      && isLoopback(url.hostname) && url.host === host
+  } catch {
+    return false
+  }
+}
+
+function validProfileName(value) {
+  return typeof value === 'string' && value !== '' && value !== '.' && value !== '..'
+    && !value.includes('/') && !value.includes('\\') && !/[\0-\x1f\x7f]/.test(value)
+}
+
+function profileNameFromArgv(argv) {
+  if (!Array.isArray(argv)) return undefined
+  for (let index = 2; index < argv.length; index += 1) {
+    if (argv[index] === '--profile') return argv[index + 1]
+    if (argv[index]?.startsWith('--profile=')) return argv[index].slice('--profile='.length)
+  }
+  return argv[2] === 'web' ? 'web' : undefined
+}
+
+function findDshCliEntry() {
+  const value = process.argv[1]
+  if (value === undefined || value === '') return undefined
+  const entry = value.startsWith('file:') ? fileURLToPath(value) : resolve(process.cwd(), value)
+  if (!existsSync(entry)) return undefined
+  for (let directory = dirname(entry); ; directory = dirname(directory)) {
+    const manifestPath = resolve(directory, 'package.json')
+    if (existsSync(manifestPath)) {
+      try {
+        const manifest = JSON.parse(readFileSync(manifestPath, 'utf8'))
+        const bin = typeof manifest.bin === 'string'
+          ? manifest.bin
+          : typeof manifest.bin === 'object' && manifest.bin !== null
+            ? manifest.bin.dsh
+            : undefined
+        if (manifest.name === '@deepseek-ai/dsh' && typeof bin === 'string'
+          && !isAbsolute(bin) && resolve(directory, bin) === resolve(entry)) return entry
+      } catch {
+        /* continue */
+      }
+    }
+    const parent = dirname(directory)
+    if (parent === directory) return undefined
+  }
+}
+
+function detectRuntime() {
+  const profileDir = resolve(process.env.DSH_PROFILE_DIR
+    ?? resolve(homedir(), '.dsh', 'profiles', 'web'))
+  const selected = profileNameFromArgv(process.argv)
+  const profileName = validProfileName(selected)
+    ? selected
+    : validProfileName(basename(profileDir)) ? basename(profileDir) : 'web'
+  const cliEntry = findDshCliEntry()
+  return cliEntry === undefined ? { profileName, profileDir } : { profileName, profileDir, cliEntry }
+}
+
+function parseSemver(value) {
+  const match = /^v?(\d+)\.(\d+)\.(\d+)(?:-([0-9A-Za-z.-]+))?(?:\+[0-9A-Za-z.-]+)?$/.exec(String(value || ''))
+  if (match === null) return undefined
+  return {
+    core: [Number(match[1]), Number(match[2]), Number(match[3])],
+    prerelease: match[4]?.split('.') ?? [],
+  }
+}
+
+function comparePrerelease(candidateParts, currentParts) {
+  // A normal version with no pre-release tag is newer than a pre-release version
+  if (candidateParts.length === 0 && currentParts.length > 0) return 1
+  if (candidateParts.length > 0 && currentParts.length === 0) return -1
+  if (candidateParts.length === 0 && currentParts.length === 0) return 0
+
+  const len = Math.max(candidateParts.length, currentParts.length)
+  for (let i = 0; i < len; i += 1) {
+    const a = candidateParts[i]
+    const b = currentParts[i]
+    if (a === undefined) return -1
+    if (b === undefined) return 1
+    if (a === b) continue
+
+    const aNum = /^\d+$/.test(a) ? Number(a) : undefined
+    const bNum = /^\d+$/.test(b) ? Number(b) : undefined
+
+    if (aNum !== undefined && bNum !== undefined) {
+      return aNum > bNum ? 1 : -1
+    }
+    if (aNum !== undefined && bNum === undefined) {
+      return -1
+    }
+    if (aNum === undefined && bNum !== undefined) {
+      return 1
+    }
+    return a.localeCompare(b) > 0 ? 1 : -1
+  }
+  return 0
+}
+
+export function isNewerVersion(currentValue, candidateValue) {
+  const current = parseSemver(currentValue)
+  const candidate = parseSemver(candidateValue)
+  if (current === undefined || candidate === undefined) return false
+  for (let index = 0; index < 3; index += 1) {
+    if (candidate.core[index] !== current.core[index]) return candidate.core[index] > current.core[index]
+  }
+  return comparePrerelease(candidate.prerelease, current.prerelease) > 0
+}
+
+async function fetchLatestVersion(packageName, registry) {
+  if (latestCache?.packageName === packageName && latestCache.registry === registry && Date.now() < latestCache.expiresAt) {
+    return latestCache.version
+  }
+  try {
+    const reg = registry.replace(/\/+$/, '')
+    const response = await fetch(`${reg}/${encodeURIComponent(packageName)}/latest`, {
+      signal: AbortSignal.timeout(6000),
+    })
+    if (!response.ok) return undefined
+    const value = await response.json()
+    if (typeof value?.version !== 'string' || !value.version) return undefined
+    latestCache = { packageName, registry, version: value.version, expiresAt: Date.now() + VERSION_CACHE_MS }
+    return value.version
+  } catch {
+    return undefined
+  }
+}
+
+async function readCurrentVersion(manifestUrl) {
+  const value = JSON.parse(await readFile(manifestUrl, 'utf8'))
+  if (typeof value?.version !== 'string' || !value.version) throw new Error('Cannot read current plugin version.')
+  return value.version
+}
+
+export async function checkUpdateStatus(options, target = detectRuntime()) {
+  const current = await readCurrentVersion(options.manifestUrl)
+  const latest = await fetchLatestVersion(options.packageName, options.registry || 'https://registry.npmjs.org')
+  return {
+    packageName: options.packageName,
+    currentVersion: current,
+    ...(latest === undefined ? {} : { latestVersion: latest }),
+    latestCheckFailed: latest === undefined,
+    updateAvailable: latest !== undefined && isNewerVersion(current, latest),
+    profileName: target.profileName,
+    canAutoUpdate: target.cliEntry !== undefined,
+  }
+}
+
+async function installExact(target, packageSpec, options) {
+  if (target.cliEntry === undefined) throw new Error('Automatic update is unavailable in this runtime.')
+  await new Promise((resolvePromise, reject) => {
+    const child = spawn(process.execPath, [
+      target.cliEntry, 'plugin', '--profile', target.profileName, 'add',
+      '--config.minimumReleaseAge=0', packageSpec,
+      `--registry=${options.registry || 'https://registry.npmjs.org/'}`,
+    ], {
+      cwd: target.profileDir,
+      windowsHide: true,
+      stdio: ['ignore', 'pipe', 'pipe'],
+      env: { ...process.env, NO_COLOR: '1' },
+    })
+    let detail = ''
+    child.stdout?.on('data', (chunk) => { detail = (detail + String(chunk)).slice(-4000) })
+    child.stderr?.on('data', (chunk) => { detail = (detail + String(chunk)).slice(-4000) })
+    const timer = setTimeout(() => {
+      child.kill()
+      reject(new Error('Update timed out.'))
+    }, UPDATE_TIMEOUT_MS)
+    child.once('error', (error) => { clearTimeout(timer); reject(error) })
+    child.once('exit', (code) => {
+      clearTimeout(timer)
+      if (code === 0) resolvePromise()
+      else reject(new Error(detail.trim() || `Update exited with code ${String(code)}.`))
+    })
+  })
+}
+
+function writeResponseJson(response, statusCode, value) {
+  response.writeHead(statusCode, {
+    'content-type': 'application/json; charset=utf-8',
+    'cache-control': 'no-store',
+  })
+  response.end(JSON.stringify(value))
+}
+
+export function registerPluginUpdater(ctx, options) {
+  if (!ctx?.webServer?.register) return () => {}
+  let installing = false
+  return ctx.webServer.register({
+    kind: 'exact',
+    path: options.endpoint,
+    handler: async (request, response) => {
+      try {
+        const target = detectRuntime()
+        if (request.method === 'GET' || request.method === 'HEAD') {
+          const payload = await checkUpdateStatus(options, target)
+          writeResponseJson(response, 200, payload)
+          return
+        }
+        if (request.method !== 'POST') {
+          response.writeHead(405, { allow: 'GET, HEAD, POST' })
+          response.end()
+          return
+        }
+        if (!isTrustedUpdateRequest(request)) {
+          writeResponseJson(response, 403, { ok: false, error: 'Rejected non-local or cross-origin update request.' })
+          return
+        }
+        if (installing) {
+          writeResponseJson(response, 409, { ok: false, error: 'This plugin is already updating.' })
+          return
+        }
+        installing = true
+        try {
+          const before = await checkUpdateStatus(options, target)
+          if (before.latestVersion === undefined) {
+            writeResponseJson(response, 503, { ok: false, error: 'The latest version is temporarily unavailable.' })
+            return
+          }
+          if (!before.updateAvailable) {
+            writeResponseJson(response, 200, before)
+            return
+          }
+          await installExact(target, `${options.packageName}@${before.latestVersion}`, options)
+          writeResponseJson(response, 200, {
+            ...before,
+            updatedVersion: before.latestVersion,
+            restartRequired: true,
+          })
+        } finally {
+          installing = false
+        }
+      } catch (error) {
+        writeResponseJson(response, 500, { ok: false, error: String(error?.message || error) })
+      }
+    },
+  })
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-github-ops",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "GitHub operations for DeepSeek Harness: releases, tags, a guarded generic API pass-through, workflow runs, secrets and sanitized mirror publication.",
   "license": "MIT",
   "type": "module",