@goodandready/dsh-github-ops 0.2.11 → 0.2.12

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 0.2.12
+
+### Security
+- **Release Preflight Test Confirmation & CWD Containment** (#80): Required `confirm: true` to execute `npm test` during `gh_release_preflight` audit, and routed audit directory through `validateCwd` to prevent arbitrary directory test execution.
+- **SCM Symlink Traversal Protection** (#96): Enhanced `validateCwd` with `realpathSync` resolution to prevent directory traversal and symlink escape into protected system directories (`/etc`, `/proc`, `/sys`, etc.).
+- **Socket Remote Address Verification & IPv6 Support** (#97): Enforced socket `remoteAddress` validation in `isTrustedRequest` and `isTrustedWriteRequest` to block untrusted external clients from spoofing matching `Host` and `Origin` headers. Fixed unbracketed IPv6 address parsing in `isTrustedHost`.
+
+### Refactored
+- **Mirror Git Index Directory Isolation** (#91): Created mirror temporary git-index inside an isolated `fs.mkdtemp` (0700) directory with guaranteed cleanup in `finally`.
+- **Dead Parameter Aliases Removed** (#92): Removed undeclared schema fallback aliases (`tagName`, `targetCommitish`, `previousTagName`, `configurationFilePath`, `pullNumber`) from tool registrations.
+- **Unused Parameters & Re-exports Cleanup** (#95): Removed unused `repoHint` in slash commands, dead `liveConfig()` call in `gh_auth_status`, and unused re-export of `runReleasePreflight`.
+
 ## 0.2.11
 
 ### Security

package/lib/commands.js

@@ -72,7 +72,7 @@ export function buildGhInstruction({ topic, tool, args } = {}) {
  * Register the commands. Every handler returns an instruction for the model; none of them
  * touches GitHub.
  */
-export function registerCommands(commands, { readGitState, repoHint } = {}) {
+export function registerCommands(commands, { readGitState } = {}) {
   const disposers = []
   const context = async () => {
     try {
@@ -92,7 +92,7 @@ export function registerCommands(commands, { readGitState, repoHint } = {}) {
       const git = await context()
       return {
         kind: 'success',
-        text: buildPrInstruction({ title: rest.join(' '), branch: git.branch, base: git.base || 'main', repo: git.repo || (typeof repoHint === 'function' ? repoHint() : undefined), remoteUrl: git.remoteUrl }),
+        text: buildPrInstruction({ title: rest.join(' '), branch: git.branch, base: git.base || 'main', repo: git.repo, remoteUrl: git.remoteUrl }),
       }
     },
   }))
@@ -107,7 +107,7 @@ export function registerCommands(commands, { readGitState, repoHint } = {}) {
       const git = await context()
       return {
         kind: 'success',
-        text: buildReviewInstruction({ number, branch: git.branch, repo: git.repo || (typeof repoHint === 'function' ? repoHint() : undefined) }),
+        text: buildReviewInstruction({ number, branch: git.branch, repo: git.repo }),
       }
     },
   }))
@@ -119,7 +119,7 @@ export function registerCommands(commands, { readGitState, repoHint } = {}) {
     handler: async (invocation) => {
       const [sub, ...rest] = String(invocation.rawInput || '').trim().split(/\s+/)
       const git = await context()
-      const repo = git.repo || (typeof repoHint === 'function' ? repoHint() : undefined)
+      const repo = git.repo
       if (sub === 'new') return { kind: 'success', text: buildIssueInstruction({ sub, title: rest.join(' '), repo }) }
       if (sub === 'show' && /^\d+$/.test(rest[0] || '')) return { kind: 'success', text: buildIssueInstruction({ sub, number: Number(rest[0]), repo }) }
       if (!sub || sub === 'list') return { kind: 'success', text: buildIssueInstruction({ sub: 'list', repo }) }

package/lib/scm-write.js

@@ -1,3 +1,4 @@
+import { realpathSync } from 'node:fs'
 // Writing to a working copy, from the Source Control tab.
 //
 // Every action is a list of argv arrays — never a shell string. The route runs them one by one
@@ -172,5 +173,16 @@ export function validateCwd(path) {
       throw new Error(`access to system directory "${root}" is not allowed`)
     }
   }
+  let realPath = value
+  try {
+    realPath = realpathSync(value)
+  } catch {
+    realPath = value
+  }
+  for (const root of DISALLOWED_ROOTS) {
+    if (realPath === root || realPath.startsWith(root + '/')) {
+      throw new Error(`access to system directory "${root}" is not allowed`)
+    }
+  }
   return value
 }

package/lib/status.js

@@ -14,8 +14,11 @@ function isTrustedHost(host) {
   if (hostname.startsWith('[')) {
     const end = hostname.indexOf(']')
     if (end > 0) hostname = hostname.slice(1, end)
-  } else {
-    hostname = hostname.split(':')[0]
+  } else if (hostname.includes(':')) {
+    const colons = hostname.split(':').length - 1
+    if (colons === 1) {
+      hostname = hostname.split(':')[0]
+    }
   }
   hostname = hostname.toLowerCase()
   if (!hostname) return false
@@ -43,6 +46,9 @@ export function isTrustedRequest(req) {
   const cleanIp = address.replace(/^::ffff:/, '')
   const loopback = cleanIp === '127.0.0.1' || cleanIp === '::1' || cleanIp.startsWith('127.')
 
+  // If socket remoteAddress is present, it MUST be a trusted local/private IP (never an untrusted remote IP)
+  if (cleanIp && !isTrustedHost(cleanIp)) return false
+
   const host = header(req, 'host')
   const origin = header(req, 'origin') || header(req, 'referer')
 
@@ -80,6 +86,12 @@ export function isTrustedWriteRequest(req) {
     return false
   }
 
+  const address = (req.socket && (req.socket.remoteAddress || req.socket.address?.().address)) || ''
+  const cleanIp = address.replace(/^::ffff:/, '')
+  const loopback = cleanIp === '127.0.0.1' || cleanIp === '::1' || cleanIp.startsWith('127.')
+
+  if (cleanIp && !isTrustedHost(cleanIp)) return false
+
   const host = header(req, 'host')
   const origin = header(req, 'origin') || header(req, 'referer')
   if (origin) {
@@ -91,9 +103,6 @@ export function isTrustedWriteRequest(req) {
     }
   } else {
     // Write request without origin: only permit local loopback
-    const address = (req.socket && (req.socket.remoteAddress || req.socket.address?.().address)) || ''
-    const cleanIp = address.replace(/^::ffff:/, '')
-    const loopback = cleanIp === '127.0.0.1' || cleanIp === '::1' || cleanIp.startsWith('127.')
     if (!loopback) return false
   }
 

package/lib/tools/mirror.js

@@ -162,7 +162,9 @@ export async function publishMirror({
 
   if (dryRun) return { ...plan, mirror: mirrorRef, parent, commit: null, pushed: false }
 
-  const indexFile = path.join(tmpdir(), `dsh-mirror-${process.pid}-${randomUUID()}.index`)
+  const fs = await import('node:fs/promises')
+  const tmpIndexDir = await fs.mkdtemp(path.join(tmpdir(), 'dsh-mirror-index-'))
+  const indexFile = path.join(tmpIndexDir, `mirror-${randomUUID()}.index`)
   const env = { GIT_INDEX_FILE: indexFile }
   try {
     await git(['read-tree', '--empty'], { cwd, env })
@@ -190,5 +192,6 @@ export async function publishMirror({
     }
   } finally {
     await git(['update-index', '--refresh'], { cwd, env }).catch(() => {})
+    await fs.rm(tmpIndexDir, { recursive: true, force: true }).catch(() => {})
   }
 }

package/lib/tools/register-collab.js

@@ -245,7 +245,7 @@ export function registerCollabTools({ tool, asRepo, client, liveConfig, reviewRu
       const { owner, repo } = await asRepo(args, liveConfig())
       return listReviewThreads(await client(), {
         owner, repo,
-        number: args.number || args.pullNumber,
+        number: args.number,
         unresolvedOnly: Boolean(args.unresolvedOnly),
       })
     },
@@ -266,7 +266,7 @@ export function registerCollabTools({ tool, asRepo, client, liveConfig, reviewRu
       const { owner, repo } = await asRepo(args, liveConfig())
       return replyReviewThread(await client(), {
         owner, repo,
-        number: args.number || args.pullNumber,
+        number: args.number,
         threadId: args.threadId,
         commentId: args.commentId,
         body: args.body,

package/lib/tools/register-core.js

@@ -1,3 +1,4 @@
+import { validateCwd } from '../scm-write.js'
 import { runReleasePreflight } from './release-preflight.js'
 // Core tool registrations: repository and file reads, releases, tags, the guarded
 // generic API pass-through, and repository creation/edits.
@@ -255,10 +256,10 @@ export function registerCoreTools({ tool, asRepo, client, liveConfig, defaultCwd
       const { owner, repo } = await asRepo(args, liveConfig())
       return generateReleaseNotes(await client(), {
         owner, repo,
-        tag: args.tag || args.tagName,
-        target: args.target || args.targetCommitish,
-        previousTag: args.previousTag || args.previousTagName,
-        configFile: args.configFile || args.configurationFilePath,
+        tag: args.tag,
+        target: args.target,
+        previousTag: args.previousTag,
+        configFile: args.configFile,
       })
     },
   )
@@ -337,16 +338,23 @@ export function registerCoreTools({ tool, asRepo, client, liveConfig, defaultCwd
 
   tool(
     'gh_release_preflight',
-    'Run automated pre-release audit on the plugin package: checks package.json version, cordis.patch.yml, CHANGELOG.md release notes, three READMEs (EN/RU/ZH), npm pack file sizes (<256 KiB), and git index hygiene.',
+    'Run automated pre-release audit on the plugin package: checks package.json version, cordis.patch.yml, CHANGELOG.md release notes, three READMEs (EN/RU/ZH), npm pack file sizes (<256 KiB), and git index hygiene. Running test suite requires confirm: true.',
     {
       cwd: { type: 'string', description: 'Directory to audit (defaults to workspace or process.cwd()).' },
-      runTests: { type: 'boolean', description: 'Whether to run npm test as part of the audit (default false).' },
+      runTests: { type: 'boolean', description: 'Whether to run npm test as part of the audit (requires confirm: true).' },
       maxFileSize: { type: 'number', description: 'Max allowed size in bytes per packaged file (default 262144).' },
+      confirm: { type: 'boolean', description: 'Must be true to execute npm test when runTests is true.' },
     },
     async (args) => {
+      if (args.runTests === true && args.confirm !== true) {
+        throw new Error('running test suite during preflight audit requires confirm: true')
+      }
+      const rawCwd = args.cwd || (typeof defaultCwd === 'function' ? defaultCwd() : process.cwd())
+      const validatedCwd = validateCwd(rawCwd)
       return runReleasePreflight({
-        cwd: args.cwd,
+        cwd: validatedCwd,
         runTests: args.runTests,
+        confirm: args.confirm,
         maxFileSize: args.maxFileSize,
       })
     },

package/lib/tools/register-write.js

@@ -210,7 +210,6 @@ export function registerWriteTools({ tool, asRepo, client, liveConfig, auth }) {
     'Report where the current access comes from and whether it works: the source (credential, environment, this plugin\'s sign-in, gh CLI), the account, and the remaining API rate limit. The value itself is never shown. Read-only.',
     {},
     async () => {
-      const cfg = liveConfig()
       const access = await auth.resolve()
       if (!access.value) return { configured: false, guidance: access.guidance }
       const github = await client()
@@ -240,6 +239,4 @@ export function registerWriteTools({ tool, asRepo, client, liveConfig, auth }) {
     },
   )
 
-  // keep the imports honest for callers that compose their own flows
-  return { accessFilePath, readAccessFile }
 }

package/lib/tools/release-preflight.js

@@ -1,3 +1,4 @@
+import { validateCwd } from '../scm-write.js'
 // lib/tools/release-preflight.js
 // Automated release preflight audit for DSH plugins according to
 // dhs-plugin-release-workflow and dsh-documentation-standard.
@@ -23,8 +24,12 @@ const FORBIDDEN_PACK_EXACT = ['AGENTS.md', '.env', '.env.local', 'deploy.sh']
  * @param {object} [deps] Injectable dependencies for unit testing
  */
 export async function runReleasePreflight(options = {}, deps = {}) {
-  const cwd = options.cwd || process.cwd()
+  const rawCwd = options.cwd || process.cwd()
+  const cwd = validateCwd(rawCwd)
   const runTests = options.runTests === true
+  if (runTests && options.confirm !== true) {
+    throw new Error('running test suite during preflight audit requires confirm: true')
+  }
   const maxFileSize = typeof options.maxFileSize === 'number' ? options.maxFileSize : MAX_FILE_SIZE_DEFAULT
   const exec = deps.execFile || pExecFile
   const fsRead = deps.readFileSync || readFileSync

package/lib/tools/releases.js

@@ -236,4 +236,3 @@ export async function generateReleaseNotes(client, { owner, repo, tag, target, p
     previousTag: previousTag || '',
   }
 }
-export { runReleasePreflight } from './release-preflight.js'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-github-ops",
-  "version": "0.2.11",
+  "version": "0.2.12",
   "description": "GitHub operations for DeepSeek Harness: releases, tags, a guarded generic API pass-through, workflow runs, secrets and sanitized mirror publication.",
   "license": "MIT",
   "type": "module",