@goodandready/dsh-clinebot 0.6.27 → 0.6.29

package/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.29] - 2026-11-06
+
+### Fixed
+- **DSH Desktop key verification (#295, GitHub #19)**: `assertTrustedSettingsRequest()` now accepts a write after `connection.requestRejection()` has admitted it, even when Desktop strips `Origin`/`Referer`. Host auth is called once, and unauthenticated loopback writes still require Origin/Referer.
+
+## [0.6.28] - 2026-11-05
+
+### Security
+- **Loopback hostname bypass (#294)**: URL hostnames are now matched exactly as `localhost`, `::1` or a valid `127.0.0.0/8` address; names such as `127.0.0.1.evil.example` no longer pass the HTTPS gate.
+
 ## [0.6.27] - 2026-11-05
 
 ### Security

package/README.md

@@ -4,7 +4,7 @@
 
 <h3>Native ClineBot / ClinePass Provider Companion for DeepSeek Harness</h3>
 
-<p><b>0.6.27</b> completes the native-settings security boundary: HTTPS-only remote endpoints, allowlisted credential names, path-safe telemetry/price writes, dangling-symlink rejection and a Windows-safe updater environment. It keeps DSH <code>0.2.2-rc.1</code> support, automatic model/free/dated catalog backfill, model-scoped credit cooldowns and 402/413 errors. Chat runs on the native <code>ctx.llm</code> adapter; the legacy <code>llm-pi-ai</code>, loopback proxy and <code>llm/stream</code> path are removed.</p>
+<p><b>0.6.29</b> fixes DSH Desktop key verification when the host strips <code>Origin</code>/<code>Referer</code> but admits the request through <code>connection.requestRejection()</code>. It keeps the complete security boundary from 0.6.28, DSH <code>0.2.2-rc.1</code> support, automatic model/free/dated catalog backfill, model-scoped credit cooldowns and 402/413 errors. Chat runs on the native <code>ctx.llm</code> adapter; the legacy <code>llm-pi-ai</code>, loopback proxy and <code>llm/stream</code> path are removed.</p>
 
 <p align="center">
   <a href="https://www.npmjs.com/package/@goodandready/dsh-clinebot"><img src="https://img.shields.io/npm/v/@goodandready/dsh-clinebot.svg?style=for-the-badge&color=6366f1&labelColor=1e1b4b" alt="npm version"></a>

package/README.ru.md

@@ -4,7 +4,7 @@
 
 <h3>Нативное подключение провайдера ClineBot / ClinePass для DeepSeek Harness</h3>
 
-<p><b>0.6.27</b> завершает security-границу native settings: HTTPS-only внешние endpoints, allowlist имён credentials, безопасные пути telemetry/price, отклонение dangling symlink и Windows-safe окружение updater. Сохраняются поддержка DSH <code>0.2.2-rc.1</code>, автодобор каталога моделей/FREE/dated, cooldown недостатка кредитов для конкретной модели и ошибки 402/413. Чат работает через нативный адаптер <code>ctx.llm</code>; старые <code>llm-pi-ai</code>, loopback-прокси и <code>llm/stream</code> удалены.</p>
+<p><b>0.6.29</b> исправляет проверку ключа в DSH Desktop, когда host убирает <code>Origin</code>/<code>Referer</code>, но принимает запрос через <code>connection.requestRejection()</code>. Сохраняются полная security-граница из 0.6.28, поддержка DSH <code>0.2.2-rc.1</code>, автодобор каталога моделей/FREE/dated, cooldown недостатка кредитов для конкретной модели и ошибки 402/413. Чат работает через нативный адаптер <code>ctx.llm</code>; старые <code>llm-pi-ai</code>, loopback-прокси и <code>llm/stream</code> удалены.</p>
 
 <p align="center">
   <a href="https://www.npmjs.com/package/@goodandready/dsh-clinebot"><img src="https://img.shields.io/npm/v/@goodandready/dsh-clinebot.svg?style=for-the-badge&color=6366f1&labelColor=1e1b4b" alt="npm version"></a>

package/README.zh.md

@@ -4,7 +4,7 @@
 
 <h3>适用于 DeepSeek Harness 的 ClineBot / ClinePass 原生模型提供商伴侣插件</h3>
 
-<p><b>0.6.27</b> 完善 native settings 安全边界：远程端点仅允许 HTTPS、凭据名称白名单、遥测/价格安全路径、拒绝悬空符号链接，以及 Windows 安全的 updater 环境。保留 DSH <code>0.2.2-rc.1</code> 支持、模型/免费/日期变体自动补齐、按模型隔离的余额不足冷却和明确的 402/413 错误。聊天使用原生 <code>ctx.llm</code> 适配器；旧的 <code>llm-pi-ai</code>、回环代理和 <code>llm/stream</code> 已删除。</p>
+<p><b>0.6.29</b> 修复 DSH Desktop 在移除 <code>Origin</code>/<code>Referer</code> 后通过 <code>connection.requestRejection()</code> 认证时密钥验证失败的问题。保留 0.6.28 的完整安全边界、DSH <code>0.2.2-rc.1</code> 支持、模型/免费/日期变体自动补齐、按模型隔离的余额不足冷却和明确的 402/413 错误。聊天使用原生 <code>ctx.llm</code> 适配器；旧的 <code>llm-pi-ai</code>、回环代理和 <code>llm/stream</code> 已删除。</p>
 
 <p align="center">
   <a href="https://www.npmjs.com/package/@goodandready/dsh-clinebot"><img src="https://img.shields.io/npm/v/@goodandready/dsh-clinebot.svg?style=for-the-badge&color=6366f1&labelColor=1e1b4b" alt="npm version"></a>

package/lib/access.js

@@ -4,6 +4,7 @@ export { isTrustedSettingsRequest }
 
 export function assertTrustedSettingsRequest(req, res, ctx = null) {
   const conn = getConnection(ctx) || req?.connectionService
+  let hostAuthAccepted = false
   if (conn && typeof conn.requestRejection === 'function') {
     let rejection
     try {
@@ -18,18 +19,20 @@ export function assertTrustedSettingsRequest(req, res, ctx = null) {
       })
       return false
     }
+    hostAuthAccepted = true
   }
 
-  if (!isTrustedSettingsRequest(req, ctx)) {
+  if (!isTrustedSettingsRequest(req, ctx, { skipConnectionAuth: hostAuthAccepted })) {
     writeJson(res, 403, { ok: false, error: 'Forbidden' })
     return false
   }
 
-  // A loopback-only caller is not enough for state changes: dsh-lanmode can
-  // proxy LAN/Tailscale clients into the host over loopback. Browsers attach
-  // Origin/Referer; non-browser writes without one are rejected fail-closed.
+  // A loopback-only caller is not enough for state changes unless the host
+  // authentication service explicitly admitted the request. DSH Desktop
+  // authenticates with its session cookie and strips Origin/Referer while
+  // forwarding to the local host; requiring those headers breaks Desktop.
   const method = String(req?.method || 'GET').toUpperCase()
-  if (method !== 'GET' && method !== 'HEAD' && method !== 'OPTIONS') {
+  if (!hostAuthAccepted && method !== 'GET' && method !== 'HEAD' && method !== 'OPTIONS') {
     const origin = req?.headers?.origin || req?.headers?.referer
     if (typeof origin !== 'string' || origin.length === 0) {
       writeJson(res, 403, { ok: false, error: 'Forbidden' })

package/lib/http.js

@@ -53,11 +53,19 @@ function isLoopbackAddress(value) {
     || address.startsWith('::ffff:127.')
 }
 
+function isLoopbackHostname(value) {
+  const host = String(value || '').toLowerCase().replace(/^\[|\]$/g, '')
+  if (host === 'localhost' || host === 'localhost.' || host === '::1') return true
+  const parts = host.split('.')
+  if (parts.length !== 4 || parts[0] !== '127') return false
+  return parts.every((part) => /^\d{1,3}$/.test(part) && Number(part) <= 255)
+}
+
 export function isSecureRemoteBaseUrl(value) {
   try {
     const url = new URL(String(value || ''))
     return url.protocol === 'https:'
-      || (url.protocol === 'http:' && isLoopbackAddress(url.hostname))
+      || (url.protocol === 'http:' && isLoopbackHostname(url.hostname))
   } catch {
     return false
   }
@@ -79,10 +87,12 @@ export function getConnection(ctx) {
 }
 
 /** Reject unauthenticated LAN/remote writes while allowing admitted DSH and local requests (#222). */
-export function isTrustedSettingsRequest(request, ctx = null) {
-  // 1. Core DSH connection auth gate (#222)
+export function isTrustedSettingsRequest(request, ctx = null, options = {}) {
+  // 1. Core DSH connection auth gate (#222). assertTrustedSettingsRequest may
+  // already have called it, so allow skipping the duplicate auth call safely.
   const conn = getConnection(ctx) || request?.connectionService
-  if (conn && typeof conn.requestRejection === 'function') {
+  const skipConnectionAuth = options?.skipConnectionAuth === true
+  if (!skipConnectionAuth && conn && typeof conn.requestRejection === 'function') {
     let rejection
     try {
       rejection = conn.requestRejection(request)
@@ -97,7 +107,7 @@ export function isTrustedSettingsRequest(request, ctx = null) {
   }
 
   const remoteLoopback = isLoopbackAddress(request?.socket?.remoteAddress)
-  const hasConnectionAuth = Boolean(conn && typeof conn.requestRejection === 'function')
+  const hasConnectionAuth = skipConnectionAuth || Boolean(conn && typeof conn.requestRejection === 'function')
   // Without the host auth service, a remote request cannot prove it is a
   // same-origin browser request: Origin/Referer/Sec-Fetch are caller-controlled.
   if (!hasConnectionAuth && !remoteLoopback) return false
@@ -113,7 +123,7 @@ export function isTrustedSettingsRequest(request, ctx = null) {
       if (host && url.host.toLowerCase() === host.toLowerCase()) {
         return true
       }
-      if (isLoopbackAddress(url.hostname) && remoteLoopback) {
+      if (isLoopbackHostname(url.hostname) && remoteLoopback) {
         return true
       }
       return false
@@ -129,7 +139,7 @@ export function isTrustedSettingsRequest(request, ctx = null) {
       if (host && url.host.toLowerCase() === host.toLowerCase()) {
         return true
       }
-      if (isLoopbackAddress(url.hostname) && remoteLoopback) {
+      if (isLoopbackHostname(url.hostname) && remoteLoopback) {
         return true
       }
       return false

package/lib/transport/cline-transport.js

@@ -10,7 +10,7 @@ import { createRequire } from 'node:module'
 import { isSecureRemoteBaseUrl } from '../http.js'
 
 const require = createRequire(import.meta.url)
-let packageVersion = '0.6.27'
+let packageVersion = '0.6.29'
 try {
   packageVersion = require('../../package.json').version || packageVersion
 } catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.6.27",
+  "version": "0.6.29",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",