@goodandready/dsh-clinebot 0.5.32 → 0.5.33

package/CHANGELOG.md

@@ -5,6 +5,15 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.33] - 2026-10-19
+
+### Security
+- **Proxy Token Isolation from Environment & Child Processes (Issue #247)**:
+  - Local proxy bearer authentication token (`CLINEBOT_LOCAL_PROXY_TOKEN`) is now retained strictly in module-private memory and never exported to `process.env`.
+  - Added startup and mutation scrubbing to ensure `process.env[CLINEBOT_LOCAL_PROXY_TOKEN]` is deleted immediately.
+  - Sanitized child process spawn environment in `lib/updater.js` to ensure the token cannot be inherited by sub-processes.
+  - Enforced unified DSH connection authorization gate (`connection.requestRejection`) across `/dsh-clinebot/v1/chat/completions` and `/dsh-clinebot/v1/models` endpoints.
+
 ## [0.5.32] - 2026-10-19
 
 ### Security

package/lib/proxy-token.js

@@ -1,22 +1,30 @@
 /**
- * Local Proxy Authentication Token (Issue #145)
+ * Local Proxy Authentication Token (Issues #145, #247)
  *
  * Secures transparent proxy endpoints (/dsh-clinebot/v1/*) from unauthorized
  * LAN clients or cross-site browser requests (CSRF).
+ * Token is stored strictly in-memory and isolated from process.env and child processes (#247).
  */
 
 import crypto from 'node:crypto'
 import { createRequire } from 'node:module'
-import { writeJson } from './http.js'
+import { writeJson, isLoopbackAddress, getConnection } from './http.js'
+import { resolveAccountPool } from './account-pool.js'
 
 export const LOCAL_PROXY_KEY_ENV = 'CLINEBOT_LOCAL_PROXY_TOKEN'
 
 let cachedToken = null
 
+// At module startup, scrub any token from process.env if present (#247)
+if (process.env[LOCAL_PROXY_KEY_ENV]) {
+  cachedToken = process.env[LOCAL_PROXY_KEY_ENV]
+  delete process.env[LOCAL_PROXY_KEY_ENV]
+}
+
 const require = createRequire(import.meta.url)
-let packageVersion = '0.5.32'
+let packageVersion = '0.5.33'
 try {
-  packageVersion = require('../package.json').version || '0.5.32'
+  packageVersion = require('../package.json').version || '0.5.33'
 } catch (err) {
   /* fallback to default version if manifest is unreadable */
 }
@@ -25,6 +33,7 @@ export const USER_AGENT = `@goodandready/dsh-clinebot/${packageVersion}`
 
 /**
  * Get or generate the local proxy bearer token.
+ * Token is stored strictly in module-private memory and never exported to process.env (#247).
  *
  * @returns {string}
  */
@@ -32,25 +41,22 @@ export function getLocalProxyToken() {
   if (cachedToken) return cachedToken
   if (process.env[LOCAL_PROXY_KEY_ENV]) {
     cachedToken = process.env[LOCAL_PROXY_KEY_ENV]
+    delete process.env[LOCAL_PROXY_KEY_ENV]
     return cachedToken
   }
   cachedToken = crypto.randomBytes(24).toString('hex')
-  process.env[LOCAL_PROXY_KEY_ENV] = cachedToken
   return cachedToken
 }
 
 /**
  * Manually set local proxy token (for testing).
+ * Never leaks token to process.env (#247).
  *
  * @param {string|null} token
  */
 export function setLocalProxyToken(token) {
   cachedToken = token
-  if (token) {
-    process.env[LOCAL_PROXY_KEY_ENV] = token
-  } else {
-    delete process.env[LOCAL_PROXY_KEY_ENV]
-  }
+  delete process.env[LOCAL_PROXY_KEY_ENV]
 }
 
 /**
@@ -75,6 +81,48 @@ export function isAuthorizedProxyRequest(req, accountPool = []) {
   return Array.isArray(accountPool) && accountPool.some((acc) => acc.value && acc.value === token)
 }
 
+/**
+ * Unified gate for proxy endpoints (/v1/chat/completions, /v1/models) (#247).
+ * Verifies loopback address, browser origin, DSH connection rejection, and bearer token.
+ */
+export async function assertAuthorizedProxyRequest(ctx, req, res, live) {
+  if (!isLoopbackAddress(req.socket?.remoteAddress)) {
+    writeJson(res, 403, { ok: false, error: 'Loopback access only' })
+    return { ok: false }
+  }
+
+  if (hasDisallowedBrowserOrigin(req)) {
+    writeJson(res, 403, { ok: false, error: 'Cross-site or browser requests to proxy are forbidden' })
+    return { ok: false }
+  }
+
+  const conn = getConnection(ctx) || req?.connectionService
+  if (conn && typeof conn.requestRejection === 'function') {
+    let rejection
+    try {
+      rejection = conn.requestRejection(req)
+    } catch {
+      rejection = 403
+    }
+    if (rejection !== undefined) {
+      const status = typeof rejection === 'number' ? rejection : 403
+      writeJson(res, status, {
+        ok: false,
+        error: status === 401 ? 'Authentication required' : 'Forbidden',
+      })
+      return { ok: false }
+    }
+  }
+
+  const pool = await resolveAccountPool(ctx, typeof live === 'function' ? live() : live)
+  if (!isAuthorizedProxyRequest(req, pool)) {
+    writeJson(res, 401, { ok: false, error: 'Unauthorized: missing or invalid bearer token' })
+    return { ok: false }
+  }
+
+  return { ok: true, pool }
+}
+
 /**
  * Write appropriate terminal JSON error response when retries are exhausted.
  */
@@ -119,7 +167,6 @@ export function sendProxyTerminalError(res, { hadTimeout, is429Exhausted, lastEr
   })
 }
 
-
 /**
  * Safely extract standard and reasoning token counts from usage object.
  */
@@ -137,4 +184,4 @@ export function extractUsageMetrics(usage) {
   )
   const totalTokens = Number(usage.total_tokens) || (promptTokens + completionTokens)
   return { promptTokens, completionTokens, reasoningTokens, totalTokens }
-}
+}

package/lib/routes/proxy.js

@@ -15,19 +15,19 @@
  * 7. Streaming SSE token usage interception & persistent telemetry recording.
  */
 
-import { writeJson, readBody, isLoopbackAddress } from '../http.js'
+import { writeJson, readBody } from '../http.js'
 import { publicConfig, plainConfig } from '../config.js'
-import { resolveAccountPool } from '../account-pool.js'
 import { resolveSessionAccount, markAccountCooldown } from '../session-router.js'
 import { recordUsage } from '../stats-storage.js'
 import { getAllModels, DEFAULT_MODEL_ID } from '../models.js'
 import { optimizePromptCacheAndBudget } from '../multimodal-budget.js'
 import {
   getLocalProxyToken, hasDisallowedBrowserOrigin, isAuthorizedProxyRequest,
+  assertAuthorizedProxyRequest,
   USER_AGENT, sendProxyTerminalError, extractUsageMetrics
 } from '../proxy-token.js'
 
-export { hasDisallowedBrowserOrigin, isAuthorizedProxyRequest, USER_AGENT }
+export { hasDisallowedBrowserOrigin, isAuthorizedProxyRequest, assertAuthorizedProxyRequest, USER_AGENT }
 
 export function createChatCompletionsHandler(ctx, { live, getSettingsApi, syncProviderState }) {
   return async (req, res) => {
@@ -35,18 +35,9 @@ export function createChatCompletionsHandler(ctx, { live, getSettingsApi, syncPr
       return writeJson(res, 405, { ok: false, error: 'POST only' })
     }
 
-    if (!isLoopbackAddress(req.socket?.remoteAddress)) {
-      return writeJson(res, 403, { ok: false, error: 'Loopback access only' })
-    }
-
-    if (hasDisallowedBrowserOrigin(req)) {
-      return writeJson(res, 403, { ok: false, error: 'Cross-site or browser requests to proxy are forbidden' })
-    }
-
-    const pool = await resolveAccountPool(ctx, live())
-    if (!isAuthorizedProxyRequest(req, pool)) {
-      return writeJson(res, 401, { ok: false, error: 'Unauthorized: missing or invalid bearer token' })
-    }
+    const auth = await assertAuthorizedProxyRequest(ctx, req, res, live)
+    if (!auth.ok) return
+    const pool = auth.pool
 
     let bodyBuf
     try {
@@ -543,18 +534,8 @@ export function createModelsHandler(ctx, { live }) {
       return writeJson(res, 405, { ok: false, error: 'GET only' })
     }
 
-    if (!isLoopbackAddress(req.socket?.remoteAddress)) {
-      return writeJson(res, 403, { ok: false, error: 'Loopback access only' })
-    }
-
-    if (hasDisallowedBrowserOrigin(req)) {
-      return writeJson(res, 403, { ok: false, error: 'Cross-site or browser requests to proxy are forbidden' })
-    }
-
-    const pool = await resolveAccountPool(ctx, live())
-    if (!isAuthorizedProxyRequest(req, pool)) {
-      return writeJson(res, 401, { ok: false, error: 'Unauthorized: missing or invalid bearer token' })
-    }
+    const auth = await assertAuthorizedProxyRequest(ctx, req, res, live)
+    if (!auth.ok) return
 
     const pub = publicConfig(live())
     const dynamic = Array.isArray(pub.dynamicModels) ? pub.dynamicModels : []

package/lib/updater.js

@@ -263,7 +263,11 @@ export async function installExact(target, packageSpec, options = {}) {
       cwd: target.profileDir,
       windowsHide: true,
       stdio: ['ignore', 'pipe', 'pipe'],
-      env: { ...process.env, NO_COLOR: '1' },
+      env: (() => {
+        const childEnv = { ...process.env, NO_COLOR: '1' }
+        delete childEnv.CLINEBOT_LOCAL_PROXY_TOKEN
+        return childEnv
+      })(),
       detached: options.detached !== undefined ? options.detached : process.platform !== 'win32',
     })
     let detail = ''

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.5.32",
+  "version": "0.5.33",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",