@goodandready/dsh-clinebot 0.5.13 → 0.5.15

package/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.15] - 2026-10-02
+
+### Fixed
+- **Atomic Catalog Snapshot Reset on Settings Persistence (Issue #192)**: In `settingsApi.update` and `settingsApi.replace`, defer invalidating the verified model catalog snapshot (`resetCatalogSnapshot()`) and updating `lastCatalogIdentity` until after persistence to the DSH settings service completes successfully. If settings persistence fails (e.g. revision conflict or rejection), local in-memory dynamic models and plan synchronization timestamp are strictly preserved, preventing catalog loss when endpoint and credentials remain unchanged.
+
+## [0.5.14] - 2026-10-02
+
+### Fixed
+- **Catalog Identity Lifecycle on Endpoint & Primary Credential Switch (Issue #168)**: Unified catalog invalidation under an identity contract: the verified catalog and plan synchronization timestamp strictly belong to the identity tuple (`baseUrl::activeAccount::apiKeyEnv`). Changing primary credential reference (`apiKeyEnv`) or provider endpoint (`baseUrl`) — via native Cosmokit volatile updates or `PUT /dsh-clinebot/config` — immediately resets `dynamicModels = []`, `planSyncedAt = 0`, and purges both usage and probe caches (`clearUsageCache()`, `clearProbeCache()`), preventing foreign or unverified model snapshots from persisting across endpoint or credential changes.
+
 ## [0.5.13] - 2026-10-02
 
 ### Fixed

package/lib/index.js

@@ -106,25 +106,35 @@ export function apply(ctx, config) {
     }
   }
 
-  let lastActiveAccount = publicConfig(live()).activeAccount
+  const normalizeEndpoint = (url) => String(url || '').trim().replace(/\/+$/, '')
+  const getCatalogIdentity = (cfg) => {
+    const pub = publicConfig(cfg)
+    return `${normalizeEndpoint(pub.baseUrl)}::${String(pub.activeAccount || '').trim()}::${String(pub.apiKeyEnv || '').trim()}`
+  }
+
+  let lastCatalogIdentity = getCatalogIdentity(live())
+  const resetCatalogSnapshot = () => {
+    try {
+      if (currentConfig && typeof currentConfig === 'object') {
+        currentConfig.dynamicModels = []
+        currentConfig.planSyncedAt = 0
+      }
+    } catch {
+      /* ignore read-only or frozen */
+    }
+    overrides.dynamicModels = []
+    overrides.planSyncedAt = 0
+    clearUsageCache()
+    clearProbeCache()
+  }
+
   if (typeof ctx?.on === 'function') {
     ctx.on('loader/volatile-update', () => {
       const liveCfg = live()
-      const currentActive = publicConfig(liveCfg).activeAccount
-      if (currentActive !== lastActiveAccount) {
-        lastActiveAccount = currentActive
-        try {
-          if (currentConfig && typeof currentConfig === 'object') {
-            currentConfig.dynamicModels = []
-            currentConfig.planSyncedAt = 0
-          }
-        } catch {
-          /* ignore read-only or frozen */
-        }
-        overrides.dynamicModels = []
-        overrides.planSyncedAt = 0
-        clearUsageCache()
-        clearProbeCache()
+      const currentIdentity = getCatalogIdentity(liveCfg)
+      if (currentIdentity !== lastCatalogIdentity) {
+        lastCatalogIdentity = currentIdentity
+        resetCatalogSnapshot()
       }
       syncStatsStorage(liveCfg)
     })
@@ -181,7 +191,14 @@ export function apply(ctx, config) {
       if (!svc || (typeof svc.replace !== 'function' && typeof svc.update !== 'function')) {
         throw new Error('DSH settings service is unavailable or non-writable')
       }
+      const prevIdentity = getCatalogIdentity(live())
       const parsed = Config(structuredClone(plainConfig(next)))
+      const nextIdentity = getCatalogIdentity(parsed)
+      const identityChanged = nextIdentity !== prevIdentity
+      if (identityChanged) {
+        if (!('dynamicModels' in next)) parsed.dynamicModels = []
+        if (!('planSyncedAt' in next)) parsed.planSyncedAt = 0
+      }
       const payload = volatileConfig(parsed)
       const rev = getRevision(svc)
       if (typeof svc.replace === 'function') {
@@ -189,6 +206,10 @@ export function apply(ctx, config) {
       } else {
         await svc.update(NS, payload, rev)
       }
+      if (identityChanged) {
+        lastCatalogIdentity = nextIdentity
+        resetCatalogSnapshot()
+      }
       applyConfigMutations(currentConfig, parsed)
       syncStatsStorage(live())
       await syncProviderState(live())
@@ -199,7 +220,14 @@ export function apply(ctx, config) {
       if (!svc || (typeof svc.update !== 'function' && typeof svc.replace !== 'function')) {
         throw new Error('DSH settings service is unavailable or non-writable')
       }
+      const prevIdentity = getCatalogIdentity(live())
       const merged = Config({ ...publicConfig(live()), ...plainConfig(patch) })
+      const nextIdentity = getCatalogIdentity(merged)
+      const identityChanged = nextIdentity !== prevIdentity
+      if (identityChanged) {
+        if (!('dynamicModels' in patch)) merged.dynamicModels = []
+        if (!('planSyncedAt' in patch)) merged.planSyncedAt = 0
+      }
       const payload = volatileConfig(merged)
       const rev = getRevision(svc)
       if (typeof svc.update === 'function') {
@@ -207,6 +235,10 @@ export function apply(ctx, config) {
       } else {
         await svc.replace(NS, payload, rev)
       }
+      if (identityChanged) {
+        lastCatalogIdentity = nextIdentity
+        resetCatalogSnapshot()
+      }
       applyConfigMutations(currentConfig, merged)
       syncStatsStorage(live())
       await syncProviderState(live())

package/lib/routes/settings.js

@@ -93,7 +93,10 @@ export function registerSettingsRoutes(ctx, { live, getSettingsApi, syncProvider
         const base = plainConfig(live()) || {}
         delete base.enabledModels
         const merged = { ...base, ...rawPayload }
-        if (rawPayload.activeAccount !== undefined && String(rawPayload.activeAccount).trim() !== String(base.activeAccount || "").trim()) {
+        const activeChanged = rawPayload.activeAccount !== undefined && String(rawPayload.activeAccount).trim() !== String(base.activeAccount || "").trim()
+        const apiKeyEnvChanged = rawPayload.apiKeyEnv !== undefined && String(rawPayload.apiKeyEnv).trim() !== String(base.apiKeyEnv || "").trim()
+        const baseUrlChanged = rawPayload.baseUrl !== undefined && String(rawPayload.baseUrl).trim().replace(/\/+$/, '') !== String(base.baseUrl || "").trim().replace(/\/+$/, '')
+        if (activeChanged || apiKeyEnvChanged || baseUrlChanged) {
           if (!("dynamicModels" in rawPayload)) merged.dynamicModels = []
           if (!("planSyncedAt" in rawPayload)) merged.planSyncedAt = 0
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.5.13",
+  "version": "0.5.15",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",