@goodandready/dsh-clinebot 0.4.5 → 0.4.6

package/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.6] - 2026-09-25
+
+### Fixed
+- **Obsolete Settings Service Dependency Removal (#119)**: Removed ` settings` from `inject` and eradicated legacy `ctx.inject([settings], ...)` and `sctx.settings.register(...)` calls, adapting to DSH 0.1.7 kernel architecture where the Cordis `settings` service was removed.
+- **Config Reader Export (#119)**: Exported `configReader(config)` returning `() => config` to provide standard DSH configuration introspection.
+- **Defensive SettingsForms Adapter (#119)**: Implemented lightweight `settingsApi` adapter providing `get()`, `replace()`, `update()`, and `watch()` without declaring `settings` in `inject`, accessing `ctx?.get?.(settings)` defensively.
+- **Failover & Settings Regression Tests (#119)**: Added 5 strict DoD regression tests verifying `inject`, absence of `settings.register`, proxy property safety, config reader, and strict proxy boot.
+
 ## [0.4.5] - 2026-09-25
 
 ### Fixed

package/lib/index.js

@@ -26,7 +26,11 @@ import { registerAuthRoutes } from './routes/auth.js'
 import { registerSlashCommand } from './slash-command.js'
 
 export const name = '@goodandready/dsh-clinebot'
-export const inject = ['settings', 'webServer', 'credentials']
+export const inject = ['webServer', 'credentials']
+
+export function configReader(config) {
+  return () => config
+}
 
 export { NS, LLM_PI_AI_NS, Config, sessionStats, recordSessionRequest, resetSessionStats, rotateToNextAccount }
 
@@ -56,66 +60,51 @@ export function apply(ctx, config) {
     autoDiscoverPlanModels(ctx, { live, getSettingsApi: () => settingsApi, syncProviderState })
   }
 
-  const createSettingsAdapter = (svc) => {
-    if (!svc) return undefined
-    if (typeof svc.replace === 'function' || typeof svc.update === 'function' || typeof svc.write === 'function') {
-      const getRevision = () => {
-        try {
-          return svc.describe?.().find((row) => row.ns === NS)?.revision
-        } catch {
-          return undefined
-        }
-      }
-      return {
-        get: () => live(),
-        replace: async (next) => {
-          const parsed = Config(structuredClone(plainConfig(next)))
-          currentConfig = parsed
-          const payload = volatileConfig(parsed)
-          if (typeof svc.replace === 'function') {
-            await svc.replace(NS, payload, getRevision())
-          } else if (typeof svc.update === 'function') {
-            await svc.update(NS, payload, getRevision())
-          }
-          return parsed
-        },
-        update: async (patch) => {
-          const merged = Config({ ...publicConfig(live()), ...plainConfig(patch) })
-          currentConfig = merged
-          const payload = volatileConfig(merged)
-          if (typeof svc.update === 'function') {
-            await svc.update(NS, payload, getRevision())
-          } else if (typeof svc.replace === 'function') {
-            await svc.replace(NS, payload, getRevision())
-          }
-          return merged
-        },
-        watch: (cb) => {
-          if (typeof svc.watch === 'function') return svc.watch(cb)
-          return () => {}
-        },
-      }
+  const getRevision = (svc) => {
+    try {
+      return svc?.describe?.().find((row) => row.ns === NS)?.revision
+    } catch {
+      return undefined
     }
-    return undefined
   }
 
-  if (typeof ctx.inject === 'function') {
-    ctx.inject(['settings'], (sctx) => {
-      if (typeof sctx.settings?.register === 'function') {
-        const scope = sctx.settings.register(NS, Config, { base: config })
-        settingsApi = scope
-        getConfig = () => (scope?.get?.() ?? config) ?? config
-        sctx.effect(() => scope.watch((next) => {
-          syncProviderState(live())
-        }), 'dsh-clinebot: settings')
-      } else {
-        settingsApi = createSettingsAdapter(sctx.settings)
+  settingsApi = {
+    get: () => live(),
+    replace: async (next) => {
+      const parsed = Config(structuredClone(plainConfig(next)))
+      currentConfig = parsed
+      const svc = ctx?.get?.('settings')
+      if (svc) {
+        const payload = volatileConfig(parsed)
+        if (typeof svc.replace === 'function') {
+          await svc.replace(NS, payload, getRevision(svc))
+        } else if (typeof svc.update === 'function') {
+          await svc.update(NS, payload, getRevision(svc))
+        }
       }
-      sctx.effect(() => () => {
-        getConfig = () => config
-        settingsApi = undefined
-      })
-    })
+      await syncProviderState(live())
+      return parsed
+    },
+    update: async (patch) => {
+      const merged = Config({ ...publicConfig(live()), ...plainConfig(patch) })
+      currentConfig = merged
+      const svc = ctx?.get?.('settings')
+      if (svc) {
+        const payload = volatileConfig(merged)
+        if (typeof svc.update === 'function') {
+          await svc.update(NS, payload, getRevision(svc))
+        } else if (typeof svc.replace === 'function') {
+          await svc.replace(NS, payload, getRevision(svc))
+        }
+      }
+      await syncProviderState(live())
+      return merged
+    },
+    watch: (cb) => {
+      const svc = ctx?.get?.('settings')
+      if (typeof svc?.watch === 'function') return svc.watch(cb)
+      return () => {}
+    },
   }
 
   syncProviderState(live())

package/lib/slash-command.js

@@ -22,6 +22,7 @@ import {
 } from './cline-client.js'
 
 export function registerSlashCommand(ctx, { live, getSettingsApi, syncProviderState }) {
+  if (typeof ctx.inject !== 'function') return
   ctx.inject(['commands'], (cmdCtx) => {
     const commands = cmdCtx.commands
     if (typeof commands?.register !== 'function') return

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",