@goodandready/dsh-clinebot 0.3.24 → 0.3.25

package/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.25] - 2026-09-24
+
+### Fixed
+
+- **SettingsPage "Settings Unavailable" Banner Removal (#96 / GitHub #7)**: Removed the blocking `snapshotStatus === 'unavailable'` render gate in `SettingsPage`. When DSH serves no native settings form or when the page is accessed over non-loopback connections (`persistence === 'memory'`), the page no longer displays the dead-end warning banner and instead smoothly renders its fully functional standalone REST UI from `/dsh-clinebot/status` and `/dsh-clinebot/config`.
+- **Modern DSH `SettingsForms` Adapter**: In `lib/index.js`, implemented a robust adapter for modern DSH `SettingsForms` (`svc.replace` / `svc.update` / `svc.describe`). DSH 0.1.7 removed `sctx.settings.register`, which previously caused `PUT /dsh-clinebot/config` to fail with HTTP 503 `settings not ready` and prevented key changes, account switching, and model toggles from persisting to DSH.
+- **Volatile Field Projection (`volatileConfig`)**: Marked only user-editable settings as `.volatile()`, leaving internal derived fields (`dynamicModels` and deprecated `enabledModels`) non-volatile. Added `volatileConfig` helper to strip non-volatile fields before passing payloads to `SettingsForms.replace`, preventing DSH from rejecting configuration writes with `Config field is not volatile`.
+
 ## [0.3.24] - 2026-09-24
 
 ### Fixed

package/lib/client.js

@@ -1199,13 +1199,6 @@ function SettingsPage(props) {
   }
 
   if (!status || !draft) {
-    if (snapshotStatus === 'unavailable') {
-      return React.createElement(
-        'div',
-        { className: 'cb-page' },
-        React.createElement('div', { className: 'cb-banner-warning' }, t('settings.unavailable'))
-      )
-    }
     if (err) {
       return React.createElement(
         'div',

package/lib/config.js

@@ -38,7 +38,7 @@ export const Config = z.object({
   disabledModels: z.array(z.string()).default([])
     .description('List of model IDs explicitly disabled by the user (new models are enabled automatically).').volatile(),
   enabledModels: z.array(z.string()).default([])
-    .description('Deprecated: preserved for backwards compatibility with earlier versions.').volatile(),
+    .description('Deprecated: preserved for backwards compatibility with earlier versions.'),
   dynamicModels: z.array(z.object({
     id: z.string(),
     name: z.string(),
@@ -50,7 +50,7 @@ export const Config = z.object({
     isCustom: z.boolean().default(false),
     reasoningEfforts: z.any().default(undefined),
   })).default([])
-    .description('Models automatically discovered from the official ClinePass subscription plan.').volatile(),
+    .description('Models automatically discovered from the official ClinePass subscription plan.'),
   timeoutMs: z.number().default(DEFAULT_TIMEOUT_MS)
     .description('HTTP probe timeout in milliseconds.').volatile(),
   smokeTimeoutMs: z.number().default(DEFAULT_SMOKE_TIMEOUT_MS)
@@ -84,6 +84,18 @@ export function plainConfig(cfg) {
   return out
 }
 
+export function volatileConfig(cfg) {
+  const plain = plainConfig(cfg)
+  if (!plain || typeof plain !== 'object') return plain
+  const out = {}
+  for (const [key, field] of Object.entries(Config.dict || {})) {
+    if (field?.meta?.volatile && Object.hasOwn(plain, key)) {
+      out[key] = plain[key]
+    }
+  }
+  return out
+}
+
 export function publicConfig(cfg) {
   cfg = plainConfig(cfg)
   const dynamic = Array.isArray(cfg?.dynamicModels) ? cfg.dynamicModels : []

package/lib/index.js

@@ -1,4 +1,4 @@
-import { Config, publicConfig, plainConfig, NS, LLM_PI_AI_NS } from './config.js'
+import { Config, publicConfig, plainConfig, volatileConfig, NS, LLM_PI_AI_NS } from './config.js'
 import { registerPluginUpdater } from './updater.js'
 import {
   sessionStats,
@@ -29,7 +29,8 @@ export const inject = ['settings', 'webServer', 'credentials']
 export { NS, LLM_PI_AI_NS, Config, sessionStats, recordSessionRequest, resetSessionStats, rotateToNextAccount }
 
 export function apply(ctx, config) {
-  let getConfig = () => config
+  let currentConfig = config
+  let getConfig = () => currentConfig
   const live = () => (getConfig() ? Config(structuredClone(plainConfig(getConfig()))) : config)
   let settingsApi
 
@@ -55,14 +56,61 @@ export function apply(ctx, config) {
     autoDiscoverPlanModels(ctx, { live, getSettingsApi: () => settingsApi, syncProviderState })
   }
 
+  const createSettingsAdapter = (svc) => {
+    if (!svc) return undefined
+    if (typeof svc.replace === 'function' || typeof svc.update === 'function' || typeof svc.write === 'function') {
+      const getRevision = () => {
+        try {
+          return svc.describe?.().find((row) => row.ns === NS)?.revision
+        } catch {
+          return undefined
+        }
+      }
+      return {
+        get: () => live(),
+        replace: async (next) => {
+          const parsed = Config(structuredClone(plainConfig(next)))
+          currentConfig = parsed
+          const payload = volatileConfig(parsed)
+          if (typeof svc.replace === 'function') {
+            await svc.replace(NS, payload, getRevision())
+          } else if (typeof svc.update === 'function') {
+            await svc.update(NS, payload, getRevision())
+          }
+          return parsed
+        },
+        update: async (patch) => {
+          const merged = Config({ ...publicConfig(live()), ...plainConfig(patch) })
+          currentConfig = merged
+          const payload = volatileConfig(merged)
+          if (typeof svc.update === 'function') {
+            await svc.update(NS, payload, getRevision())
+          } else if (typeof svc.replace === 'function') {
+            await svc.replace(NS, payload, getRevision())
+          }
+          return merged
+        },
+        watch: (cb) => {
+          if (typeof svc.watch === 'function') return svc.watch(cb)
+          return () => {}
+        },
+      }
+    }
+    return undefined
+  }
+
   if (typeof ctx.inject === 'function') {
     ctx.inject(['settings'], (sctx) => {
-      const scope = sctx.settings.register(NS, Config, { base: config })
-      settingsApi = scope
-      getConfig = () => (scope?.get?.() ?? config) ?? config
-      sctx.effect(() => scope.watch((next) => {
-        syncProviderState(live())
-      }), 'dsh-clinebot: settings')
+      if (typeof sctx.settings?.register === 'function') {
+        const scope = sctx.settings.register(NS, Config, { base: config })
+        settingsApi = scope
+        getConfig = () => (scope?.get?.() ?? config) ?? config
+        sctx.effect(() => scope.watch((next) => {
+          syncProviderState(live())
+        }), 'dsh-clinebot: settings')
+      } else {
+        settingsApi = createSettingsAdapter(sctx.settings)
+      }
       sctx.effect(() => () => {
         getConfig = () => config
         settingsApi = undefined
@@ -79,6 +127,8 @@ export function apply(ctx, config) {
           syncProviderState(live())
         }), 'dsh-clinebot: settings')
       }
+    } else {
+      settingsApi = createSettingsAdapter(settingsService)
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.3.24",
+  "version": "0.3.25",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",