@goodandready/dsh-clinebot 0.3.20 → 0.3.22

package/CHANGELOG.md

@@ -5,6 +5,17 @@ All notable changes to `@goodandready/dsh-clinebot` will be documented in this f
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.22] - 2026-09-24
+
+### Fixed
+- **SettingsPage Crash on Cordis Strict Context (#67 / GitHub #4)**: Fixed unhandled `TypeError: cannot get property "settingsScope" without inject` thrown when accessing `ctx?.settingsScope` under DSH 0.17+ / Cordis v3+ strict proxy contexts. Replaced bare property access with defensive `ctx.get('lanSettings') || ctx.get('settingsScope')` inside `try/catch` across both `settings-page.js` and `entry.js`.
+- **Standalone Unblocked UI Rendering**: When `settingsScope` / `lanSettings` service is absent or not injected in the client fiber, `SettingsPage` snapshot now defaults to `{ status: 'ready', view: null }` instead of permanently hanging on `status: 'loading'`. The settings page is entirely functional via its own HTTP REST endpoints (`/dsh-clinebot/status`, `/save-key`, `/models/toggle`, etc.).
+
+## [0.3.21] - 2026-09-23
+
+### Fixed
+- **Account Failover Persistence & Cache Invalidation (#61)**: Fixed `rotateToNextAccount` returning `rotated: true` when settings persistence (`settingsApi.replace` or `settings.mutate`) fails. It now returns `{ rotated: false, activeAccount: active, reason: 'failed_to_persist' }` on failure, and defers `clearUsageCache()` and `clearProbeCache()` until settings are confirmed written. This prevents the provider from staying on the previous account while its quota and health telemetry caches are wiped.
+
 ## [0.3.20] - 2026-09-23
 
 ### Fixed

package/lib/account-pool.js

@@ -117,6 +117,17 @@ export async function rotateToNextAccount(ctx, cfg, reason = 'rate_limit', setti
     }
   }
 
+  if (!updated) {
+    return {
+      rotated: false,
+      previousAccount: active,
+      activeAccount: active,
+      reason: 'failed_to_persist',
+      message: 'Failed to persist rotated activeAccount to settings',
+      updatedSettings: false,
+    }
+  }
+
   // Reset cached quota and host probes so new account immediately revalidates
   clearUsageCache()
   clearProbeCache()
@@ -126,6 +137,6 @@ export async function rotateToNextAccount(ctx, cfg, reason = 'rate_limit', setti
     previousAccount: active,
     activeAccount: nextAcc.apiKeyEnv,
     reason,
-    updatedSettings: updated,
+    updatedSettings: true,
   }
 }

package/lib/client.js

@@ -839,13 +839,31 @@ function SettingsPage(props) {
   const t = props?.t || makeT(en, en)
 
   const scope = React.useMemo(() => {
-    const s = (ctx?.get && ctx.get('lanSettings')) || ctx?.settingsScope
-    if (!s?.bind) return undefined
+    let s = null
     try {
-      return s.bind({ namespace: NS })
+      if (typeof ctx?.get === 'function') {
+        s = ctx.get('lanSettings') || ctx.get('settingsScope')
+      }
+    } catch (_) {
+      s = null
+    }
+    if (!s) {
+      try {
+        if (ctx && typeof ctx === 'object') {
+          s = ctx.lanSettings || ctx.settingsScope || null
+        }
+      } catch (_) {
+        s = null
+      }
+    }
+    if (!s) return undefined
+    try {
+      if (typeof s.bind === 'function') return s.bind({ namespace: NS })
+      if (typeof s.get === 'function') return s.get(NS)
     } catch (_) {
       return undefined
     }
+    return undefined
   }, [ctx])
 
   const subscribe = React.useMemo(() => {
@@ -860,11 +878,11 @@ function SettingsPage(props) {
   }, [scope])
 
   const getSnapshot = React.useCallback(() => {
-    if (!scope?.getSnapshot) return SNAPSHOT_LOADING
+    if (!scope?.getSnapshot) return { status: 'ready', view: null }
     try {
-      return scope.getSnapshot() || SNAPSHOT_LOADING
+      return scope.getSnapshot() || { status: 'ready', view: null }
     } catch (_) {
-      return SNAPSHOT_LOADING
+      return { status: 'ready', view: null }
     }
   }, [scope])
 
@@ -1369,28 +1387,48 @@ function PluginCard(props) {
 
 // --- src/client/entry.js ---
 function refreshMirrorUntilVisible(ctx) {
+  const getSettingsService = () => {
+    try {
+      if (typeof ctx?.get === 'function') {
+        const s = ctx.get('lanSettings') || ctx.get('settingsScope')
+        if (s) return s
+      }
+    } catch (_) {}
+    try {
+      if (ctx && typeof ctx === 'object') {
+        return ctx.lanSettings || ctx.settingsScope || null
+      }
+    } catch (_) {}
+    return null
+  }
+
+  const s = getSettingsService()
+  if (!s) return
+
   const visible = () => {
     try {
-      const s = (ctx?.get && ctx.get('lanSettings')) || ctx?.settingsScope
-      const view = s?.describe?.()?.getSnapshot?.()?.view
+      const current = getSettingsService()
+      const view = current?.describe?.()?.getSnapshot?.()?.view
       return !!view && Array.isArray(view.namespaces) && view.namespaces.some((row) => row.ns === NS)
     } catch (_) {
       return false
     }
   }
-  if (visible()) return () => {}
+  if (visible()) return
+
+  if (typeof setInterval !== 'function') return
+
   let tries = 0
   const timer = setInterval(() => {
     if (visible() || tries >= 15) { clearInterval(timer); return }
     tries += 1
     try {
-      const s = (ctx?.get && ctx.get('lanSettings')) || ctx?.settingsScope
-      s?.describe?.()?.load?.()
+      const current = getSettingsService()
+      current?.describe?.()?.load?.()
     } catch (e) {
       console.debug?.('[dsh-clinebot] Polling settings mirror:', e)
     }
   }, 1000)
-  return () => clearInterval(timer)
 }
 
 function apply(ctx) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-clinebot",
-  "version": "0.3.20",
+  "version": "0.3.22",
   "description": "DeepSeek Harness companion for ClineBot / ClinePass: dynamic subscription models sync, quota exhaustion warnings, session metrics, dedicated settings page, live usage limits, and /cline slash-command.",
   "license": "MIT",
   "type": "module",