@goodandready/dsh-approval-gate 0.1.27 → 0.1.28

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.28
+
+- Fix: Безопасное чтение версии хоста в lib/compat.js через ctx.get(version) и защищенный доступ без падений на строгих Proxy-контекстах Cordis при отсутствии инжекции version (Refs: #184).
+
 ## 0.1.27
 
 - Feature: Интерактивный визуальный редактор правил и белых списков путей (ApprovalGateSettingsCard в lib/client.js, TimelineService endpoints /rules в lib/timeline-service.js, слот settings.plugin.item) (Refs: #49).

package/lib/compat.js

@@ -1,8 +1,10 @@
 // lib/compat.js
-// Host compatibility checks and polyfills across DeepSeek Harness minor versions (#106).
+// Host compatibility checks and polyfills across DeepSeek Harness minor versions (#106, #184).
 
 /**
- * Detects available runtime capabilities and services in the Cordis host context (#106).
+ * Detects available runtime capabilities and services in the Cordis host context (#106, #184).
+ * Safely accesses properties via ctx.get() and guarded property lookup to avoid
+ * throwing in strict Cordis contexts where uninjected property access is forbidden.
  *
  * @param {any} ctx - Cordis / DSH host context
  * @returns {{
@@ -11,7 +13,7 @@
  *   hasPreExecuteHook: boolean,
  *   hasProvideApi: boolean,
  *   hasLocaleService: boolean,
- *   harnessVersion: string | null
+ *   harnessVersion: string
  * }}
  */
 export function detectHarnessCapabilities(ctx) {
@@ -22,39 +24,48 @@ export function detectHarnessCapabilities(ctx) {
       hasPreExecuteHook: false,
       hasProvideApi: false,
       hasLocaleService: false,
-      harnessVersion: null,
+      harnessVersion: "unknown",
     };
   }
 
-  const getService = (name) => {
+  const safeGet = (name) => {
     try {
       if (typeof ctx.get === "function") return ctx.get(name);
     } catch {
       // ignore
     }
-    return ctx[name];
+    try {
+      return ctx[name];
+    } catch {
+      return undefined;
+    }
   };
 
-  const tools = getService("tools");
-  const locale = getService("locale");
+  const tools = safeGet("tools");
+  const locale = safeGet("locale");
+  const onFn = safeGet("on");
+  const provideFn = safeGet("provide");
+
+  const rawVersion = safeGet("version");
 
   const harnessVersion =
-    (typeof ctx.version === "string" && ctx.version) ||
-    (typeof process.env.DSH_VERSION === "string" && process.env.DSH_VERSION) ||
-    null;
+    (typeof rawVersion === "string" && rawVersion.trim()) ||
+    (rawVersion && typeof rawVersion === "object" && typeof rawVersion.version === "string" && rawVersion.version.trim()) ||
+    (typeof process.env.DSH_VERSION === "string" && process.env.DSH_VERSION.trim()) ||
+    "unknown";
 
   return {
     hasContext: true,
     hasToolsService: Boolean(tools),
-    hasPreExecuteHook: typeof ctx.on === "function",
-    hasProvideApi: typeof ctx.provide === "function",
+    hasPreExecuteHook: typeof onFn === "function",
+    hasProvideApi: typeof provideFn === "function",
     hasLocaleService: Boolean(locale && typeof locale.register === "function"),
     harnessVersion,
   };
 }
 
 /**
- * Asserts host compatibility and identifies missing optional or required features (#106).
+ * Asserts host compatibility and identifies missing optional or required features (#106, #184).
  *
  * @param {any} ctx
  * @param {{ requireTools?: boolean }} [options]
@@ -80,7 +91,7 @@ export function assertHarnessCompatibility(ctx, options = {}) {
 }
 
 /**
- * Safely provides a service to the host context with backward-compatible polyfill (#106).
+ * Safely provides a service to the host context with backward-compatible polyfill (#106, #184).
  *
  * @param {any} ctx
  * @param {string} serviceName
@@ -90,21 +101,32 @@ export function assertHarnessCompatibility(ctx, options = {}) {
 export function provideServicePolyfill(ctx, serviceName, serviceInstance) {
   if (!ctx || typeof ctx !== "object" || !serviceName) return false;
 
-  if (typeof ctx.provide === "function") {
+  let provideFn = undefined;
+  try {
+    provideFn = ctx.provide;
+  } catch {
+    // ignore
+  }
+
+  if (typeof provideFn === "function") {
     try {
-      ctx.provide(serviceName, serviceInstance);
+      provideFn.call(ctx, serviceName, serviceInstance);
       return true;
     } catch {
       // fallback to property assignment below
     }
   }
 
-  ctx[serviceName] = serviceInstance;
-  return true;
+  try {
+    ctx[serviceName] = serviceInstance;
+    return true;
+  } catch {
+    return false;
+  }
 }
 
 /**
- * Safely attaches an event hook to the host context with error boundary (#106).
+ * Safely attaches an event hook to the host context with error boundary (#106, #184).
  *
  * @param {any} ctx
  * @param {string} event
@@ -112,12 +134,23 @@ export function provideServicePolyfill(ctx, serviceName, serviceInstance) {
  * @returns {(() => void) | null} Unsubscribe dispose function or null
  */
 export function registerHookPolyfill(ctx, event, handler) {
-  if (!ctx || typeof ctx.on !== "function" || typeof handler !== "function") {
+  if (!ctx || typeof ctx !== "object" || typeof handler !== "function") {
+    return null;
+  }
+
+  let onFn = undefined;
+  try {
+    onFn = ctx.on;
+  } catch {
+    // ignore
+  }
+
+  if (typeof onFn !== "function") {
     return null;
   }
 
   try {
-    return ctx.on(event, handler);
+    return onFn.call(ctx, event, handler);
   } catch {
     return null;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@goodandready/dsh-approval-gate",
-  "version": "0.1.27",
+  "version": "0.1.28",
   "description": "Host-only command safety gate for DeepSeek Harness: blocks recognized dangerous operations and requests DSH approval when a command cannot be inspected.",
   "type": "module",
   "main": "lib/index.js",