@gomusdev/web-components 4.8.0 → 4.8.2

package/README.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 4.8.2 (2026-07-16)
+
+### Bug Fixes
+
+* **mr2:** expand spec detection to include sibling `spec/` subdirectory
+* **ticket-selection:** derive day-ticket time per ticket, not from first quota (TC-04), closes [#136](https://gitlab.giantmonkey.de/gomus/frontend/issues/136)
+
+## 4.8.1 (2026-07-16)
+
+### Bug Fixes
+
+* **couponRedemption:** clear stale error when flush() succeeds
+* **forms:** clear form-level api errors on valid submit, closes [#apiErrors](https://gitlab.giantmonkey.de/gomus/frontend/issues/apiErrors) [#147](https://gitlab.giantmonkey.de/gomus/frontend/issues/147)
+* **forms:** reset stale success message on valid submit
+
 ## 4.8.0 (2026-07-15)
 
 ### Features

package/dist-js/gomus-webcomponents.iife.js

@@ -11860,6 +11860,17 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 	function initUITimeslotTickets(tickets, selectedTime = "") {
 		return sort(Object.values(tickets).map((ticket) => createUITicket(ticket, { selectedTime })), (f) => f.shop_order);
 	}
+	/**
+	* Day tickets (TC-04): each day quota keys its capacity at its OWN first-entry time, so
+	* capacity keys differ across quotas. The day 'time' must be derived per ticket — the
+	* first positive key of the ticket's own total_capacities — never from one global quota
+	* key. A ticket with capacity keys that are all zero is sold out and dropped; a ticket
+	* with no keys at all (no quota) is kept and gets `fallbackTime`.
+	*/
+	function initUIDayTickets(tickets, fallbackTime) {
+		const ownDayTime = (t) => Object.keys(t.total_capacities ?? {}).find((key) => (t.total_capacities?.[key] ?? 0) > 0);
+		return sort(Object.values(tickets).filter((t) => ownDayTime(t) || Object.keys(t.total_capacities ?? {}).length === 0).map((t) => createUITicket(t, { selectedTime: ownDayTime(t) ?? fallbackTime })), (f) => f.shop_order);
+	}
 	function filterAvailabletickets(tickets, selectedTime = "") {
 		let available = Object.entries(tickets);
 		if (selectedTime !== "") available = available.filter(([, t]) => t.total_capacities?.[selectedTime] && t.total_capacities[selectedTime] > 0);
@@ -14872,6 +14883,7 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 		* @param {string[] | Record<string, string[]>} errors - Errors passed as an array or an object where keys are API field keys and values are arrays of error messages. If an array is provided, it assigns the errors directly. If an object is provided, it maps the errors to the respective fields based on their API keys.
 		*/
 		set apiErrors(errors) {
+			set(this.#apiErrors, [], true);
 			this.fields.forEach((f) => f.apiErrors = []);
 			if (isArray(errors)) {
 				set(this.#apiErrors, errors, true);
@@ -14912,7 +14924,7 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 		*/
 		get fields() {
 			const parent = this.form.closest("go-form");
-			return Array.from(this.form.querySelectorAll("go-field")).filter((fe) => fe.closest("go-form") === parent).map((fe) => fe.getField?.()).filter((f) => f);
+			return Array.from(this.form.querySelectorAll("go-field")).filter((fe) => fe.closest("go-form") === parent).map((fe) => fe.getField?.()).filter((f) => !!f);
 		}
 		toString() {
 			return `Form: ${this.formId}, Fields: [${this.fields.map((f) => f.key).join(", ")}], Data: ${JSON.stringify(this.formData)}`;
@@ -14980,6 +14992,7 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 			details?.form?.dispatchEvent(new Event("go-after-validation", event));
 			if (details.isValid) {
 				details.apiErrors = {};
+				details.successMessage = void 0;
 				details?.form?.dispatchEvent(new Event("go-submit", event));
 				$$props.$$host.dispatchEvent(new Event("submit", {
 					bubbles: true,
@@ -18599,6 +18612,7 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 				form.details.apiErrors = result.errors;
 				return result;
 			}
+			form.details.apiErrors = [];
 			if (field) field.value = "";
 			form.dispatchEvent(new Event("go-success", {
 				bubbles: true,
@@ -35400,11 +35414,9 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 					"by_ticket_group_ids[]": segment.ticketGroupIds ?? tsd.ticketGroupIds
 				}));
 				shop.capacityManager.addQuotas(quotas);
-				const firstQuota = Object.values(quotas)[0];
-				const timeslot = firstQuota ? Object.keys(firstQuota.capacities)[0] : void 0;
-				const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, timeslot), timeslot);
+				const uiTickets = initUIDayTickets(tickets);
 				await enrichTicketsWithContent(segment, uiTickets);
-				for (const ticket of uiTickets) segment.preCart.addItem(createCartItem(ticket, { time: timeslot }));
+				for (const ticket of uiTickets) segment.preCart.addItem(createCartItem(ticket, { time: ticket.selectedTime }));
 			}
 		},
 		"ticket:annual": {
@@ -35496,11 +35508,9 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 					valid_at: tsd.selectedDate.toString()
 				}));
 				shop.capacityManager.addQuotas(quotas);
-				const firstQuota = Object.values(quotas)[0];
-				const time = firstQuota ? Object.keys(firstQuota.capacities)[0] : void 0;
-				const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, time), time);
+				const uiTickets = initUIDayTickets(tickets);
 				await enrichTicketsWithContent(segment, uiTickets);
-				for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time }));
+				for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time: t.selectedTime }));
 			}
 		},
 		"event:admission:timeslot": {
@@ -35659,11 +35669,9 @@ Set the \`cycles\` parameter to \`"ref"\` to resolve cyclical schemas with defs.
 						valid_at: date.start_time.slice(0, 10)
 					}));
 					shop.capacityManager.addQuotas(quotas);
-					const firstQuota = Object.values(quotas)[0];
-					const time = firstQuota ? Object.keys(firstQuota.capacities)[0] : date.start_time;
-					const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, time), time);
+					const uiTickets = initUIDayTickets(tickets, date.start_time);
 					await enrichTicketsWithContent(segment, uiTickets);
-					for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time }));
+					for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time: t.selectedTime }));
 				}
 			}
 		},

package/dist-js/gomus-webcomponents.js

@@ -11859,6 +11859,17 @@ function createUITicket(apiTicket, options) {
 function initUITimeslotTickets(tickets, selectedTime = "") {
 	return sort(Object.values(tickets).map((ticket) => createUITicket(ticket, { selectedTime })), (f) => f.shop_order);
 }
+/**
+* Day tickets (TC-04): each day quota keys its capacity at its OWN first-entry time, so
+* capacity keys differ across quotas. The day 'time' must be derived per ticket — the
+* first positive key of the ticket's own total_capacities — never from one global quota
+* key. A ticket with capacity keys that are all zero is sold out and dropped; a ticket
+* with no keys at all (no quota) is kept and gets `fallbackTime`.
+*/
+function initUIDayTickets(tickets, fallbackTime) {
+	const ownDayTime = (t) => Object.keys(t.total_capacities ?? {}).find((key) => (t.total_capacities?.[key] ?? 0) > 0);
+	return sort(Object.values(tickets).filter((t) => ownDayTime(t) || Object.keys(t.total_capacities ?? {}).length === 0).map((t) => createUITicket(t, { selectedTime: ownDayTime(t) ?? fallbackTime })), (f) => f.shop_order);
+}
 function filterAvailabletickets(tickets, selectedTime = "") {
 	let available = Object.entries(tickets);
 	if (selectedTime !== "") available = available.filter(([, t]) => t.total_capacities?.[selectedTime] && t.total_capacities[selectedTime] > 0);
@@ -14871,6 +14882,7 @@ var FormDetails = class {
 	* @param {string[] | Record<string, string[]>} errors - Errors passed as an array or an object where keys are API field keys and values are arrays of error messages. If an array is provided, it assigns the errors directly. If an object is provided, it maps the errors to the respective fields based on their API keys.
 	*/
 	set apiErrors(errors) {
+		set(this.#apiErrors, [], true);
 		this.fields.forEach((f) => f.apiErrors = []);
 		if (isArray(errors)) {
 			set(this.#apiErrors, errors, true);
@@ -14911,7 +14923,7 @@ var FormDetails = class {
 	*/
 	get fields() {
 		const parent = this.form.closest("go-form");
-		return Array.from(this.form.querySelectorAll("go-field")).filter((fe) => fe.closest("go-form") === parent).map((fe) => fe.getField?.()).filter((f) => f);
+		return Array.from(this.form.querySelectorAll("go-field")).filter((fe) => fe.closest("go-form") === parent).map((fe) => fe.getField?.()).filter((f) => !!f);
 	}
 	toString() {
 		return `Form: ${this.formId}, Fields: [${this.fields.map((f) => f.key).join(", ")}], Data: ${JSON.stringify(this.formData)}`;
@@ -14979,6 +14991,7 @@ function Form($$anchor, $$props) {
 		details?.form?.dispatchEvent(new Event("go-after-validation", event));
 		if (details.isValid) {
 			details.apiErrors = {};
+			details.successMessage = void 0;
 			details?.form?.dispatchEvent(new Event("go-submit", event));
 			$$props.$$host.dispatchEvent(new Event("submit", {
 				bubbles: true,
@@ -18598,6 +18611,7 @@ function CouponRedemption($$anchor, $$props) {
 			form.details.apiErrors = result.errors;
 			return result;
 		}
+		form.details.apiErrors = [];
 		if (field) field.value = "";
 		form.dispatchEvent(new Event("go-success", {
 			bubbles: true,
@@ -35399,11 +35413,9 @@ var REGISTRY = {
 				"by_ticket_group_ids[]": segment.ticketGroupIds ?? tsd.ticketGroupIds
 			}));
 			shop.capacityManager.addQuotas(quotas);
-			const firstQuota = Object.values(quotas)[0];
-			const timeslot = firstQuota ? Object.keys(firstQuota.capacities)[0] : void 0;
-			const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, timeslot), timeslot);
+			const uiTickets = initUIDayTickets(tickets);
 			await enrichTicketsWithContent(segment, uiTickets);
-			for (const ticket of uiTickets) segment.preCart.addItem(createCartItem(ticket, { time: timeslot }));
+			for (const ticket of uiTickets) segment.preCart.addItem(createCartItem(ticket, { time: ticket.selectedTime }));
 		}
 	},
 	"ticket:annual": {
@@ -35495,11 +35507,9 @@ var REGISTRY = {
 				valid_at: tsd.selectedDate.toString()
 			}));
 			shop.capacityManager.addQuotas(quotas);
-			const firstQuota = Object.values(quotas)[0];
-			const time = firstQuota ? Object.keys(firstQuota.capacities)[0] : void 0;
-			const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, time), time);
+			const uiTickets = initUIDayTickets(tickets);
 			await enrichTicketsWithContent(segment, uiTickets);
-			for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time }));
+			for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time: t.selectedTime }));
 		}
 	},
 	"event:admission:timeslot": {
@@ -35658,11 +35668,9 @@ var REGISTRY = {
 					valid_at: date.start_time.slice(0, 10)
 				}));
 				shop.capacityManager.addQuotas(quotas);
-				const firstQuota = Object.values(quotas)[0];
-				const time = firstQuota ? Object.keys(firstQuota.capacities)[0] : date.start_time;
-				const uiTickets = initUITimeslotTickets(filterAvailabletickets(tickets, time), time);
+				const uiTickets = initUIDayTickets(tickets, date.start_time);
 				await enrichTicketsWithContent(segment, uiTickets);
-				for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time }));
+				for (const t of uiTickets) segment.preCart.addItem(createCartItem(t, { time: t.selectedTime }));
 			}
 		}
 	},