@godxjp/ui 31.11.1 → 31.12.0

package/agent/START-HERE.md

@@ -3,7 +3,7 @@
 You are about to write code against a design system you did not author. This file is the whole
 contract. Read it before you write JSX.
 
-**This catalog describes `@godxjp/ui` 31.11.1.** If the project you are editing has a different
+**This catalog describes `@godxjp/ui` 31.12.0.** If the project you are editing has a different
 version in its `package.json`, read the pinned catalog for THAT version instead
 (`…/v<their-version>/agent/…`). A catalog newer than the installed package describes props that do
 not exist yet; older, and it hides props that do. Neither failure announces itself.

package/agent/index.json

@@ -48,7 +48,7 @@
   "note": "Pin to the tag that matches the @godxjp/ui version you installed. A catalog newer than your package describes props you do not have; older, and it hides props you do.",
   "read": {
     "live": "https://raw.githubusercontent.com/godx-jp/godxjp-ui/main/agent/index.json",
-    "pinned": "https://raw.githubusercontent.com/godx-jp/godxjp-ui/v31.11.1/agent/index.json"
+    "pinned": "https://raw.githubusercontent.com/godx-jp/godxjp-ui/v31.12.0/agent/index.json"
   },
   "source": "mcp/src/data — the same data @godxjp/ui-mcp serves — plus the foundation and semantic token tiers, read from src/tokens/*.css",
   "start": "https://raw.githubusercontent.com/godx-jp/godxjp-ui/main/agent/START-HERE.md",
@@ -62,5 +62,5 @@
     "foundation": "the seeds a consumer is invited to set — --primary, --background, --radius",
     "semantic": "named roles that follow the seeds — --ring, --text-link, --overlay-background"
   },
-  "version": "31.11.1"
+  "version": "31.12.0"
 }

package/agent/llms.txt

@@ -1,10 +1,10 @@
 # @godxjp/ui
 
 > A Japanese-enterprise React design system: 178 components, 2116 design tokens,
-> 50 cardinal rules. This file is the entry point for AI agents. Catalog version 31.11.1.
+> 50 cardinal rules. This file is the entry point for AI agents. Catalog version 31.12.0.
 
 If your client can run a process, do not read these files — run the MCP server instead
-(`npx @godxjp/ui-mcp@31.11.1`). It is searchable and version-locked. These files exist for agents
+(`npx @godxjp/ui-mcp@31.12.0`). It is searchable and version-locked. These files exist for agents
 that can only fetch URLs.
 
 ## Start
@@ -26,7 +26,7 @@ that can only fetch URLs.
 ## Pinning
 
 Every URL above tracks `main`. To pin to the release a project actually installed, swap `main` for
-the tag: `.../godx-jp/godxjp-ui/v31.11.1/agent/...`. A catalog that does not match the installed
+the tag: `.../godx-jp/godxjp-ui/v31.12.0/agent/...`. A catalog that does not match the installed
 package describes props that are absent, or hides props that are present, and says nothing either way.
 
 Pinned catalogs only exist for releases whose tag actually contains `agent/`. If `…/v<version>/agent/index.json` returns 404, that release predates this catalog: read `…/main/…` instead and compare `index.json` → `version` against the package you have, so you at least know which way it drifted.

package/dist/contracts/measurement.json

@@ -1,6 +1,6 @@
 {
   "$comment": "AUTO-GENERATED by scripts/gen-measurement-contract.mjs — do not edit. Read this instead of guessing: docs/MEASUREMENT-CONTRACT.md.",
-  "version": "31.11.1",
+  "version": "31.12.0",
   "targetSize": {
     "standard": "WCAG 2.2 SC 2.5.8 Target Size (Minimum), level AA — 24×24 CSS px",
     "min": 24,

package/dist/styles/layers.json

@@ -1,5 +1,5 @@
 {
-  "version": "31.11.1",
+  "version": "31.12.0",
   "generatedBy": "scripts/gen-style-layers.mjs — do not edit by hand; run `pnpm gen:style-layers`",
   "base": "base.css",
   "fonts": "fonts.css",

package/docs/CONSUMER-RULES.md

@@ -6,7 +6,7 @@ Read this once; the audit enforces it. Everything else in `docs/` is for contrib
 2. **Mount `<AppProvider defaultLocale="…">` once, at the root.** Without it the kit's OWN strings (dialog close/cancel/delete, counters, picker labels) fall to the resting locale `vi` and pickers to UTC — measured in a Japanese app as Vietnamese buttons, silently (gh#1005). A development build now warns once when a kit component renders outside it; `syncI18nLocale(locale, fallback)` is the escape for an app that truly cannot mount the provider. Every page is `<PageContainer title subtitle extra footer>`; its sections are spaced by the page. Group items inside a section with `<Flex direction="col" gap>` or `<ResponsiveGrid>`.
 3. No Tailwind layout on your own elements: no `flex`, `grid`, `gap-*`, `p-*`, `m-*`, `space-*`. Rows are `<Flex>` (default row), stacks are `<Flex direction="col">`, grids are `<ResponsiveGrid>`.
 4. No hand-rolled surfaces: no `rounded-* border bg-*` divs. A box is `Card`, a pill is `Badge`, a person is `Avatar`, a row is `ListRow`, a label/value pair is `Descriptions`, an empty area is `EmptyState`, a read-only sample of a colour the USER chose is `Swatch`. A LIST of those rows is `<Flex as="ul" marker="none" direction="col" gap="none">` with `<ListRow as="li">` children — `marker="none"` keeps the `<ul>`, the `<li>` semantics and the gap token while dropping the bullet and the indent. Never a raw `<ul>`/`<ol>` (it carries no gap token), never `<div role="list">` + `<div role="listitem">`, and never a wrapper around each row: the divider is `:not(:last-child)` among siblings, so a row alone in its own wrapper is always the last one and EVERY divider disappears silently. A bulleted prose list is the same `<Flex as="ul">` without `marker`.
-5. Real controls only: `Button`, `Input`, `Select`, `Textarea`, `Checkbox`… never raw `<button>`/`<input>`; a labelled control lives in `<FormField label>`. A Select outside a form takes `width="auto"`. **A disabled control's reason is visible text, never a tooltip** — see below. **Fields live in a `<Form layout="horizontal" labelWidth controlWidth>`** — never a group of `FormField`s without one, never a hand-rolled `<Flex>` row of fields (a row that belongs together is `<SpaceCompact>` or `<Form columns>`); size each control for its content with `controlWidth` (GOV.UK text-input width: a port ~7rem, a short enum ~10rem); three or more fields is a page, not a Dialog. The audit rules are `formfield-needs-form`, `dialog-form-too-big` and `select-width-hint`. **A case the kit cannot express is an issue, not a hand-roll:** open it on godx-jp/godxjp-ui, use the nearest valid composition, and mark it `// TODO(godxjp-ui#<n>)` (gh#998).
+5. Real controls only: `Button`, `Input`, `Select`, `Textarea`, `Checkbox`… never raw `<button>`/`<input>`; a labelled control lives in `<FormField label>`. A Select outside a form takes `width="auto"`. **A disabled control's reason is visible text, never a tooltip** — see below. **Fields live in a `<Form layout="horizontal" labelWidth controlWidth>`** — never a group of `FormField`s without one, never a hand-rolled `<Flex>` row of fields (a row that belongs together is `<SpaceCompact>` or `<Form columns>`); size each control for its content with `controlWidth` (GOV.UK text-input width: a port ~7rem, a short enum ~10rem); three or more fields is a page, not a Dialog. The audit rules are `formfield-needs-form`, `dialog-form-too-big` and `select-width-hint`. **A case the kit cannot express is an issue, not a hand-roll:** open it on godx-jp/godxjp-ui, use the nearest valid composition, and mark it `// TODO(godxjp-ui#<n>)` (gh#998). **One action row, one Button size:** every `Button` under one parent takes the same `size` — a missing size is `default`, and `icon-sm` pairs with `sm`, `icon-xs` with `xs`, `icon` with default. Never `size="sm"` beside a default Button. The audit rules are `mixed-button-size` (static) and `mixed-button-height` (visual-audit, within 0.5px) (gh#1084).
 6. Text is `<Text>` / `<Heading>` with `tone`, `size`, `weight`, `truncate`, `mono` — not `className="text-muted-foreground font-semibold"`. A STANDALONE glyph is `<Icon as={Lock} size="sm" tone="muted" />` from `@godxjp/ui/general`: a bare lucide icon carries its own `width="24" height="24"` and only four places re-size it for you (`Button`, a `DropdownMenuItem`, a `TopbarItem`, a `ListRow` leading slot), so everywhere else — in a `Text`, a table cell, an `<a>` — it draws at 24px beside 14px type. `size-4` and `w-[16px]` are closed to you by rules 3 and 8, and `size={16}` hard-codes a number the theme owns; `Icon` puts the glyph on the `--icon-size-*` scale (`2xs…4xl`) instead, and is `aria-hidden` unless you give it a `label` (then it is `role="img"` with that name). The audit rule is `lucide-icon-needs-size`.
 7. Colours are semantic tokens (`tone="destructive"`, `bg-primary`), never palette names, hex, or `bg-black` / `text-white`.
 8. Sizes come from props (`size`, `width`, `columns`), never `w-[240px]` / `max-h-[420px]`.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@godxjp/ui",
-  "version": "31.11.1",
-  "godxUiMcp": "31.11.1",
+  "version": "31.12.0",
+  "godxUiMcp": "31.12.0",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",

package/scripts/ui-audit.mjs

@@ -891,6 +891,30 @@ const RULES = [
     message:
       'Hand-rolled overflow-wrap:anywhere ([overflow-wrap:anywhere] / wrap-anywhere) — use <Text break="anywhere"> for an email, code or id in a table cell or Descriptions value. It also releases the cell\'s inherited nowrap, so drop the break-words / whitespace-normal that came with it. Not whitespace="pre-wrap": its break-word does not shrink a table column (gh#927).',
   },
+  {
+    id: "mixed-button-size",
+    replacement: "one Button size per row",
+    scope: "consumer",
+    severity: "error",
+    /*
+     * ONE ROW, ONE BUTTON SIZE. A consumer shipped 「AIスコアを編集」 at `size="sm"` beside 裁定する at
+     * the default size in one action row: two heights, two paddings, two type sizes side by side,
+     * and the owner saw it before any audit did. Sibling <Button>s under one JSX parent must share
+     * a size. A missing `size` is `default`; an `icon-*` size belongs to its text size's family
+     * (`icon-sm` = `sm`, `icon-xs` = `xs`, `icon` = default), so `xs` beside `icon-sm` still fails.
+     *
+     * "Siblings" looks through what renders no box of its own: fragments, `{cond && …}`,
+     * ternaries, `.map(…)` and a Tooltip / TooltipTrigger around a button. Any other element is a
+     * new parent — FormActions, CardFooter, ModalFooter, Space, Flex, PageHeader `actions={…}` are
+     * all just parents here. A `size={expr}` that is not a string literal is unknown and skipped;
+     * a button kept in a variable (`{editButton}`) is invisible to a static scan — the runtime
+     * `mixed-button-height` check in visual-audit.mjs catches that one.
+     */
+    spansElement: true,
+    matches: mixedButtonSizeMatches,
+    message:
+      "Buttons in one row mix sizes — every Button under one parent takes the same `size` (a missing size is `default`; `icon-sm` pairs with `sm`, `icon-xs` with `xs`, `icon` with default). Pick the row's size and apply it to every button in it (docs/CONSUMER-RULES.md §5).",
+  },
 ];
 
 /**
@@ -1518,6 +1542,111 @@ function jsxOpeningEnd(source, start) {
   return source.length;
 }
 
+/** Transparent wrappers: they render no row of their own, so the buttons inside stay siblings. */
+const BUTTON_ROW_TRANSPARENT = new Set([
+  "",
+  "Fragment",
+  "React.Fragment",
+  "Tooltip",
+  "TooltipTrigger",
+]);
+
+/** A Button's `size` literal from its OPENING tag's own attributes (not a nested element's). */
+function buttonSizeOf(openTag) {
+  // Blank every `{…}` body so `icon={<Plus size="sm" />}` cannot answer for the Button.
+  let top = "";
+  let depth = 0;
+  let quote = "";
+  for (let i = 0; i < openTag.length; i++) {
+    const ch = openTag[i];
+    if (quote) {
+      if (ch === "\\") i++;
+      else if (ch === quote) quote = "";
+      top += depth ? " " : ch;
+      continue;
+    }
+    if (ch === '"' || ch === "'" || ch === "`") quote = ch;
+    if (ch === "{") depth++;
+    top += depth ? (ch === "{" && depth === 1 ? "{" : " ") : ch;
+    if (ch === "}") depth--;
+  }
+  const at = /\bsize\s*=\s*/.exec(top);
+  if (!at) return "default";
+  const rest = openTag.slice(at.index + at[0].length);
+  const lit = /^(?:"([^"]*)"|'([^']*)'|\{\s*(?:"([^"]*)"|'([^']*)'|`([^`$]*)`)\s*\})/.exec(rest);
+  return lit ? (lit[1] ?? lit[2] ?? lit[3] ?? lit[4] ?? lit[5]) : null;
+}
+
+/** `icon-sm` → `sm`, `icon` → `default`, `md` → `default` (Button maps md to the default size). */
+const buttonSizeFamily = (size) => {
+  const bare = size.replace(/^icon-?/, "");
+  return bare === "" || bare === "md" ? "default" : bare;
+};
+
+/**
+ * `mixed-button-size`: group every <Button> by its nearest non-transparent JSX parent and yield
+ * one match per group whose size families differ. A tag stack over the whole file; an element in
+ * an attribute (`actions={<>…</>}`) gets the attribute's owner as its parent, kept apart from the
+ * owner's children. A `<` glued to an identifier outside JSX children is a TS generic.
+ */
+function* mixedButtonSizeMatches(source) {
+  const stack = []; // { tag, id, attr }
+  const pending = []; // opening tags whose attributes are still being scanned
+  const groups = new Map();
+  let nextId = 0;
+  const settle = (upTo) => {
+    while (pending.length && pending.at(-1).end < upTo) {
+      const p = pending.pop();
+      const i = stack.lastIndexOf(p.frame);
+      if (i >= 0) stack.length = i;
+      if (!p.selfClose) stack.push({ tag: p.frame.tag, id: nextId++, attr: false });
+    }
+  };
+  const tagRe = /<(\/?)(?:([A-Za-z][\w.]*)(?=[\s/>])|(?=>))/g;
+  for (const m of source.matchAll(tagRe)) {
+    settle(m.index);
+    const [, close, tag = ""] = m;
+    // `useState<Issue>(` — a `<` glued to an identifier, `)` or `]` is a generic, unless it sits
+    // in JSX children, where `Total<b>` is text followed by a tag.
+    const glued = /[\w$)\].]/.test(source[m.index - 1] ?? "");
+    if (!close && glued && (stack.length === 0 || stack.at(-1).attr)) continue;
+    if (close) {
+      for (let i = stack.length - 1; i >= 0; i--) {
+        if (!stack[i].attr && stack[i].tag === tag) {
+          stack.length = i;
+          break;
+        }
+      }
+      continue;
+    }
+    const end = jsxOpeningEnd(source, m.index);
+    if (end >= source.length) continue;
+    const openTag = source.slice(m.index, end + 1);
+    if (tag === "Button") {
+      const parent = stack.findLast((f) => f.attr || !BUTTON_ROW_TRANSPARENT.has(f.tag));
+      const size = buttonSizeOf(openTag);
+      if (parent && size !== null) {
+        (groups.get(parent.id) ?? groups.set(parent.id, []).get(parent.id)).push({
+          size,
+          index: m.index,
+          openTag,
+        });
+      }
+    }
+    const frame = { tag, id: nextId++, attr: true };
+    stack.push(frame);
+    pending.push({ end, frame, selfClose: /\/\s*>$/.test(openTag) });
+  }
+  for (const group of groups.values()) {
+    const families = new Set(group.map((b) => buttonSizeFamily(b.size)));
+    if (group.length < 2 || families.size < 2) continue;
+    yield {
+      0: `sizes ${group.map((b) => b.size).join(" + ")}: ${group[0].openTag}`,
+      index: group[0].index,
+    };
+  }
+}
+
 // Structural: a <Card> (without p-0) whose first child is body content rather than a Card
 // sub-component sits FLUSH (no padding). Per-line regexes can't see across lines, so this is a
 // whole-file pass. The body must be wrapped in <CardContent> (titles in <CardHeader>).

package/scripts/visual-audit-rules.mjs

@@ -43,6 +43,13 @@ export const VISUAL_RULES = [
     standard: "@godxjp/ui control tier (--control-height) · Nielsen consistency heuristic",
     fix: "Every control in one row (Flex row, PageContainer extra, footer) must share --control-height. Replace the odd one with the real primitive (Avatar/Button/Badge) instead of a hand-rolled pill; never restyle a control's height.",
   },
+  {
+    id: "mixed-button-height",
+    severity: "error",
+    category: "layout",
+    standard: "@godxjp/ui Button size (one size per row) · Nielsen consistency heuristic",
+    fix: "Every Button in one flex row renders at one height (within 0.5px): give them all the same `size` (icon-sm pairs with sm, icon-xs with xs, icon with default). This is the runtime twin of the static `mixed-button-size` rule and catches rows assembled from variables.",
+  },
   {
     id: "sibling-card-gap",
     severity: "error",
@@ -185,6 +192,16 @@ export function controlHeightMismatches(rows) {
   return rows.filter((r) => new Set(r.heights).size > 1);
 }
 
+/**
+ * Flex rows whose Buttons render at different heights (spread > 0.5px). Heights are NOT rounded:
+ * 28 vs 28.4 is the same size, 24 vs 28 is `xs` beside `sm`. @param {{name:string, heights:number[]}[]} rows
+ */
+export function mixedButtonHeights(rows, tolerance = 0.5) {
+  return rows.filter(
+    (r) => r.heights.length > 1 && Math.max(...r.heights) - Math.min(...r.heights) > tolerance,
+  );
+}
+
 /** Adjacent card pairs closer than the minimum gap. @param {{gap:number}[]} pairs */
 export function tightCardPairs(pairs, min = 8) {
   return pairs.filter((p) => p.gap < min);

package/scripts/visual-audit.mjs

@@ -13,6 +13,7 @@ import {
   alertControlIssues,
   missingCssLayers,
   controlHeightMismatches,
+  mixedButtonHeights,
   tightCardPairs,
   starvedRowTexts,
 } from "./visual-audit-rules.mjs";
@@ -261,6 +262,27 @@ function collectInPage() {
       heights: controls.map((c) => Math.round(c.getBoundingClientRect().height)),
     });
   }
+  // Button rows — every flex row (any container, not only .ui-flex: CardFooter, a dialog footer,
+  // PageHeader actions) whose Buttons render at more than one height. A child counts when it IS a
+  // Button or directly wraps one (a Tooltip trigger span). `h-auto` opts a Button out of the
+  // control tier on purpose (a two-line list item), so it is not a row member.
+  const buttonRows = [];
+  const isRowButton = (el) => el.matches("[data-slot=button]") && !el.classList.contains("h-auto");
+  for (const row of document.querySelectorAll("body *")) {
+    const cs = getComputedStyle(row);
+    if (!cs.display.includes("flex") || !cs.flexDirection.startsWith("row") || !visible(row))
+      continue;
+    const buttons = [...row.children]
+      .filter(visible)
+      .map((c) => (isRowButton(c) ? c : c.querySelector(":scope > [data-slot=button]")))
+      .filter((b) => b && isRowButton(b) && visible(b));
+    if (buttons.length < 2) continue;
+    buttonRows.push({
+      name: (row.className || row.tagName).toString().slice(0, 40),
+      heights: buttons.map((b) => b.getBoundingClientRect().height),
+      sizes: buttons.map((b) => b.getAttribute("data-size") || "?"),
+    });
+  }
   // Sibling cards — the gap between consecutive cards in one parent.
   const cardPairs = [];
   const seen = new Set();
@@ -295,7 +317,7 @@ function collectInPage() {
       });
     }
   }
-  return { accents, targets, text, alerts, layers, rows, cardPairs, rowTexts };
+  return { accents, targets, text, alerts, layers, rows, buttonRows, cardPairs, rowTexts };
 }
 /* c8 ignore stop */
 
@@ -395,6 +417,14 @@ async function audit(targets, { chromium }) {
               `row "${r.name}" mixes control heights ${[...new Set(r.heights)].join("/")}px`,
             ),
           );
+        for (const r of mixedButtonHeights(m.buttonRows || []))
+          findings.push(
+            buildFinding(
+              "mixed-button-height",
+              url,
+              `row "${r.name}" mixes Button heights ${r.heights.map((h) => +h.toFixed(1)).join("/")}px (sizes ${r.sizes.join("/")})`,
+            ),
+          );
         const tight = tightCardPairs(m.cardPairs || []);
         if (tight.length)
           findings.push(