@godv61/dsh-task-engine 0.23.0 → 0.23.2

package/.workflow-test.mjs

@@ -0,0 +1,290 @@
+import test from 'node:test'
+import assert from 'node:assert/strict'
+import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join, resolve, sep } from 'node:path'
+import { registerDevTask } from './lib/dev-task.js'
+import { newTask } from './lib/engine.js'
+import { resolveFlow } from './lib/workflows.js'
+import Controller from './lib/controller.js'
+import { registerShippedSkills } from './lib/shipped-skills.js'
+
+function fixture(stage = '开发', extra = {}, services = {}) {
+  const cwd = resolve('test-project')
+  const config = resolveFlow('standard', { stage_bindings: { 完成: { skills: ['software-testing'] } } }).config
+  const state = newTask({ id: 'LIVE-1', title: 'EAM regression', branch: 'test', work_size: 'standard', risk_level: 'standard', flow: { flow: 'standard', version: 2, config }, root: cwd })
+  Object.assign(state, { stage, execution_version: 1, files: ['app.js'], requirement_confirmed: true, solution_confirmed: true, ...extra })
+  const records = new Map([[join(cwd, '.dsh/task-LIVE-1.json'), JSON.stringify(state)], [join(cwd, 'app.js'), 'source']])
+  const events = [], runs = []
+  const session = { id: 'test-session', header: { cwd }, snapshotEvents: () => events }
+  const policy = { mode: 'workspace-write', workspaceRoot: cwd, sessionId: session.id }
+  const abort = new AbortController()
+  let execute
+  const key = (path, options) => join(options?.cwd ?? cwd, path)
+  const fs = {
+    resolve: async (path, options) => ({ targetKey: key(path, options) }),
+    readText: async target => records.get(target.targetKey),
+    listDir: async () => [...records.keys()].filter(path => /task-.+\.json$/.test(path)).map(path => ({ name: path.split(/[\\/]/).at(-1) })),
+    lstat: async (path, options) => records.has(key(path, options)) ? { version: 'v' } : undefined,
+    writeText: async (target, content) => { records.set(target.targetKey, content) },
+  }
+  const ctx = { fs, tools: { register(tool) { execute = tool.execute; return () => {} } }, get(name) {
+    if (Object.hasOwn(services, name)) return services[name]
+    if (name === 'sandboxPolicy') return { resolve(request) { assert.equal(request.session, session); return policy } }
+    if (name === 'shell') return { resolve(request) { runs.push(request); return request }, async run(request) {
+      const fail = request.command === 'fail'
+      return { exitCode: fail ? 1 : 0, timedOut: false, aborted: false, sandbox: { mode: 'workspace-write', denied: false }, stdout: { text: request.command.startsWith('git -c core.quotepath=false log') ? 'abcdef1234567890\n【LIVE-1】【TASK】done\n\napp.js\n' : 'checks passed' }, stderr: { text: '' } }
+    } }
+    return undefined
+  } }
+  registerDevTask(ctx)
+  const exec = { agent: { session }, signal: abort.signal }
+  function load(name, success = true) {
+    const callId = `call-${events.length}`
+    events.push({ type: 'tool/call', data: { name: 'skill', callId, arguments: JSON.stringify({ name }) } })
+    events.push({ type: 'tool/result', data: { message: { content: [{ type: 'tool-result', toolCallId: callId, isError: !success }] } } })
+  }
+  return { call: args => execute(JSON.parse(JSON.stringify({ task_id: 'LIVE-1', ...args })), exec), load, runs, policy, exec, records, cwd,
+    state: () => JSON.parse(records.get(join(cwd, '.dsh/task-LIVE-1.json'))) }
+}
+
+test('审查通过后更新状态并激活下一项，保留已完成项的审计', async () => {
+  const f = fixture()
+  await f.call({ operation: 'items', items: [{ id: 'A', title: 'first', status: 'doing' }, { id: 'B', title: 'second' }] })
+  await f.call({ operation: 'dispatch', item_id: 'A', description: 'implemented by worker' })
+  await f.call({ operation: 'review_item', item_id: 'A', spec_outcome: 'pass', quality_outcome: 'pass' })
+  await f.call({ operation: 'items', items: [{ id: 'A', title: 'first', status: 'done' }, { id: 'B', title: 'second', status: 'doing' }] })
+  assert.equal(f.state().items[0].review.spec.outcome, 'pass')
+  assert.equal(f.state().items[0].dispatch.description, 'implemented by worker')
+  await f.call({ operation: 'items', items: [{ id: 'A', title: 'changed', status: 'doing' }, { id: 'B', title: 'second', status: 'todo' }] })
+  assert.equal(f.state().items[0].review, undefined)
+  await assert.rejects(f.call({ operation: 'items', items: [{ id: 'A', title: 'x' }, { id: 'A', title: 'y' }] }), /unique/)
+})
+
+test('追加修复项可按 id 保留旧标题，拒绝已完成项改名后静默丢审核', async () => {
+  const f = fixture()
+  await f.call({ operation: 'items', items: [{ id: 'A', title: 'reviewed models', status: 'doing' }] })
+  await f.call({ operation: 'review_item', item_id: 'A', spec_outcome: 'pass', quality_outcome: 'pass' })
+  await f.call({ operation: 'items', items: [{ id: 'A', status: 'done' }, { id: 'B', title: 'fix race', status: 'doing' }] })
+  assert.equal(f.state().items[0].title, 'reviewed models')
+  assert.equal(f.state().items[0].review.quality.outcome, 'pass')
+  await assert.rejects(f.call({ operation: 'items', items: [{ id: 'A', title: 'rewritten summary', status: 'done' }, { id: 'B', status: 'doing' }] }), /omit title|reopen/)
+  assert.equal(f.state().items[0].review.quality.outcome, 'pass')
+  assert.equal(f.state().items.length, 2)
+  await assert.rejects(f.call({ operation: 'items', items: [{ id: 'NEW' }] }), /title/)
+})
+
+test('派发立即反映进行中，重派不复用旧审核且保持单一进行项', async () => {
+  const f = fixture()
+  await f.call({ operation: 'items', items: [{ id: 'A', title: 'models' }, { id: 'B', title: 'api' }] })
+  await f.call({ operation: 'dispatch', item_id: 'A', description: 'implement models' })
+  assert.equal(f.state().items[0].status, 'doing')
+  await assert.rejects(f.call({ operation: 'dispatch', item_id: 'B' }), /current doing item/)
+  await f.call({ operation: 'review_item', item_id: 'A', spec_outcome: 'pass', quality_outcome: 'pass' })
+  await f.call({ operation: 'dispatch', item_id: 'A', description: 'rework models' })
+  assert.equal(f.state().items[0].review, undefined)
+})
+
+test('无任务 id 的 status 发现当前工作区任务并支持分支过滤', async () => {
+  const f = fixture()
+  assert.equal(JSON.parse(await f.call({ operation: 'status', task_id: undefined })).tasks[0].id, 'LIVE-1')
+  assert.equal(JSON.parse(await f.call({ operation: 'status', task_id: undefined, branch: 'other' })).tasks.length, 0)
+})
+
+test('verify 升级审批不可用时不得先执行命令', async () => {
+  const f = fixture('交付')
+  const before = JSON.stringify(f.state())
+  await assert.rejects(f.call({ operation: 'verify', command: 'npm test', sandbox_permissions: 'danger-full-access', justification: 'Retry the denied test command' }), /approval/)
+  assert.equal(f.runs.length, 0, 'approval must precede shell execution')
+  assert.equal(JSON.stringify(f.state()), before)
+})
+
+test('verify 拒绝、取消及无效升级参数均不执行命令或改写台账', async () => {
+  for (const outcome of ['rejected', 'cancelled', 'unavailable']) {
+    const f = fixture('交付', {}, { approval: { request: async () => outcome } })
+    const before = JSON.stringify(f.state())
+    await assert.rejects(f.call({ operation: 'verify', command: 'npm test', sandbox_permissions: 'danger-full-access', justification: 'Retry denied command' }), /not approved/)
+    assert.equal(f.runs.length, 0)
+    assert.equal(JSON.stringify(f.state()), before)
+  }
+  for (const args of [{ sandbox_permissions: 'danger-full-access' }, { justification: 'orphan justification' }]) {
+    const f = fixture('交付')
+    await assert.rejects(f.call({ operation: 'verify', command: 'npm test', ...args }), /invalid escalation/)
+    assert.equal(f.runs.length, 0)
+  }
+})
+
+test('验证命令审批先于执行，只授权本次命令且回执写入不重复审批', async () => {
+  for (const operation of ['verify', 'skill_result']) {
+    const approvals = []
+    const f = fixture('完成', {}, { approval: { request: async request => {
+      assert.equal(f.runs.length, 0)
+      approvals.push(request)
+      return 'allowed-once'
+    } } })
+    f.load('software-testing')
+    await f.call({ operation, command: 'npm test', skill_name: 'software-testing', evidence: ['real checks'], sandbox_permissions: 'danger-full-access', justification: 'Retry denied test command' })
+    assert.equal(approvals.length, 1)
+    assert.match(approvals[0].reason, /npm test/)
+    assert.equal(f.runs[0].sandboxPolicy.mode, 'danger-full-access')
+    assert.equal(f.runs[0].sandboxPolicy.workspaceRoot, f.cwd)
+    assert.equal(f.runs[0].sandboxPolicy.sessionId, f.policy.sessionId)
+    assert.equal(f.runs[0].signal, f.exec.signal)
+    assert.equal(f.policy.mode, 'workspace-write')
+    await f.call({ operation: 'verify', command: 'npm test' })
+    assert.equal(f.runs[1].sandboxPolicy, f.policy)
+    assert.equal(approvals.length, 1)
+  }
+})
+
+test('skill_result 审批拒绝时不执行命令、不写入技能回执', async () => {
+  const f = fixture('完成', {}, { approval: { request: async () => 'rejected' } })
+  f.load('software-testing')
+  const before = JSON.stringify(f.state())
+  await assert.rejects(f.call({ operation: 'skill_result', skill_name: 'software-testing', command: 'npm test', evidence: ['test'], sandbox_permissions: 'danger-full-access', justification: 'Retry denied tests' }), /not approved/)
+  assert.equal(f.runs.length, 0)
+  assert.equal(JSON.stringify(f.state()), before)
+})
+
+test('状态明确区分内置节点门禁与附加技能命令回执，避免重复验证', async () => {
+  const f = fixture('代码审核')
+  const status = JSON.parse(await f.call({ operation: 'status' }))
+  assert.deepEqual(status.skill_obligations.find(row => row.stage === '代码审核').command_receipts_required, [])
+  assert.deepEqual(status.skill_obligations.find(row => row.stage === '完成').command_receipts_required, ['software-testing'])
+})
+
+test('status 披露当前阶段记录字段和缺项，字段误用不写入且可按提示恢复', async () => {
+  const f = fixture('需求评审')
+  const before = JSON.stringify(f.state())
+  const status = JSON.parse(await f.call({ operation: 'status' }))
+  assert.deepEqual(status.artifact_requirements, [{ id: 'requirement', name: '需求说明', fields: ['scope', 'acceptance_criteria'], missing_fields: ['scope', 'acceptance_criteria'] }])
+  assert.equal(JSON.stringify(f.state()), before)
+  await assert.rejects(f.call({ operation: 'record', artifact: 'requirement', fields: { scope: 'goal', 待确认取舍: 'question' } }), /status.artifact_requirements/)
+  assert.equal(JSON.stringify(f.state()), before)
+  await f.call({ operation: 'record', artifact: 'requirement', fields: { scope: '目标及待确认取舍', acceptance_criteria: '  ' } })
+  assert.deepEqual(JSON.parse(await f.call({ operation: 'status' })).artifact_requirements[0].missing_fields, ['acceptance_criteria'])
+  await f.call({ operation: 'record', artifact: 'requirement', fields: { acceptance_criteria: '可执行验收' } })
+  assert.deepEqual(JSON.parse(await f.call({ operation: 'status' })).artifact_requirements[0].missing_fields, [])
+})
+
+test('记录字段来自冻结流程，精简流程不硬编码标准字段，无记录阶段返回空列表', async () => {
+  const config = resolveFlow('agile').config
+  const f = fixture('需求', { flow: { flow: 'agile', version: 1, config } })
+  assert.deepEqual(JSON.parse(await f.call({ operation: 'status' })).artifact_requirements, [{ id: 'requirement', name: '需求说明', fields: ['scope'], missing_fields: ['scope'] }])
+  await f.call({ operation: 'record', artifact: 'requirement', fields: { scope: '目标、验收与疑问' } })
+  assert.deepEqual(JSON.parse(await f.call({ operation: 'status' })).artifact_requirements[0].missing_fields, [])
+  assert.deepEqual(JSON.parse(await fixture('开发').call({ operation: 'status' })).artifact_requirements, [])
+  assert.deepEqual(JSON.parse(await fixture('设计').call({ operation: 'status' })).artifact_requirements[0].fields, ['approach', 'risks', 'impact'])
+})
+
+test('可选内置技能回执不会因范围变更升级成额外流转门禁', async () => {
+  const f = fixture('需求评审', { artifacts: { requirement: { scope: 'device picker', acceptance_criteria: 'contract and selection' } } })
+  f.load('requirement-analysis')
+  await f.call({ operation: 'skill_result', skill_name: 'requirement-analysis', command: 'check', evidence: ['optional check'] })
+  await f.call({ operation: 'scope', files: ['app.js', 'new-vo.java'] })
+  await f.call({ operation: 'advance', target_stage: '设计' })
+  assert.equal(f.state().stage, '设计')
+})
+
+test('验证使用会话策略与取消信号，并明确返回失败及沙箱信息', async () => {
+  const f = fixture('交付')
+  const result = JSON.parse(await f.call({ operation: 'verify', command: 'fail' }))
+  assert.equal(result.ok, false)
+  assert.equal(f.runs[0].sandboxPolicy, f.policy)
+  assert.equal(f.runs[0].signal, f.exec.signal)
+  assert.equal(result.verification.receipt.sandbox.mode, 'workspace-write')
+})
+
+test('只声明已测试、或加载失败，均不能冒充执行绑定技能', async () => {
+  const f = fixture('代码审核')
+  f.load('code-review'); f.load('code-commit'); f.load('software-testing', false)
+  await assert.rejects(f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', command: 'check', evidence: ['tested'] }), /load skill/)
+  await assert.rejects(f.call({ operation: 'advance', target_stage: '完成' }), /software-testing/)
+  f.load('software-testing')
+  await assert.rejects(f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', evidence: ['claimed pass'] }), /real validation command/)
+})
+
+test('绑定技能失败阻止完成；成功后仍须提交真实 Git 回执', async () => {
+  const f = fixture('代码审核', { review: { outcome: 'pass' }, artifacts: { review: { conclusion: 'pass', issues: 'none' } }, verification: { passed: true, evidence: ['checks'] } })
+  f.load('code-review'); f.load('code-commit'); f.load('software-testing')
+  await f.call({ operation: 'verify', command: 'check', evidence: ['real checks'] })
+  await f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', command: 'fail', evidence: ['scenario failed'] })
+  await assert.rejects(f.call({ operation: 'advance', target_stage: '完成' }), /skill_result/)
+  await f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', command: 'check', evidence: ['scenario passed'] })
+  await assert.rejects(f.call({ operation: 'advance', target_stage: '完成' }), /commit required/)
+  await f.call({ operation: 'commit', files: ['app.js'], message: '【LIVE-1】【TASK】done' })
+  await assert.rejects(f.call({ operation: 'commit', files: ['app.js'], message: '【LIVE-1】【TASK】done', hash: 'bbbbbbb' }), /does not match/)
+  await f.call({ operation: 'commit', files: ['app.js'], message: '【LIVE-1】【TASK】done', hash: 'abcdef1' })
+  await f.call({ operation: 'advance', target_stage: '完成' })
+  assert.equal(f.state().stage, '完成')
+  assert.equal(f.state().skill_results.完成['software-testing'].load_call_id.startsWith('call-'), true)
+})
+
+test('验证后修改代码会使旧回执失效，必须重新验证', async () => {
+  const f = fixture('交付')
+  f.load('code-verify')
+  await f.call({ operation: 'verify', command: 'check' })
+  f.records.set(join(f.cwd, 'app.js'), 'modified source')
+  await assert.rejects(f.call({ operation: 'advance', target_stage: '代码审核' }), /stale/)
+  await f.call({ operation: 'verify', command: 'check' })
+  await f.call({ operation: 'advance', target_stage: '代码审核' })
+  assert.equal(f.state().stage, '代码审核')
+})
+
+test('status 提交提示与真实门禁一致，分别披露过期验证和附加技能回执且不改台账', async () => {
+  const f = fixture('代码审核', { review: { outcome: 'pass' }, artifacts: { review: { conclusion: 'pass', issues: 'none' } } })
+  await f.call({ operation: 'verify', command: 'check' })
+  assert.equal(JSON.parse(await f.call({ operation: 'status' })).commit.allowed, false)
+  f.load('code-review'); f.load('code-commit'); f.load('software-testing')
+  await f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', command: 'check', evidence: ['tested'] })
+  assert.equal(JSON.parse(await f.call({ operation: 'status' })).commit.allowed, true)
+  f.records.set(join(f.cwd, 'app.js'), 'changed after testing')
+  const before = JSON.stringify(f.state())
+  const stale = JSON.parse(await f.call({ operation: 'status' }))
+  assert.equal(stale.commit.allowed, false)
+  assert.match(stale.commit.reason, /stale/)
+  assert.equal(stale.evidence_blockers.length, 2)
+  assert.equal(JSON.stringify(f.state()), before)
+  await assert.rejects(f.call({ operation: 'commit', files: ['app.js'], message: '【LIVE-1】【TASK】done' }), /stale/)
+  await f.call({ operation: 'verify', command: 'check' })
+  const partial = JSON.parse(await f.call({ operation: 'status' }))
+  assert.equal(partial.commit.allowed, false)
+  assert.equal(partial.evidence_blockers.length, 1)
+  assert.match(partial.evidence_blockers[0], /software-testing/)
+  await f.call({ operation: 'skill_result', target_stage: '完成', skill_name: 'software-testing', command: 'check', evidence: ['retested'] })
+  const current = JSON.parse(await f.call({ operation: 'status' }))
+  assert.equal(current.commit.allowed, true)
+  assert.deepEqual(current.evidence_blockers, [])
+})
+
+test('同名技能与规则在项目和个人目录各自保留管理入口', async t => {
+  const root = mkdtempSync(join(tmpdir(), 'engine-catalog-'))
+  const original = process.env.DSH_HOME
+  t.after(() => { if (original === undefined) delete process.env.DSH_HOME; else process.env.DSH_HOME = original; assert.ok(resolve(root).startsWith(resolve(tmpdir()) + sep)); rmSync(root, { recursive: true, force: true }) })
+  process.env.DSH_HOME = join(root, 'user')
+  const project = join(root, 'project')
+  for (const base of [join(project, '.dsh'), process.env.DSH_HOME]) {
+    mkdirSync(join(base, 'skills/software-testing'), { recursive: true })
+    mkdirSync(join(base, 'rules'), { recursive: true })
+    writeFileSync(join(base, 'skills/software-testing/SKILL.md'), '\uFEFF---\r\nname: software-testing\r\ndescription: tests\r\n---\r\nRun tests.\r\n')
+    writeFileSync(join(base, 'rules/test-rule.md'), 'Test rule\n')
+  }
+  const receiver = { authorizedPath: async path => path }
+  const skills = await Controller.prototype.listSkills.call(receiver, project)
+  const rules = await Controller.prototype.listRules.call(receiver, project)
+  assert.deepEqual(skills.skills.filter(x => x.name === 'software-testing').map(x => x.source), ['project', 'user'])
+  assert.deepEqual(rules.rules.filter(x => x.name === 'test-rule').map(x => x.source), ['project', 'user'])
+  const read = await Controller.prototype.readSkill.call(receiver, { path: project, level: 'project', name: 'software-testing' })
+  assert.equal(read.ok, true)
+  assert.match(read.content, /Run tests/)
+})
+
+test('安装包的七个内置技能实际注册且可在资源目录发现', async () => {
+  const registered = []
+  registerShippedSkills({ get: name => name === 'skills' ? { register: skill => { registered.push(skill); return () => {} } } : undefined })
+  const expected = ['code-commit', 'code-implement', 'code-review', 'code-verify', 'eng-delivery', 'requirement-analysis', 'solution-design']
+  assert.deepEqual(registered.map(skill => skill.name).sort(), expected)
+  assert.ok(registered.every(skill => skill.content.trim().length > 0))
+  const catalog = await Controller.prototype.listSkills.call({ authorizedPath: async path => path }, '')
+  assert.deepEqual(catalog.skills.filter(skill => skill.source === 'bundled').map(skill => skill.name).sort(), expected)
+})