@gobing-ai/spur 0.4.3 → 0.4.4

package/plugins/sp/scripts/feature-verification-steps.ts

@@ -18,10 +18,16 @@
  * Always exits 0 after a completed pass; the transition guard reads the status file and the
  * completion boundary validates the receipt (fail-closed). Unsafe ids are refused by the operation.
  *
+ * The installed `.mjs` twin may be launched with plain `node` (the `feature-verification` workflow
+ * selects `installed -> node`), but the generated inline bundle keeps `bun:sqlite` external by design, so the
+ * twin re-enters Bun at the top of `main()` (task 1197). Unlike daily-summary it fails closed when Bun
+ * is missing — a verifier that cannot load its bundle cannot run the checks.
+ *
  * Node-builtin imports only (ADR-065); the application seams come from the generated inline bundle,
  * never from `packages/app/src/index.ts`, which is not a plugin-script contract surface (0948 R3).
  */
 
+import { spawnSync } from 'node:child_process';
 import { existsSync } from 'node:fs';
 import { fileURLToPath } from 'node:url';
 import { getEnvVar } from '../lib/env';
@@ -97,6 +103,8 @@ async function verify(
     cmdOverride: string,
     spurBin: string,
     mode: ModuleMode,
+    confidenceOverride: string,
+    ackLowConfidence: boolean,
 ): Promise<void> {
     const mod = await loadModule(spurBin, mode);
     const result = await mod.runFeatureVerification({
@@ -104,11 +112,26 @@ async function verify(
         featureId,
         runId,
         cmdOverride,
+        // Operator-declared level (empty = derive from the pass) and the acknowledgement of a LOW
+        // level. Both ride the receipt, so the completion boundary reads them from the evidence
+        // rather than from whatever flags a later transition happens to pass.
+        confidenceOverride,
+        ackLowConfidence,
     });
     console.log(`feature-verification-steps: ${featureId} ${result.message}`);
 }
 
 function main(): void {
+    // The portable Node twin has no workspace imports; the generated bundle still uses Spur's Bun
+    // runtime (bun:sqlite stays external by design). Re-enter Bun before any app import; fail closed
+    // when Bun is missing — the verifier must not report a pass it could not run.
+    if (!process.versions.bun) {
+        const child = spawnSync('bun', [fileURLToPath(import.meta.url), ...process.argv.slice(2)], {
+            stdio: 'inherit',
+        });
+        if (child.error) console.error(`feature-verification-steps requires Bun on PATH: ${child.error.message}`);
+        process.exit(child.status ?? 1);
+    }
     const args = process.argv.slice(2);
     const command = args[0];
     const flag = (name: string): string => {
@@ -116,7 +139,10 @@ function main(): void {
         return i >= 0 && i + 1 < args.length ? (args[i + 1] ?? '') : '';
     };
     if (command !== 'verify') {
-        console.error('Usage: feature-verification-steps.ts verify --feature-id <id> --run-id <id> [--cmd <command>]');
+        console.error(
+            'Usage: feature-verification-steps.ts verify --feature-id <id> --run-id <id> [--cmd <command>] ' +
+                '[--confidence HIGH|MEDIUM|LOW] [--ack-low-confidence]',
+        );
         process.exit(2);
     }
     verify(
@@ -125,6 +151,8 @@ function main(): void {
         flag('--cmd') || getEnvVar('verificationCmd') || '',
         flag('--spur-bin') || getEnvVar('spurBin') || '',
         resolveModuleMode(flag('--module-mode')),
+        flag('--confidence') || getEnvVar('confidence') || '',
+        args.includes('--ack-low-confidence') || getEnvVar('ackLowConfidence') === 'true',
     )
         .then(() => process.exit(0))
         .catch((err: unknown) => {

package/plugins/sp/scripts/history-anatomy-cache.mjs

@@ -908,24 +908,24 @@ ${reasons}`, stderr: "" };
   process.exitCode = exitCode;
 }
 export {
-  validateSelector,
-  stampReport,
-  semanticArtifactDigest,
-  runCacheCli,
-  resolvePaths,
-  renderProvenanceFrontmatter,
-  refreshReport,
-  publishAtomically,
-  probe,
-  porcelainPaths,
-  parseProvenance,
-  logicDigest,
-  importedSnapshotAsOf,
-  diffPorcelain,
-  decideCache,
-  checkReportStructure,
-  buildProvenance,
-  bannerLine,
+  FINDING_FIELDS,
   REPORT_SECTIONS,
-  FINDING_FIELDS
+  bannerLine,
+  buildProvenance,
+  checkReportStructure,
+  decideCache,
+  diffPorcelain,
+  importedSnapshotAsOf,
+  logicDigest,
+  parseProvenance,
+  porcelainPaths,
+  probe,
+  publishAtomically,
+  refreshReport,
+  renderProvenanceFrontmatter,
+  resolvePaths,
+  runCacheCli,
+  semanticArtifactDigest,
+  stampReport,
+  validateSelector
 };

package/plugins/sp/scripts/idea-handoff.mjs

@@ -26,7 +26,7 @@ async function main(argv, env = getEnvVars()) {
   process.exit(await main(process.argv.slice(2)));
 }
 export {
-  main,
+  IDEA_HANDOFF_USAGE,
   loadHandoffLib,
-  IDEA_HANDOFF_USAGE
+  main
 };

package/plugins/sp/scripts/inline-run-dispatch.mjs

@@ -34,8 +34,8 @@ function resolveAppEntry(spurBin) {
   }
   return { entry, portable: true };
 }
-async function loadInlineApp(spurBin, resolveAppEntry2, required) {
-  const { entry, portable } = resolveAppEntry2(spurBin);
+async function loadInlineApp(spurBin, resolveAppEntry, required) {
+  const { entry, portable } = resolveAppEntry(spurBin);
   const app = await import(entry);
   const missing = portable ? required.filter((name) => typeof app[name] !== "function") : [];
   if (missing.length > 0) {

package/plugins/sp/scripts/inline-run-setup.mjs

@@ -34,8 +34,8 @@ function resolveAppEntry(spurBin) {
   }
   return { entry, portable: true };
 }
-async function loadInlineApp(spurBin, resolveAppEntry2, required) {
-  const { entry, portable } = resolveAppEntry2(spurBin);
+async function loadInlineApp(spurBin, resolveAppEntry, required) {
+  const { entry, portable } = resolveAppEntry(spurBin);
   const app = await import(entry);
   const missing = portable ? required.filter((name) => typeof app[name] !== "function") : [];
   if (missing.length > 0) {
@@ -149,21 +149,21 @@ function accumulate(acc, row, ts) {
   if (row.type === "message") {
     const m = row.message;
     if (m?.role === "assistant") {
-      const blocks2 = Array.isArray(m.content) ? m.content : [];
-      for (const b of blocks2) {
+      const blocks = Array.isArray(m.content) ? m.content : [];
+      for (const b of blocks) {
         if (b.type === "toolCall" && b.id) {
           acc.toolIds.add(b.id);
           if (b.name && OPERATOR_TOOLS.has(b.name))
             acc.asks.set(b.id, ts);
         }
       }
-      const u2 = m.usage;
-      if (u2 && row.id)
+      const u = m.usage;
+      if (u && row.id)
         acc.messages.set(row.id, {
-          input: u2.input ?? 0,
-          cacheCreate: u2.cacheWrite ?? 0,
-          cacheRead: u2.cacheRead ?? 0,
-          output: u2.output ?? 0
+          input: u.input ?? 0,
+          cacheCreate: u.cacheWrite ?? 0,
+          cacheRead: u.cacheRead ?? 0,
+          output: u.output ?? 0
         });
     } else if (m?.role === "toolResult" && m.toolCallId && acc.asks.has(m.toolCallId)) {
       acc.askMs += ts - (acc.asks.get(m.toolCallId) ?? ts);
@@ -658,8 +658,8 @@ async function main() {
   if (fingerprint) {
     if (runId !== "" || file !== "" || taskFiles.length !== 1 || (taskFiles[0] ?? "").trim() === "")
       usage();
-    const { app: app2 } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunFingerprint"]);
-    process.exit(await app2.runInlineRunFingerprint({ taskFile: taskFiles[0] ?? "", featureFile }));
+    const { app } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunFingerprint"]);
+    process.exit(await app.runInlineRunFingerprint({ taskFile: taskFiles[0] ?? "", featureFile }));
   }
   if (decide) {
     if (action || close || fingerprint || file !== "" || taskFiles.length > 0)
@@ -669,14 +669,14 @@ async function main() {
     if (!SAFE_RUN_ID_RE.test(runId))
       refuseUnsafeRunId(runId);
     try {
-      const { app: app2, portable: portable2 } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunDecide"]);
-      const { app: lib } = await loadInlineApp(spurBin, () => ({ entry: fileURLToPath2(new URL("../lib/inline-run.generated.mjs", import.meta.url)), portable: portable2 }), ["resolveDecideDecisionMakerEnabled", "loadSpurConfig"]);
-      const loadOpts = portable2 ? { embeddedSchemas: lib.EMBEDDED_SPUR_SCHEMAS } : undefined;
+      const { app, portable } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunDecide"]);
+      const { app: lib } = await loadInlineApp(spurBin, () => ({ entry: fileURLToPath2(new URL("../lib/inline-run.generated.mjs", import.meta.url)), portable }), ["resolveDecideDecisionMakerEnabled", "loadSpurConfig"]);
+      const loadOpts = portable ? { embeddedSchemas: lib.EMBEDDED_SPUR_SCHEMAS } : undefined;
       const [enabled, spurConfig] = await Promise.all([
         lib.resolveDecideDecisionMakerEnabled(process.cwd(), loadOpts),
         lib.loadSpurConfig(process.cwd(), loadOpts)
       ]);
-      process.exit(await app2.runInlineRunDecide({ runId, node, optionsFile: optionsJson, enabled, spurConfig }));
+      process.exit(await app.runInlineRunDecide({ runId, node, optionsFile: optionsJson, enabled, spurConfig }));
     } catch (error) {
       const message = error instanceof Error ? error.message : String(error);
       process.stdout.write(`${JSON.stringify({ ok: false, runId, error: message })}
@@ -689,15 +689,15 @@ async function main() {
       usage();
     if (from.trim() === "" || taskFiles.some((taskFile) => taskFile.trim() === ""))
       usage();
-    const { app: app2 } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunPersistOut"]);
-    process.exit(await app2.runInlineRunPersistOut({ from, taskFiles }));
+    const { app } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunPersistOut"]);
+    process.exit(await app.runInlineRunPersistOut({ from, taskFiles }));
   }
   if (nodeEnter || actionsFile !== "" || action || close) {
     if (!SAFE_RUN_ID_RE.test(runId))
       refuseUnsafeRunId(runId);
     const mode = nodeEnter ? "node-enter" : actionsFile !== "" ? "actions-file" : close ? "close" : "action";
-    const { app: app2 } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunTraceMode"]);
-    const code = await app2.runInlineRunTraceMode({
+    const { app } = await loadInlineApp(spurBin, resolveAppEntry, ["runInlineRunTraceMode"]);
+    const code = await app.runInlineRunTraceMode({
       mode,
       runId,
       node,

package/plugins/sp/scripts/persist-out-check.mjs

@@ -204,10 +204,10 @@ persist-out-check: --from must be an existing worktree directory
   process.exit(main(process.argv.slice(2)));
 }
 export {
-  wbsOfTaskFile,
-  persistOutCheckUsage,
-  main,
-  listObligations,
+  compareTrees,
   defaultInvokeRoot,
-  compareTrees
+  listObligations,
+  main,
+  persistOutCheckUsage,
+  wbsOfTaskFile
 };

package/plugins/sp/scripts/pr-reviewing.mjs

@@ -695,18 +695,18 @@ function main(argv) {
   process.exit(main(process.argv.slice(2)));
 }
 export {
-  spawnRunner,
-  setCommandRunner,
-  scanHygiene,
-  renderFindings,
-  parseArgs,
-  normalizeFindings,
-  main,
-  isHeadReviewed,
-  isExplicitCleanReview,
-  isCodexAuthor,
-  hasCurrentCleanReview,
-  hasCodeReviewRules,
+  buildRequestBody,
   extractSeverity,
-  buildRequestBody
+  hasCodeReviewRules,
+  hasCurrentCleanReview,
+  isCodexAuthor,
+  isExplicitCleanReview,
+  isHeadReviewed,
+  main,
+  normalizeFindings,
+  parseArgs,
+  renderFindings,
+  scanHygiene,
+  setCommandRunner,
+  spawnRunner
 };