@gobing-ai/spur 0.3.95 → 0.3.97

package/plugins/sp/scripts/quality-gate.mjs

@@ -2,7 +2,16 @@
 // @bun
 
 // plugins/sp/scripts/quality-gate.ts
-import { spawnSync } from "child_process";
+import { appendFileSync as appendFileSync2 } from "fs";
+import { join as join2 } from "path";
+
+// plugins/sp/lib/env.ts
+function getEnvVars() {
+  return process.env;
+}
+
+// plugins/sp/lib/quality-gate.generated.mjs
+import { spawnSync } from "node:child_process";
 import {
   appendFileSync,
   closeSync,
@@ -14,16 +23,9 @@ import {
   rmSync,
   statSync,
   writeFileSync
-} from "fs";
-import { tmpdir } from "os";
-import { join } from "path";
-
-// plugins/sp/lib/env.ts
-function getEnvVars() {
-  return process.env;
-}
-
-// plugins/sp/scripts/quality-gate.ts
+} from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
 var MAX_GATE_ATTEMPTS = 5;
 var MAX_FINDINGS = 20;
 var RETRY_DELAY_MS_DEFAULT = 1e4;
@@ -121,6 +123,9 @@ function readReceiptStatus(receiptPath, currentDigest) {
   }
   if (receipt.tier !== "full")
     return { reuse: false, reason: "light-only" };
+  if (!Array.isArray(receipt.checks) || receipt.checks.length === 0 || receipt.checks.some((row) => row === null || typeof row !== "object" || row.status !== "PASS" || typeof row.cmd !== "string" || row.cmd.trim().length === 0)) {
+    return { reuse: false, reason: "failed" };
+  }
   return { reuse: true, reason: "ok" };
 }
 var TEST_FILE_PATTERN = /\.test\.tsx?$/;
@@ -241,7 +246,7 @@ function runLightGate(env, options = {}) {
     if (priorRow !== undefined) {
       checks.push(priorRow);
       skipped++;
-      const line = `--- light ${plan.id}: check.reused \u2014 skipped (PASS at the same input digest)
+      const line = `--- light ${plan.id}: check.reused — skipped (PASS at the same input digest)
 `;
       process.stdout.write(line);
       appendFileSync(abs(logFile), line);
@@ -264,7 +269,7 @@ ${result.output}`);
     completedAt: new Date().toISOString()
   });
   if (preserveFullReceipt) {
-    appendFileSync(abs(logFile), `--- light receipt: not written \u2014 the full-tier receipt at the same input digest is preserved
+    appendFileSync(abs(logFile), `--- light receipt: not written — the full-tier receipt at the same input digest is preserved
 `);
     process.stdout.write(`light gate ${receipt.status} (${scope.files.length} changed files; checks: ${checks.length},` + ` skipped: ${skipped}; receipt: ${receiptFile} preserved (full tier); log: ${logFile})
 `);
@@ -315,17 +320,32 @@ function runQualityGate(mode, env, options = {}) {
     writeFileSync(abs(attemptFile), `0
 `);
   const gateStartedAtMs = Date.now();
-  let gateRc = 0;
+  const commandPresent = (env.qualityGateCmd ?? "").trim().length > 0;
+  let gateRc = commandPresent ? 0 : 1;
   let gateAttempt = 0;
-  const noProgressSkip = mode === "recheck" && receiptFailsAtDigest(readReceipt(abs(rel("-check-receipt.json"))), env.proofDigest ?? "");
+  if (!commandPresent)
+    appendFileSync(abs(logFile), `quality-gate: mode ${mode} requires env \`qualityGateCmd\` to be non-empty
+`);
+  const reusePass = commandPresent && readReceiptStatus(abs(rel("-check-receipt.json")), env.proofDigest ?? "").reuse;
+  if (reusePass) {
+    const line = `check.reused — full-tier PASS receipt at input digest ${env.proofDigest ?? ""}; gate skipped
+`;
+    process.stdout.write(line);
+    appendFileSync(abs(logFile), line);
+    writeFileSync(abs(findingsFile), extractFindings(readFileSync(abs(logFile), "utf8")));
+    writeFileSync(abs(statusFile), `PASS
+`);
+    return { status: "PASS", attempts: 0, logFile, findingsFile, statusFile, attemptFile };
+  }
+  const noProgressSkip = commandPresent && mode === "recheck" && receiptFailsAtDigest(readReceipt(abs(rel("-check-receipt.json"))), env.proofDigest ?? "");
   if (noProgressSkip) {
-    const line = `check.skipped-no-progress \u2014 full-tier FAIL receipt at input digest ${env.proofDigest ?? ""}; recheck skipped
+    const line = `check.skipped-no-progress — full-tier FAIL receipt at input digest ${env.proofDigest ?? ""}; recheck skipped
 `;
     process.stdout.write(line);
     appendFileSync(abs(logFile), line);
     gateRc = 1;
   }
-  if (mode === "recheck" && !noProgressSkip && (env.gateProbeCmd ?? "").length > 0) {
+  if (mode === "recheck" && gateRc === 0 && (env.gateProbeCmd ?? "").length > 0) {
     const probe = runShellCommand(env.gateProbeCmd ?? "", cwd);
     writeFileSync(abs(`${logFile}.probe`), probe.output);
     gateRc = probe.code;
@@ -371,7 +391,7 @@ function runQualityGate(mode, env, options = {}) {
     process.stdout.write(`quality gate PASS (attempts: ${attemptsLabel}; log: ${logFile}; bytes: ${bytes})
 `);
   } else {
-    process.stdout.write(`quality gate FAIL \u2014 last 40 lines follow (full log: ${logFile})
+    process.stdout.write(`quality gate FAIL — last 40 lines follow (full log: ${logFile})
 `);
     process.stdout.write(tailLines(readFileSync(abs(logFile), "utf8"), 40));
   }
@@ -382,7 +402,7 @@ function runQualityGate(mode, env, options = {}) {
   appendFileSync(abs(logFile), `proof-digest: ${env.proofDigest ?? ""}
 `);
   let receiptFile;
-  if (!noProgressSkip) {
+  if (!noProgressSkip && commandPresent) {
     if ((env.proofDigest ?? "").length > 0) {
       receiptFile = join(runDir, `${env.wbs}-check-receipt.json`);
       const receipt = buildReceipt({
@@ -404,11 +424,13 @@ function runQualityGate(mode, env, options = {}) {
       writeFileSync(abs(receiptFile), `${JSON.stringify(receipt, null, 2)}
 `);
     } else {
-      appendFileSync(abs(logFile), "check-receipt: not written \u2014 env `proofDigest` is not set\n");
+      appendFileSync(abs(logFile), "check-receipt: not written — env `proofDigest` is not set\n");
     }
   }
   return { status, attempts: gateAttempt, logFile, findingsFile, statusFile, attemptFile, receiptFile };
 }
+
+// plugins/sp/scripts/quality-gate.ts
 var QUALITY_GATE_USAGE = "usage: quality-gate.ts <run|recheck|light|status>  (env: wbs, qualityGateCmd, gateProbeCmd, proofDigest, runId)";
 function main(argv, rawEnv = getEnvVars(), options = {}) {
   const mode = argv[0];
@@ -426,18 +448,18 @@ function main(argv, rawEnv = getEnvVars(), options = {}) {
   if (mode === "light") {
     runLightGate(env);
   } else if (mode === "status") {
-    const runDir = join(options.cwd ?? ".", ".spur", "run");
-    const verdict = readReceiptStatus(join(runDir, `${env.wbs}-check-receipt.json`), env.proofDigest ?? "");
+    const runDir = join2(options.cwd ?? ".", ".spur", "run");
+    const verdict = readReceiptStatus(join2(runDir, `${env.wbs}-check-receipt.json`), env.proofDigest ?? "");
     if (verdict.reuse) {
       const line = `check.reused \u2014 full-tier receipt reused for input digest ${env.proofDigest ?? ""}
 `;
       process.stdout.write(line);
-      appendFileSync(join(runDir, `${env.wbs}-test-gate.log`), line);
+      appendFileSync2(join2(runDir, `${env.wbs}-test-gate.log`), line);
     }
     process.stdout.write(`${JSON.stringify(verdict)}
 `);
   } else {
-    runQualityGate(mode, env);
+    return runQualityGate(mode, env, options).status === "PASS" ? 0 : 1;
   }
   return 0;
 }