@gobing-ai/spur 0.3.13 → 0.3.14

package/spur.js

@@ -48,10 +48,7 @@ var __esm = (fn, res) => () => (fn && (res = fn(fn = 0)), res);
 var __require = import.meta.require;
 
 // ../../node_modules/.bun/@gobing-ai+ts-utils@0.4.10/node_modules/@gobing-ai/ts-utils/dist/errors.js
-function isAppError(error) {
-  return error instanceof AppError;
-}
-var ErrorCode, AppError, NotFoundError;
+var ErrorCode;
 var init_errors = __esm(() => {
   ErrorCode = {
     NotFound: "NOT_FOUND",
@@ -59,20 +56,6 @@ var init_errors = __esm(() => {
     Conflict: "CONFLICT",
     Internal: "INTERNAL"
   };
-  AppError = class AppError extends Error {
-    code;
-    constructor(code, message) {
-      super(message);
-      this.name = "AppError";
-      this.code = code;
-    }
-  };
-  NotFoundError = class NotFoundError extends AppError {
-    constructor(message) {
-      super(ErrorCode.NotFound, message);
-      this.name = "NotFoundError";
-    }
-  };
 });
 
 // ../../node_modules/.bun/@gobing-ai+ts-utils@0.4.10/node_modules/@gobing-ai/ts-utils/dist/api-response.js
@@ -58399,6 +58382,8 @@ var init_schema4 = __esm(() => {
     priority: exports_external.enum(PRIORITIES).optional(),
     tags: exports_external.array(exports_external.string()).optional(),
     dependencies: exports_external.array(exports_external.string()).optional(),
+    done_forced: exports_external.preprocess((v) => typeof v === "string" ? v === "true" : v, exports_external.boolean().optional()),
+    done_reason: exports_external.string().optional(),
     created_at: isoDateString,
     updated_at: isoDateString
   });
@@ -59046,6 +59031,110 @@ var init_corpus_migrator = __esm(() => {
   NULL_PRESERVING_KEYS = new Set(["parent_wbs"]);
 });
 
+// ../../packages/app/src/services/done-transition-guard.ts
+async function readVerdictArtifact(fs3, runDir, wbs) {
+  const path9 = `${runDir}/${wbs}-verdict.json`;
+  let exists2;
+  try {
+    exists2 = await fs3.exists(path9);
+  } catch {
+    exists2 = true;
+  }
+  if (!exists2) {
+    return { artifact: undefined, path: path9 };
+  }
+  let raw;
+  try {
+    raw = await fs3.readFile(path9);
+  } catch (err) {
+    return { artifact: undefined, path: path9, readError: `unreadable artifact: ${err.message}` };
+  }
+  let parsed;
+  try {
+    parsed = JSON.parse(raw);
+  } catch (err) {
+    return { artifact: undefined, path: path9, readError: `malformed JSON: ${err.message}` };
+  }
+  if (typeof parsed !== "object" || parsed === null || !("verdict" in parsed)) {
+    return { artifact: undefined, path: path9, readError: "missing required `verdict` field" };
+  }
+  return { artifact: parsed, path: path9 };
+}
+function computeAggregate(artifact) {
+  const reqs = artifact.requirements ?? [];
+  const acs = artifact.acceptanceCriteria ?? [];
+  if (reqs.length === 0 && acs.length === 0) {
+    return artifact.verdict;
+  }
+  if (reqs.some((r) => r.status === "UNMET") || acs.some((a2) => a2.status === "UNMET")) {
+    return "FAIL";
+  }
+  if (reqs.some((r) => r.status === "PARTIAL") || acs.some((a2) => a2.status === "PARTIAL")) {
+    return "PARTIAL";
+  }
+  return "PASS";
+}
+function formatDenialMessage(args) {
+  const { wbs, taskFilePath, verdictPath, verdict, inconsistency, artifact } = args;
+  const lines = [
+    `Cannot transition task ${wbs} to done: verify verdict is ${verdict}.`,
+    `  task:    ${taskFilePath}`,
+    `  verdict: ${verdictPath}`
+  ];
+  if (inconsistency) {
+    lines.push(`  warning: artifact is self-inconsistent \u2014 stored aggregate ${inconsistency.stored} contradicts rows (computed ${inconsistency.computed}). Treated as non-PASS.`);
+  }
+  const reqCount = artifact?.requirements?.length ?? 0;
+  const acCount = artifact?.acceptanceCriteria?.length ?? 0;
+  const rowCount = reqCount + acCount;
+  if (verdict === "UNKNOWN" && artifact !== undefined && (artifact.source === "spur-task-verdict" || rowCount === 0)) {
+    const source = artifact.source ?? "unknown";
+    lines.push(`  source:  ${source} artifact contains ${rowCount} structured row${rowCount === 1 ? "" : "s"} ` + `(${reqCount} requirement${reqCount === 1 ? "" : "s"}, ${acCount} AC${acCount === 1 ? "" : "s"}). ` + `UNKNOWN means the verify answer file carried no parseable markdown tables ` + `(\`| Req | Status | Evidence |\` and \`| AC | Status | Evidence Type | Evidence |\`).`);
+    lines.push(`           see sp:spur-cli \`tasks/verbs.md\` \xA7Answer-file shape for the expected format. ` + `Re-run \`/sp:dev-verify ${wbs}\` so the skill authors the tables; do not loosen the parser.`);
+  }
+  lines.push("  remediation: re-run `/sp:dev-verify " + wbs + "` until PASS, or override with `spur task update " + wbs + ' done --force-done --reason "<why>"`.');
+  return lines.join(`
+`);
+}
+function formatNoopMessage(wbs, status) {
+  return `${wbs}: already ${status} \u2014 no transition`;
+}
+function evaluateDoneTransition(input) {
+  const { wbs, taskFilePath, currentStatus, targetStatus, forced, reason, artifact } = input;
+  if (targetStatus === currentStatus) {
+    return { kind: "noop", fromStatus: currentStatus, message: formatNoopMessage(wbs, currentStatus) };
+  }
+  if (artifact === undefined) {
+    return { kind: "allow", reason: "no-artifact" };
+  }
+  if (forced) {
+    return { kind: "allow", reason: "forced" };
+  }
+  const computed = computeAggregate(artifact);
+  const effective = harshnessMax(artifact.verdict, computed);
+  if (effective === "PASS") {
+    return { kind: "allow", reason: "pass" };
+  }
+  const verdictPath = `.spur/run/${wbs}-verdict.json`;
+  const inconsistency = artifact.verdict !== computed ? { stored: artifact.verdict, computed } : undefined;
+  return {
+    kind: "deny",
+    verdict: effective,
+    message: formatDenialMessage({
+      wbs,
+      taskFilePath,
+      verdictPath,
+      verdict: effective,
+      inconsistency,
+      artifact
+    })
+  };
+}
+function harshnessMax(a2, b) {
+  const rank = { PASS: 0, UNKNOWN: 1, PARTIAL: 2, FAIL: 3 };
+  return rank[a2] >= rank[b] ? a2 : b;
+}
+
 // ../../packages/app/src/services/event-names.ts
 function event(name, source, renderer, payloadPolicy = "metadata-only", tier = "default") {
   return {
@@ -61663,6 +61752,18 @@ var init_task_check = __esm(() => {
       }
     }
     async runL4(doc2, fm, findings, featuresDir, tasksDir) {
+      const template = typeof fm.template === "string" ? fm.template : DEFAULT_TASK_VARIANT;
+      if (template === DEFAULT_TASK_VARIANT) {
+        const designBody = doc2.getSection("Design");
+        if (designBody !== null && isPlaceholderBody(designBody)) {
+          findings.push({
+            layer: "L4",
+            severity: "warning",
+            section: "Design",
+            message: "Design section is present but empty (placeholder-only) \u2014 populate it so the task retains an explicit implementation approach"
+          });
+        }
+      }
       const featureId2 = fm.feature_id ?? fm["feature-id"];
       const parentWbs = fm.parent_wbs ?? fm["parent-wbs"];
       const deps = fm.dependencies;
@@ -62360,9 +62461,15 @@ class TaskService {
     return this.writeService.transition(ref, toStatus, actor ?? this.ctx.actor ?? "system");
   }
   async updateField(wbs, key, value) {
-    const allowed = new Set(["feature_id", "parent_wbs", "priority"]);
-    if (!allowed.has(key)) {
-      throw new Error(`Field "${key}" is not settable via update; allowed: ${[...allowed].join(", ")}.`);
+    const allowed = {
+      feature_id: true,
+      parent_wbs: true,
+      priority: true,
+      done_forced: true,
+      done_reason: true
+    };
+    if (!(key in allowed)) {
+      throw new Error(`Field "${key}" is not settable via update; allowed: ${Object.keys(allowed).join(", ")}.`);
     }
     const filePath = await this.resolveTaskFile(wbs);
     const ref = { kind: "task", id: wbs, filePath, folder: this.ctx.tasksDir };
@@ -65068,6 +65175,7 @@ __export(exports_src2, {
   renderReview: () => renderReview,
   registerSystemEventTap: () => registerSystemEventTap,
   registerSpurBuiltins: () => registerSpurBuiltins,
+  readVerdictArtifact: () => readVerdictArtifact,
   readVerdict: () => readVerdict,
   parseVerdict: () => parseVerdict,
   parsePsOutput: () => parsePsOutput,
@@ -65077,10 +65185,14 @@ __export(exports_src2, {
   hitlConfirmDefault: () => hitlConfirmDefault,
   hitlAutoApproveEnabled: () => hitlAutoApproveEnabled,
   hasPopulatedPriorityTable: () => hasPopulatedPriorityTable,
+  formatNoopMessage: () => formatNoopMessage,
+  formatDenialMessage: () => formatDenialMessage,
   extractSystemEventActor: () => extractSystemEventActor,
   extractReviewSectionBody: () => extractReviewSectionBody,
+  evaluateDoneTransition: () => evaluateDoneTransition,
   deriveVerdict: () => deriveVerdict,
   createPsProcessInspector: () => createPsProcessInspector,
+  computeAggregate: () => computeAggregate,
   clampToolUseLimit: () => clampToolUseLimit,
   bridgeEventBus: () => bridgeEventBus,
   WorkflowAppService: () => WorkflowAppService,
@@ -73122,7 +73234,7 @@ import { join as join15, resolve as resolve5 } from "path";
 var CLI_CONFIG = {
   binaryName: "spur",
   binaryLabel: "spur",
-  binaryVersion: "0.3.13",
+  binaryVersion: "0.3.14",
   configDir: ".spur",
   configFile: ".spur/config.yaml",
   databaseFile: ".spur/spur.db"
@@ -78973,18 +79085,15 @@ var contextInjector = (appRt) => async function contextInjectorMiddleware(c3, ne
   await next();
 };
 
-// ../server/src/middleware/error-handler.ts
-init_dist();
-
 // ../server/src/errors.ts
-init_src3();
+init_errors5();
 
 // ../server/src/middleware/error-handler.ts
 function hasHttpStatus(err) {
   return typeof err === "object" && err !== null && "status" in err && typeof err.status === "number";
 }
 function isAppErrorLike(err) {
-  return isAppError(err);
+  return typeof err === "object" && err !== null && "code" in err && typeof err.code === "string" && "message" in err && typeof err.message === "string";
 }
 function errorEnvelope(code, message, details) {
   return { ok: false, error: { code, message, ...details !== undefined ? { details } : {} } };
@@ -79661,7 +79770,6 @@ var contract = {
 
 // ../server/src/modules/feature/handlers.ts
 init_schema4();
-init_dist();
 var os2 = implement(contract);
 function createResponseShape(r2) {
   return { id: r2.ref.id, filePath: r2.ref.filePath };
@@ -79684,7 +79792,7 @@ function createFeatureHandlers(ctx) {
     show: os2.feature.show.handler(async ({ input }) => {
       const result = await ctx.featureService().show(input.id);
       if (!result)
-        throw new NotFoundError(`Feature ${input.id} not found`);
+        throw new HTTPException(404, { message: `Feature ${input.id} not found` });
       return {
         ok: true,
         data: {
@@ -79713,7 +79821,7 @@ function createFeatureHandlers(ctx) {
       const folders = ctx.planningFolders();
       const feature = await ctx.featureService().show(input.id);
       if (!feature)
-        throw new NotFoundError(`Feature ${input.id} not found`);
+        throw new HTTPException(404, { message: `Feature ${input.id} not found` });
       const { FeatureCheckService: FeatureCheckService2 } = await Promise.resolve().then(() => (init_feature_check(), exports_feature_check));
       const svc = new FeatureCheckService2(ctx.fs);
       return {
@@ -79727,7 +79835,7 @@ function createFeatureHandlers(ctx) {
     body: os2.feature.body.handler(async ({ input }) => {
       const feature = await ctx.featureService().show(input.id);
       if (!feature)
-        throw new NotFoundError(`Feature ${input.id} not found`);
+        throw new HTTPException(404, { message: `Feature ${input.id} not found` });
       await ctx.featureService().updateBody(input.id, input.body);
       return { ok: true, data: {} };
     }),
@@ -79899,17 +80007,33 @@ function parseLimit(raw2, fallback) {
 }
 
 // ../server/src/modules/observability/index.ts
-init_src3();
 var ledgerWatcher;
+var ledgerWatcherLoad;
 var watcherPath;
-function getLedgerWatcher(path9) {
-  if (!ledgerWatcher || watcherPath !== path9) {
-    ledgerWatcher?.stop();
-    ledgerWatcher = new TokenLedgerWatcher({ ledgerPath: path9 });
-    watcherPath = path9;
-    ledgerWatcher.start();
+async function getLedgerWatcher(path9) {
+  if (watcherPath === path9) {
+    if (ledgerWatcher)
+      return ledgerWatcher;
+    if (ledgerWatcherLoad)
+      return ledgerWatcherLoad;
+  }
+  ledgerWatcher?.stop();
+  ledgerWatcher = undefined;
+  watcherPath = path9;
+  const load2 = Promise.resolve().then(() => (init_src3(), exports_src2)).then(({ TokenLedgerWatcher: TokenLedgerWatcher2 }) => {
+    const watcher2 = new TokenLedgerWatcher2({ ledgerPath: path9 });
+    watcher2.start();
+    return watcher2;
+  });
+  ledgerWatcherLoad = load2;
+  const watcher = await load2;
+  if (watcherPath === path9 && ledgerWatcherLoad === load2) {
+    ledgerWatcher = watcher;
+    ledgerWatcherLoad = undefined;
+  } else {
+    watcher.stop();
   }
-  return ledgerWatcher;
+  return watcher;
 }
 function toolUseSsePayload(event2) {
   return {
@@ -79924,7 +80048,7 @@ function handleProcesses(ctx) {
       const snapshot = await ctx.processInventory().snapshot();
       return c3.json(snapshot);
     } catch (err) {
-      if (err instanceof UnsupportedProcessPlatformError) {
+      if (err instanceof Error && "code" in err && err.code === "UNSUPPORTED_PLATFORM") {
         return c3.json({ error: err.message, code: err.code }, 501);
       }
       const message = err instanceof Error ? err.message : String(err);
@@ -79943,7 +80067,7 @@ function handleToolUseGet(ctx) {
           limitRaw = parsed;
       }
       const before = c3.req.query("before") ?? undefined;
-      const limit = clampToolUseLimit(limitRaw);
+      const limit = limitRaw === undefined || !Number.isFinite(limitRaw) || limitRaw <= 0 ? 200 : Math.min(limitRaw, 1000);
       const snapshot = ctx.tokenLedger().snapshot({ limit, before });
       return c3.json(snapshot);
     } catch (err) {
@@ -79972,7 +80096,7 @@ function handleToolUseStream(ctx) {
       closeController();
     };
     const stream = new ReadableStream({
-      start(controller) {
+      async start(controller) {
         const encoder = new TextEncoder;
         closeController = () => {
           try {
@@ -79985,17 +80109,17 @@ function handleToolUseStream(ctx) {
         }
         signal.addEventListener("abort", teardown);
         heartbeatInterval = setInterval(sendSseKeepalive, 15000, closed, controller, encoder);
-        enqueueSseFrame(closed, controller, encoder, {
-          type: "connected",
-          occurredAt: new Date().toISOString()
-        });
         try {
           const path9 = ctx.tokenLedger().path;
-          const watcher = getLedgerWatcher(path9);
+          const watcher = await getLedgerWatcher(path9);
           unsubscribe = watcher.subscribe((event2) => {
             if (!enqueueSseFrame(closed, controller, encoder, toolUseSsePayload(event2)))
               teardown();
           });
+          enqueueSseFrame(closed, controller, encoder, {
+            type: "connected",
+            occurredAt: new Date().toISOString()
+          });
         } catch {
           enqueueSseFrame(closed, controller, encoder, {
             type: "error",
@@ -80027,7 +80151,6 @@ var observabilityModule = {
 
 // ../server/src/modules/task/handlers.ts
 init_schema4();
-init_dist();
 var os3 = implement(contract);
 function toFilters(query) {
   if (!query)
@@ -80068,7 +80191,7 @@ function createTaskHandlers(ctx) {
     show: os3.task.show.handler(async ({ input }) => {
       const result = await ctx.taskService().show(input.wbs);
       if (!result)
-        throw new NotFoundError(`Task ${input.wbs} not found`);
+        throw new HTTPException(404, { message: `Task ${input.wbs} not found` });
       return {
         ok: true,
         data: {
@@ -83546,6 +83669,13 @@ var STATUS_TITLE = {
   done: "Done",
   cancelled: "Canceled"
 };
+function canonicalStatusOrRaw(raw2) {
+  try {
+    return normalizeTaskStatus(raw2);
+  } catch {
+    return raw2;
+  }
+}
 function renderTaskBoard(tasks, boardTitle, color, columns2) {
   const lines = ["", `  ${color.blue(`Kanban Board \u2014 ${boardTitle}`)}`, ""];
   for (const status of columns2) {
@@ -83631,7 +83761,7 @@ ${result.content}`);
       context4.setExitCode(1);
     }
   });
-  task.command("update").summary("Update a task status or replace a section.").argument("<wbs>", "Task WBS number").argument("[status]", "New status (for lifecycle transition)").option("--section <name>", "Section name to replace").option("--from-file <path>", "File to read section body from (requires --section)").option("--feature <id>", "Set the feature_id frontmatter field (traceability edge)").option("--priority <p>", "Set the priority frontmatter field (P0\u2013P3)").option("--no-lifecycle", "Suppress lifecycle workflow run creation (use during pipeline runs to avoid orphaned lifecycle runs)").option("--folder <path>", "Custom tasks folder").option("--json", "Output machine-readable JSON").action(async (wbs, status, options) => {
+  task.command("update").summary("Update a task status or replace a section.").argument("<wbs>", "Task WBS number").argument("[status]", "New status (for lifecycle transition)").option("--section <name>", "Section name to replace").option("--from-file <path>", "File to read section body from (requires --section)").option("--feature <id>", "Set the feature_id frontmatter field (traceability edge)").option("--priority <p>", "Set the priority frontmatter field (P0\u2013P3)").option("--no-lifecycle", "Suppress lifecycle workflow run creation (use during pipeline runs to avoid orphaned lifecycle runs)").option("--force-done", "Allow transitioning to `done` even when the verify verdict is not PASS; records an override (task 0292)").option("--reason <text>", "Rationale for a forced-done override (paired with --force-done; persisted as done_reason)").option("--verdict-dir <path>", "Directory holding <wbs>-verdict.json artifacts (default: .spur/run)").option("--folder <path>", "Custom tasks folder").option("--json", "Output machine-readable JSON").action(async (wbs, status, options) => {
     const svc = await makeService2(context4, options.folder, options.lifecycle === false);
     try {
       if (options.section !== undefined) {
@@ -83659,6 +83789,7 @@ ${result.content}`);
           context4.output.write(`Set ${key}=${value2} on task ${result.ref.id}`);
         }
       } else if (status !== undefined) {
+        status = canonicalStatusOrRaw(status);
         if (options.lifecycle !== false && (status === "done" || status === "testing")) {
           const adapter = makeLifecycleAdapter(context4, TASK_LIFECYCLE_PROFILE);
           if (adapter === undefined) {
@@ -83671,11 +83802,59 @@ ${result.content}`);
             }
           }
         }
+        let forcedDone = false;
+        let forcedDoneReason;
+        let forcedDoneVerdict;
+        if (status === "done") {
+          const current = await svc.show(wbs);
+          const verdictDir = options.verdictDir ?? join22(context4.cwd, ".spur", "run");
+          const loaded = await readVerdictArtifact(context4.fs, verdictDir, wbs);
+          const guardOutcome = evaluateDoneTransition({
+            wbs,
+            taskFilePath: current.filePath,
+            currentStatus: canonicalStatusOrRaw(String(current.frontmatter.status)),
+            targetStatus: "done",
+            forced: options.forceDone === true,
+            reason: options.reason,
+            artifact: loaded.artifact
+          });
+          if (guardOutcome.kind === "noop") {
+            if (options.json) {
+              context4.output.write(toJson2({ ok: true, noop: true, wbs, status: "done" }));
+            } else {
+              context4.output.write(guardOutcome.message);
+            }
+            return;
+          }
+          if (guardOutcome.kind === "deny") {
+            context4.output.error(guardOutcome.message);
+            context4.setExitCode(1);
+            return;
+          }
+          if (guardOutcome.reason === "forced" && loaded.artifact !== undefined) {
+            forcedDone = true;
+            forcedDoneReason = options.reason;
+            forcedDoneVerdict = loaded.artifact.verdict;
+          }
+        }
         const result = await svc.updateStatus(wbs, status);
+        if (forcedDone) {
+          try {
+            await svc.updateField(wbs, "done_forced", "true");
+            if (forcedDoneReason !== undefined && forcedDoneReason.length > 0) {
+              await svc.updateField(wbs, "done_reason", forcedDoneReason);
+            }
+          } catch (auditErr) {
+            context4.output.error(`warning: failed to record done-forced audit fields: ${String(auditErr)}`);
+          }
+        }
         if (options.json) {
           context4.output.write(toJson2(result));
         } else {
           context4.output.write(`${result.ref.id}: ${result.fromStatus} \u2192 ${result.toStatus}`);
+          if (forcedDone && forcedDoneVerdict !== undefined) {
+            context4.output.write(`\u24D8  Override recorded: task advanced to done despite ${forcedDoneVerdict} verdict (done_forced=true).`);
+          }
         }
         if (status === "done" && !options.json) {
           const task2 = await svc.show(wbs);

package/web/_astro/BoardApp.BdyUxAQU.js

@@ -0,0 +1 @@
+import{a as t}from"./BoardApp.oOZMY52P.js";import"./index.A0eX93qW.js";export{t as default};