@gobing-ai/spur 0.2.8 → 0.2.10

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gobing-ai/spur",
-    "version": "0.2.8",
+    "version": "0.2.10",
     "description": "Spur CLI — local-first harness for mainstream coding agents: constraint checking, workflow orchestration, agent health, and history analytics. Bun-native; exposes the `spur` command.",
     "keywords": [
         "spur",

package/spur-cli/config/rules/structure/protected-files.yaml

@@ -26,6 +26,7 @@ rules:
             - ".test.ts"
             - "/node_modules/"
             - "/dist/"
+            - "vendors/"
 
   - id: no-unsafe-git-commands
     description: "Unsafe git commands (force-push, hard reset) can overwrite history or cause data loss (AGENTS.md CRITICAL safety)."

package/spur-cli/config/rules/structure/test-location.yaml

@@ -52,3 +52,4 @@ rules:
       - "**/tests/**"
       ## pure re-export for UI components
       - "apps/web/src/ui.ts"
+      - "apps/web/src/modules/config.ts"

package/spur-cli/config/tasks/section-matrix.yaml

@@ -14,22 +14,19 @@ variants:
   standard:
     backlog:
       required: [Background]
-      forbidden: [Solution, Review, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     # todo = "ready to execute" (§2.3): fully specified and HITL-reviewable.
-    # Design + Plan + Acceptance Criteria are required so a task can be reviewed
-    # and approved before any code is written. Solution stays forbidden — it is
-    # the implementation change-map (file:line), authored at wip/testing.
+    # Templates intentionally carry the full lifecycle scaffold; required lists
+    # express readiness, while optional lists tolerate empty future-stage placeholders.
     todo:
       required: [Background, Acceptance Criteria, Design, Plan]
-      optional: [Q&A, Requirements]
-      forbidden: [Solution, Review, Testing]
+      optional: [Q&A, Requirements, Solution, Testing, Review]
     wip:
       required: [Background, Acceptance Criteria, Design, Plan]
-      optional: [Q&A, Requirements, Solution]
-      forbidden: [Review]
+      optional: [Q&A, Requirements, Solution, Testing, Review]
     testing:
       required: [Solution, Testing]
-      optional: [Background, Review]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Review]
     # done REQUIRES the evidence trio (Solution/Testing/Review). The spec sections
     # a task was built from (Design/Plan/AC/…) are OPTIONAL, not forbidden, so a
     # finished task keeps its design history rather than being stripped to pass the
@@ -40,27 +37,25 @@ variants:
       gate: true
     blocked:
       required: [Background]
-      optional: [Plan, Solution]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     cancelled:
       required: []
-      optional: [Background]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
 
   # Feature implementation — AC pre-seeded from the linked feature's scenarios.
   feature-impl:
     backlog:
       required: [Background]
-      forbidden: [Solution, Review, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     todo:
       required: [Background, Acceptance Criteria, Design, Plan]
-      optional: [Q&A, Requirements]
-      forbidden: [Solution, Review, Testing]
+      optional: [Q&A, Requirements, Solution, Testing, Review]
     wip:
       required: [Background, Acceptance Criteria, Design, Plan]
-      optional: [Q&A, Requirements, Solution]
-      forbidden: [Review]
+      optional: [Q&A, Requirements, Solution, Testing, Review]
     testing:
       required: [Solution, Testing]
-      optional: [Background, Requirements, Acceptance Criteria, Design, Plan, Review]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Review]
     # done keeps the spec sections optional (see `standard` rationale above) so a
     # finished feature-impl task retains its Design/Plan/AC history.
     done:
@@ -69,37 +64,35 @@ variants:
       gate: true
     blocked:
       required: [Background]
-      optional: [Plan, Solution]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     cancelled:
       required: []
-      optional: [Background]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
 
   # Bug / issue report — repro in Background, verified Root Cause, then fix.
   issue:
     backlog:
       required: [Background]
-      forbidden: [Solution, Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Root Cause, Solution, Testing, Review]
     todo:
       required: [Background, Root Cause, Plan]
-      optional: [Acceptance Criteria, Design, Q&A]
-      forbidden: [Solution, Review]
+      optional: [Requirements, Acceptance Criteria, Design, Q&A, Solution, Testing, Review]
     wip:
       required: [Background, Root Cause, Plan]
-      optional: [Design, Solution, Q&A]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Design, Solution, Testing, Review, Q&A]
     testing:
       required: [Root Cause, Solution, Testing]
-      optional: [Background, Review]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Review]
     done:
       required: [Root Cause, Solution, Testing, Review]
-      optional: [Background, Acceptance Criteria, Design, Plan, Q&A]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan]
       gate: true
     blocked:
       required: [Background]
-      optional: [Root Cause, Plan]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Root Cause, Solution, Testing, Review]
     cancelled:
       required: []
-      optional: [Background]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Root Cause, Solution, Testing, Review]
 
   # Code-review result task — the deliverable is the P1–P4 findings table.
   #
@@ -108,81 +101,80 @@ variants:
   # Plan and Review are optional at backlog/todo so the template renders cleanly;
   # Review becomes required at wip+.
   #
-  # Solution and Testing are optional at wip+ — not required, but tolerated so that
-  # a review-findings task that evolves into implementation work (the common dogfood
-  # follow-up path) can carry a change-map and coverage data without matrix violations.
+  # Requirements is optional from todo onward (the authoring stage where a refined
+  # review-findings task gains scoped requirements); Solution and Testing are optional
+  # at wip+ — none required, but tolerated so that a review-findings task that evolves
+  # into implementation work (the common dogfood follow-up path) can carry scoped
+  # requirements, a change-map, and coverage data without matrix violations.
   # The required list guards the real deliverables; optional is permissive on purpose.
   review:
     backlog:
       required: [Background]
-      optional: [Plan, Review]
-      forbidden: [Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     todo:
       required: [Background, Plan]
-      optional: [Q&A, Review]
-      forbidden: [Testing]
+      optional: [Q&A, Requirements, Acceptance Criteria, Design, Solution, Testing, Review]
     wip:
       required: [Background, Review]
-      optional: [Plan, Q&A, Solution, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing]
     testing:
       required: [Background, Review]
-      optional: [Plan, Solution, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing]
     done:
       required: [Background, Review]
-      optional: [Plan, Q&A, Solution, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing]
       gate: true
     blocked:
       required: [Background]
-      optional: [Plan, Review, Solution]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     cancelled:
       required: []
-      optional: [Background]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
 
-  # Process / docs / chore — lightweight: Background + Plan, no Solution/AC gate.
+  # Process / docs / chore — same scaffold, lighter required gates.
   meta:
     backlog:
       required: [Background]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     todo:
       required: [Background, Plan]
-      optional: [Q&A, Design]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Solution, Testing, Review]
     wip:
       required: [Background, Plan]
-      optional: [Q&A, Design, Solution]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Solution, Testing, Review]
     testing:
       required: [Background, Plan]
-      optional: [Solution, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Solution, Testing, Review]
     done:
       required: [Background, Plan]
-      optional: [Solution, Testing, Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Solution, Testing, Review]
     blocked:
       required: [Background]
-      optional: [Plan]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     cancelled:
       required: []
-      optional: [Background]
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
 
   # Brainstorm template (minimal idea capture).
   brainstorm:
     backlog:
       required: [Background]
-      forbidden: [Solution, Review, Testing]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     todo:
       required: [Background]
-      optional: [Q&A]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     wip:
       required: [Background, Plan]
-      optional: [Q&A, Design]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Solution, Testing, Review]
     testing:
       required: [Background, Solution]
-      optional: [Testing]
-      forbidden: [Review]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Testing, Review]
     done:
       required: [Background, Solution]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Testing, Review]
     blocked:
       required: [Background]
+      optional: [Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]
     cancelled:
       required: []
+      optional: [Background, Requirements, Acceptance Criteria, Q&A, Design, Plan, Solution, Testing, Review]

package/spur-cli/config/templates/task/brainstorm.md

@@ -20,10 +20,40 @@ updated_at: "{{ CREATED_AT }}"
 
 {{ BACKGROUND }}
 
+### Requirements
+
+<!-- Constraints the eventual direction must satisfy, if known. -->
+
+### Acceptance Criteria
+
+<!-- Decision criteria or success checks for the brainstorm output. Keep empty if not applicable. -->
+
 ### Q&A
 
+<!-- Questions, answers, assumptions, and decision notes from the brainstorm. -->
+
+### Design
+
+<!-- Candidate approaches, tradeoffs, and selected direction. -->
+
 ### Plan
 
+<!-- Follow-up steps or task/feature creation plan once the idea is ready to execute. -->
+
+### Solution
+
+<!-- Final synthesized recommendation or output from the brainstorm. -->
+
+### Testing
+
+<!-- Validation performed for claims, links, or feasibility. Use N/A when not applicable. -->
+
+### Review
+
+<!-- Risks, open concerns, and follow-up review notes. -->
+
 ### References
 
+<!-- Links to docs, examples, related tasks/features, or external references. -->
+
 ### History

package/spur-cli/config/templates/task/feature-impl.md

@@ -20,31 +20,42 @@ updated_at: "{{ CREATED_AT }}"
 
 {{ BACKGROUND }}
 
+### Requirements
+
+<!-- R-numbered list derived from the linked feature or refined task scope. -->
+
 ### Acceptance Criteria
 
-```gherkin
-Feature: {{ NAME }}
+<!-- Copy or derive real scenarios from the linked feature. Do not leave placeholder AC here. -->
 
-  Scenario: Basic acceptance
-    Given a precondition
-    When an action is taken
-    Then an expected result occurs
-```
+### Q&A
 
-- [ ] Acceptance checklist item
+<!-- Clarifications and decisions made during refinement. Keep empty if none. -->
 
 ### Design
 
+<!-- Chosen implementation approach, key tradeoffs, invariants, and impacted surfaces. -->
+
 ### Plan
 
-- [ ] Implementation step
+<!-- Ordered implementation checklist. Fill before moving to todo/wip. -->
 
 ### Solution
 
+<!-- Filled during implementation: file:line change map and concise rationale. -->
+
 ### Testing
 
+<!-- Filled during verification: commands run, outcomes, coverage claim or N/A. -->
+
 ### Review
 
+<!-- Filled during review: P1-P4 findings, residual risk, and final disposition. -->
+
 ### References
 
+{{ FEATURE_ID }}
+
+<!-- Links to the parent feature, design docs, related tasks, or external references. -->
+
 ### History

package/spur-cli/config/templates/task/issue.md

@@ -20,14 +20,44 @@ updated_at: "{{ CREATED_AT }}"
 
 {{ BACKGROUND }}
 
+### Requirements
+
+<!-- R-numbered expectations for the fix. Include repro/expected behavior if it helps traceability. -->
+
+### Acceptance Criteria
+
+<!-- Given/When/Then regression scenario or checklist proving the bug is fixed. -->
+
+### Q&A
+
+<!-- Clarifications and triage decisions. Keep empty if none. -->
+
+### Design
+
+<!-- Fix approach and tradeoffs. Keep this short unless the issue changes architecture. -->
+
+### Plan
+
+<!-- Ordered debugging/fix checklist. Fill before moving to todo/wip. -->
+
 ### Root Cause
 
+<!-- Verified underlying cause with file:line evidence. Fill once reproduced/isolated. -->
+
 ### Solution
 
+<!-- Filled during implementation: file:line change map and concise rationale. -->
+
 ### Testing
 
+<!-- Filled during verification: regression command(s), outcomes, coverage claim or N/A. -->
+
 ### Review
 
+<!-- Filled during review: P1-P4 findings, residual risk, and final disposition. -->
+
 ### References
 
+<!-- Links to failing logs, related issues, tasks, docs, or external references. -->
+
 ### History

package/spur-cli/config/templates/task/meta.md

@@ -20,12 +20,40 @@ updated_at: "{{ CREATED_AT }}"
 
 {{ BACKGROUND }}
 
+### Requirements
+
+<!-- R-numbered expectations for the process/docs/chore outcome. Keep empty if not applicable. -->
+
+### Acceptance Criteria
+
+<!-- Lightweight checklist or Given/When/Then if there is an observable completion condition. -->
+
+### Q&A
+
+<!-- Clarifications and decisions made during refinement. Keep empty if none. -->
+
+### Design
+
+<!-- Approach and tradeoffs for process/docs/config changes. Keep this short. -->
+
 ### Plan
 
-- [ ] Implementation step
+<!-- Ordered checklist. Fill before moving to todo/wip. -->
+
+### Solution
+
+<!-- Filled during implementation: changed files/sections and concise rationale. -->
 
 ### Testing
 
+<!-- Filled during verification: commands/checks run, outcomes, coverage claim or N/A. -->
+
+### Review
+
+<!-- Filled during review: P1-P4 findings, residual risk, and final disposition. -->
+
 ### References
 
+<!-- Links to docs, tasks, decisions, or external references. -->
+
 ### History

package/spur-cli/config/templates/task/review.md

@@ -4,7 +4,6 @@ name: "{{ NAME }}"
 description: ""
 status: backlog
 type: review
-template: review
 profile: standard
 feature_id: null
 parent_wbs: null
@@ -31,12 +30,37 @@ in the reviewed PR/commit/diff). Fix in priority order (P1 → P2 → …); re-r
 | P1       |      |         |                |
 | P2       |      |         |                |
 
+### Requirements
+
+<!-- R-numbered fix requirements derived from the findings. Fill after triage/refinement. -->
+
+### Acceptance Criteria
+
+<!-- Checks that prove the findings were addressed. Keep empty until the review task becomes executable work. -->
+
+### Q&A
+
+<!-- Clarifications, false positives, accepted risk, and triage decisions. -->
+
+### Design
+
+<!-- Fix approach and tradeoffs if the findings require design judgment. -->
+
 ### Plan
 
 - [ ] Fix P1 findings
 - [ ] Fix P2 findings
+- [ ] Fix all the remaining findings if any
 - [ ] Re-review the changed code
 
+### Solution
+
+<!-- Filled during implementation: file:line change map and concise rationale. -->
+
+### Testing
+
+<!-- Filled during verification: commands/checks run, outcomes, coverage claim or N/A. -->
+
 ### Review
 
 Post-implementation reflection — filled **after** the first fix round: what went wrong, what
@@ -49,4 +73,6 @@ remains to fix before closing, and any **back-issues** (new findings surfaced by
 
 ### References
 
+<!-- Links to source review, dogfood report, PR/diff, related tasks, or external references. -->
+
 ### History

package/spur-cli/config/templates/task/standard.md

@@ -20,29 +20,40 @@ updated_at: "{{ CREATED_AT }}"
 
 {{ BACKGROUND }}
 
+### Requirements
+
+<!-- R-numbered list of what must be true when this task is complete. Keep empty until requirements are known. -->
+
 ### Acceptance Criteria
 
-```gherkin
-Feature: {{ NAME }}
+<!-- Given/When/Then scenarios or a checklist derived from Requirements. Keep empty if this task has no objective AC yet. -->
+
+### Q&A
+
+<!-- Clarifications and decisions made during refinement. Keep empty if none. -->
 
-  Scenario: Basic acceptance
-    Given a precondition
-    When an action is taken
-    Then an expected result occurs
-```
+### Design
 
-- [ ] Acceptance checklist item
+<!-- Chosen approach, key tradeoffs, invariants, and impacted surfaces. Keep snippets short. -->
 
 ### Plan
 
-- [ ] Implementation step
+<!-- Ordered implementation checklist. Fill before moving to todo/wip. -->
 
 ### Solution
 
+<!-- Filled during implementation: file:line change map and concise rationale. -->
+
 ### Testing
 
+<!-- Filled during verification: commands run, outcomes, coverage claim or N/A. -->
+
 ### Review
 
+<!-- Filled during review: P1-P4 findings, residual risk, and final disposition. -->
+
 ### References
 
+<!-- Links to features, docs, ADRs, related tasks, or external references. -->
+
 ### History

package/spur-cli/config/workflows/feature-dev.yaml

@@ -1,4 +1,3 @@
-$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 "$schema": "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 kind: state-machine
 name: feature-dev
@@ -63,7 +62,7 @@ states:
     description: >
       Drive EVERY pending task under the feature to done. The agent enumerates the work with
       `spur task list --feature ${featureId} --status todo --json`, then runs each task through
-      task-pipeline.yaml (refine → implement → test → review → verify → record → done). It
+      task-pipeline.yaml (precheck → implement → test → review → approve → verify → record → done). It
       stops and reports on the first non-PASS verdict — a failing task fails the feature.
     onEnter:
       - kind: agent.run
@@ -71,9 +70,13 @@ states:
           agent: ${vars.agent}
           input: >
             Run every pending task under feature ${vars.featureId} to done. Enumerate with
-            `${vars.spurBin} task list --feature ${vars.featureId} --status todo --json`, then
-            for each task run the task-pipeline (e.g. /sp:dev-refine <wbs> --auto --next, which
-            chains implement → verify → done). Stop and report on the first non-PASS verdict.
+            `${vars.spurBin} task list --feature ${vars.featureId} --status todo --json`; then
+            for each WBS run the standard single-task pipeline VERBATIM:
+            `${vars.spurBin} workflow run config/workflows/task-pipeline.yaml --vars
+            '{"wbs":"<wbs>","profile":"${vars.profile}","agent":"${vars.agent}"}' --async --json`,
+            polling `${vars.spurBin} workflow trace <run-id>` until terminal and inspecting
+            `.spur/run/<wbs>-verdict.json`. Stop and report on the first non-PASS verdict
+            (a failing task fails the feature).
 
   - id: feature-verify
     description: >

package/spur-cli/config/workflows/feature-lifecycle.yaml

@@ -1,4 +1,3 @@
-$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 "$schema": "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 kind: state-machine
 name: feature-lifecycle

package/spur-cli/config/workflows/planning-pipeline.yaml

@@ -1,4 +1,3 @@
-$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 # Planning pipeline — front-half of the development workflow (task 0088, design §6).
 #
 # Orchestration is configuration (ADR-022 / §3.2): this is YAML over the existing

package/spur-cli/config/workflows/task-lifecycle.yaml

@@ -1,4 +1,3 @@
-$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 "$schema": "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 kind: state-machine
 name: task-lifecycle

package/spur-cli/config/workflows/task-pipeline.yaml

@@ -1,4 +1,3 @@
-$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 # Task execution pipeline — one run per execution attempt of a task (design §6).
 #
 # Orchestration is configuration (ADR-022 / §3.2): this is YAML over the existing
@@ -56,20 +55,26 @@ states:
 
   - id: implement
     description: >
-      Move the task to `wip` (via the normal verb — lifecycle guards apply, R3),
-      then run agent-driven implementation via /sp:dev-run --mode implement.
+      Run agent-driven implementation via /sp:dev-run --mode implement, THEN move the
+      task to `wip` via the normal verb. The lifecycle transition fires AFTER the
+      implement agent.run succeeds — onEnter runs in declaration order and the default
+      'fail' policy halts the sequence (routing the run to `failed`) if the agent.run
+      fails or times out, so a halted implement never leaves the task at `wip` with an
+      empty Solution (the F3 half-state). The `--no-lifecycle` flag is correct here: the
+      pipeline owns this transition; the FSM guard would otherwise re-run `spur task
+      check`, which is precheck's job.
       NOTE: this step must NOT call /sp:dev-run in full mode (the default) —
       that command DRIVES this pipeline, so calling it here recurses.
       --mode implement is the single-step implement entry.
     onEnter:
-      - kind: shell
-        options:
-          command: "${vars.spurBin} task update ${vars.wbs} wip --no-lifecycle"
       - kind: agent.run
         options:
           agent: ${vars.agent}
           input: /sp:dev-run --mode implement ${vars.wbs} --auto
           timeoutMs: ${vars.stepTimeoutMs}
+      - kind: shell
+        options:
+          command: "${vars.spurBin} task update ${vars.wbs} wip --no-lifecycle"
 
   - id: test
     description: Test execution + coverage via /sp:dev-unit.
@@ -81,7 +86,7 @@ states:
           timeoutMs: ${vars.stepTimeoutMs}
 
   - id: review
-    description: SECU code review via /sp:dev-review.
+    description: SECUA-framework code review via /sp:dev-review (Security, Efficiency, Correctness, Usability, Architecture).
     onEnter:
       - kind: agent.run
         options: